summaryrefslogtreecommitdiff
path: root/basic/source/classes/sb.cxx
AgeCommit message (Collapse)Author
2016-05-23Convert SbxClassType to scoped enumNoel Grandin
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-15remove tools/solarmutex.hxxNoel Grandin
Deprecated in favour of comphelper::SolarMutex Change-Id: I159077562660de5df25601fa471447f4b64a2cf1 Reviewed-on: https://gerrit.libreoffice.org/24079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11make GetGlobalUNOConstant and GetUNOConstant take an OUStringNoel Grandin
and eliminate converting backwards and forwards between sal_Char*/OString/OUString Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f Reviewed-on: https://gerrit.libreoffice.org/23919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22BASIC : Add tools::make_ref and simplify SvRef usageArnaud Versini
Change-Id: I8fe846dbd353bace05a8732a9b961f3507d97ef8 Reviewed-on: https://gerrit.libreoffice.org/22587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16BASIC : Remove useless virtual function overrideArnaud Versini
Change-Id: I0f8e480bf73256e7f1284e11983cc70c0426172c Reviewed-on: https://gerrit.libreoffice.org/21513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-16BASIC : Remove useless methods in StarBasicArnaud Versini
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d Reviewed-on: https://gerrit.libreoffice.org/21498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-12loplugin:unusedmethods unused return value in include/basicNoel Grandin
Change-Id: Ib1a006adaa92e257d40a20ff0d8beeb37e7c2fe0 Reviewed-on: https://gerrit.libreoffice.org/21360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-07Some cleanup for sal_uIntPtr usageJohannes Hauf
Change-Id: Ia9779e6477d8848588f3543d09ea6b4477f594a2 Reviewed-on: https://gerrit.libreoffice.org/21022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-07BASIC : use std::vector instead of SbArray for Modules.Arnaud Versini
Change-Id: I9594efb13b3dccc637ccd61eea4b42255c2a775c Reviewed-on: https://gerrit.libreoffice.org/20817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-05Fix typosAndrea Gelmini
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727 Reviewed-on: https://gerrit.libreoffice.org/21103 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-12-30BASIC : Remove useless allocation operator overloadArnaud Versini
Change-Id: I134cdbfe388347264a810bbfbff8b4f9f373e663 Reviewed-on: https://gerrit.libreoffice.org/20873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-12-27sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32Matteo Casalin
also avoid some explicit temporaries and group some checks. Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
2015-12-13BASIC: use c++ foreach loops when possible.Arnaud Versini
Change-Id: Ia1c734e26da88010eef40a4375c423b0765f43ae Reviewed-on: https://gerrit.libreoffice.org/20423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30Fix typosAndrea Gelmini
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3 Reviewed-on: https://gerrit.libreoffice.org/18938 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29tdf#94559: first step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in avmedia, basctl, basic, cui, dbaccess, vcl,xmloff Change-Id: If4496762e82e896b6fbc362e6626502703c245f5 Reviewed-on: https://gerrit.libreoffice.org/18905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-08-27Clean up aEmptyStephan Bergmann
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-07-28inline "old" SbERR constantsNoel Grandin
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
2015-07-28inline the "old" SbxErr constantsNoel Grandin
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28convert SbxFlagsBits to scoped enumNoel Grandin
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-20com::sun::star->css in basicNoel Grandin
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212 Reviewed-on: https://gerrit.libreoffice.org/17206 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, in basic. Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36 Reviewed-on: https://gerrit.libreoffice.org/16719 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04Fix typosAndrea Gelmini
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-24remove SFX_NOTIFY macroNoel Grandin
it has not served any purpose since we switched to using normal C++ RTTI for the SfxHint objects Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-06-02cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-05-19basic: used typed LINKsNoel Grandin
Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
2015-05-18Remove include stdio (part2)Julien Nabet
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd Reviewed-on: https://gerrit.libreoffice.org/15775 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-12tdf#90969: basic: add horrible hack to avoid crash due to ...Michael Stahl
... the stupid global variable GaDocBasicItems. Change-Id: Ib849e0e2b661e54005d00091f6d6fc474dc5549b
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: I6e181bc4b144c2559ede99d3bae0496cf546415c
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-18basic: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
2014-12-12basic: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ied7e5eba39672363065083493bd5e60449fda371
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05coverity#1242794 Untrusted loop boundCaolán McNamara
Change-Id: I902a5bf989a8f385994a2f927cce4975b18f06d2
2014-10-23fdo#84935: basic: DocBasicItem is a UNO service, lock SolarMutex in dtorMichael Stahl
Change-Id: Ia31d735ba54d18f406653debce04a07c077d09eb