Age | Commit message (Collapse) | Author |
|
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed.
Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3
Reviewed-on: https://gerrit.libreoffice.org/1530
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit dbfc8777bf73872d1b96f956b9e778d9099d52b3)
|
|
Instead of returning lowercase characters with BASIC's HEX command, uppercase characters are now returned. Digits from 0-9 are not affected. This change utilizes on OUString's toAsciiUpperCase() method.
Change-Id: Id6ea93a7635c1913c8592bf5519bdd7391f4e3bc
Reviewed-on: https://gerrit.libreoffice.org/1428
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
OUStringBuffer doesn't handler append ( if it had been previously assigned to "" literal )
Change-Id: Ief4379490a4873fbee4117db5833111943b86334
|
|
Change-Id: I0d169b7cd0f47b6986063d0cc0b6697b1d575e6a
|
|
Change-Id: I2ceaa3159e8669c2c569fa8559c1e061dcad399d
|
|
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
|
|
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
|
|
Change-Id: I91cdd3a52917b89ab2a452e0eeb7a9e00dc35e8b
Reported-by: vmiklos@suse.cz
|
|
I upgraded the service to return XSimpleFileAccess3, since it
already implemented that interface, and it's backwards
compatible.
Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
|
|
Also, avoid global static data in sb lib, so that gengal.bin now also works well
on Mac OS X, cf. 12fa9ece663f24eff44197befe546a92e6c90724 "Avoid global static
data."
Change-Id: I23f2a7abc0c06a752ded1c1c64619b3aab009190
|
|
...so that e.g.,
DateAdd("x", 1, "1/31/2004")
(where "x" is not in the list of valid values for the Add parameter, "yyyy",
"q", "m", etc.) leads to a Basic runtime error rather than going into a
seemingly endless while(nNewMonth>nTargetMonth) loop at the end of
RTLFUNC(DateAdd) (basic/source/runtime/methods.cxx).
Change-Id: I15c3bdb62723ffddf36ff2396ffb294369d93ff8
|
|
Change-Id: I9e5ff5be1f001a9f55953fd516fb5ef7fe94bf44
|
|
Change-Id: I038848aed0c64c39ca93da89b4a78bd3a1f6d7d0
|
|
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
|
|
Simply make the service implement XExtendedTransliteration, since all
of the implementatins already do that.
Change-Id: If03bf56a8d33931ad0230743a4603e2ae9b104ac
|
|
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.
So as the review progress, in order to follow the code, cosmetic changes
were made...
In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.
Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
|
|
Change-Id: I2af40d7c8117aff8ce62a8ea0eec579664f8bdeb
|
|
Change-Id: I1f9403174b3779801d91ba20d846191ed9a09eed
|
|
Change-Id: I19d05f455767c973a47d0233b3af20af1ac3a20a
|
|
Change-Id: I92c86f672cc79506c2c7c56bb3402b4436f71c98
|
|
Change-Id: Icfecff549161c3c429524549b65752671792a94f
|
|
Change-Id: I691a59b8ab9e6352a9257dac35b8e378e6ef9666
|
|
Change-Id: If741661f1151950a2180fa5c6504957b44a7e998
|
|
Change-Id: Icca8c40db4a4449876e115a0746319f3f893e846
|
|
Change-Id: I9ea243f93b7477814037deca2f332c3359ce527d
|
|
Change-Id: I9435d926beb2fd7ebe350f61634673eed7228fbe
|
|
Change-Id: Ie9569fba8b03656b9a50e9add06c8e13d0026624
|
|
Change-Id: Iff2150cf45569ca3d95f461495f49c455178cb5e
|
|
Change-Id: I6c41b8f4d3ad739eff545063bd1f8fe8f4fba65e
|
|
Did not need to create a new interface, because XCalendar3
already covers the whole service interface.
Change-Id: Iaf094014c16e872d2003ca6e8e7588abd081d882
|
|
Change-Id: I9938d7c4ab5594baeb10f405f0aa0964ef84d6c5
|
|
http://lists.freedesktop.org/archives/libreoffice/2012-October/039639.html
Change-Id: I231f0b367bf0b513c6c1ce4c4cfdb7c3dc8660d5
|
|
Change-Id: I1666e64b2b611054e1a713a76575e2f06781f80a
|
|
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: Id10a6cef0ae25247ded7846dfd7df27922a9410a
|
|
...and some further clean-up.
Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
|
|
Change-Id: I14794ca0cd2a8ea84ba41e1dc689503647696e3a
|
|
Create a merged XBridgeFactory2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.
Change-Id: I7309f4d30f0e772bc203c701eb3407b920ffafcc
|
|
* As UCB is only ever initialized with "Local"/"Office", remove this
configuration vector completely. The "create" ctor creates an instance
internally initialized with those "Local"/"Office" keys. Special (test) code
can still instantiate an uninitialized one via plain createInstance. And for
backwards compatilibity process startup still ensures to create an initialized
instance early, in case there is still code out there (in extensions) that
later calls plain createInstance and expects to get the already-initialized
(single) instance.
* XInitialization is an "implementation detail" of the UniversalContentBroker
service, do not expose in XUniversalContentBroker.
* ucbhelper/configurationkeys.hxx is no longer needed and is removed.
* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
requires ucbhelper::Content constructors to take explicit XComponentContext
arguments now.
* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
Android-only InitUCBHelper. Is that relevant still?
Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
|
|
Create a merged XUniversalContentBroker interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.
Change-Id: Id264387bf8af8bf211050e15b8801a1fde368167
|
|
|
|
fix is followup to bf5b493104d2dd4ab964f1fcb845200eaefbbcd5 which didn't adjust the runtime to
cater for the new enum layout
Change-Id: I6613fb8aacd8a70947c4fff556fb3e2d33c1113e
|
|
Change-Id: I86e5b49ccc9737517ecde17dbdaba44eeaee2371
|
|
Change-Id: Ie8a128db35bebcdcee5eda984a7875339418d9bb
|
|
Change-Id: Iebed1c159606ab695b049032da5a3509e468fb91
|
|
Change-Id: I684e371c31ba76d2e9b563eed70449764346161b
|
|
fix case where the value is neither uno object or unostruct
Change-Id: I2862ab23a875a691edb202bb9d334b000871f718
|
|
Change-Id: I96fe31c80f952b1ac6d25c65431597d81e0fdda3
|
|
Change-Id: I75dd089b34c94831bfdfd0e02585af7609013a08
|
|
Change-Id: I38141187c4f0809343a93c5765c0773d2321968a
|