summaryrefslogtreecommitdiff
path: root/basic/source/uno
AgeCommit message (Collapse)Author
2013-10-09Improve ErrorCodeIOException messagesStephan Bergmann
...and clean up some includes. Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
2013-10-07sal_Bool to boolTakeshi Abe
Change-Id: Ie8e35c4342db6e2dc35fca33cee7b4d71cfcb732
2013-09-25Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-17convert BASIC from String to OUStringNoel Grandin
Change-Id: I4b046e4c460305acad29862341092af948639215
2013-09-02XubString->OUStringCaolán McNamara
Change-Id: I5424a148c7173409e6e56f9483fcc769696707bc
2013-08-18Use subfolder names from <config_folders.h>Tor Lillqvist
Change all instances of hardcoded "program", "share" etc subfolder names to use those from <config_folders.h> instead. In normal builds, the end result will not change. Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-02do *not* silently ignore errors when saving librariesLionel Elie Mamane
In case of error, it leads to *data* *loss*. Change-Id: I80d806ef10a3364174eced3095ebf1ea217d75b4
2013-08-02fdo#67685 open xSourceLibrariesStor only when neededLionel Elie Mamane
else it keeps loadLibrary from completing, because the latter cannot open the storage because it is already open in read/write mode. Change-Id: Icd0aabfff6e67af2c38a8f9185f8485b46ab1516
2013-07-29Remove effectively unused INetURLObject OString overloadsStephan Bergmann
Change-Id: Icbbe27b229d5454d27be646e00e8b362a77359b3
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-05remove unused componentcontext.hxx includesNoel Grandin
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-03SfxLibraryContainer::storeLibraries_Impl: make saving basic macros work againMiklos Vajna
Regression from cbd1a89676f39135ed2e9c47d20475b2053289b9, that commit accidentally not only removed the #if 0 block, but also two other braces -- because of this, in case bStorage was false, nothing was saved. The effect of this was that if the user edited some macro in the basic IDE, then saved the macro, it was shown as saved, but in fact that didn't happen. Change-Id: I20f8358dddfb226976be72f95dcad64de88d83c3
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-15fdo#46808, Use service constructorsNoel Grandin
Change-Id: I34a41cde5d40e14803859116648c8da9f50c4b07
2013-05-14fdo#46808, use XComponentContext in SfxLibraryContainerNoel Grandin
Change-Id: I6f66fc69a40e2cd2ef2372e0413ff95b6202c5c5
2013-05-14fdo#46808, replace XMultiServiceFactory with XComponentContext is SfxLibraryNoel Grandin
Change-Id: I150d86b4ae4004e7c39ec6a3ed7fba31029f8ab1
2013-05-09remove #if 0 block ( from af34774d260a68fc02cd78ba90dd8d4afaf1a2a4 )Noel Power
I left in that block in the mentioned commit above for mostly because I preferred a more obvious hack/change to cherry-pick to 4.0 The more I think about this ( despite the still imho problematic setting of the modify state ) I think always writing from memory to the storage is the right thing to do Change-Id: I13c82b9d6b55120482c65fb7a5bfadb2396c347c
2013-05-08hopefully this fixed the strange autorecovery related dataloss fdo#42899Noel Power
also this is a fix for bnc#817477 Disabling the optimisation of copying the library container storage to target storage for the moment ( hopefully after some rework it might make some sense to re-enable this code ) The problem here is there is a tragic flaw in the api implementation. In the implementation the library in-memory model state reflects that the library model has been saved to storage but not the library container storage as you ( or at least I ) would expect but actually any storage. So to illustrate the problem, during autorecovery when the basic library containers are stored to the autorecovery file the library pImplLib->implIsModified() is set to false, any subsequent save attempt will think the library is not modified and will attempt to the librarycontainer storage to the target one. However, in this case the source (library container) storage has never been updated with the changes from memory. Can't we simply only update the 'implIsModified' state only if the library container's own storage and the storage to store to are the same ? Sounds like a good idea, unfortunately this is not possible due to the way that sfx spaghetti code uses temporary storages for even own copies and also because it sets the new root storage for the library container after the library copy happens. ( some stuff in dbaccess appears to depend on this as well ) AFAICT for any document save/saveas etc. operation the librarycontainer's own storage and the storage we save to are *always* different. So for the moment it seems best to *always* write the storage from the in-memory model. Change-Id: Ia24e7a6119558497d901370dbc0986101bde4de9
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-28Bypass extension scanning unless HAVE_FEATURE_EXTENSIONSTor Lillqvist
Change-Id: I6ada96fc5cea895b967387c10814a7003e1e492b
2013-03-19More "compareToAscii(RTL_CONSTASCII_STRINGPARAM(s)) != compareTo(s)" fixesStephan Bergmann
Change-Id: Ia93b281b07559fb6f0d67d53dd91dfacf2be0d0b
2013-03-08some further OUString cleanupThomas Arnhold
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-04doubled includesThomas Arnhold
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-02-11fdo#46808, Use singleton util::theMacroExpander new-style constructorNoel Grandin
And deprecate the old-style service util::MacroExpander Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-01-28fdo#46808, Adapt document::GraphicObjectResolver UNO service to new styleNoel Grandin
The services already existed, it just did not have an IDL file Change-Id: I245f78c165dbfde11a981efd7033c5c282f4e8ad
2013-01-03fix buildLuboš Luňák
Change-Id: I2588b69280abbc510ee2fdc9845df56616db8b95
2013-01-03fdo#57950: Fix some chained appends in basicMarcos Paulo de Souza
Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1515 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-03Remove all occurences of RTL_* and ::rtl prefix from basicMarcos Paulo de Souza
This is a big commit, so thanks for your time reviewing this :) Conflicts: basic/source/sbx/sbxscan.cxx Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933 Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2012-11-22AllSettings with LanguageTagEike Rathke
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-15fdo#46808, use service constructor for ucb::SimpleFileAccessNoel Grandin
I upgraded the service to return XSimpleFileAccess3, since it already implemented that interface, and it's backwards compatible. Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-07basic: String -> OUStringNorbert Thiebaud
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-03basic: preliminary cosmetic clean-upNorbert Thiebaud
parsing 1000s of line of code is hard enough without having to fight with weird indentation and irregular formatting. So as the review progress, in order to follow the code, cosmetic changes were made... In order to minimize the task of the reviewers and allow them to concentrate on what matter, an effort is made to collect these cosmetic changes into this separate commit. Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03basic: String -> OUString in basicmanagerNorbert Thiebaud
Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5
2012-10-22fdo#46808, Adapt xml::sax::XWriter UNO service to new styleNoel Grandin
Create a merged XWriter interface for the service. The xml.sax.Writer service already existed, it just did not have an IDL file. Change-Id: I4e6d3f3c68f9282a55fc7aa19778f97632fd8ad5
2012-10-04fdo#46808, Adapt xml::sax::XParser UNO service to new styleNoel Grandin
The xml.sax.Parser service already existed, it just did not have a new-style service to create it. Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-01Replace usage of rtl_*Memory with equivalent from string.hArnaud Versini
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159 Reviewed-on: https://gerrit.libreoffice.org/734 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-29Use comphelper::getComponentContextStephan Bergmann
...and some further clean up. Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-25replace remaining InterlockedCount() with inlined versionNorbert Thiebaud
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c Reviewed-on: https://gerrit.libreoffice.org/671 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-19ComponentContext::getUnoContext -> getComponentContext simplificationStephan Bergmann
...and some further clean-up. Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-18deprecate oustringostreaminserter.hxxNorbert Thiebaud
the intent of this header has canged over time. now it is already systematically included with ustring.hxx and the operator overload it provide fit nicely there... Just to be safe, since that include as been added to the api during the 3.5 timeframe and therefore is already in 'production' the header remain and simply attempt to include ustring.hxx but a warning is issued indicating that this header should not be used anymore... in a couple of major release we will thenr emove it completely All internal users of that header are converted. Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad Reviewed-on: https://gerrit.libreoffice.org/634 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-11kill stray line from commit:c0c7fb66985a9a3e8f9b7a796c1e0489e407879b fdo#52076Noel Power
Change-Id: I715c4a7caeb48e605babd9a91e2c10e5847cbd09
2012-09-11fix for fdo#52076 don't write out basic storage if no modulesNoel Power
Change-Id: I50908f7f6b4c9a146e4a2fe616d000e1ee7e36fe
2012-08-21sal_Bool to boolTakeshi Abe
Change-Id: I38141187c4f0809343a93c5765c0773d2321968a
2012-08-20sal_Bool to boolTakeshi Abe
Change-Id: I427e9bb30cab4698a2495de7445a4a4982abd7b4
2012-08-19sal_Bool to boolTakeshi Abe
Change-Id: I6206ee7e17e12388ea644123e180842df3e3a7ee
2012-07-18re-base on ALv2 code. Includes:Michael Meeks
118568: switch to using ucpp Patch contributed by Juergen Schmidt http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-06-30Some cppcheck cleaningJulien Nabet
Change-Id: I14cab3dfd26ac1568feef902b566873cecf049b9
2012-06-29Remove UNO includes commentsThomas Arnhold
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a