summaryrefslogtreecommitdiff
path: root/basic/source
AgeCommit message (Collapse)Author
2015-01-31Use rtl/character.hxx in basic module when possibleArnaud Versini
Change-Id: I1296541ac1a6a65a613818a1264c2b7482915e64 Reviewed-on: https://gerrit.libreoffice.org/14170 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-01-30coverity#1267698 Uninitialized scalar fieldCaolán McNamara
Change-Id: I79974d276a8f7f856dbf09b14b06ce3b1bb418f0
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29tdf#76174: basic: lock SolarMutex in BasicScriptListener_ImplMichael Stahl
... before calling into BASIC. Change-Id: I51a59fe5ca9b15ff7ec509c052964523d87a9790
2015-01-28remove unused typedefsNoel Grandin
found with some minor modifications to find/find-unused-defines.sh Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd Reviewed-on: https://gerrit.libreoffice.org/14194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-26implement css::i18n::XCalendar4 and LocaleCalendar2 service, tdf#63230Eike Rathke
Implementation only, new local date/time routines not used yet from the outside in this step.
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-25coverity#1266457 Identical code for different branchesCaolán McNamara
Change-Id: I809ad43ad4541e4dcd5c245b469d30605f9f0d27
2015-01-24WaE: rewrite call of rtl::OUString::operator= ...Tor Lillqvist
... with empty string constant argument as call of rtl::OUString::clear [loplugin:stringconstant]. Actually, no need to clear the string here as it already is empty, surely? Change-Id: Ib4b1a6e1b0c0f59c1c964fe58d26058b492c3821
2015-01-23Resolves fdo#87834: strange behavior of mid()-functionJulien Nabet
See https://bugs.freedesktop.org/show_bug.cgi?id=87834 Thank you Michael Büssow for pointing these cases Change-Id: I3a9b58360ddab529d1fb2f7eeba7f1c7ae69ba7c Reviewed-on: https://gerrit.libreoffice.org/13707 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20Some more loplugin:cstylecast: basicStephan Bergmann
Change-Id: Ib22bc7408d333a7080fa44c9c3ac9535ccf00752
2015-01-16remove unnecessary parenthesesNoel Grandin
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-13simplify Date/Time/DateTime conversion codeNoel Grandin
add constructors to Date/DateTime/Time, that take the css::util counterparts, to simplify code converting between these type Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7 Reviewed-on: https://gerrit.libreoffice.org/13855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-01-11Related: #i94895# revert the part of revision 1650261Tsutomu Uchino
replaced string should be starting with the start postion if specified (cherry picked from commit 68c6265584fb6cb0469098507dd287e6e1127324) Conflicts: basic/source/runtime/methods.cxx Change-Id: Ib729facfa78ffddebc258440324f05d037fae46f
2015-01-09Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara
and adjust the basic test-case, which is surely wrong The syntax for REPLACE is: // Replace(expression, find, replace[, start[, count[, compare]]]) surely in the case of a start of 3 the preceeding chars should be returned unchanged in the result, not stripped off as before this change. This reverts commit 869402a58720b45e7227438b2e56e5a9532c0000. Change-Id: Ie710e4de9e7e35c84abe2770142a963532820af4
2015-01-09loplugin:cstylecastStephan Bergmann
Change-Id: I86aaad9f38ad63121805fa3dc05b3a8a33428ef7
2015-01-09Resolves: #i63614# fix strange type mismatch when Iif function is usedTsutomu Uchino
Second or later compilation uses value type returned by previous execution of code. Use the defined type as return value of the runtime function of Basic always. (cherry picked from commit 7470c682e136a4a89c1e9474bbc79b2d61f31048) Conflicts: basic/inc/basic/sbxmeth.hxx basic/inc/basic/sbxobj.hxx basic/source/runtime/stdobj.cxx basic/source/sbx/sbxobj.cxx Change-Id: I3064e8403286a9c1401ef658bf139bedeae11f17
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08Revert "Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara
This reverts commit 340ca294d43f2c5b9fda1afbf178609a015f71e3 as CppunitTest_basic_vba breaks, so needs revisiting to see which is right Change-Id: I10168d454a8c67d91eee5bb8939aff74bba42954
2015-01-08Resolves: #i94895# fix illegal result of Replace runtime functionTsutomu Uchino
(cherry picked from commit a2700f75af61837033ff213607445cc1f74b36d6) Conflicts: basic/source/runtime/methods.cxx Change-Id: If9c671a612de87d8d37bfc40704a97a6062fd150
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05Resolves: fdo#87003 Kill BOOST_FOREACH on masterNathan Yee
use C++11s range-based for() loops instead Conflicts: sd/source/filter/eppt/pptx-epptooxml.cxx Change-Id: I0868eb345932c05b7e40b087035da252b99bf0b9 Reviewed-on: https://gerrit.libreoffice.org/13714 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-18basic: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-12basic: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ied7e5eba39672363065083493bd5e60449fda371
2014-12-09Resolves: fdo#86843 avoid getting deleted before finishing BroadcastCaolán McNamara
Change-Id: I19181f9e2fbd5f906e6e5d807b1b2483e7881cf0
2014-12-06reduce scope of local variablesMichael Weghorn
This eliminates some of the warnings from Cppcheck report of 2014-11-29. Change-Id: Ic4bf3bd8f5982d2ea2f25a28c0dd61084c59af11 Reviewed-on: https://gerrit.libreoffice.org/13331 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-12-03Further clean-upStephan Bergmann
Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
2014-12-03Code clean-up/consolidation task.Vishv Brahmbhatt
Removing the duplicate code,and consolidating changes by using method "getExpandedFilePath" of comphelper. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: adapted to recent change from comphelper::getExpandedFilePath to comphelper::getExpandedUri; fixed the two changes in framework to actually modify the by--non-const--ref argument; fixed a loplugin:unreffun. More clean-up to follow. Change-Id: Ie8875bcb61b616385bd64151f0a915bf7cce04e5
2014-12-03fdo#84938 replace BASERR_REASON_ constants -> enumTobias Madl
Change-Id: I80fe0108c2d27b72d2fadc23032cf2b52c3193a6 Reviewed-on: https://gerrit.libreoffice.org/13268 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-03Add missing include headerDavid Ostrovsky
Change-Id: I59d6f1401cdfc37c0949cc9d439cb7ff52857079 Reviewed-on: https://gerrit.libreoffice.org/13286 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-21busted loop conditionCaolán McNamara
regression from commit 119873328acd70ca3569c21a0b1fe36277e8bf4c Date: Thu Oct 21 15:34:02 2010 -0500 convert vos/process.hxx and related API Change-Id: I36527a4f0109105b9853a79773b4c92f9bc4e902
2014-11-21coverity#1255390 Resource leakCaolán McNamara
Change-Id: I3631d6bbcf45986deb1e911fcdb0e6606a0c6d91
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17coverity#735399 Logically dead codeCaolán McNamara
we can only enter the bAssumeExprLParenMode controlled block once because the block sets bAssumeExprLParenMode to false bAssumeExprLParenMode is only true if the first token read in the method is LPAREN so we can only enter this block if the current token is LPAREN and its the first token processed, so the token can't be BYVAL Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14this is for detecting the type of a variable based on its nameCaolán McNamara
which means legal input is any character which a variable can start with Change-Id: I0c2d13a92ba374f8020e86e90e8e5f18ce8a9c90
2014-11-14coverity#1242865 Untrusted value as argumentCaolán McNamara
Change-Id: Ie7a7a2e7894a204dd55833416b7cbc5b01826e64
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05coverity#1242689 Untrusted loop boundCaolán McNamara
Change-Id: Ie226805ef8d430eb3f7b3abaa54ac3af31f72f7b
2014-11-05coverity#1242865 Untrusted loop boundCaolán McNamara
Change-Id: I9dc9cd98d0a02a2867d4c40c7afb7bf873513143
2014-11-05coverity#1242794 Untrusted loop boundCaolán McNamara
Change-Id: I902a5bf989a8f385994a2f927cce4975b18f06d2
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-30document array_vs_singleton dismissalsCaolán McNamara
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
generated by cgit (git 2.34.1) at 2025-01-15 21:47:46 +0000