summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-12Typo: compatability->compatibilityJulien Nabet
Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08basic: use SolarMutex to lock SfxLibraryContainerMichael Stahl
Originally this used both SolarMutex and an own mutex, then a deadlock was resolved in 2fe6a4a34b38c05e252c71f4d2f18e4a90e61b29 by not locking SolarMutex. Since the class will call event listeners without dropping the mutex e.g. in insertNoCheck(), using the SolarMutex appears better anyway. With this, installing a BASIC extension no longer triggers SolarMutex asserts in SfxBroadcaster. Change-Id: Ib9a2ee491ef53b1a53855af0fc22e863c5e7cb91
2014-10-08basic::ImplRepository: use SolarMutex instead of own mutexMichael Stahl
The locking strategy in the basic module is totally unclear to me, there does not appear to be a dedicated mutex for the core stuff callable via StarBASIC, just a bunch of SolarMutexGuards at random locations; let's try to use SolarMutex at the UNO entry points... Change-Id: Ia9c45fdcfb5ffd0a4acc77ef5d2fabfb8743ad38
2014-10-08back out even more wrong tools::Time changes, geez..Eike Rathke
Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08spelling: instanciated -> instantiatedNoel Grandin
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-03coverity#1242481 Dereference null return valueCaolán McNamara
Change-Id: I21e6bdd643d898a3515a96e4c9c17c2d6f98b0e4
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02loplugin: cstylecastNoel Grandin
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
2014-10-01loplugin: cstylecastNoel Grandin
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
2014-10-01avoid calling OUString::copy() with length being -1Luboš Luňák
Which asserts in dbgutil build. Change-Id: I0f8205ae98c5a57c430b7d8a574e4c0019855841
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-26remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove pointless commentsNoel Grandin
Change-Id: I8edfe830b8f6ca7f1809332870e06d1d286b90e8
2014-09-26remove unnecessary static_cast'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22fdo#84086 Fix assorted use-after-free bugsMatthew J. Francis
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65 Reviewed-on: https://gerrit.libreoffice.org/11553 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-19vba: calm down bool -> long casting concerns.Michael Meeks
Change-Id: Ib32a66d891242701d2f5c55519e5c52a6dd3df3c
2014-09-19vba - disable Currency test / invocation on master.Michael Meeks
We're missing an effective SbxCURRENCY conversion here. Change-Id: Id6530ed3a93623b31089304f3451d9693ab4f3af
2014-09-19vba: add a different variant of the same compatibility function.Michael Meeks
Change-Id: I92bc1dbceea2f10cbb055d97f68b33e575d9be11
2014-09-19vba: initial impl. of compatibility methods.Michael Meeks
Change-Id: Iebc25f1730766e96d2ad6921a8b4d2ea880c63f3
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15Clean up StorageMode parameter of SotStorage::OpenSotStorageStephan Bergmann
...which was only used to transport either STORAGE_TRANSACTED or sal_False (i.e., 0, meaning "not STORAGE_TRANSACTED"). Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-04fdo#52076 remove Library dir when no libraryLionel Elie Mamane
when saving to same storage (in place) we already did that when empty "Standard" was the only library, but not when there was no library... Cannot get through that state in through UI, but possible through scripting. Change-Id: I0f1129e034ac31b3eaf6bd388a03aee5aae5b87e
2014-09-04detect if Standard is only library to *save*Lionel Elie Mamane
as opposed to only library at all Change-Id: I23bebfe7d156e1f4a60bc5f265a3cf9d295f3e4a
2014-09-04add const qualifierLionel Elie Mamane
Change-Id: I88d61668b465e505cfa245dd17893828aaaecaa8
2014-08-26convert SBX flag bits to type-safe enumNoel Grandin
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817 Reviewed-on: https://gerrit.libreoffice.org/11070 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22Revert "Simplify ImplRepository::impl_getLocationForModel return type"Stephan Bergmann
This reverts commit 72305ed49d4c9ba968d7bf6d8d5ae564bb92147d, which was bogus, cf. the comment in ImplRepository::getDocumentBasicManager about recursive calls.
2014-08-22Remove BasicManagerCleanerStephan Bergmann
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22Simplify ImplRepository::impl_getLocationForModel return typeStephan Bergmann
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22Remove trivial typedef, to make code more obviousStephan Bergmann
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-21coverity#1202729 - ensure we have exactly a one dimensional array.Michael Meeks
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-17coverity#1231668 Unchecked return valueCaolán McNamara
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
2014-08-13update_pchThomas Arnhold
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-11-Werror,-Wundefined-bool-conversionStephan Bergmann
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-29basic: -Werror=sign-compareMichael Stahl
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29fdo#46037: remove unused comphelper/configurationhelper.hxxAlexandre Vicenzi
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa Reviewed-on: https://gerrit.libreoffice.org/10603 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-14 13:21:15 +0000