summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2013-02-28coverity#705626 and coverity#705627: fix memory leakMarkus Mohrhard
Change-Id: I68f43d07798ccb3fc3a5ab438992ac74f4cd262a
2013-02-25loplugin: improve indentationThomas Arnhold
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25loplugin: unused variablesThomas Arnhold
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-23Fix typo accessable/accessibleJulien Nabet
Change-Id: I2f6d00a6361243a52a593acaaf2bf624d8a2730e
2013-02-23Fix typo seperated/separatedJulien Nabet
Change-Id: I133423de994b1befe246b6c921802428a3528202
2013-02-23Fix typo "paramater" -> "parameter" + remove some commented linesJulien Nabet
Change-Id: I1e6343fdcee91d23aacd776520e8bfdf81d411e4
2013-02-22coverity#707499 coverity#735400 coverity#738541Norbert Thiebaud
Change-Id: Idc00fe9ad5158043cf2eee652567581111c89177 Reviewed-on: https://gerrit.libreoffice.org/2277 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22coverity#704204 Logically dead codeNorbert Thiebaud
Change-Id: I0a8dbbb3dbe7408e6f4d92c0bbebdaaa7d882f01 Reviewed-on: https://gerrit.libreoffice.org/2271 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22coverity#982288 Logically dead codeNorbert Thiebaud
Change-Id: I4fb90cb00829bc4be7d050521215528de4748d76 Reviewed-on: https://gerrit.libreoffice.org/2245 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-19coverity#735398 Logically dead codeNorbert Thiebaud
Change-Id: Iadb7fbd8a1fb1c535a3ed78d4b2f7120b29aeb75 Reviewed-on: https://gerrit.libreoffice.org/2270 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-02-17coverity#707502 Uninitialized scalar variableCaolán McNamara
Change-Id: I38db032b2e9331170da9e8d84eaa85c894f9d8fb
2013-02-17coverity#707496 Uninitialized scalar variableCaolán McNamara
also... coverity#707497 Uninitialized scalar variable Change-Id: Ie3ac361685a52b23e088b78404ea4e013407fe2a
2013-02-16Move SyntaxHighlighter class from svtools to comphelperAndras Timar
We use this class in helpcompiler, and it is not desirable to compile svtools (thus half of LibreOffice) for a build tool in cross-compiling environment. Change-Id: I5e6bc3e576af41eb03c1420dd347c542306f69fa
2013-02-12Some cppcheck cleaningJulien Nabet
Change-Id: Idb380dbb7470dbdb371778ba0c486392cc55380e
2013-02-12Fix Variable 'TimeBuffer' is not assigned a valueJulien Nabet
See http://nabble.documentfoundation.org/Cppcheck-TimeBuffer-is-not-assigned-a-value-in-basic-module-td4036591.html Change-Id: I2d67cecf3530301d49c43bbe397c5e975b2816b0
2013-02-11blind wae fix for PPUNIT_ASSERT_EQUALNoel Power
Change-Id: I0842e354fb766ebbbf2cff57a410a38fb8b8d3b1
2013-02-11fix basic access to nested uno structures fdo#60117Noel Power
Although basic might appear to correctly change nested struct elements fdo#60117 shows that basic can be fooled ( and even the watch(ed) variable in the debugger shows the expected values ). The problem stems from the fact that the uno object held by basic isn't infact modified when changed via the introspection uno service. Additionally pimp the existing tests to check the actual uno struct to see if the changes made are *really* reflected in the object Change-Id: Iff007e17df87148ea81e69d3567c8cf9857fdcaa
2013-02-11fdo#46808, Use singleton util::theMacroExpander new-style constructorNoel Grandin
And deprecate the old-style service util::MacroExpander Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-11fdo#46808, Use service constructor for awt::DialogProviderNoel Grandin
Change-Id: I5d0a3e66afeadafa6d53ff0a255d036b7e3d528d
2013-02-05fix for fdo#60065Noel Power
squash errors trying to gain object for rhs ( where no object yet exists ( Change-Id: I81548d1c6a32f0445dc18e31c84c3df85163ed45
2013-01-30make basic XubString freeCaolán McNamara
Change-Id: Iea5c01fe902b052a55c86ca3b879bcca12c80690
2013-01-28fdo#46808, Convert SvNumberFormatter to use XComponentContextNoel Grandin
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28fdo#46808, Adapt document::GraphicObjectResolver UNO service to new styleNoel Grandin
The services already existed, it just did not have an IDL file Change-Id: I245f78c165dbfde11a981efd7033c5c282f4e8ad
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-21Changed SetText() / GetText() to take/return OUStringChr. Rossmanith
replaced lots of Len() with isEmpty() Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0 Reviewed-on: https://gerrit.libreoffice.org/1795 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()Jean-Noël Rouvignac
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de Reviewed-on: https://gerrit.libreoffice.org/1784 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-14fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan
- Clean up OSL_ - Clean up DBG_ - Clean up OUString Change-Id: I002d17ffbbd8371b0518ede34931b2eea30865a3 Reviewed-on: https://gerrit.libreoffice.org/1602 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-07fdo#53521 Crash when running BASIC's "shell()" with a non-existent programChristopher Copits
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed. Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3 Reviewed-on: https://gerrit.libreoffice.org/1530 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-03fix buildLuboš Luňák
Change-Id: I2588b69280abbc510ee2fdc9845df56616db8b95
2013-01-03fdo#57950: One more chained append in basicMarcos Paulo de Souza
Change-Id: I179b5bfd1d85152a53bb821ab9eeb78efb8a6083 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1516 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-03fdo#57950: Fix some chained appends in basicMarcos Paulo de Souza
Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1515 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-03Remove all occurences of RTL_* and ::rtl prefix from basicMarcos Paulo de Souza
This is a big commit, so thanks for your time reviewing this :) Conflicts: basic/source/sbx/sbxscan.cxx Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933 Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-01remove use of #pragma optimizeLuboš Luňák
All these are years old, guessing from some comments as old as Windows 9x support. These workarounds do not seem to be needed now. Change-Id: If67baa5cdefcec33b28696c764b1ed96143b7ccd
2012-12-31Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test_scanner.cxxMarcos Paulo de Souza
Change-Id: Ie9bb6018955faa41c359d18c6b2c10b58fd20db9 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1512 Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br> Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-29Remove rtl prefixes and some RTL_CONST* from basicMarcos Paulo de Souza
Change-Id: If15d7c97de5295ea7d7f341e6b34acbfc917218d Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1504 Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br> Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-28Some cppcheck cleaning in basicJulien Nabet
Change-Id: I01ad0d95a94ede6998850937c58495920e7a4113
2012-12-27fdo#58222 The BASIC HEX Command now returns uppercase hexadecimal charactersChristopher Copits
Instead of returning lowercase characters with BASIC's HEX command, uppercase characters are now returned. Digits from 0-9 are not affected. This change utilizes on OUString's toAsciiUpperCase() method. Change-Id: Id6ea93a7635c1913c8592bf5519bdd7391f4e3bc Reviewed-on: https://gerrit.libreoffice.org/1428 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-12-27Sigh, my git grep regexps missed some casesTor Lillqvist
Change-Id: I085f14f40fb83cba171b35b14cf7c0d99091fc00
2012-12-25Get rid of (most uses of) GUITor Lillqvist
GUI only takes values UNX or WNT, so it is fairly pointless. One can check whether OS is WNT or not instead. Change-Id: I78ae32c03536a496a563e5deeb0fca78aebf9c34 Reviewed-on: https://gerrit.libreoffice.org/1304 Reviewed-by: Peter Foley <pefoley2@verizon.net> Tested-by: Peter Foley <pefoley2@verizon.net>
2012-12-21fdo#46808, Convert frame::Desktop to new style service.Noel Grandin
I had to drop XEventBroadcaster from the merged interface because it introduced method name conflicts (addEventListener). Shouldn't be an issue since it was scheduled to be dropped anyhow, and the service implementation still implements it, so existing clients will be fine. I dropped the interface XPropertySet from the combined IDL because nobody seems to be using it, and it's primary purpose appears to be to set weird flags. I dropped the optional interfaces XStatusIndicatorFactory XDispatchInformationProvider from the combined IDL because the service does not implement them, and nobody seems to be using them. I suspect they were mistakenly copied from XFrame. I also did not convert the Title, UserDefinedAttributes and LayoutManager properties to attributes, again because no-one is using them. Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-19fix crash for fdo#58306 by avoiding literal assignNoel Power
OUStringBuffer doesn't handler append ( if it had been previously assigned to "" literal ) Change-Id: Ief4379490a4873fbee4117db5833111943b86334
2012-12-17Remove --with-stlport from LO 4.0Stephan Bergmann
The STLport was only built for the benefit of old extensions on platforms that once used it themselves (Linux x86, Solaris x86 and SPARC, Windows). We deliberately break such old extensions for LO 4.0 by no longer shipping that backwards-compatiblity cludge. Keeps STLport listed in readlicense_oo/ because of o3tl/inc/o3tl/compat_functionality.hxx. Also removes GXX_INCLUDE_PATH, as that was only used by STLport (if at all?). Removes a spurious #define MOVEFILE_REPLACE_EXISTING 0x01 from l10ntools/inc/helpmerge.hxx that was once added with 854812584862d0609b695682d2bfea2667d75c00 "INTEGRATION: CWS extensionl10nfix01 (1.11.6); FILE MERGED: 2008/06/26 13:56:03 ihi 1.11.6.1: #i90987# windows rename -> MoveFileEx" but now starts to cause trouble on Windows. Also disables warning C4005 about redefinition of WB_LEFT/RIGHT macros (defined in both tools/wintypes.hxx and the Windows API) in a number of places that include windows.h -- however the old STLport caused those warnings to not show. Change-Id: Ie138a219fbbc86fb5aaa7ea0b88cf349935d9829
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-28fdo#46808, Adapt reflection::ProxyFactory UNO service to new styleNoel Grandin
The service is deprecated, but we still have a handful of in-tree users, and converting it lets me thread XComponentContext through a bunch of classes. Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-25German comment translationsMarkus Maier
Change-Id: I0d169b7cd0f47b6986063d0cc0b6697b1d575e6a
2012-11-23some i18n wrappers with LanguageTagEike Rathke
Change-Id: I2ceaa3159e8669c2c569fa8559c1e061dcad399d
2012-11-22AllSettings with LanguageTagEike Rathke
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22convert users of XDocumentInfo to XDocumentPropertiesMichael Stahl
Change-Id: I10f395f90d554d0ec26fe9f2654ae839e21c7ee5
2012-11-20Merge branch 'feature/killsdf'Andras Timar
Conflicts: desktop/prj/build.lst helpcontent2 l10ntools/Executable_gsicheck.mk l10ntools/Executable_uiex.mk regexp/inc/regexp/reclass.hxx solenv/gbuild/AllLangResTarget.mk Change-Id: I398f0cd9e7daefa8d2e04fd977d5bc2e9708169b
2012-11-19Bin the HACK() sillynessTor Lillqvist
Change-Id: Ieeebc4098404fa006d66bb8b656172a4348b1dc1