summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2016-12-05tdf#93592 Make it possible to add default language resource to dialogeditorNiklas Johansson
During the conversion of uno services a few lines where removed that probably should not have been removed. This caused the dialog editor to crash if you tried to add a new language resource to a document fdo#93077. The fix for that bug fixed the crash but also made it imposible to add a language resource to a dialog that isn't previously translated. With this patch the functionality should be back on track, adding/removing language resources without problems at least as far as my testing goes. Change-Id: Ie6e083837894a219bf8e9c75dec6bf7652d51615 Reviewed-on: https://gerrit.libreoffice.org/30462 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 1453bc4ab3d42c34c32a7da63ed6f7bdbe513c2d) Reviewed-on: https://gerrit.libreoffice.org/31533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28Bypass VBATest::testMiscOLEStuff() in a 64-bit Windows build for nowTor Lillqvist
It fails when Excel is installed, for some reason: Basic error: Type: com.sun.star.uno.RuntimeException Message: [automation bridge] unexpected exception in IUnknownWrapper_Impl::invoke ! Message : [automation bridge]: [Microsoft][ODBC Driver Manager] Data source name not found and no default driver specified macro result for ole_ObjAssignNoDflt.vb macro returned: C:/cygwin64/home/Tor/lo/64bit-debug/basic/qa/cppunit/test_vba.cxx:155:`anonymous namespace'::VBATest::testMiscOLEStuff assertion failed - Expression: pReturn->GetOUString() == "OK" - Result not as expected Note that this test returns early if Excel is not installed, so it is effectively not performed anyway even in 32-bit builds on most (any?) Jenkins and tinderbox machines. Change-Id: I0a0b6f27219dec116369fae1bb7c95b3e9597e77 Reviewed-on: https://gerrit.libreoffice.org/30329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-03tdf#102872 TAB function is missing its argumentLaurent Balland-Poirier
Commit 98f0e0eda50690bd01842c806bd13e3bc5af2966 introduced TAB function but its declaration in basic/source/runtime/stdobj.cxx is missing its argument So it used TAN function as argument Change-Id: Id4461ca805f9c7034b0440de46b845f29f57e3b0 Reviewed-on: https://gerrit.libreoffice.org/29452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-24Resolves: tdf#88953 byref args incorrectly passed in basic->c++Caolán McNamara
partial revert of commit 22b094f5d8e1e82375b135abd3a6f99a9a555244 Date: Tue Jul 14 14:50:07 2015 +0200 loplugin:unusedmethods basic and partial revert of... commit e2080e70fe8b085f18e868e46340454720fa94ca Date: Wed Jun 18 12:14:29 2014 +0200 new compilerplugin returnbyref and revert of... commit 536051f8862203e0e115a5394a6379acd83cc8fe Date: Wed Jul 15 14:04:01 2015 +0200 fix Windows build after commit 22b094f5d8e1e82375b135abd3a6f99a9a555244 "loplugin:unusedmethods basic" Change-Id: I612937334fdb75365080c98a9d4da5ed7ae647e3 (cherry picked from commit 4a647a04a7881964ce13b541399f89e4ab042ea8) Reviewed-on: https://gerrit.libreoffice.org/28249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-20Resolves: tdf#98778 fix parsing of exponentsCaolán McNamara
regression from... commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d Date: Tue Mar 19 23:23:16 2013 +0100 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number Change-Id: I96535fd9bc9ec59d6e07739a3118c96eb2d8bd05 Reviewed-on: https://gerrit.libreoffice.org/27342 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2aed0d49d7891b9360916b65771222810aeeac96) Reviewed-on: https://gerrit.libreoffice.org/27348 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07tdf#99696 fix build error for 64bit Windows in unit tests using ADODBTomofumi Yagi
This patch fixes the problem that the build for x64 fails in basic module on 64bit Windows installed 32bit Excel Application. New code checks the existance of ODBC driver for excel insted of the existance of Excel application(at this time the bitness of ODBC driver for excel would match that of building LibreOffice). What we need is probably not Excel Application but ODBC drivers for proper bitness. Change-Id: I62285eb2351f2022754fc34cb2d54db1bd9e8142 Reviewed-on: https://gerrit.libreoffice.org/25301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d2a44e62704f185a0acecbb6320b92a4df3063b9) Reviewed-on: https://gerrit.libreoffice.org/25981
2016-05-31Resolves: tdf#93386 crash when closing a Database with macro editor openCaolán McNamara
Change-Id: Id3ecee744cb10f539f2b57e83a4b6e4c7744d3d5 (cherry picked from commit 9a0fd9c7f424fb787e1fae2113f0a42f0895a1e9)
2016-05-25Fix typosAndrea Gelmini
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Resolves: tdf#93474 crash on importing a macro libraryCaolán McNamara
its a SfxLibrary which is not a XLibraryContainer (a SfxLibraryContainer is however) I think the issue is simply an empty name making code go down the container rather than library route. Change-Id: Ib0245d402fe375ac26ab9f2b14fe708b2a34a7a7
2016-05-23Convert SbxClassType to scoped enumNoel Grandin
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Id6e230d026184ab243e994a17515f2e5539d3646
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav
Used toAsciiUpperCase() from character.hxx Change-Id: I79f4638866daf8952103c8a521db925150e8dcda Reviewed-on: https://gerrit.libreoffice.org/24709 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-08BASIC : Remove an useless static_cast and use make_uniqueArnaud Versini
Change-Id: I32ec7e02ebf5a469db87bd2206d5fcd604b86795 Reviewed-on: https://gerrit.libreoffice.org/24720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-07BASIC: SbiParser Remove useless static_cast and indent the code correctly.Arnaud Versini
Change-Id: I8c7a01c3023f998785c8b719f7ae53da57ff3e47 Reviewed-on: https://gerrit.libreoffice.org/23939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-01Fix typo in codeAndrea Gelmini
Change-Id: Ib1daf257018d5a5da90773dd39086f18666fea9f Reviewed-on: https://gerrit.libreoffice.org/24533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256 Reviewed-on: https://gerrit.libreoffice.org/24543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21clang-tidy modernize-loop-convert in b*Noel Grandin
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Ib91f20761167ab78b68813d8877dceea5fef801f
2016-04-19BASIC : Partially revert SbxArray simplification.Arnaud Versini
Revert partially commit 0fa6c88007f61176ac707cb5d77fd35cf1521123 (BASIC : Simplify SbxArray) to make sure SbxArray::Put add too much objects behind 65k limit. Change-Id: I2d86f213711665f8cb522879ff78ff5bc9f42b31 Reviewed-on: https://gerrit.libreoffice.org/24223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18BASIC : Simplify SbxArrayArnaud Versini
Change-Id: I988fcfed2b03039cbc167eaee1d09bffe42cd411 Reviewed-on: https://gerrit.libreoffice.org/24171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove needless typedef from basic/qa/cppunit/basic_coverage.cxxRyan McCoskrie
Change-Id: Iba1c48d58daa618107ad84240d613f675d447aad Reviewed-on: https://gerrit.libreoffice.org/24175 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-17tdf#99357: Basic, return if .with pNode nullJulien Nabet
Program received signal SIGSEGV, Segmentation fault. 0x00002aaaaed9741e in SbiExprNode::GetVar (this=0x0) at /home/julien/lo/libreoffice/basic/source/comp/exprnode.cxx:118 118 if( eNodeType == SbxVARVAL ) (gdb) bt 0 0x00002aaaaed9741e in SbiExprNode::GetVar (this=0x0) at /home/julien/lo/libreoffice/basic/source/comp/exprnode.cxx:118 1 0x00002aaaaed9afd6 in SbiParser::With (this=0x50eac70) at /home/julien/lo/libreoffice/basic/source/comp/loops.cxx:266 2 0x00002aaaaed9d1a7 in SbiParser::Parse (this=0x50eac70) at /home/julien/lo/libreoffice/basic/source/comp/parser.cxx:437 Change-Id: If0ecacd007a14e2ba81181da0fe472ea667c4cb7 Reviewed-on: https://gerrit.libreoffice.org/24147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-15remove tools/solarmutex.hxxNoel Grandin
Deprecated in favour of comphelper::SolarMutex Change-Id: I159077562660de5df25601fa471447f4b64a2cf1 Reviewed-on: https://gerrit.libreoffice.org/24079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13loplugin:passstuffbyref in basicNoel Grandin
Change-Id: Ie93b33502325f00ba95ab168a445a347148f9edd
2016-04-13Related tdf#99089: avoid second crashJulien Nabet
Second bt quoted in https://cgit.freedesktop.org/libreoffice/core/commit/?id=43109b751bf5fd36318de56b2fb686acc724673f wasn't solved, try to fix it now. Change-Id: I68484f9417ff0bf747306ac8774cad5fdf84b924 Reviewed-on: https://gerrit.libreoffice.org/24042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: Ic59b23de2c11e8a0a86c3711a4507cd76e07896f
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I0ed8754bb06328b61a41079a4f446d8dd2b61bb7
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: If64f146fd9c6417ed16d459cef39b3a2d47bfb4d
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11BASIC: Remove useless static_cast from basmgr.cxxArnaud Versini
Change-Id: If389aaabd22751908beba7dee9dbc79460692524 Reviewed-on: https://gerrit.libreoffice.org/23958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-04-11Avoid reserved identifierStephan Bergmann
Change-Id: I6dfb2961adeb412405c58e0a0b51e130cbd3e0c3
2016-04-11Remove an useless check I had addedJulien Nabet
Reverts partly https://cgit.freedesktop.org/libreoffice/core/commit/?id=43109b751bf5fd36318de56b2fb686acc724673f Change-Id: Ief7fd752d260031e243ea4304f6c55fa4dc42bfd Reviewed-on: https://gerrit.libreoffice.org/23984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-11clang-tidy performance-unnecessary-value-param in basicNoel Grandin
Change-Id: I997213ca28efc2df04d454ffaf3c81c9cbad09ac
2016-04-11make GetGlobalUNOConstant and GetUNOConstant take an OUStringNoel Grandin
and eliminate converting backwards and forwards between sal_Char*/OString/OUString Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f Reviewed-on: https://gerrit.libreoffice.org/23919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10tdf#99089: avoid some crashes in BasicJulien Nabet
First stacktrace: soffice.bin: /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577: sal_Unicode rtl::OUString::operator[](sal_Int32) const: Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed. ... 3 0x00002aaaab327452 in __GI___assert_fail (assertion=0x2aaaaeea62a8 "index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())", file=0x2aaaaeea6260 "/home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx", line=577, function=0x2aaaaeea6860 <rtl::OUString::operator[](int) const::__PRETTY_FUNCTION__> "sal_Unicode rtl::OUString::operator[](sal_Int32) const") at assert.c:101 4 0x00002aaaaed91e89 in rtl::OUString::operator[](int) const (this=0x7fffffff2770, index=0) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577 5 0x00002aaaaee1c66f in SbRtl_Val(StarBASIC*, SbxArray&, bool) (pBasic=0xa2a7ec0, rPar=..., bWrite=false) at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:1792 Second stacktrace: 0x00002aaaaee6054d in printfmtstr (rStr="", rRes="", rFmt="\£0.##") at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534 534 while( *pFmt != '\' ); (gdb) bt 0 0x00002aaaaee6054d in printfmtstr(rtl::OUString const&, rtl::OUString&, rtl::OUString const&) (rStr="", rRes="", rFmt="\£0.##") at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534 1 0x00002aaaaee617ce in SbxValue::Format(rtl::OUString&, rtl::OUString const*) const (this=0xb12dd60, rRes="", pFmt=0x7fffffff20e0) at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:883 2 0x00002aaaaee217af in SbRtl_Format(StarBASIC*, SbxArray&, bool) (pBasic=0xa2cffa0, rPar=..., bWrite=false) at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:3519 Change-Id: I1798a1545ce08efa9d6fc39f4696195f9dc96c67 Reviewed-on: https://gerrit.libreoffice.org/23956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-07fix bug in SbxArray::MergeNoel Grandin
bug was recently introduced by commit a5c232831395f8987a8395816c5a60105a52b6a0 "BASIC: Store directly SbxVarEntry in SbxArray" bug was found by clang-tidy Change-Id: Ibcce6d6024ac60eb143cd873760586a7f6231858 Reviewed-on: https://gerrit.libreoffice.org/23890 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-04-06Avoid reserved identifierStephan Bergmann
Change-Id: I2f8dc470100e91841eebbe1e3b02a3d31ab3a535
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: Ibba1a36d4f3744fa68f7e9d0076c997e076262cb
generated by cgit (git 2.34.1) at 2024-08-11 23:00:17 +0000