summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2013-01-07fdo#53521 Crash when running BASIC's "shell()" with a non-existent programChristopher Copits
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed. Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3 Reviewed-on: https://gerrit.libreoffice.org/1530 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-03fix buildLuboš Luňák
Change-Id: I2588b69280abbc510ee2fdc9845df56616db8b95
2013-01-03fdo#57950: One more chained append in basicMarcos Paulo de Souza
Change-Id: I179b5bfd1d85152a53bb821ab9eeb78efb8a6083 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1516 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-03fdo#57950: Fix some chained appends in basicMarcos Paulo de Souza
Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1515 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-03Remove all occurences of RTL_* and ::rtl prefix from basicMarcos Paulo de Souza
This is a big commit, so thanks for your time reviewing this :) Conflicts: basic/source/sbx/sbxscan.cxx Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933 Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-01remove use of #pragma optimizeLuboš Luňák
All these are years old, guessing from some comments as old as Windows 9x support. These workarounds do not seem to be needed now. Change-Id: If67baa5cdefcec33b28696c764b1ed96143b7ccd
2012-12-31Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test_scanner.cxxMarcos Paulo de Souza
Change-Id: Ie9bb6018955faa41c359d18c6b2c10b58fd20db9 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1512 Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br> Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-29Remove rtl prefixes and some RTL_CONST* from basicMarcos Paulo de Souza
Change-Id: If15d7c97de5295ea7d7f341e6b34acbfc917218d Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1504 Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br> Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-28Some cppcheck cleaning in basicJulien Nabet
Change-Id: I01ad0d95a94ede6998850937c58495920e7a4113
2012-12-27fdo#58222 The BASIC HEX Command now returns uppercase hexadecimal charactersChristopher Copits
Instead of returning lowercase characters with BASIC's HEX command, uppercase characters are now returned. Digits from 0-9 are not affected. This change utilizes on OUString's toAsciiUpperCase() method. Change-Id: Id6ea93a7635c1913c8592bf5519bdd7391f4e3bc Reviewed-on: https://gerrit.libreoffice.org/1428 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-12-27Sigh, my git grep regexps missed some casesTor Lillqvist
Change-Id: I085f14f40fb83cba171b35b14cf7c0d99091fc00
2012-12-25Get rid of (most uses of) GUITor Lillqvist
GUI only takes values UNX or WNT, so it is fairly pointless. One can check whether OS is WNT or not instead. Change-Id: I78ae32c03536a496a563e5deeb0fca78aebf9c34 Reviewed-on: https://gerrit.libreoffice.org/1304 Reviewed-by: Peter Foley <pefoley2@verizon.net> Tested-by: Peter Foley <pefoley2@verizon.net>
2012-12-21fdo#46808, Convert frame::Desktop to new style service.Noel Grandin
I had to drop XEventBroadcaster from the merged interface because it introduced method name conflicts (addEventListener). Shouldn't be an issue since it was scheduled to be dropped anyhow, and the service implementation still implements it, so existing clients will be fine. I dropped the interface XPropertySet from the combined IDL because nobody seems to be using it, and it's primary purpose appears to be to set weird flags. I dropped the optional interfaces XStatusIndicatorFactory XDispatchInformationProvider from the combined IDL because the service does not implement them, and nobody seems to be using them. I suspect they were mistakenly copied from XFrame. I also did not convert the Title, UserDefinedAttributes and LayoutManager properties to attributes, again because no-one is using them. Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-19fix crash for fdo#58306 by avoiding literal assignNoel Power
OUStringBuffer doesn't handler append ( if it had been previously assigned to "" literal ) Change-Id: Ief4379490a4873fbee4117db5833111943b86334
2012-12-17Remove --with-stlport from LO 4.0Stephan Bergmann
The STLport was only built for the benefit of old extensions on platforms that once used it themselves (Linux x86, Solaris x86 and SPARC, Windows). We deliberately break such old extensions for LO 4.0 by no longer shipping that backwards-compatiblity cludge. Keeps STLport listed in readlicense_oo/ because of o3tl/inc/o3tl/compat_functionality.hxx. Also removes GXX_INCLUDE_PATH, as that was only used by STLport (if at all?). Removes a spurious #define MOVEFILE_REPLACE_EXISTING 0x01 from l10ntools/inc/helpmerge.hxx that was once added with 854812584862d0609b695682d2bfea2667d75c00 "INTEGRATION: CWS extensionl10nfix01 (1.11.6); FILE MERGED: 2008/06/26 13:56:03 ihi 1.11.6.1: #i90987# windows rename -> MoveFileEx" but now starts to cause trouble on Windows. Also disables warning C4005 about redefinition of WB_LEFT/RIGHT macros (defined in both tools/wintypes.hxx and the Windows API) in a number of places that include windows.h -- however the old STLport caused those warnings to not show. Change-Id: Ie138a219fbbc86fb5aaa7ea0b88cf349935d9829
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-28fdo#46808, Adapt reflection::ProxyFactory UNO service to new styleNoel Grandin
The service is deprecated, but we still have a handful of in-tree users, and converting it lets me thread XComponentContext through a bunch of classes. Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-25German comment translationsMarkus Maier
Change-Id: I0d169b7cd0f47b6986063d0cc0b6697b1d575e6a
2012-11-23some i18n wrappers with LanguageTagEike Rathke
Change-Id: I2ceaa3159e8669c2c569fa8559c1e061dcad399d
2012-11-22AllSettings with LanguageTagEike Rathke
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22convert users of XDocumentInfo to XDocumentPropertiesMichael Stahl
Change-Id: I10f395f90d554d0ec26fe9f2654ae839e21c7ee5
2012-11-20Merge branch 'feature/killsdf'Andras Timar
Conflicts: desktop/prj/build.lst helpcontent2 l10ntools/Executable_gsicheck.mk l10ntools/Executable_uiex.mk regexp/inc/regexp/reclass.hxx solenv/gbuild/AllLangResTarget.mk Change-Id: I398f0cd9e7daefa8d2e04fd977d5bc2e9708169b
2012-11-19Bin the HACK() sillynessTor Lillqvist
Change-Id: Ieeebc4098404fa006d66bb8b656172a4348b1dc1
2012-11-18PutEntry familly of functions use consistent pairing OUString/sal_Int32Norbert Thiebaud
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
2012-11-18basic: fix OUString copy overrun in Mid()Norbert Thiebaud
Change-Id: I91cdd3a52917b89ab2a452e0eeb7a9e00dc35e8b Reported-by: vmiklos@suse.cz
2012-11-15fdo#46808, use service constructor for ucb::SimpleFileAccessNoel Grandin
I upgraded the service to return XSimpleFileAccess3, since it already implemented that interface, and it's backwards compatible. Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-14Clean upStephan Bergmann
Also, avoid global static data in sb lib, so that gengal.bin now also works well on Mac OS X, cf. 12fa9ece663f24eff44197befe546a92e6c90724 "Avoid global static data." Change-Id: I23f2a7abc0c06a752ded1c1c64619b3aab009190
2012-11-14Report errors for invalid DateAdd/Diff/Part Add parameter valuesStephan Bergmann
...so that e.g., DateAdd("x", 1, "1/31/2004") (where "x" is not in the list of valid values for the Add parameter, "yyyy", "q", "m", etc.) leads to a Basic runtime error rather than going into a seemingly endless while(nNewMonth>nTargetMonth) loop at the end of RTLFUNC(DateAdd) (basic/source/runtime/methods.cxx). Change-Id: I15c3bdb62723ffddf36ff2396ffb294369d93ff8
2012-11-11Merge branch 'master' into feature/killsdfAndras Timar
Conflicts: Repository.mk RepositoryFixes.mk connectivity/prj/build.lst extensions/prj/build.lst filter/prj/build.lst fpicker/prj/build.lst l10ntools/StaticLibrary_transex.mk saxon/build.xml shell/prj/build.lst solenv/gbuild/AllLangResTarget.mk solenv/gbuild/Configuration.mk solenv/gbuild/UI.mk ucb/source/ucp/webdav/webdavcontent.cxx
2012-11-08fix more warning C4804 unsafe use of type boolMichael Stahl
... from commit bbf1bcd9ad9cc0368aef4a4de41e9538f6ad91b0 Change-Id: Ic8e52f6848e09a274133f2d8fd1c4044cae4b039
2012-11-07BasicScriptListener_Impl::firing_impl: actually this is the defaultMiklos Vajna
Change-Id: I0fdb522a1119da4a75094db86217449e9d940d19
2012-11-07basic: fix String -> OUString conversion in BasicScriptListener_ImplMiklos Vajna
Regression from commit ac476e78848ad02fd399633acbe9cb72e40d1235, the second parameter of OUString::copy() is not the end position, but the length. In practice this makes xray usable again. Change-Id: I9f345648c851b61e2e3c581bc605af7df4c12c87
2012-11-07basic: adapt dllmgr-x64.cxx to OUString changesMichael Stahl
Change-Id: I9e5ff5be1f001a9f55953fd516fb5ef7fe94bf44
2012-11-07Fix String -> OUString falloutTor Lillqvist
Change-Id: I038848aed0c64c39ca93da89b4a78bd3a1f6d7d0
2012-11-07basic: String -> OUStringNorbert Thiebaud
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-05fdo#46808, Adapt i18n::Transliteration UNO service to new styleNoel Grandin
Simply make the service implement XExtendedTransliteration, since all of the implementatins already do that. Change-Id: If03bf56a8d33931ad0230743a4603e2ae9b104ac
2012-11-04Fix .Len -> getLengthJulien Nabet
Change-Id: Ibe3e97a6fa59098b9234e4aae04118abc4e37eea
2012-11-03basic add a generic unit test fixtureNorbert Thiebaud
basic_coverage is a generic unit test that scan qa/basic_coverage/* each file there is supposed to be a well formed Basic script that define as least a Function doUnitTest as Integer that return 1 if OK, 0 if not OK Change-Id: I6c3cfac1e7ce4748f46c04344102a0eff69b6a49
2012-11-03basic: preliminary cosmetic clean-upNorbert Thiebaud
parsing 1000s of line of code is hard enough without having to fight with weird indentation and irregular formatting. So as the review progress, in order to follow the code, cosmetic changes were made... In order to minimize the task of the reviewers and allow them to concentrate on what matter, an effort is made to collect these cosmetic changes into this separate commit. Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03basic: OUStringification of ddectrlNorbert Thiebaud
Change-Id: I2af40d7c8117aff8ce62a8ea0eec579664f8bdeb
2012-11-03basic migration to OUStringNorbert Thiebaud
Change-Id: I1f9403174b3779801d91ba20d846191ed9a09eed
2012-11-03basic: convert StepPAD to OUStringNorbert Thiebaud
Change-Id: I19d05f455767c973a47d0233b3af20af1ac3a20a
2012-11-03simplify and use OUString for StepLOADNCNorbert Thiebaud
Change-Id: I92c86f672cc79506c2c7c56bb3402b4436f71c98
2012-11-03basic: use OUString in DimAsNewRecoverItemNorbert Thiebaud
Change-Id: Icfecff549161c3c429524549b65752671792a94f
2012-11-03basic: unnecessary round-trip via StringNorbert Thiebaud
Change-Id: I691a59b8ab9e6352a9257dac35b8e378e6ef9666
2012-11-03basic: avoid String<>OUString issue by by-passing them completelyNorbert Thiebaud
Change-Id: If741661f1151950a2180fa5c6504957b44a7e998
2012-11-03basic: clean-up String from eventatt.cxxNorbert Thiebaud
Change-Id: I78f39310dbb0a024af4268f503a6150451f12778
2012-11-03basic: String -> OUString in basicmanagerNorbert Thiebaud
Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5
2012-11-03svformatter already accept OUString inputNorbert Thiebaud
Change-Id: Icca8c40db4a4449876e115a0746319f3f893e846
2012-11-03basic: use OUString internaly for error messagesNorbert Thiebaud
Change-Id: I9ea243f93b7477814037deca2f332c3359ce527d