summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2015-03-07convert error number to stringLeMoyne Castle
BASIC error type was printing as "Error "+ odd char instead of "Error " + error number Change-Id: I7407833626d6117f932cc29c6dab1a8a64c50b5a Reviewed-on: https://gerrit.libreoffice.org/14776 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-02WaE: implicit conversion from bool to 'int'Tor Lillqvist
Change-Id: I40782009fb8d73f827c82c298586a7d4542561c9
2015-03-02convert SBI_ constants to enum classNoel Grandin
Change-Id: I65e706f4e1adfe242808293d9514c9db8d22cc12
2015-03-01likely intentDavid Tardon
Change-Id: I2372ddec8e82eb99206661469843d7837d2bf6d1
2015-02-26Clean up previous commitStephan Bergmann
Change-Id: Iddade9d297be8f4a4e69b3bec5ab7588bf68c112
2015-02-26basic: convert sb.component to constructor usageChris Sherlock
Change-Id: I45ddf460fa7d673c5210f9415b2a8015988a643e Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-02-25remove NUMBERFORMAT_ constantsNoel Grandin
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-24fix marking of free slots in arrayNoel Grandin
Change-Id: I5170b9bbc4a3acab8307f7ad5ebc5e4ba9d58352
2015-02-23tdf#86543: reinterpret_cast -1 of appropriate width as special markerStephan Bergmann
Change-Id: Idf0d2a77a78e0e8fcbf435984b9b8f4393e4c207
2015-02-17tdf#39440 - cppcheck cleanlinessRadu Ioan
Fixed some cppcheck defects Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb Reviewed-on: https://gerrit.libreoffice.org/14487 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-09Basic : Partially rewrite hex and octal constant reading.Arnaud Versini
Change-Id: I42f72e7b1ca897aba71950841f90b501cf3b6dc2 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-02-08Basic : Small OString usage simplificationArnaud Versini
Change-Id: I6d6032b3075e98abb38859207e4a25e1a2e13e98 Reviewed-on: https://gerrit.libreoffice.org/14351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Iabc7b3fe295743db014e0bce78f9dc65e069d848
2015-02-05Remove redundant explicit up-castsStephan Bergmann
Change-Id: I58fd91354fe41673216674f5ae9c11c17cb3f29d
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05fdo#39440: replace C-style cast'sJuan Picca
* Add get() method to tools::SvRef Change-Id: I3825852176c9c37f3ee21f4fd57328b1c7451951 Reviewed-on: https://gerrit.libreoffice.org/14268 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-02callcatcher: shave off a few moreCaolán McNamara
Change-Id: Ie48cf7f89c8c826e56409c2493e1e1250086f10a
2015-01-31Use rtl/character.hxx in basic module when possibleArnaud Versini
Change-Id: I1296541ac1a6a65a613818a1264c2b7482915e64 Reviewed-on: https://gerrit.libreoffice.org/14170 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-01-30coverity#1267698 Uninitialized scalar fieldCaolán McNamara
Change-Id: I79974d276a8f7f856dbf09b14b06ce3b1bb418f0
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29tdf#76174: basic: lock SolarMutex in BasicScriptListener_ImplMichael Stahl
... before calling into BASIC. Change-Id: I51a59fe5ca9b15ff7ec509c052964523d87a9790
2015-01-28remove unused typedefsNoel Grandin
found with some minor modifications to find/find-unused-defines.sh Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd Reviewed-on: https://gerrit.libreoffice.org/14194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-26implement css::i18n::XCalendar4 and LocaleCalendar2 service, tdf#63230Eike Rathke
Implementation only, new local date/time routines not used yet from the outside in this step.
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-25coverity#1266457 Identical code for different branchesCaolán McNamara
Change-Id: I809ad43ad4541e4dcd5c245b469d30605f9f0d27
2015-01-24WaE: rewrite call of rtl::OUString::operator= ...Tor Lillqvist
... with empty string constant argument as call of rtl::OUString::clear [loplugin:stringconstant]. Actually, no need to clear the string here as it already is empty, surely? Change-Id: Ib4b1a6e1b0c0f59c1c964fe58d26058b492c3821
2015-01-23Related fdo#87834: add 2 unit testsJulien Nabet
Change-Id: I4735b15c9535dc17665629510fdafe3dd4086e0b Reviewed-on: https://gerrit.libreoffice.org/13708 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-23Resolves fdo#87834: strange behavior of mid()-functionJulien Nabet
See https://bugs.freedesktop.org/show_bug.cgi?id=87834 Thank you Michael Büssow for pointing these cases Change-Id: I3a9b58360ddab529d1fb2f7eeba7f1c7ae69ba7c Reviewed-on: https://gerrit.libreoffice.org/13707 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20Some more loplugin:cstylecast: basicStephan Bergmann
Change-Id: Ib22bc7408d333a7080fa44c9c3ac9535ccf00752
2015-01-19Fix typo comments Resouce->ResourceAndrea Gelmini
Change-Id: Ia3195a21ad46b4c9830ee6293135dfe5945986a2 Reviewed-on: https://gerrit.libreoffice.org/13985 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-16remove unnecessary parenthesesNoel Grandin
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-13simplify Date/Time/DateTime conversion codeNoel Grandin
add constructors to Date/DateTime/Time, that take the css::util counterparts, to simplify code converting between these type Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7 Reviewed-on: https://gerrit.libreoffice.org/13855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-01-11Related: #i94895# revert the part of revision 1650261Tsutomu Uchino
replaced string should be starting with the start postion if specified (cherry picked from commit 68c6265584fb6cb0469098507dd287e6e1127324) Conflicts: basic/source/runtime/methods.cxx Change-Id: Ib729facfa78ffddebc258440324f05d037fae46f
2015-01-09Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara
and adjust the basic test-case, which is surely wrong The syntax for REPLACE is: // Replace(expression, find, replace[, start[, count[, compare]]]) surely in the case of a start of 3 the preceeding chars should be returned unchanged in the result, not stripped off as before this change. This reverts commit 869402a58720b45e7227438b2e56e5a9532c0000. Change-Id: Ie710e4de9e7e35c84abe2770142a963532820af4
2015-01-09loplugin:cstylecastStephan Bergmann
Change-Id: I86aaad9f38ad63121805fa3dc05b3a8a33428ef7
2015-01-09Resolves: #i63614# fix strange type mismatch when Iif function is usedTsutomu Uchino
Second or later compilation uses value type returned by previous execution of code. Use the defined type as return value of the runtime function of Basic always. (cherry picked from commit 7470c682e136a4a89c1e9474bbc79b2d61f31048) Conflicts: basic/inc/basic/sbxmeth.hxx basic/inc/basic/sbxobj.hxx basic/source/runtime/stdobj.cxx basic/source/sbx/sbxobj.cxx Change-Id: I3064e8403286a9c1401ef658bf139bedeae11f17
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08Revert "Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara
This reverts commit 340ca294d43f2c5b9fda1afbf178609a015f71e3 as CppunitTest_basic_vba breaks, so needs revisiting to see which is right Change-Id: I10168d454a8c67d91eee5bb8939aff74bba42954
2015-01-08Resolves: #i94895# fix illegal result of Replace runtime functionTsutomu Uchino
(cherry picked from commit a2700f75af61837033ff213607445cc1f74b36d6) Conflicts: basic/source/runtime/methods.cxx Change-Id: If9c671a612de87d8d37bfc40704a97a6062fd150
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07Resolves: fdo#87003 - Kill BOOST_FOREACHPieter Adriaensen
Conflicts: avmedia/source/framework/modeltools.cxx basic/source/sbx/sbxbase.cxx sd/source/filter/eppt/pptx-epptooxml.cxx svx/qa/unit/svdraw/test_SdrTextObject.cxx sw/qa/core/uwriter.cxx sw/source/core/doc/CntntIdxStore.cxx sw/source/core/doc/DocumentLinksAdministrationManager.cxx sw/source/core/doc/docnew.cxx sw/source/core/doc/gctable.cxx sw/source/core/doc/htmltbl.cxx sw/source/core/doc/sortopt.cxx sw/source/core/doc/tblcpy.cxx sw/source/core/doc/tblrwcl.cxx sw/source/core/docnode/ndcopy.cxx sw/source/core/docnode/ndtbl.cxx sw/source/core/docnode/ndtbl1.cxx sw/source/core/frmedt/tblsel.cxx sw/source/core/text/itratr.cxx sw/source/core/tox/ToxLinkProcessor.cxx sw/source/filter/xml/xmltble.cxx Change-Id: Id176d4e052c719c9afdf91ed450de84d8d2bc486 Reviewed-on: https://gerrit.libreoffice.org/13575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05Resolves: fdo#87003 Kill BOOST_FOREACH on masterNathan Yee
use C++11s range-based for() loops instead Conflicts: sd/source/filter/eppt/pptx-epptooxml.cxx Change-Id: I0868eb345932c05b7e40b087035da252b99bf0b9 Reviewed-on: https://gerrit.libreoffice.org/13714 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-30Rename "Mid" unit tests to distinguish cases with 2 and 3 argsJulien Nabet
Change-Id: Ie9241d0a28dc3871c9242123c9f000100e1a2fa1
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-18basic: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f