summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2014-02-24Remove some temporaries around calls to SvNumberFormatter methodsMatteo Casalin
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-12more SvStream:operator>> conversionNoel Grandin
Convert the template based read_lenPrefixed methods to regular methods. Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019 Reviewed-on: https://gerrit.libreoffice.org/7895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12fix crash when importing unsupported macro content, related fdo#59374Markus Mohrhard
Change-Id: I960c8174454074fd9ddb27fb17244d782c4cb24c
2014-02-07Simplify access to theCoreReflection singletonStephan Bergmann
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06Typo: applictaion -> applicationJulien Nabet
Change-Id: I2d578cb417bb1e814dcf3007f500fe8ff77510f7
2014-02-05basic: _FIND_STATIC likely not an error in SbiExprNode::GenElement()Michael Stahl
All other _FIND_* are explicitly not errors, and probably CWS npower10 forgot to adapt this assertion. Change-Id: If721c275eb1bc31d76140898602b41e11c23d82e Reviewed-on: https://gerrit.libreoffice.org/7863 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2014-02-04Related: #i123862# use O*String's isEmpty() method...Herbert Dürr
to check for emptiness in modules starting with 'b' Patch-by: j.nitschke@ok.de Review-by: hdu@apache.org (cherry picked from commit 87204b0f4062ef8fc8f138ad15f4378da609d4e2) Conflicts: basctl/source/basicide/baside2.cxx basctl/source/basicide/bastype2.cxx basctl/source/basicide/localizationmgr.cxx basctl/source/dlged/dlgedobj.cxx basic/source/basmgr/basmgr.cxx basic/source/basmgr/vbahelper.cxx basic/source/classes/sbunoobj.cxx basic/source/comp/sbcomp.cxx basic/source/runtime/iosys.cxx basic/source/runtime/methods.cxx basic/source/runtime/methods1.cxx basic/source/runtime/step2.cxx basic/source/uno/namecont.cxx basic/source/uno/scriptcont.cxx binaryurp/source/bridge.cxx binaryurp/source/bridgefactory.cxx binaryurp/source/reader.cxx binaryurp/source/unmarshal.cxx bridges/source/cpp_uno/cc50_solaris_intel/except.cxx bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx bridges/source/cpp_uno/shared/vtablefactory.cxx bridges/source/jni_uno/jni_data.cxx Change-Id: I37bd84e0a1d6426759dba81854faf32c88147fe1
2014-02-03some more continuous correctionsThomas Arnhold
2014-01-30fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter.Alexandre Vicenzi
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab Reviewed-on: https://gerrit.libreoffice.org/7731 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
2014-01-28coverity#738565 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ie969773240bd7ecdcf56d7c533010d0aa32872c8
2014-01-27coverity#441077 Dereference after null checkCaolán McNamara
Change-Id: Ia6a04846068e0bc500942e9a2dc6ee2e72d9d527
2014-01-27coverity#984078 Uninitialized scalar fieldCaolán McNamara
Change-Id: I36b4a8c7d047f392fdbbe167a0e801b9a6d80b03
2014-01-27coverity#707652 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6d561955454b0619255296704812b41a10ffe962
2014-01-27coverity#707651 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6e497d60e72efd1df6c271ce6bf8d5e46ba09ea7
2014-01-27coverity#707650 Uninitialized pointer fieldCaolán McNamara
Change-Id: I6843ce28f3e1395a2ab3c5515f393cce5096674b
2014-01-27coverity#707649 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1a95a051463860dc9c7b087bfaf17f3b70f297ee
2014-01-27coverity#707629 Uninitialized scalar fieldCaolán McNamara
Change-Id: I0e3d9d4dad46e9b88be11cc9ac2c7d3c0c4b6f6e
2014-01-24coverity#736909 Allocation too small for typeCaolán McNamara
Change-Id: I330ebdfd94d0c30b40e180e307d7543c09fd334b
2014-01-24coverity#736908 Allocation too small for typeCaolán McNamara
Change-Id: Ic41c5071957f5e95322971f8ec3ef864edecdb20
2014-01-24coverity#706117 Allocation too small for typeCaolán McNamara
Change-Id: I1bb2bd26e533cf5b7de5225f0bcf323446e69f63
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Add some unit-tests for Mid vb function (includes fdo#73771)Julien Nabet
Change-Id: Ib5ee18207897cbe16a818096769cdb055dc9dad7 Reviewed-on: https://gerrit.libreoffice.org/7583 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2014-01-21bool improvementsStephan Bergmann
Change-Id: I64288207adb083e006b4acc5e7f26d647236a443
2014-01-21Resolves: fdo#73771 Non-standard behaviour for Function MidJulien Nabet
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2 Reviewed-on: https://gerrit.libreoffice.org/7539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-19how should I fix this memory leak??Markus Mohrhard
2014-01-19CID#706118: possibly invalid castMarkus Mohrhard
2014-01-17Whatever those "true" arguments to SotStorage ctor may once have meantStephan Bergmann
...is lost to history, but they are effectively equivalent to pssing default SorageMode nStorageMode = 0 today, as the only thing that is done with that nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx) is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED (0x44). Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
2014-01-17fdo#73698 check for empty aOutAndras Timar
Change-Id: I0da26ef746553618bd8aee69f21ff0d1261efbf6 Reviewed-on: https://gerrit.libreoffice.org/7474 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-01-16Environment variables can contain >127 charactersAndras Timar
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-14bool improvementsStephan Bergmann
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-06Resolves: #i123817# prepare codebase for updating to boost 1.55Herbert Dürr
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153) Conflicts: basic/source/comp/parser.cxx basic/source/comp/token.cxx dbaccess/source/ui/dlg/generalpage.cxx sc/source/ui/unoobj/chart2uno.cxx vcl/quartz/salbmp.cxx Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-11sbxbase.hxx is private to basicTor Lillqvist
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
2013-12-11sbstdobj.hxx is private to basicTor Lillqvist
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
2013-12-11sbprop.hxx is private to basicTor Lillqvist
Change-Id: I1d7a28652ee7743b6823d78e1565338a324f0a6a
2013-12-11sbobjmod.hxx is private to basicTor Lillqvist
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
2013-12-11basic/global.hxx is private to basicTor Lillqvist
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
2013-12-08Drop duplicate #includeTakeshi Abe
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
2013-12-02Resolves: #i74854# fix buttons in MsgBox with info iconHerbert Dürr
Patch by: hanya.runo@gmail.com Found by: ooo@catcons.co.uk Tested by: hdu@apache.org (cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c) Conflicts: basic/source/runtime/methods.cxx vcl/inc/vcl/msgbox.hxx Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa