summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2016-02-26tdf#84938 Eliminate B_xxx defines in filefmt.hxx for FileOffset scoped enum.baltasarq
Second step: Make SbiOpenRecord() accept a FileOffset as second parameter This is a [partial] patch The objective is to substitute all apparitions of #defined constants for enum class. The victim here is the series of constants B_xxx that were located in filefmt.hxx and were changed for a FileOffset enum class. Obviously some other files where the type is used must be changed too. Change-Id: I7406bdc8e780ee89802ab6823f9c91c4c9b765c0 Reviewed-on: https://gerrit.libreoffice.org/22697 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-25coverity#1231668 Unchecked return valueCaolán McNamara
Change-Id: I4c83b1290484dabc9d40f970a3a86de5d6dc3928
2016-02-25change to SearchOptions2Eike Rathke
Change-Id: I07a72492f1cdc566109bf8e9247368558f420abe
2016-02-24simply the SbxRes stuff, inheriting from OUString is ickyNoel Grandin
Change-Id: Ie9794ea164d587ad87ee13d360cb3abc18166051
2016-02-24Removing #defines for String_XXX in sbxres.hxxbaltasarq
This is a [partial] patch for BUG #84938: https://bugs.documentfoundation.org/show_bug.cgi?id=84938 The objective is to substitute all apparitions of #defined constants for enum class. The victim here is the series of constants STRING_xxx that were located in sbres.hxx and were changed for a StringId enum class. Obviously some other files where the type is used must be changed too. Change-Id: I31fa684eb5eb3508d2025c9a319d5b245cc177af Reviewed-on: https://gerrit.libreoffice.org/22655 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22Actually, why passive voice?Tor Lillqvist
Change-Id: Ib8723c7ef1f74b7cfb4efa8e13e34953bff7d0da
2016-02-22Fix mis-translated German commentTor Lillqvist
Change-Id: I9c2dbccdc789b58c583e033a8d5627e0a95a95f9
2016-02-22loplugin:commaoperator in basic/Noel Grandin
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
2016-02-22BASIC : Add tools::make_ref and simplify SvRef usageArnaud Versini
Change-Id: I8fe846dbd353bace05a8732a9b961f3507d97ef8 Reviewed-on: https://gerrit.libreoffice.org/22587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22WaE vs2015 truncation of literal on static_castNorbert Thiebaud
Change-Id: I63a89c50c653145ea49aa34e4e4dd554da66598f Reviewed-on: https://gerrit.libreoffice.org/22597 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17tdf#40517 Unit test for question marks in number formatLaurent Balland-Poirier
Unit test for https://gerrit.libreoffice.org/21021/ Add unit test for Engineering format Add unit test for optional sign in exponent Change-Id: I958ccdcc68a4e496cbd4bdc74d0650c133f3a3f7 Reviewed-on: https://gerrit.libreoffice.org/21824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-17BASIC : use std::unique_ptr for storing SbiExprListArnaud Versini
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec Reviewed-on: https://gerrit.libreoffice.org/22345 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16tdf#39440: reduce scope of local variablesArnold Dumas
Change-Id: I6ba411d2e07240821518281996d543f71acf3259 Reviewed-on: https://gerrit.libreoffice.org/22378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-15cppcheck: unreadVariableCaolán McNamara
Change-Id: I15f0320b646d20f0093c77286c1ff2715aacb8ce
2016-02-15fix indentCaolán McNamara
Change-Id: I48552afc35c1f7cfff3562c36eca3f1cf6174077
2016-02-12tdf#95857 Sort out German plurals ...danielt998
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08BASIC : Use std::unique_ptr in SbiExpression and SbiExpListArnaud Versini
Change-Id: I6f09615d19560673319e103af36c40c94ea77f12 Reviewed-on: https://gerrit.libreoffice.org/22186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-08sequence->vector in basicNoel Grandin
Change-Id: Ic42f7218bda81effe870d950f666ba7653d60c66 Reviewed-on: https://gerrit.libreoffice.org/22177 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08sequence->vector in basicNoel Grandin
Change-Id: Ic1b72a6c5e9df5d0fa65626ec1d8eda6a2d2feec Reviewed-on: https://gerrit.libreoffice.org/22176 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08BASIC : Use vector in SbiExprList to avoid any dependenciesArnaud Versini
Change-Id: I1ae88ae9c4276452a00aadaaadebf582e639b15a Reviewed-on: https://gerrit.libreoffice.org/22174 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05basic: Merge macro snippet testsMatúš Kukan
Change-Id: Ia2d8944227c6be8b5ae7b42f7d566ac150d522b9
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04loplugin:fpcomparison in basic/Noel Grandin
Change-Id: I76ffac6a0f0b1525c85d1995277d3ca22ef268e1 Reviewed-on: https://gerrit.libreoffice.org/21869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-27BASIC: SbiExpression::IsIntConstant has side effects.Arnaud Versini
Also renames IsIntConstant to ConvertToIntConstIfPossible. Change-Id: Ib4b465ac0d890762547fb2d83c26ad6be6ee75e8 Reviewed-on: https://gerrit.libreoffice.org/21746 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-24BASIC : Remove class SbiDimList and SbiParametersArnaud Versini
Change-Id: I039bdc786a65ad534390e7138f584cdb470428af Reviewed-on: https://gerrit.libreoffice.org/21734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-01-24BASIC : Remove SbiExprList::pParserArnaud Versini
Change-Id: Ib9386d97ddb12f148cf76dc71aa8c41003286f50 Reviewed-on: https://gerrit.libreoffice.org/21534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-16BASIC : Remove useless virtual function overrideArnaud Versini
Change-Id: I0f8e480bf73256e7f1284e11983cc70c0426172c Reviewed-on: https://gerrit.libreoffice.org/21513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-16BASIC : Remove useless methods in StarBasicArnaud Versini
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d Reviewed-on: https://gerrit.libreoffice.org/21498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15basic: coverity#1348466 checked returnMichael Stahl
Kind of unnecessary but let's hope it shuts up coverity. Change-Id: I4903c9df788ce5fb9648c5fd68627ff21362828f
2016-01-13-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: Ia633b859df94ede325469ec8a20e7383d2a178d4
2016-01-12loplugin:loopvartoosmallNoel Grandin
Change-Id: Ifa813b91b153004aa0fba42cdc209f4c4fd9578f
2016-01-12loplugin:unusedmethods unused return value in include/basicNoel Grandin
Change-Id: Ib1a006adaa92e257d40a20ff0d8beeb37e7c2fe0 Reviewed-on: https://gerrit.libreoffice.org/21360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-12BASIC: Store directly SbxVarEntry in SbxArrayArnaud Versini
Change-Id: I64ae6c2a45e0ed880f5b76ca2ad420d684fdfeb4 Reviewed-on: https://gerrit.libreoffice.org/21308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-01-11fix windows buildNoel Grandin
Change-Id: Ie00d2dd3fbf6ff498c652249797f8d01acef8a97
2016-01-11loplugin:unusedmethods unused return value in basicNoel Grandin
Change-Id: I0ccbf994d2c9be35f43fc3c62e60da90634bacdf
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-07Some cleanup for sal_uIntPtr usageJohannes Hauf
Change-Id: Ia9779e6477d8848588f3543d09ea6b4477f594a2 Reviewed-on: https://gerrit.libreoffice.org/21022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-07BASIC : use std::vector instead of SbArray for Modules.Arnaud Versini
Change-Id: I9594efb13b3dccc637ccd61eea4b42255c2a775c Reviewed-on: https://gerrit.libreoffice.org/20817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-05Fix typosAndrea Gelmini
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27 Reviewed-on: https://gerrit.libreoffice.org/21078 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05Fix typosAndrea Gelmini
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727 Reviewed-on: https://gerrit.libreoffice.org/21103 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2016-01-04Use CPPUNIT_ASSERT_DOUBLES_EQUALStephan Bergmann
...except when checking for infinity Change-Id: If6e3b8965169cc615fa5d76422e1925866714936
2016-01-04loplugin:cstylecastStephan Bergmann
Change-Id: I5ecd63d79e8be77879d3789c45079929696abe03
2016-01-04tdf#96136 replace CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUALDipangar Niranjar
Change-Id: Ib45af8a56ac3adc428c530908cf1bbd95e9cc64c Reviewed-on: https://gerrit.libreoffice.org/21065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-10 15:39:10 +0000