summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-03coverity#1242481 Dereference null return valueCaolán McNamara
Change-Id: I21e6bdd643d898a3515a96e4c9c17c2d6f98b0e4
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02loplugin: cstylecastNoel Grandin
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
2014-10-01loplugin: cstylecastNoel Grandin
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
2014-10-01avoid calling OUString::copy() with length being -1Luboš Luňák
Which asserts in dbgutil build. Change-Id: I0f8205ae98c5a57c430b7d8a574e4c0019855841
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-26remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove pointless commentsNoel Grandin
Change-Id: I8edfe830b8f6ca7f1809332870e06d1d286b90e8
2014-09-26remove unnecessary static_cast'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22fdo#84086 Fix assorted use-after-free bugsMatthew J. Francis
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65 Reviewed-on: https://gerrit.libreoffice.org/11553 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-19vba: calm down bool -> long casting concerns.Michael Meeks
Change-Id: Ib32a66d891242701d2f5c55519e5c52a6dd3df3c
2014-09-19vba - disable Currency test / invocation on master.Michael Meeks
We're missing an effective SbxCURRENCY conversion here. Change-Id: Id6530ed3a93623b31089304f3451d9693ab4f3af
2014-09-19vba: add a different variant of the same compatibility function.Michael Meeks
Change-Id: I92bc1dbceea2f10cbb055d97f68b33e575d9be11
2014-09-19vba: initial impl. of compatibility methods.Michael Meeks
Change-Id: Iebc25f1730766e96d2ad6921a8b4d2ea880c63f3
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15Clean up StorageMode parameter of SotStorage::OpenSotStorageStephan Bergmann
...which was only used to transport either STORAGE_TRANSACTED or sal_False (i.e., 0, meaning "not STORAGE_TRANSACTED"). Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-04fdo#52076 remove Library dir when no libraryLionel Elie Mamane
when saving to same storage (in place) we already did that when empty "Standard" was the only library, but not when there was no library... Cannot get through that state in through UI, but possible through scripting. Change-Id: I0f1129e034ac31b3eaf6bd388a03aee5aae5b87e
2014-09-04detect if Standard is only library to *save*Lionel Elie Mamane
as opposed to only library at all Change-Id: I23bebfe7d156e1f4a60bc5f265a3cf9d295f3e4a
2014-09-04add const qualifierLionel Elie Mamane
Change-Id: I88d61668b465e505cfa245dd17893828aaaecaa8
2014-08-26convert SBX flag bits to type-safe enumNoel Grandin
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817 Reviewed-on: https://gerrit.libreoffice.org/11070 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22Revert "Simplify ImplRepository::impl_getLocationForModel return type"Stephan Bergmann
This reverts commit 72305ed49d4c9ba968d7bf6d8d5ae564bb92147d, which was bogus, cf. the comment in ImplRepository::getDocumentBasicManager about recursive calls.
2014-08-22Remove BasicManagerCleanerStephan Bergmann
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22Simplify ImplRepository::impl_getLocationForModel return typeStephan Bergmann
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22Remove trivial typedef, to make code more obviousStephan Bergmann
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-21coverity#1202729 - ensure we have exactly a one dimensional array.Michael Meeks
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-17coverity#1231668 Unchecked return valueCaolán McNamara
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
2014-08-13update_pchThomas Arnhold
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-11-Werror,-Wundefined-bool-conversionStephan Bergmann
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-29basic: -Werror=sign-compareMichael Stahl
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29fdo#46037: remove unused comphelper/configurationhelper.hxxAlexandre Vicenzi
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa Reviewed-on: https://gerrit.libreoffice.org/10603 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29convert linked list to std::vector in SbxDimArrayNoel Grandin
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23 Reviewed-on: https://gerrit.libreoffice.org/10298 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-24fdo#52076 remove empty library instead of writing it out emptyLionel Elie Mamane
Change-Id: Id4fd8c4f34e8ed07044eb428049731c4b9b694ca Reviewed-on: https://gerrit.libreoffice.org/10507 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-07-24Drop unused #includesTakeshi Abe
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
2014-07-18Drop an unused functionTakeshi Abe
Change-Id: I59eb46f9d57e9fd72ed86c972685be93d154e3c7
2014-07-17fdo#75757: remove inheritance to std::vectorTakeshi Abe
... which was introduced at 2110397670695991b3a5cd28a15ba0ffd2a3a611. Change-Id: If0f634b29e1891574267edf8cc07b24d07a9406c Reviewed-on: https://gerrit.libreoffice.org/10363 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-16Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-06DBG_ASSERT->assert when followed by dereferenceCaolán McNamara
Change-Id: I9390228721df1b713d8cf2e719854b74d6b639c8