summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2024-09-20no need to do UNO_QUERY hereNoel Grandin
Change-Id: I52d13a7e4806d8fc34c4ff6f4cc5ab1e785a8b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173729 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-20tdf#162431 - Check for missing parametersAndreas Heinisch
Don't silently convert missing parameters including their error code to the request target typen when the target type can't handle the conversion. Change-Id: I2300aa594ae3cc1045a6397c1195718b6662aa61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172593 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-09-18Avoid -Werror,-Wunused-functionStephan Bergmann
Change-Id: I95ca13db07a778fc260cbb78364916cc7400e378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173590 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-09-18use more concrete UNO in basicNoel Grandin
Change-Id: I6606008d9b45e00295cf441a7321a677d62317f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173581 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-17Fix formatting of datesMike Kaganski
Redression after commit 81e1e0a2a671f19950c1bd3c69f9aa24b0c562e7 (Refactor SbxValue::Format, 2024-09-13). Change-Id: Ie7eb50c32f3c1a3aec73fc882dc33cce42734747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173449 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-17Related: i#109051 There's no "Exit Let/Get/Set"Mike Kaganski
Before, these incorrect combinations were allowed, together with the correct "Exit Property", which had been implemented in commit 5ed103d2dd5f8ee2f13183263c0930f84437bdc7 (mib16: contributed bugfixes and various new symbols in VBA compatibility implementation, 2010-06-15). Change-Id: Ic132c0860bb04007766977975a6ce9c8887138dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173427 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-17i#109051: also handle Exit Property for Property SetMike Kaganski
An omission from commit 5ed103d2dd5f8ee2f13183263c0930f84437bdc7 (mib16: contributed bugfixes and various new symbols in VBA compatibility implementation, 2010-06-15) Change-Id: I1e08406eb1dcb64eeef5d925d22475f1b9f74de0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173426 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-16tdf#162962: always create a local "Nothing" for the "WITH" variableMike Kaganski
Other "WITH" blocks create the symbol that can be found by pPool->Find, but can be not accessible at the call site. Change-Id: I85ecc763a1bb3fd692c2c98e674047fdbde3f8f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173417 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-13tdf#162935: use PUTC for WITH variable assignment: it doesn't copy valueMike Kaganski
SbiRuntime::StepPUT, SbiRuntime::StepSET, SbiRuntime::StepVBASET call checkUnoStructCopy eventually, which copies the UNO struct by value. This is not what we need. On the other hand, SbiRuntime::StepPUTC only makes the by-ref assignment, and makes the reference const; but Basic code never assigns anything to the internal variable itself, only to its members. I hope that this time, I get it right. Change-Id: I2b4a51a2dca9e7106e14e03360ef0d5a50b60079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173305 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-13Refactor SbxValue::FormatMike Kaganski
Change-Id: I1a55f2c6148246733699c1ff1086436af9d450b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173254 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-12Temporarily skip unit tests on native arm64 buildBalazs Varga
which indicating unit test fails. Change-Id: I2689b0dda888e15e52ca60cc18e1705a1aefe968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173143 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-09-11Related: tdf#158092 add a comment to avoid symbols localizationMike Kaganski
The localizable string is to allow different position/precision of the components; but the localization of the symbols themselves (decimal and thousand separator, currency) happens in code. This comment is shown in Weblate UI. Change-Id: Ib2f62fc8edf12ad3b182b40e3a8981c43b7ed67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173104 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-09Improve run-time Currency type support in BasicMike Kaganski
Change-Id: I1e04c6022944034a30ef896b8cd24050ebe3bbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173042 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-05use less dynamic_cast when broadcasting SfxHintNoel Grandin
Change-Id: If4d33cbbf36a9ad495b80a7347b39d0f4bc0405e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-02Fix ImpCurrencyToString to handle SAL_MIN_INT64Mike Kaganski
It can't be negated; so avoid the negation, and skip the minus in the string result. Also, avoid needless creation of OUString. Change-Id: If867c189b2ffd2794a58f66fd2511004ed4fc25a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172733 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-01Refactor ImpCurrencyToString for simplicityMike Kaganski
Change-Id: Ie7acafb3c81348f03340f1aaa53b3849c8dae4a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172694 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-01tdf#162724: use localized decimal separator in ImpCurrencyToStringMike Kaganski
Same as in ImpCvtNum Change-Id: Icbaa237e944a39309b01fdb18e668d054ff61c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172693 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-31Move variables into their usage scopeMike Kaganski
Change-Id: I8d708ecdc94c19069d955b19daf1a5c5c4bc2f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172584 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-30Simplify default ImpScan usageMike Kaganski
Drop LibreOffice6FloatingPointMode, and move the check introcuced in commit 47aabde053a1472dc32770da29d68c8de5bd7919 (Make the tdf#97983 changes to BASIC optional) into a simplified ImpScan overload. Change-Id: Ibef723878179113a5403d2a3c55ded9df9cb292d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172595 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-27SbClassModuleObject never take a non-null argCaolán McNamara
Change-Id: I1be4710a32355c104ba25005ec4f46c6f650b9c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-27use a shared_ptr for SbiBreakpoints pBreaks as wellCaolán McNamara
Change-Id: I3dec5ffe5fdf937d761c902970a94b73878a2cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172441 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-27cid#1554789 Different smart pointers managing same raw pointerCaolán McNamara
lets just use a shared_ptr here Change-Id: I31ec113da2c060e8b89ea4e438d182f0f22e810f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18Simplify a bitMike Kaganski
Change-Id: Ibe34a1c17d856146d191e784af06b8cb6301b912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172007 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-18Related: tdf#132064 Use set to clear the With internal variableMike Kaganski
In commit f3f46b5fe729876d128f63f7ab158954ab6657d7 (tdf#132064: make With statement only evaluate its argument once, 2024-08-17), I made a mistake, clearing the internal variable in the end of SbiParser::With using an Erase call, which does not just clears the variable itself, but destroys the underlying object, which is not what we need. I don't know how to refer to a global Nothing object to assign to the variable; so just create an own internal Nothing, and use it in the assignment. Change-Id: Ic8ce52e0402d8461a9b9e4ee07614c4f0a46a95e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172006 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-18tdf#150458: evaluate for loop's end and step once in VBA support modeMike Kaganski
As required by [MS-VBAL], and actual VBA implementation. It is a question if we also need to change it likewise in other modes (normal, compatible) - see tdf#150460. Change-Id: I1e83d57fe4be3bf264a64fe977909cf7684bc798 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172005 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-17Move the check out of the loopMike Kaganski
Change-Id: I151ac6399d2cc5870971f258614480fcbdff5c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-17tdf#132064: make With statement only evaluate its argument onceMike Kaganski
This is implemented by creating a unique variable at entry of the block, using it as the "with parent", and clearing afterwards. It uses an invalid name, so can't be used by a user. The generation of the bytecode is done in compatible way; only existing opcodes were used (which was the reason to choose the implementation with a variable), so compiled binaries in password-protected libraries are expected to work with older versions. The functional changes are: 1. The argument of With statement is evaluated immediately at the start of the block; previously, it evaluated first time, when the leading dot operator was used, and could even be never evaluated, if the operator wasn't used. This is consistent with VBA, and has a benefit that the lifetime of the object is guaranteed to cover the whole block (might be useful if other block statements depend on the object, similar to Python's 'with' statement contexts). 2. The primary goal of the change: it is only ever evaluated once, no matter how many times was the dot operator used in the block. Change-Id: I4dbd520538a57e3668ab706e8f45740db5d33393 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171980 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-14cid#1557980 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557869 COPY_INSTEAD_OF_MOVE cid#1557807 COPY_INSTEAD_OF_MOVE cid#1557804 COPY_INSTEAD_OF_MOVE cid#1557799 COPY_INSTEAD_OF_MOVE cid#1557781 COPY_INSTEAD_OF_MOVE cid#1557781 COPY_INSTEAD_OF_MOVE cid#1557766 COPY_INSTEAD_OF_MOVE cid#1557746 COPY_INSTEAD_OF_MOVE cid#1557737 COPY_INSTEAD_OF_MOVE Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-11cid#1558088 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1558080 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558055 COPY_INSTEAD_OF_MOVE cid#1558043 COPY_INSTEAD_OF_MOVE cid#1558039 COPY_INSTEAD_OF_MOVE cid#1558015 COPY_INSTEAD_OF_MOVE cid#1558014 COPY_INSTEAD_OF_MOVE cid#1558009 COPY_INSTEAD_OF_MOVE cid#1558002 COPY_INSTEAD_OF_MOVE cid#1557998 COPY_INSTEAD_OF_MOVE cid#1557996 COPY_INSTEAD_OF_MOVE cid#1557990 COPY_INSTEAD_OF_MOVE cid#1557986 COPY_INSTEAD_OF_MOVE cid#1557980 COPY_INSTEAD_OF_MOVE cid#1557971 COPY_INSTEAD_OF_MOVE cid#1557968 COPY_INSTEAD_OF_MOVE cid#1557967 COPY_INSTEAD_OF_MOVE cid#1557961 COPY_INSTEAD_OF_MOVE cid#1557959 COPY_INSTEAD_OF_MOVE cid#1557958 COPY_INSTEAD_OF_MOVE cid#1557956 COPY_INSTEAD_OF_MOVE cid#1557953 COPY_INSTEAD_OF_MOVE cid#1557949 COPY_INSTEAD_OF_MOVE cid#1557947 COPY_INSTEAD_OF_MOVE cid#1557940 COPY_INSTEAD_OF_MOVE cid#1557931 COPY_INSTEAD_OF_MOVE cid#1557930 COPY_INSTEAD_OF_MOVE cid#1557915 COPY_INSTEAD_OF_MOVE cid#1557913 COPY_INSTEAD_OF_MOVE cid#1557910 COPY_INSTEAD_OF_MOVE cid#1557886 COPY_INSTEAD_OF_MOVE cid#1557884 COPY_INSTEAD_OF_MOVE cid#1557880 COPY_INSTEAD_OF_MOVE cid#1557875 COPY_INSTEAD_OF_MOVE cid#1557871 COPY_INSTEAD_OF_MOVE cid#1557862 COPY_INSTEAD_OF_MOVE cid#1557847 COPY_INSTEAD_OF_MOVE cid#1557845 COPY_INSTEAD_OF_MOVE cid#1557844 COPY_INSTEAD_OF_MOVE cid#1557843 COPY_INSTEAD_OF_MOVE cid#1557838 COPY_INSTEAD_OF_MOVE cid#1557835 COPY_INSTEAD_OF_MOVE cid#1557834 COPY_INSTEAD_OF_MOVE cid#1557828 COPY_INSTEAD_OF_MOVE cid#1557823 COPY_INSTEAD_OF_MOVE cid#1557817 COPY_INSTEAD_OF_MOVE cid#1557813 COPY_INSTEAD_OF_MOVE cid#1557812 COPY_INSTEAD_OF_MOVE Change-Id: I55d4a920daa2d148683419169eb828325fd3c757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171732 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-05VBA QA new unit test for IF THEN statementAlain Romedenne
Intent is to cover: - EndIf / End If equivalence - repeating ElseIf blocks _ nested IF statements - IF THEN one liner Change-Id: I667f0381529afcc82fc44ae461081f7ba84b01d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171352 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-04cid#1556583 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556585 COPY_INSTEAD_OF_MOVE cid#1556588 COPY_INSTEAD_OF_MOVE cid#1556593 COPY_INSTEAD_OF_MOVE cid#1556597 COPY_INSTEAD_OF_MOVE cid#1556605 COPY_INSTEAD_OF_MOVE cid#1556617 COPY_INSTEAD_OF_MOVE cid#1556635 COPY_INSTEAD_OF_MOVE cid#1556790 COPY_INSTEAD_OF_MOVE cid#1556792 COPY_INSTEAD_OF_MOVE cid#1556796 COPY_INSTEAD_OF_MOVE cid#1556799 COPY_INSTEAD_OF_MOVE cid#1556815 COPY_INSTEAD_OF_MOVE cid#1556836 COPY_INSTEAD_OF_MOVE cid#1556840 COPY_INSTEAD_OF_MOVE cid#1556842 COPY_INSTEAD_OF_MOVE cid#1556859 COPY_INSTEAD_OF_MOVE cid#1556860 COPY_INSTEAD_OF_MOVE cid#1556866 COPY_INSTEAD_OF_MOVE cid#1556869 COPY_INSTEAD_OF_MOVE cid#1556870 COPY_INSTEAD_OF_MOVE Change-Id: I3df8698a4aecbb03999c084517e37e12ff46ee97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-04Clarify MsgBox buttons handling codeMike Kaganski
Change-Id: I0095b4b5312c851f1f64ec013c64f26e1b24ce09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171454 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-03Refactor basic methods representing constantsMike Kaganski
Makes them more comprehensible; uses semantic names instead of magic numbers. Added comments to the constants that are unclear. Change-Id: Ifcb8a0d93ce057b8af08859b87ad3af8c67479e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171443 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-02cid#1556472 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556481 COPY_INSTEAD_OF_MOVE cid#1556486 COPY_INSTEAD_OF_MOVE cid#1556491 COPY_INSTEAD_OF_MOVE cid#1556507 COPY_INSTEAD_OF_MOVE cid#1556515 COPY_INSTEAD_OF_MOVE cid#1556518 COPY_INSTEAD_OF_MOVE cid#1556519 COPY_INSTEAD_OF_MOVE cid#1556533 COPY_INSTEAD_OF_MOVE cid#1556536 COPY_INSTEAD_OF_MOVE cid#1556559 COPY_INSTEAD_OF_MOVE cid#1556577 COPY_INSTEAD_OF_MOVE cid#1556581 COPY_INSTEAD_OF_MOVE Change-Id: I2ad2f2194e2a89c7246e8742b2fc8be7580e38c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-02cid#1556086 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556087 COPY_INSTEAD_OF_MOVE cid#1556093 COPY_INSTEAD_OF_MOVE cid#1556094 COPY_INSTEAD_OF_MOVE cid#1556105 COPY_INSTEAD_OF_MOVE cid#1556121 COPY_INSTEAD_OF_MOVE cid#1556184 COPY_INSTEAD_OF_MOVE cid#1556399 COPY_INSTEAD_OF_MOVE cid#1556405 COPY_INSTEAD_OF_MOVE cid#1556419 COPY_INSTEAD_OF_MOVE cid#1556421 COPY_INSTEAD_OF_MOVE cid#1556444 COPY_INSTEAD_OF_MOVE cid#1556448 COPY_INSTEAD_OF_MOVE cid#1556457 COPY_INSTEAD_OF_MOVE cid#1556468 COPY_INSTEAD_OF_MOVE Change-Id: I1f352682daebd4e3ed2e7fe669aa0943dcc33edd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171372 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-01Basic QA new unit test for IF THEN statementAlain Romedenne
Intent is to cover: - repeating ElseIf blocks _ nested IF statements - IF THEN one liner Change-Id: Iee37707e26a563f336438ce7ba17271a7f06e6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171285 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-29cid#1554812 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555227 COPY_INSTEAD_OF_MOVE cid#1555329 COPY_INSTEAD_OF_MOVE cid#1555384 COPY_INSTEAD_OF_MOVE cid#1555387 COPY_INSTEAD_OF_MOVE cid#1555399 COPY_INSTEAD_OF_MOVE cid#1555400 COPY_INSTEAD_OF_MOVE cid#1555406 COPY_INSTEAD_OF_MOVE Change-Id: I85dc45e2686c6b3e8b97a23872cb26416edc27c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-25O[U]String overloads that return view for rest parameterNoel Grandin
Add new overloads to OUString methods that have a "OUString* rest" style parameter. Instead return a view, which does not require allocation. To avoid overload ambiguity, split the methods into different variants that do not use default parameters. Change-Id: I1aa366115750f1f7ea4fe665804195f59f7c4b69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167632 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-23cid#1555167 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555172 COPY_INSTEAD_OF_MOVE cid#1555184 COPY_INSTEAD_OF_MOVE cid#1555188 COPY_INSTEAD_OF_MOVE cid#1555197 COPY_INSTEAD_OF_MOVE cid#1555209 COPY_INSTEAD_OF_MOVE cid#1555211 COPY_INSTEAD_OF_MOVE cid#1555215 COPY_INSTEAD_OF_MOVE cid#1555216 COPY_INSTEAD_OF_MOVE cid#1555217 COPY_INSTEAD_OF_MOVE cid#1555218 COPY_INSTEAD_OF_MOVE cid#1555222 COPY_INSTEAD_OF_MOVE cid#1556674 COPY_INSTEAD_OF_MOVE cid#1555229 COPY_INSTEAD_OF_MOVE cid#1555233 COPY_INSTEAD_OF_MOVE cid#1555234 COPY_INSTEAD_OF_MOVE cid#1555242 COPY_INSTEAD_OF_MOVE cid#1555250 COPY_INSTEAD_OF_MOVE cid#1555251 COPY_INSTEAD_OF_MOVE cid#1555254 COPY_INSTEAD_OF_MOVE cid#1555304 COPY_INSTEAD_OF_MOVE cid#1555307 COPY_INSTEAD_OF_MOVE cid#1555317 COPY_INSTEAD_OF_MOVE cid#1555329 COPY_INSTEAD_OF_MOVE cid#1555340 COPY_INSTEAD_OF_MOVE cid#1555347 COPY_INSTEAD_OF_MOVE cid#1555352 COPY_INSTEAD_OF_MOVE cid#1555358 COPY_INSTEAD_OF_MOVE cid#1555363 COPY_INSTEAD_OF_MOVE cid#1555365 COPY_INSTEAD_OF_MOVE cid#1555367 COPY_INSTEAD_OF_MOVE cid#1555374 COPY_INSTEAD_OF_MOVE cid#1555380 COPY_INSTEAD_OF_MOVE Change-Id: I343194c10749488a1143e2517ee0638ab19da218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-20Remove now unneeded osl/diagnose.hGabor Kelemen
followup to commit 57c228803e55ed343c6693de7d0857ad7d3cd9e3 Change-Id: Iebfb23bb65e2bf898bf27f367cc9641f47a14cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167998 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-07-14cid#1607572 silence bogus Copy-paste errorCaolán McNamara
Change-Id: Id8355a033089a47299d76e1743b7da5a1b4a5d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-29Fix "lets" -> "let's"Andrea Gelmini
Change-Id: I01968fc18b093dbbc27213f01c3da38ae151c62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169748 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-06-20Fix typoAndrea Gelmini
Change-Id: Ib6bfd1938d8d2da3d3aa9ccbb7b80750c4671f39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169279 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-06-20-Werror,-Wunused-functionStephan Bergmann
Change-Id: I11af8dfbcdda6bbb77f2ccfaf2c994492bc3f807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169282 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-06-20tdf#161469 - Basic: align implementation now with the now function in calcAndreas Heinisch
Align the implementation of the now function in basic with the now function in calc to include the also nanoseconds. The precision is limited to milliseconds to avoid comparision inaccuracies. Change-Id: Ia85b653898f5849f67a171749725faab976b2a8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168706 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-06-10tdf#160321 - Added missing VB testAndreas Heinisch
Change-Id: I4019599aa9d7803a63e4270b06841915ea428392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168637 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-06-10tdf#160321 - Don't execute jump statement if the expression is out of rangeAndreas Heinisch
Don't execute On expression GoSub Statement; On expression GoTo Statement if the expression lies out of range. Change-Id: I5c1de25918b5e812d7ec82034f8d56351374d56a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165960 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-05-06loplugin:ostr basicNoel Grandin
Change-Id: Ie5fc4676bd1cab2c0417b479bf08dda00936469a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-05basic : use more OUString literalsArnaud VERSINI
Change-Id: I38f57c64c0d110e892982eaed2619c0915fe93b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166825 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
2024-05-05basic : use std::u16string_view and new OUString literalArnaud VERSINI
Change-Id: Id3cd708b98e1b0551955562afe3ac594bdc6e50a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
generated by cgit (git 2.34.1) at 2025-01-08 08:43:32 +0000