summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2016-04-11BASIC: Remove useless static_cast from basmgr.cxxArnaud Versini
Change-Id: If389aaabd22751908beba7dee9dbc79460692524 Reviewed-on: https://gerrit.libreoffice.org/23958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-04-11Avoid reserved identifierStephan Bergmann
Change-Id: I6dfb2961adeb412405c58e0a0b51e130cbd3e0c3
2016-04-11Remove an useless check I had addedJulien Nabet
Reverts partly https://cgit.freedesktop.org/libreoffice/core/commit/?id=43109b751bf5fd36318de56b2fb686acc724673f Change-Id: Ief7fd752d260031e243ea4304f6c55fa4dc42bfd Reviewed-on: https://gerrit.libreoffice.org/23984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-11clang-tidy performance-unnecessary-value-param in basicNoel Grandin
Change-Id: I997213ca28efc2df04d454ffaf3c81c9cbad09ac
2016-04-11make GetGlobalUNOConstant and GetUNOConstant take an OUStringNoel Grandin
and eliminate converting backwards and forwards between sal_Char*/OString/OUString Change-Id: Iaf52ce93f0e732ab338f75d21b95ab4b020a4d6f Reviewed-on: https://gerrit.libreoffice.org/23919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10tdf#99089: avoid some crashes in BasicJulien Nabet
First stacktrace: soffice.bin: /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577: sal_Unicode rtl::OUString::operator[](sal_Int32) const: Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed. ... 3 0x00002aaaab327452 in __GI___assert_fail (assertion=0x2aaaaeea62a8 "index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())", file=0x2aaaaeea6260 "/home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx", line=577, function=0x2aaaaeea6860 <rtl::OUString::operator[](int) const::__PRETTY_FUNCTION__> "sal_Unicode rtl::OUString::operator[](sal_Int32) const") at assert.c:101 4 0x00002aaaaed91e89 in rtl::OUString::operator[](int) const (this=0x7fffffff2770, index=0) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:577 5 0x00002aaaaee1c66f in SbRtl_Val(StarBASIC*, SbxArray&, bool) (pBasic=0xa2a7ec0, rPar=..., bWrite=false) at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:1792 Second stacktrace: 0x00002aaaaee6054d in printfmtstr (rStr="", rRes="", rFmt="\£0.##") at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534 534 while( *pFmt != '\' ); (gdb) bt 0 0x00002aaaaee6054d in printfmtstr(rtl::OUString const&, rtl::OUString&, rtl::OUString const&) (rStr="", rRes="", rFmt="\£0.##") at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:534 1 0x00002aaaaee617ce in SbxValue::Format(rtl::OUString&, rtl::OUString const*) const (this=0xb12dd60, rRes="", pFmt=0x7fffffff20e0) at /home/julien/compile-libreoffice/libreoffice/basic/source/sbx/sbxscan.cxx:883 2 0x00002aaaaee217af in SbRtl_Format(StarBASIC*, SbxArray&, bool) (pBasic=0xa2cffa0, rPar=..., bWrite=false) at /home/julien/compile-libreoffice/libreoffice/basic/source/runtime/methods.cxx:3519 Change-Id: I1798a1545ce08efa9d6fc39f4696195f9dc96c67 Reviewed-on: https://gerrit.libreoffice.org/23956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-07fix bug in SbxArray::MergeNoel Grandin
bug was recently introduced by commit a5c232831395f8987a8395816c5a60105a52b6a0 "BASIC: Store directly SbxVarEntry in SbxArray" bug was found by clang-tidy Change-Id: Ibcce6d6024ac60eb143cd873760586a7f6231858 Reviewed-on: https://gerrit.libreoffice.org/23890 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-04-06Avoid reserved identifierStephan Bergmann
Change-Id: I2f8dc470100e91841eebbe1e3b02a3d31ab3a535
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: Ibba1a36d4f3744fa68f7e9d0076c997e076262cb
2016-04-06Turn SbiOpcode into scoped enumStephan Bergmann
Change-Id: I75d808dd3a42e57e7f55bad97e24fef65bb62dc6
2016-04-06Avoid reserved identifiersStephan Bergmann
Change-Id: I3fbc7cb107bdab770d5ce9ed3ecddb962d2d4666
2016-04-04BASIC : Use a vector to store the argv stackArnaud Versini
Change-Id: I29c93aec598b7f784f549ce05f6b32dfabbfc3ad Reviewed-on: https://gerrit.libreoffice.org/23815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-04-04tdf#94306 replace boost::noncopyable in ..Jochen Nitschke
.. accessibility, avmedia, basctl, basic and bridges remove boost from module if not needed anymore Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2 Reviewed-on: https://gerrit.libreoffice.org/23744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #2tymyjan
Change-Id: I2e77c3b33ae3b8a49a7890cac77be566391972f2 Reviewed-on: https://gerrit.libreoffice.org/23751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-03BASIC : Use a vector to store the go sub stack.Arnaud Versini
Change-Id: I80987f3f7c036279a8292a7fbbd2dcd232196226 Reviewed-on: https://gerrit.libreoffice.org/23753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: Id0304994a692f1004993dda2ffd7fb819ab8e8d0 Reviewed-on: https://gerrit.libreoffice.org/23670 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23loplugin:constantparam in basicNoel Grandin
Change-Id: I6831cb8628eed76db35070934f62dccb1345ba12
2016-03-20BASIC: Calling SbxDimArray::Clear should also call SbxArray.Arnaud Versini
Change-Id: I832a192bbb3ddd2d32d80f22ae8f2cf95e3edfb7 Reviewed-on: https://gerrit.libreoffice.org/23192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-03-20BASIC : Use std::vector in SbiRuntime to save referencesArnaud Versini
Change-Id: Ica819538b39e58416825e651d057620a66f731cd Reviewed-on: https://gerrit.libreoffice.org/23193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-03-17loplugin:constantparam in toolsNoel Grandin
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-14coverity#1355498 assume Unchecked return value is deliberateCaolán McNamara
Change-Id: I8b0597a5ab87d4d4529e3ccc097902486a41e957
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09deref of nullCaolán McNamara
regression from commit f17a4694b07856292804c23b80ce92967d401bb8 Author: Arnaud Versini <arnaud.versini@gmail.com> Date: Sat Feb 13 20:17:41 2016 +0100 BASIC : use std::unique_ptr for storing SbiExprList Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec Reviewed-on: https://gerrit.libreoffice.org/22345 because they have been moved into the container at this point Change-Id: If21e0321ffdce66aa9629637d0ff8c16efbbd25e
2016-03-09loplugin:constantparam in basicNoel Grandin
Change-Id: I5b49406535c1ec95e47fe237a23184a499b875e5
2016-03-08tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctorsSteven Guo
Replaced boost::noncopyable with plain C++11 deleted copy ctors in /basic/* files. Change-Id: I9c0eb0a51ec5cb25c88c72b55f42864e73006e6b Reviewed-on: https://gerrit.libreoffice.org/22969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-08Remove ancient StarPortal leftoversStephan Bergmann
No UNO bridge has a "user" token in its description anyway, so needsSecurityRestrictions always returned false. Change-Id: Ibc3aa25212a2e8b245c13578fa29582be42791e6
2016-03-07basic: tdf#87530 if a new password is set, must set mbLoadedSource flagMichael Stahl
... so that the library is stored (and encrypted), and not copied unencrypted from source storage. Change-Id: I9546087ec6f07007aa1ec377d2e959f2bae99a38
2016-03-07basic: tdf#87530 don't copy storage that doesn't existMichael Stahl
If the Basic library is newly created it may not have been stored to the document storage yet. (regression from 5246fa262450f686674850c53df666422f441c86) Change-Id: I9c2fc1d7446795b9c1c2224671118b2a671dcad8
2016-03-07tdf84938 Replaced Sb_Attr_ defined constants with enum class in runtime.hxxSteven Guo
Replaced the #define Sb_Attr_* constants with SbAttributes enum class in runtime.hxx and adjusted uses in methods.cxx. Change-Id: Ic7f6f6452849ffc9675ffd697ffc130276082318 Reviewed-on: https://gerrit.libreoffice.org/22948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:unuseddefaultparams in basicNoel Grandin
Change-Id: I286efdac6af47a859693fccc71b445915f76945c
2016-03-02tdf#84938 Change average enum for scoped enumbaltasarq
This is a [partial] patch for tdf#84938, involving the substitution of an average enum for a scoped one. Change-Id: I4b3a19914d30a14dec2640355ba392b943e1ddd7 Reviewed-on: https://gerrit.libreoffice.org/22808 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-26tdf#84938 Eliminate B_xxx defines in filefmt.hxx for FileOffset scoped enum.baltasarq
Second step: Make SbiOpenRecord() accept a FileOffset as second parameter This is a [partial] patch The objective is to substitute all apparitions of #defined constants for enum class. The victim here is the series of constants B_xxx that were located in filefmt.hxx and were changed for a FileOffset enum class. Obviously some other files where the type is used must be changed too. Change-Id: I7406bdc8e780ee89802ab6823f9c91c4c9b765c0 Reviewed-on: https://gerrit.libreoffice.org/22697 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-25coverity#1231668 Unchecked return valueCaolán McNamara
Change-Id: I4c83b1290484dabc9d40f970a3a86de5d6dc3928
2016-02-25change to SearchOptions2Eike Rathke
Change-Id: I07a72492f1cdc566109bf8e9247368558f420abe
2016-02-24simply the SbxRes stuff, inheriting from OUString is ickyNoel Grandin
Change-Id: Ie9794ea164d587ad87ee13d360cb3abc18166051
2016-02-24Removing #defines for String_XXX in sbxres.hxxbaltasarq
This is a [partial] patch for BUG #84938: https://bugs.documentfoundation.org/show_bug.cgi?id=84938 The objective is to substitute all apparitions of #defined constants for enum class. The victim here is the series of constants STRING_xxx that were located in sbres.hxx and were changed for a StringId enum class. Obviously some other files where the type is used must be changed too. Change-Id: I31fa684eb5eb3508d2025c9a319d5b245cc177af Reviewed-on: https://gerrit.libreoffice.org/22655 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22Actually, why passive voice?Tor Lillqvist
Change-Id: Ib8723c7ef1f74b7cfb4efa8e13e34953bff7d0da
2016-02-22Fix mis-translated German commentTor Lillqvist
Change-Id: I9c2dbccdc789b58c583e033a8d5627e0a95a95f9
2016-02-22loplugin:commaoperator in basic/Noel Grandin
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
2016-02-22BASIC : Add tools::make_ref and simplify SvRef usageArnaud Versini
Change-Id: I8fe846dbd353bace05a8732a9b961f3507d97ef8 Reviewed-on: https://gerrit.libreoffice.org/22587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22WaE vs2015 truncation of literal on static_castNorbert Thiebaud
Change-Id: I63a89c50c653145ea49aa34e4e4dd554da66598f Reviewed-on: https://gerrit.libreoffice.org/22597 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17tdf#40517 Unit test for question marks in number formatLaurent Balland-Poirier
Unit test for https://gerrit.libreoffice.org/21021/ Add unit test for Engineering format Add unit test for optional sign in exponent Change-Id: I958ccdcc68a4e496cbd4bdc74d0650c133f3a3f7 Reviewed-on: https://gerrit.libreoffice.org/21824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-17BASIC : use std::unique_ptr for storing SbiExprListArnaud Versini
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec Reviewed-on: https://gerrit.libreoffice.org/22345 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16tdf#39440: reduce scope of local variablesArnold Dumas
Change-Id: I6ba411d2e07240821518281996d543f71acf3259 Reviewed-on: https://gerrit.libreoffice.org/22378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-15cppcheck: unreadVariableCaolán McNamara
Change-Id: I15f0320b646d20f0093c77286c1ff2715aacb8ce
2016-02-15fix indentCaolán McNamara
Change-Id: I48552afc35c1f7cfff3562c36eca3f1cf6174077
generated by cgit (git 2.34.1) at 2025-02-03 16:16:23 +0000