summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)Author
2025-02-26use more concrete UNO types in some local varsNoel Grandin
found by a little plugin I created. Plugin parked into store/ folder because it needs hand-holding when run. Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-26basic : use more OUString literals in basic compArnaud VERSINI
Change-Id: Ib67bee7e4ba85602be266bb7acc23c52251548b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177611 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
2025-02-25tdf#165420: handle empty arguments correctlyMike Kaganski
Change-Id: Ib30cce816b2af8a780e09fa04a2129afd91fafe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182118 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-02-23tdf#158237 Use C++20 contains() instead of find() and end()Simon Chenery
Change-Id: I0efe76b814035aad9faa86c9dfed447759a4448b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182015 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2025-02-15tdf#147132: Flatten Basic function implementationsRahul Anand
Change-Id: Iac462f843bb1437027d2e7a5b6b856d2f00deb8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181317 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-02-12tdf#154285 Check too many arguments to SbRtl_Abs() for BASIC ABS functionSimon Chenery
Change-Id: I82f1df998afca37f5e14baacc9c36339596724ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181447 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-02-09tdf#154285 Check correct number of arguments to SbRtl_Now functionSimon Chenery
If BASIC function NOW is called with the wrong number of arguments, then return error code 5 (Invalid procedure call). Change-Id: I123f316e36e6726a2cfc9d1e53664ce632af1289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181303 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-02-05avoid uno casting cost, and simplifyCaolán McNamara
these are always XStorageBasedLibraryContainers, so transport around as that and can avoid casting and some expensive throw/catches Change-Id: I772efceea3bb4f38d70be0497345f5f81173494c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-02-04disable SbRtl_Shell by default in kit-modeCaolán McNamara
Change-Id: I645c776bf59a718f4946c2c70edd9194f039e471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-02-03tdf#147132 Flatten Basic function implementationsManish Bera
Change-Id: I3a9fe3c74b869195ffa9b34f180e8e58c841d9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180312 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2025-01-23tdf#160578: do not modify procedure argument type based on its useMike Kaganski
Since the initial import, there is a code in SbiExpression::Term, that checks if the defined symbol is used as object (e.g., dot notation to access its members), and then, if its defined type is Variant, then it is corrected to Object. There is no rationale for this in comments; so I have no way to know what could break if that core is dropped. It's obvious that at least for procedure arguments, such correction is wrong: the argument definition is the procedure's API; and the actual use of the symbol should not unexpectedly change what is advertised. This change limits the application of the correction to non-arguments. If it should be dropped completely is a separate question. Change-Id: Ia902afa3f744d0d51510ba6903be45f78e2f6429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180665 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-23tdf#164811: swap the "if IsCompatibility()" branches to match other placesMike Kaganski
Commit 9cdb73ff28c4cd6380412468f34ff10e46292a07 (INTEGRATION: CWS jl5vba (1.25.94); FILE MERGED, 2004-03-17) has introduced handling of decimal, currency, and date for VBASupport mode in sbunoobj.cxx. However, in getUnoTypeForSbxBaseType, it changed the behavior for date type in the non-VBASupport mode, obviously by mistake. This change swaps the code in the 'if' branches, to what appears to be the original intention. Change-Id: I88cddf7cec1a980f56de96ae1c5e64d8e7630b77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180637 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-19tdf#145614 Convert #define to enumbruh
Change-Id: I146b65cc931dfc3ce2785ccb5c921e6385fbb4a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180015 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-16tdf#147132 Flatten Basic function implementations.bruh
Change-Id: I5e5d01c43b39f68f38290ce04b26730af362b43e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180282 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Second functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ib3a97f9acb7778c90aa1c172ca82cf450a1e792f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179249 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Hour functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ib372b4dfde77961e7982bd0d8f1f8598be7da726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179252 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Month functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ifc27af0f091c75c02d3816b83b3717fc435ad31b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179250 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Day functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ic22d420f0f5596ea3a4ff9cd7e540e6c51a559ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-09tdf#154285 Check upper bound of arguments in SbRtl_Year functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Iffffe3988afdc91068e85beaafc5ff1580210ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-08tdf#164600: Return true from IsNumeric for booleans in VBASupport modeMike Kaganski
Change-Id: Ib68f237001389c8f7b9d2771d5162a583b544b83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179866 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-08tdf#164599: Allow space between sign and number in VBASupport modeMike Kaganski
Change-Id: Ib9e8c8770f8c2d1b348ff032502467915829c4f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179865 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-08Use sal_Int32 for string lengthMike Kaganski
Change-Id: Ie069c20b7d91631cb3b5d39e1a52f09cc13e8a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179864 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-08tdf#154284: check if ImpScan found a number at allMike Kaganski
Change-Id: Iddc87bd0d04f9b0212b03d63f3177b17bb07d278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179863 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-05tdf#154285 Check upper bound of arguments in SbRtl_Minute functionAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Ic861d453395a10d484614e29b5a491800ddb7a25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179251 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-27tdf#147132 Flatten Basic functionBogdan Buzea
Change-Id: I7dfec2da7ee3982255cd5be11d350c343331ed0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177459 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-24tdf#164446: fix internationalized FP input in Basic IDE WatchMike Kaganski
Now that tdf#97983 fix made the default conversion internationalized, the special handling of the Watch window input needs to do it in the other direction. Additionally, move ImpConvStringExt to the single place that uses it. Change-Id: I18a4043511f4a1b32f79410447e96c7679329886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179302 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-23Simplify ImpScanMike Kaganski
Change-Id: I8928d3c7f0fc6884a75c05e77908df7f482c9e44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179246 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-23Simplify a bitMike Kaganski
The previous code made sure that cNonIntntlDecSep is always equal to IntntlDecSep (in the code handling bOnlyIntntl). Frop the redundancy, and make the variable names simpler. Change-Id: I31c994cd49bdbf007e110f593297acf112cc420b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179198 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-23Fix a copypastaMike Kaganski
From commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d (resolved rhbz#919020 Basic CDbl() and CSng() scan localized number, 2013-03-19) Change-Id: I871d7fb06ccb5d15723f7acfb57701890607055f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179197 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-07SfxLibraryContainer: use std::mutex, and pass it to NameContainerMike Kaganski
... to avoid own mutexes in own name container implementation. Change-Id: I29ff6ef987154359c35d0628d529b0606ef08c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177637 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01NameContainer need not be an UNO object itselfMike Kaganski
Change-Id: I56f07a62ed3d2388eede16a85e673027cfed8158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177616 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01Optimize SfxLibrary / SfxLibraryContainer memory layout a bitMike Kaganski
Change-Id: I63ba583ef990dd2bbfb7f44af613fce1d8d1b411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177608 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01Simplify SfxLibrary hierarchyMike Kaganski
For some reason, SfxLibrary's own interfaces were used outside of WeakComponentImplHelper; and derived classes didn't use inheritance helper. Change-Id: Ib0b6cf5cfa559fe5eedc4d05247655aca1bfc4b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177607 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-01Simplify a bitMike Kaganski
Change-Id: Ia48a24d1696aaf2ee7e49f5e8c9f9dcc0ae9e8e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177606 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01Simplify NameContainerMike Kaganski
Having a map, two vectors, and a counter for what is a job for a single map is a bit too much. Change-Id: I50d29f03a2463e6f63ed8e645c36b4c77aa1413a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177604 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01Drop unneeded indirection and unused argumentMike Kaganski
The extra complexity was introduced for #i94994# in commit 326696598621c5883d7c28f491ca8192e8cfb21c (CWS-TOOLING: integrate CWS ab61, 2009-02-11). Change-Id: If5a69984e3c2c963d4eea2824373fbf1e8a47fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177603 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-14tdf#108189 inspection of object hangs LONoel Grandin
There is no general solution to this that I am aware of, so just implement a rather specific solution that will need periodic extending to check for other dangerous properties Change-Id: Ie09d89416fea5b7cdf782319ed9921657faa5a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176593 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-14Improve loplugin:dyncastvisibility to check for non-inline key functionsStephan Bergmann
This would have caught the issue discussed in 709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique RTTI". (The commit message talks about RTTI there, while what Clang actually compared for an optimized implementation of a dynamic_cast to a final class is vtable pointers, but the overall picture remains the same. Both RTTI and vtables are emitted along the key function, and if that is missing or inline, they are emitted for each dynamic library individually, and as internal symbols on macOS.) This commit also addresses all the issues found by the improved loplugin:dyncastvisibility on Linux. See the newly added TODO in compilerplugins/clang/dyncastvisibility.cxx and 86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function" for an issue with key functions for class template instantiations. Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: Ic54a8e009f68ab992831ba849ae1349a6235bedd V1037: Two or more case-branches perform the same actions. Check lines: 1276 and 1408, 1434 and 1510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175149 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in basicNoel Grandin
Change-Id: I38bc2711bdec2bdaf998401083ff9b62a5595616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08loplugin:reftotemp in basicNoel Grandin
Change-Id: I41385d279cc81de9b5b2e9ff55b0b5c2f40aba66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08Simplify a bitMike Kaganski
Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-06loplugin:passstuffbyref in basicNoel Grandin
Change-Id: I1aee08f0ff2a3dabcedc49a31e7ff4de9428007e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-02Simplify a bitMike Kaganski
Change-Id: I2e4635c660a57abefa57b046e3f0da411939cf1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175953 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-01no need to heap allocate theseNoel Grandin
Change-Id: I28127f5943a80aca1689d5982cd1f6e6e11eb2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-31tdf#163680: fix fixed-length strings assignmentMike Kaganski
Change-Id: I4aa8144df5dfb836ad0689c7855301b8b04da485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175878 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-31No need to heap-allocate itMike Kaganski
Change-Id: Ia6bbf6d3f5b9af2a5b52b8c6baec85bdcb579275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>