summaryrefslogtreecommitdiff
path: root/bin/gla11y
AgeCommit message (Collapse)Author
2023-10-22gla11y: Add link to a white paper describing the rationales of the toolSamuel Thibault
Change-Id: I0d60cb6b3ee2105d58ea56f3efc5bb5ee856a44a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151147 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2022-03-08replace member-of in .ui a11y relationsCaolán McNamara
Change-Id: I454c945c5ce17bcc1834923064014b43a0b45be7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06remove support for deprecated GtkAlignmentCaolán McNamara
Change-Id: I29e21e9e4d9b80b8c8e331ed9cce76b2e7fe0f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18Fix typo in codeAndrea Gelmini
Change-Id: I7a9b2dccc118395494cf39cfa64867c09a358c31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100869 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-07-08Fix typoAndrea Gelmini
Change-Id: I91bd071261dfd964a6f7705cf8bb30814ef3a671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98295 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-07gla11y: improve warning printingSamuel Thibault
Also print the howto URL in messages about suppressed warnings When showing suppression lines, also print the suppression file name. Change-Id: I72da4149c505cec04bf715791f45a2b809d3ce63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97989 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-07gla11y: Document global variablesSamuel Thibault
Change-Id: Ic8ed50bdff182bab1104b5a22e667aadfd25c684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97982 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-05gla11y: add check, buffer output and # commentJan-Marek Glogowski
- add visible check to labelled-by - buffer output, so it's consistent in parallel builds - remove per-line file reference and just add a general header referencing the used suppress and false-positive files - allow common commenting in suppression and false-positive files by starting a line with a # Change-Id: Iefac711deb9ea620728ab5b0aeac73cfff40a7b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/61051 Tested-by: Jenkins Reviewed-by: Samuel Thibault <sthibault@hypra.fr> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-04-15Related tdf#130778: New About dialogHeiko Tietze
More flexible dialog logo & about images as SVGs Change-Id: Icefa035893e241a7dee6aa28236e6b89b38477de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91908 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-01gla11y: Fix checking orphan labelsSamuel Thibault
Change-Id: Icd43014f40a655b512b6328f4800906325d9b164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89767 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02weld SfxRecordingFloat_Impl utility windowCaolán McNamara
we can't abuse action_name anymore as the uno command are not legal actions Change-Id: Iaf9306c6e3eec852d2a50df9161bd20383881a04 Reviewed-on: https://gerrit.libreoffice.org/81902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01remove some resolved ui suppressionsNoel Grandin
and enhance the script to make finding the unused ones easier Change-Id: I937246e98d93fb999a23f2283b6794eaaa6dfa99 Reviewed-on: https://gerrit.libreoffice.org/76806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13gla11y: whitelist GtkTreeViewColumn as not needing labellingSamuel Thibault
and remove corresponding suppressions. Change-Id: I0dd88082ee0af4c5ee82590e894305fa53574c6b Reviewed-on: https://gerrit.libreoffice.org/72133 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-04Fix typoAndrea Gelmini
Change-Id: I58c1158dbd96ace17666177ef9b2d9f19309a2d6 Reviewed-on: https://gerrit.libreoffice.org/70228 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-04gla11y: better print paired element for visibility conflictSamuel Thibault
Change-Id: I1f3bcaf732d01c5def7b84ecbd14e0cbe3397927 Reviewed-on: https://gerrit.libreoffice.org/61300 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28gla11y: check element visibilityJan-Marek Glogowski
Add warnings for different visibility settings in the "label-for" and "labelled-by" elements. Sine LO doesn't support multiple annotations per accessibility element, we have to switch them manually, if we change the visibility of one element of a pair. Change-Id: I9b3d941248b804b8435591536277677e99b77340 Reviewed-on: https://gerrit.libreoffice.org/61050 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-04-20Update gla11ySamuel Thibault
This updates the gla11y tool - mnemonic-widget is actually an alias for mnemonic_widget - ditto for tooltip-text vs tooltip_text - ditto for placeholder-text vs placeholder_text - glade introduced a notation for specifying the role of a widget, which can be used to make a label static for instance (thus not orphan). - --help is fixed to use the standard formatting. - Remove the documentation of unexisting -i option - Add the documentation of -P option - Add --help/-h and --version options for completeness. Change-Id: I8510ba9c5a877c05edd3af305b4e7fe1f105acd5 Reviewed-on: https://gerrit.libreoffice.org/52973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27gla11y: add support for marking false positivesSamuel Thibault
Change-Id: I62c24f0aa20dea1cca4ba77a71dbb247bc37a5b5 Reviewed-on: https://gerrit.libreoffice.org/51545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27gla11y: update heuristics but don't enable warnings yetSamuel Thibault
This updates gla11y with all heuristics to detect orphan labels and widgets without too many false positives. This updates gbuild to tell gla11y to only emit errors about undefined targets and about orphan warnings for GtkScale (as was the case with previous versions). More errors and warnings will be enabled progressively later on. Change-Id: I96580eb0eb8eb327f0f54563d7976a5148e9531a Reviewed-on: https://gerrit.libreoffice.org/51161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-04gla11y: allow python 2.6 when lxml is availableSamuel Thibault
python2.6's internal xml parser is not enough for gla11y, but it can run python-lxml fine. Change-Id: I725471729c8e2f25ce60f1d92e08d87a96e171a5 Reviewed-on: https://gerrit.libreoffice.org/50686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-02build fix: disable gla11y for python 2.6Thorsten Behrens
Things got massively worse with f927fc06b8160c6db134b29dab510e2cd567e3f3 so disable for the moment Change-Id: Ie8a03aa42d5c29bc6931c9c621d1b0427eeddab8
2018-03-01gla11y: fix build outside sourceSamuel Thibault
We need to pass the absolute path to gla11y for build outside source to work. We however do not want to expose absolute paths in suppression files, so we have to introduce a parameter that provides the common prefix to be stripped. Change-Id: Iaf652cb8d6c3646438f828a0949dfd811f964e77 Reviewed-on: https://gerrit.libreoffice.org/50568 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2018-02-28gla11y: add warning/error suppression machinerySamuel Thibault
Also add an accessibility test which does have a few existing issues, and the corresponding suppression lines. Change-Id: I7095cdc13e40501bbdf6e635c1e4f93f70bc1316 Reviewed-on: https://gerrit.libreoffice.org/50251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28Build external lxml if not provided by systemSamuel Thibault
except on windows, where gla11y will resort to python's internal xml parser, which does not provide line numbers. This allows gla11y to be runnable on all systems. Change-Id: Ica4eb90f59bddfcefd783fc2ed9c8c27357e7572 Reviewed-on: https://gerrit.libreoffice.org/50115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-26Fix typosAndrea Gelmini
Change-Id: Ifcfb8ed6783f7d022e7c7f139e3f3bafa7b4b71a Reviewed-on: https://gerrit.libreoffice.org/50088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-22The vim mode line supposedly needs to go at the end of the fileStephan Bergmann
Change-Id: I413b01e93000f9f81ba6190811cea51c04f1d58b
2018-02-21gla11y: do not fail when not passed any .ui fileSamuel Thibault
This avoids build failures when a directory uses UIConfig but does not add any ui file. Change-Id: I63413f87fc5515ffb9e3dd9baf25c6a4ba70c2be Reviewed-on: https://gerrit.libreoffice.org/50071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-20Integrate initial version of gla11y tool in the build systemSamuel Thibault
This is part of integrating an accessibility non-regression tool. This adds checks in configure.ac for the presence of python lxml which we will need, and adds support for calling the tool at build time, to check for definite UI errors. For now, that only emits errors for missing or duplicate accessibility relation targets, and senseless relations: a label being mnemonic for several widgets. Change-Id: Idda91b15b9a9e0322d16db33dfac8e03f2aa518c Reviewed-on: https://gerrit.libreoffice.org/49856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>