summaryrefslogtreecommitdiff
path: root/bin
AgeCommit message (Collapse)Author
2022-04-25find-unneeded-includes: bail out early if no files are found with --recursiveGabor Kelemen
Change-Id: I5bd726b33e4fc7068baad91ff185763274307b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133308 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-24Fix typoAndrea Gelmini
Change-Id: I85013e2fc1150b1830fa21da7ed77ac95ff7452e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133352 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-04-23find-unneeded-includes: add --noexclude argumentGabor Kelemen
To ignore the excludelist, thereby checking if its exclusions are still valid. It may happen that some refactorings make an exclusion obsolete. In this case the IWYU suggestion to remove a now-really-unnecessary header would be ignored forever. It makes sense to use it after a full cleanup of a module in normal mode. Change-Id: I8216a79ea2354ab428d6ce7a56a49e5cf67056fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133307 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-08ofz#46162 and ofz#46287 Integer overflowCaolán McNamara
Change-Id: I58bc9aadab1765e8ce4bc8e6e631cd72b853f9b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-16ofz#45581 and ofz#45574 suppress Integer-overflowCaolán McNamara
Change-Id: Ia32f0ae42e4ac45681749e25d95f3c84359396d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131683 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-15ofz#45574 suppress Integer-overflowCaolán McNamara
Change-Id: I869a88964540538c7ccb2d91e80ea5095dd31367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-13don't need this exclude entry anymoreCaolán McNamara
Change-Id: Ifb9f611dfb5751af40c8d8ec5f967e0ec535ae60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12ofz#45501 and ofz#45503 Integer-overflowCaolán McNamara
Change-Id: I20576860dc20900589d13c43a98af91c5fd0fff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131443 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-12check-missing-unittests: fix pathXisco Fauli
Change-Id: I568cfdd1874ccba2f7233e21166026cfcda8e733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131384 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-10ofz#45344 and ofz#45392 suppress Integer-overflowCaolán McNamara
Change-Id: I775a5f3c12e784d2716f14fff15a65a669f0ce15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131328 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-09tweak suppressionCaolán McNamara
Change-Id: I85d343b87477fe98b131158c0f8e0654bd130e94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08replace member-of in .ui a11y relationsCaolán McNamara
Change-Id: I454c945c5ce17bcc1834923064014b43a0b45be7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-07Drop useless parameterTor Lillqvist
The parameter to PrintFontManager::countFontconfigFonts() was only written to since babf6d5e53516e80e8e3f2485796ebfaeb20e9c1. Change-Id: Ie206fdbd620f1cfc6402c1d02709c3b653140c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131097 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-03-07ofz#45323 suppress Integer-overflowCaolán McNamara
Change-Id: I22f9e2cd04d152e28cf91a4d474e46b83f85c952 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131099 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-06ofz#45271 suppress Integer-overflowCaolán McNamara
Change-Id: I8611f340e6fde049f209627e46f8ca0e100b9b6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131083 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-06ofz#45237 suppress Integer-overflowCaolán McNamara
Change-Id: I44496ae9428a75a6a08633e5ec31a754522ef1d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-22Adapt CustomTarget_postprocess/check_dynamic_objects to --enable-gtk4Stephan Bergmann
> instdir/program/libavmediagtk.so has suspicious NEEDED: libgtk-4.so.1 > instdir/program/libavmediagtk.so has suspicious NEEDED: libpangocairo-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libpango-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libharfbuzz.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libcairo-gobject.so.2 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgraphene-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgio-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgmodule-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libglib-2.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libatk-1.0.so.0 > instdir/program/libavmediagtk.so has suspicious NEEDED: libgobject-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgtk-4.so.1 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpangocairo-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpango-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo-gobject.so.2 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgraphene-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgio-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgmodule-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libglib-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo.so.2 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libatk-1.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgobject-2.0.so.0 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libX11.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libXext.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libSM.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libICE.so.6 > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libdbus-1.so.3 Change-Id: I686cdc5f21c9a730167e9efa120946f6d96eaed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130305 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-16flat-odf-cleanup.py: fix FutureWarningMichael Stahl
The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead. Change-Id: Ic1aedaff3569b9b3063823c747c1d09623b2efad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130032 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-15find-unneeded-includes: check existence of files listed in yaml filesGabor Kelemen
It might happen that some files are removed/renamed warn about such files to adjust filter rules Change-Id: Ib8f1c586a67310cc8be04edfcc75f655da2dbfe0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129881 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-14flat-odf-cleanup.py: remove rsid attributesMichael Stahl
Change-Id: I2d2bcd2bce525b111906c59d2d119e1d63d2174b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129852 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-14find-unneeded-includes: rename argument to --continueGabor Kelemen
sounds more natural than --dontstop Change-Id: I4650f8bf97a426782828f0e088805551c5830acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129880 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-10Fixed function nameAndrea Gelmini
It passed "make check" Change-Id: I0828ea2c2531cb970f32581333776f02a46a8d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129314 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-07Fix typo in codeAndrea Gelmini
Change-Id: I78730afbfdebbd634343741b57718a467f6c9b15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129350 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-02flat-odf-cleanup: survive already missing settings/scriptsMiklos Vajna
If they are already removed, just don't do anything. Change-Id: I3ef09ea5de8841820d586b41ed6c86e78bd06b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129326 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-01add bin/flat-odf-cleanup.pyMichael Stahl
Change-Id: I0e4512762519a6ac4e4968cbeee3576cc7eeafa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129286 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-31extract an initial webpfuzzer_seed_corpus.zip from the afl corpusCaolán McNamara
Change-Id: Iae44bf9113cf78e2f7dcf20a4f987bda0614b2d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129214 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-31support for the WebP image format (tdf#114532)Luboš Luňák
This commit implements a WebP reader and writer for both lossless and lossy WebP, export dialog options for selecting lossless/lossy and quality for lossy, and various internal support for the format. Since writing WebP to e.g. ODT documents would make those images unreadable by previous versions with no WebP support, support for that is explicitly disabled in GraphicFilter, to be enabled somewhen later. Change-Id: I9b10f6da6faa78a0bb74415a92e9f163c14685f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-29gtk4: remove stray label_yalignCaolán McNamara
Change-Id: Ia1eb3fe4fac9511c4d0b531bdbc722e420a96f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129150 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29gtk4: remove unwanted caps-lock-warning from GtkSpinButtonCaolán McNamara
Change-Id: I723b13a5b012a89379cf6984a2b0fdd44ae932f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29gtk4: remove stray 'gravity' propertyCaolán McNamara
Change-Id: Ia68e3d96a7fbc381fc4215800b33dd21d2a38119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28Fix CustomTarget_postprocess/check_dynamic_objects for --enable-dconf...Stephan Bergmann
...plus --enable-mergelibs, like 4a2db3545a023468e191a5ec89a6343b7aef2ef2 "Fix CustomTarget_postprocess/check_dynamic_objects for --enable-dconf" Change-Id: I981ab82ecf2a459b384e243260a9611f6016acf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129119 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-26ensure no 'angle' is used in a GtkLabelCaolán McNamara
Change-Id: Id6231774fb1a8d12e771815023e661d5e0ac06a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25gtk4: deprecated GtkEntry shadow_type was removedCaolán McNamara
Change-Id: I378db5406c508e3672927905735449a3a1003e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25Related: tdf#146971 remove %PRODUCTNAME from accessible-descriptionCaolán McNamara
Change-Id: I83ff18c8b5e95fa172de950eb351cbfd855c9d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-24Dispatch commands: Include tooltip labels in the Description columnJean-Pierre Ledure
The modified script updates the https://wiki.documentfoundation.org/WikiAction/history/Development/DispatchCommands wiki page. A typo excluded the tooltips while they're meaningful when they are longer than the usual UI labels or the "context" labels (whatever a context label might mean). Change-Id: I001d1a5624be9f40761f5e0dcd28da0a9feb981e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128866 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2022-01-24gtk3: set placeholder image in GtkButton in .uiCaolán McNamara
so the image+text layout is created by default Change-Id: Id5e9801274ebaa9e9cfdddcfac628b83828342fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-14Dispatch commands: reviewed wiki layout and contentJean-Pierre Ledure
The wiki page https://wiki.documentfoundation.org/Development/DispatchCommands is generated by the execution of the python script: /bin/list-dispatch-commands.py Layout and content changes: - better commands list coverage Scan of .xcu, .sdi and .hxx files The list is the "union" of the found commands => Base and Charts commands are part of the list - new classification based in the 1st place on the .xcu files i.o. the .hxx (or "slots") names => Commands are listed only once - The sources providing the listed info are referenced for each command with a direct link to the opengrok sources - New information when available A subclassification: the group The potential arguments of the command Change-Id: I54dd8c219d0e7a00fd346faa7577e181a068bbaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128254 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2022-01-06get-bugzilla-attachments-by-mimetype: query different bzs concurrentlyMichael Stahl
Downside is we can't easily detect when one tracker is done, but it should be faster. Change-Id: Ie78ddf0381690040d7a4fa06f910717fcdfe0eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128038 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-02oss-fuzz: put LO downloads into $SRC/external-tarJan-Marek Glogowski
Change-Id: I0d5cf89fabc8e044959dbd0af484b5ca46404eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127854 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-30oss-fuzz: add more verbose output to build scriptJan-Marek Glogowski
* dump git HEAD status on build start * dump "date -r" and "df -h $OUT $WORK" at various steps * run "make clean" before autogen.sh, if Makefile exists Change-Id: I22885f820e81fa46d02699fb5c2129ac5921c5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127609 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-25oss-fuzz: convert to static cross-buildJan-Marek Glogowski
This way we can get rid of the pre-generated locale data and the special fuzzers target, which invokes a full gbuild make for every prereqisite, always parsing the whole tree, taking ages. This also reverts: - commit d0780b21cfe235c4446adf649eb690f9c1771dd5 ("fix oss-fuzz build") by adding epubgen and revenge dependencies. - commit ff25d6a123beb42476bf42d189b3033a86835b2a ("ofz#41602 fix more build failure"), which shouldn't happen anymore since commit d47628f287f4377394c4ff488c433bfe254b6abe ("don't want to link to system static libs for DISABLE_DYNLOADING") Change-Id: I3aed9ec62da507254b42e4e7470bae1097b4bc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127031 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-16drop ui-previewerCaolán McNamara
the need for this is gone now the transition from src to ui is completed. I certainly don't use this anymore. Change-Id: I5bf9c8bc4f00152977091f466c2e808b824acb44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-15ucb: remove --with-webdav=serfMichael Stahl
Remove code in ucb/source/ucp/webdav, and now unused externals apr, apr-util, serf. Change-Id: I31ab8bb1491f5290e175e87f2b30499811c5a359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126835 Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-12-14find-unneeded-includes: add exception for boost/shared_ptr.hppGabor Kelemen
* as seen in vcl/inc/skia/salbmp.hxx * also remove earlier exception from ucb modules file Change-Id: Ie0ad46048147916b615f74d8eab6e033c2020565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126739 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-14Fail module-deps.pl on more errorsJan-Marek Glogowski
* Fail on the error code returned from make * Collect dependency errors in the tree and fail and print them The "perldoc -f open" has an example in the "Opening a filehandle into a command" section, which uses waitpid in the parent. Since we parse the pipe output, there seems to be no need for waitpid, because we end when the pipe is closed by the writer. waitpid always returns -1 at this point and since there aren't any zombie processes, it seems to be fine to ignore. Additionally strace shows, clone, execve and waitpid calls, so the explicit exit in the example seems bogus, if the process is actually overwritten. And the pipe is just open in the parent process anyway. Change-Id: I2e77aa33a0eaa5d6d3e06904bb0af53f4b66ef91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126789 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-10Revert "Re-Enable DrawTransformBitmapExDirect for render backends"Armin Le Grand
This reverts commit 7e5af164b7d293dd410710bed411e1ca64bbecf7. Reason for revert: Not the best/effective way to clear out the stuff remaining to be done, would need additional stuff Change-Id: Ia6ab90384da29a5e34eff0ab8881bad2ab49c58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126601 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-12-08remove an oss-fuzz workaround with upstream merge of better fixCaolán McNamara
Change-Id: I8a89b80f804bbcf4606d55dcecf44e44095112eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126504 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-07Re-Enable DrawTransformBitmapExDirect for render backendsArmin Le Grand (Allotropia)
Unfortunately the add/usage of HasFastDrawTransformedBitmap did disable the system-dependent implementations/fast-path for DrawTransformBitmapExDirect and it's implemenations, except for Skia. This means that the current backends for Windows/Mac/Cairo/headless/Qt5 have to do expensive pixel operations when a Bitmap is 'really' transformed (rotate/shear) since some time. The nine implementations using ::hasFastDrawTransformedBitmap (grep for it) all return false, except the Skia one. Since HasFastDrawTransformedBitmap() uses that and itself is used in the very central mehod OutputDevice::DrawTransformedBitmapEx(...) to decide if that fast-path shall/can be used at all, it was *no longer used* - except for Skia - what makes Skia definitely performing better with transformed Bitmaps, or the other way around - the others worse. HasFastDrawTransformedBitmap() is used in only two places, the second is in the canvas helper to decide if to try to use that fast-path for presentation rendering. A method at OutputDevice to see if that fast-path is implemented is therefore currently needed, but for the canvas helper only. Since this will/should be converted to primitive usage (hopefully) anyways, nine impementations calling these virtual functions often and the danger to produce a mismatch/ error beween implementations of hasFastDrawTransformedBitmap and drawTransformedBitmap (as happened here, but can also happen when someone adds or removes an implementation) I looked for a way to solve that differenly and more safe. Since SalGraphics::DrawTransformedBitmap anyways returns a bool to signal it's success I take this as base to implement a buffered test directly at SalGraphics, also directly set a local flag to detect that functionality if DrawTransformedBitmap is used anyways before the test is/would be needed. Combined wih that small test to check only if this was not yet used and thus tested by DrawTransformedBitmap anyways I can offer a reliable non-virtual method at OutputDevice called ImplementsFastDrawTransformedBitmap() that will be used at the single necessary location - in the canvas helper. Since that small test direcly uses one of the nine implementations of hasFastDrawTransformedBitmap it is fundamenally more reliable and probably the copy bitmap/writeBack never really used (I tested that it works) due to an earlier use of DrawTransformedBitmap did the check potentially already. I also took a look at the cairo version (since I had this one running here) and ensured that the buffering of the system-dependent form of the Bitmap as cairo surface still works. Regarding the newly introduced fAlpha parameter I want to add some remarks: - It should be called fOpacity to make clear that it describes opacity, defining that if 1.0 == fAlpha means *no* transparency. That word is used in other graphic systems and makes more clear what function it has. It is the opposite of transparency, but works the same. - Currently all implementations of ::drawTransformedBitmap - except Skia where it was implemented - do not use it, but return false. It will in most cases not be too complicated to add/implement it, e.g. for cairo anyways a transparency surface will/is created, fAlpha can just be merged in, and the criteria for buffering that may be extended to remember for which value (if at all) of fAlpha that was prepared. I strongly recommend implementing these for our main graphic backends. - The primitive renderer uses another more general way to add an extra alpha channel to paint when needed - it draws the content (any content) that needs to be transparent to a buffer and then that buffer using the intended transparency. This is discussable since may be more expensive, but more general and keeps the interface less complex. We can see here that adding that complexity to the existing interface at OutputDevice makes the implementations more complex what might be the reason his was only implemented for one of nine backends. When adding something like this and extending the complexity I would prefer that at the same time it gets also *implemented* in all or most or at least most used cases. I want to make clear that from my POV in those cases choosing possible runtime speed over complexity is not always preferable. Change-Id: I5bab59f59fca878a7b11a20094e49e8b50196063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126480 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-12-06Retire build-nocheckThorsten Behrens
Build target was kept for backward compat in 'rework the default make target', so lets retire it after 1.5 years. Use 'make build' instead (which is since the default target anyway). Change-Id: I93d5237dce2abf2536a4d847d79d33d5b6d6cec9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126362 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-03bodge installation of lockfile-progs for nowCaolán McNamara
Change-Id: I1f7395fd12539d936f3651e5e173799a7c61e14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126286 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-05 18:19:00 +0000