Age | Commit message (Collapse) | Author |
|
This does not really work: even when it seems to, it compiles only
because of transitive includes
- Filter o3tl/typed_flags_set.hxx in f-u-u
- Remove already added fw declarations from hxx files and
include full header just in case
- Remove now unnecessary blacklist entries
Change-Id: Ie0de6667af697095a623b435806449e7e28a6004
Reviewed-on: https://gerrit.libreoffice.org/64659
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I40c9591cd9787c919a5da7526ab866518bad3812
Reviewed-on: https://gerrit.libreoffice.org/64912
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I69e4d471c806159d6748016a79f041c01b40b888
Reviewed-on: https://gerrit.libreoffice.org/64430
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95
Reviewed-on: https://gerrit.libreoffice.org/64102
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
Default IWYU output is sorted alphabetically by filename
A more friendly way to present f-u-i information would be
to sort by line numbers: so that a developer can go through the removal
proposals in the editor top to bottom, without too much cursor positioning
in the list of 100 header lines to delete 20 of them.
The result is not perfect, because numbers in text are not naturally sorted:
line 205 will be listed between 20 and 21; but that's a really rare occasion
Change-Id: I8011321a299a76f5a32469a9d77eb8fcc4521034
Reviewed-on: https://gerrit.libreoffice.org/63144
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This gets rid of the horrible hack in gbuild.mk to accomodate the
case-incorrect iOS platform makefiles that cannot be renamed without
upsetting git on file systems that sadly lack the case sensitivity
feature.
Keep the macro defined to IOS though.
Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234
Reviewed-on: https://gerrit.libreoffice.org/62705
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
...as happens e.g. in
<https://ci.libreoffice.org/job/lo_daily_update_gandalf/515/>. (Regression
introduced with d157e510252636d3519c71415c20dfd113d40960
"check-elf-dynamic-objects: allow extending the whitelist via env-var".)
Change-Id: I93097d0bb7781b1bfac818872f40bbe38c5f5fea
|
|
to allow working on packaging with epm without a baseline setup...
Change-Id: I9ab737cd52adf51c9eb23a4bc67f09c0ac06647e
Reviewed-on: https://gerrit.libreoffice.org/62454
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: Ic7e6aa31e5c6d210101da7223a294092ab5b7481
Reviewed-on: https://gerrit.libreoffice.org/62334
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Better to not replace stable API headers with implementation details
Change-Id: I66c7a237b1df13b7aa2523eba87d45d123621a95
Reviewed-on: https://gerrit.libreoffice.org/61742
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
This regex parsed unneeded fw declarations reported by IWYU in the form of:
class foo;
But not ones inside namespaces, e.g.:
namespace foo { class bar; }
namespace com { namespace sun { namespace star { namespace foo { class bar; } } } }
Change-Id: Ie2962b9fb1cf9382e8da45903f3716d0311dd58e
Reviewed-on: https://gerrit.libreoffice.org/61485
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I1f3bcaf732d01c5def7b84ecbd14e0cbe3397927
Reviewed-on: https://gerrit.libreoffice.org/61300
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I46db49472dcaa80b54a937f03bf03b06a2d8a87c
Reviewed-on: https://gerrit.libreoffice.org/61240
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Add warnings for different visibility settings in the "label-for"
and "labelled-by" elements.
Sine LO doesn't support multiple annotations per accessibility
element, we have to switch them manually, if we change the
visibility of one element of a pair.
Change-Id: I9b3d941248b804b8435591536277677e99b77340
Reviewed-on: https://gerrit.libreoffice.org/61050
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
I am writing a separate unit test app that will include selected
existing unit tests that make sense and are important to run on iOS.
Change-Id: I4722f1ed872ba21e181eeba5ed3b58e82d8fed72
Reviewed-on: https://gerrit.libreoffice.org/61049
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
As seen for include/comphelper/doublecheckedinit.hxx - won't compile anyways
Change-Id: I3a0d5e115ecfc61ae90c6e843ecf4f0213b76e82
Reviewed-on: https://gerrit.libreoffice.org/60838
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
clear previous build results, but leave results of this build in place
Change-Id: Ia2857c7cfb33ac0227323d90828818ceb6e693a8
|
|
It can be useful.
This reverts commit b140f92531396c1087b997852d7ece18429b79d1.
|
|
Otherwise we could break some external code for no good reason.
Change-Id: I01b1e266425688d3d4b5293c0f8609d78c6b7f2f
Reviewed-on: https://gerrit.libreoffice.org/60331
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
This allows to avoid the "(Visual Studio 2015)" labels next to project
names in Solution Explorer; and also avoid multiple warnilgs like
project-name.vcxproj : warning : The build tools for Visual Studio
2015 (v140) cannot be found. Install Visual Studio 2015 (v140) to
build using the Visual Studio 2015 (v140) build tools.
in IDE's Output pane in case VS2015 is absent locally.
Change-Id: I53b68ac810cbf2a31667c35dd549310e7209e010
Reviewed-on: https://gerrit.libreoffice.org/59797
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Fixes the problem that e.g. this code:
OUString str;
str += "";
is marked as a compile error, when clang would still work with c++11,
but the tree is configured for gnu++17.
Change-Id: Id60c0cf4b8c693b534f16ba813cf01a4bad7e560
Reviewed-on: https://gerrit.libreoffice.org/59746
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I3b03e3a75f5a6157479582e74be349c567fc1e8c
|
|
Change-Id: I8166bef1c7786c17f531be807029ba8d609931b3
Reviewed-on: https://gerrit.libreoffice.org/58971
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic5d2cbdbcce29a2d9b9db1485da9ed18a3330e4a
Reviewed-on: https://gerrit.libreoffice.org/58943
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If633ffae3cd3acaf489a31891ca91f810c5e50c4
Reviewed-on: https://gerrit.libreoffice.org/58917
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic591748eedbe82b1c7305ef68156370f1b97f216
Reviewed-on: https://gerrit.libreoffice.org/58904
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ida877ab6e65d4bcbd42d37fd2567db63f84ed8ad
Reviewed-on: https://gerrit.libreoffice.org/58456
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
Change-Id: I25703979ebe94649f9cf1464d282b21a70cfe1fa
Reviewed-on: https://gerrit.libreoffice.org/58041
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I6e5bef8840730f61ca976c72a808b9ffd21fe8dc
Reviewed-on: https://gerrit.libreoffice.org/57883
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: I07cf04cd2acc5b50d64224edb9f2c2de2c61e356
Reviewed-on: https://gerrit.libreoffice.org/57884
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: Ia578c71ae70aa0a85b49fa50138edf90f961b1e9
Reviewed-on: https://gerrit.libreoffice.org/57533
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I4a17cfb567f5ebec8bb416b9aa4d58763ff36c36
|
|
They wouldn't really compile anyways and only cause unnecessary
blacklist entries.
Some '- memory' entries can already be removed from the blacklists.
Change-Id: Iab53d5a57121f61abe935e712dc23a55390235bf
Reviewed-on: https://gerrit.libreoffice.org/56979
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Seems that 'git worktree' is now the upstream-supported way to create
light-weight working directories:
https://blog.github.com/2015-07-29-git-2-5-including-multiple-worktrees-and-triangular-workflows/
Change-Id: I9f019238b59686e2a7e924869ffd2e8d1d8e2269
Reviewed-on: https://gerrit.libreoffice.org/52411
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
This requires a new validator jar for the -m flag to specify
MathML schema.
Change-Id: If99cf70f386a16a90ba676f8f5ff65a537c9ce56
Reviewed-on: https://gerrit.libreoffice.org/56487
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I2ed73a296b813de722156c69ac64cf9d6cff199d
Reviewed-on: https://gerrit.libreoffice.org/55197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Change-Id: I4bbea7e1af34bd5c30e3830ecb58af2b6a3a09d4
|
|
Change-Id: Ic2e6138b1ba1a8031a80e4e58f468b6c0f7a4de3
|
|
Change-Id: I51daa79f3f2772d054b7ece248a37b9e5cca4960
Reviewed-on: https://gerrit.libreoffice.org/55121
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This way it's easy to copy-paste the problematic command
for further investigation of IWYUs proposals
Change-Id: I9e7403f0f05e64e562441941f00127a62bf15265
Reviewed-on: https://gerrit.libreoffice.org/54560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
... so add it to whitelists.
Change-Id: Ia9f55ecfa9dcbc809827070e0ae6522f1e7ba2bf
Reviewed-on: https://gerrit.libreoffice.org/54607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Moves all platform specific code from CommonSalLayout into the
platform specific plugins. This way the vcl library won't depend
on the Qt5 libraries and the Qt5Font header can be moved into the
qt5 VCL plugin.
While at it, switch the CommonSalLayouts font reference from the
FontSelectPattern to the LogicalFontInstance and also add the
harfbuzz font handling to the instance.
Change-Id: Ida910b8d88837ea949a2f84394ccc0cfae153060
Reviewed-on: https://gerrit.libreoffice.org/47408
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
|
|
It turns out that VS IDE's "Peek definition" (and other functions that
navigate to sources) fail if the short ("DOS") path to the file is given
in project's includes: see issue at
https://developercommunity.visualstudio.com/content/problem/139659/vc-peek-definition-fails-to-navigate-to-windows-ki.html
This patch converts the include paths to full Windows paths, to avoid the
problem. Also, since IDE starts working correctly with this change, this
patch removes inclusion of "inherited" paths "$(IncludePath)", which are
the paths added by Visual Studio itself. Since we do specify all include
paths explicitly, that is not required, and avoids confusion.
Change-Id: Ide2d948f8c7b050b02f550342144fede4fcafb82
Reviewed-on: https://gerrit.libreoffice.org/53731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Makes completely no sense, the for already gives us the "broken" arguments
This reverts commit e0201bbb7f4e05bf3a4273eca6129e88a4d246f8.
|
|
as we have files with spaces now. E.g.
grep: /data/rene/git/LibreOffice/master/debian/tmp/usr/lib/libreoffice/help/media/icon-themes/svx/res/symphony/enlarge: No such file or directory
grep: font.png: No such file or directory
happens otherwise.
Change-Id: I13f8cab2aac751f7a0c2f673b5e958ed08657d52
|
|
Also check for not needed forward declarations.
Change-Id: I92759f3f40d9458fd192665b39b87a78d8b97e5a
Reviewed-on: https://gerrit.libreoffice.org/53418
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I9ff961e9d6558478e72098a74048a5957299a953
Reviewed-on: https://gerrit.libreoffice.org/52547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
This updates the gla11y tool
- mnemonic-widget is actually an alias for mnemonic_widget
- ditto for tooltip-text vs tooltip_text
- ditto for placeholder-text vs placeholder_text
- glade introduced a notation for specifying the role of a widget, which can
be used to make a label static for instance (thus not orphan).
- --help is fixed to use the standard formatting.
- Remove the documentation of unexisting -i option
- Add the documentation of -P option
- Add --help/-h and --version options for completeness.
Change-Id: I8510ba9c5a877c05edd3af305b4e7fe1f105acd5
Reviewed-on: https://gerrit.libreoffice.org/52973
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429
Reviewed-on: https://gerrit.libreoffice.org/52847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0ed97515a03a5633628a492ec7797fc3ade8a3d8
Reviewed-on: https://gerrit.libreoffice.org/52846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|