Age | Commit message (Collapse) | Author |
|
Change-Id: I49ef02102620d6f455758a136d980b2c39b076df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117910
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
also fix the file filtering in case directories are passed for recursive
traversal (pdb files are not created in instdir, so that never really
matched our build-env)
Pass a directory to the invocation to make use of that filtering, and
also add a retry in case dump_syms segfaults during processing
(see also 73299faa75a4974eb49c93ffdfb2d6329cb4e519)
Change-Id: I8989c3fd72de0b18eecce490fac81db956f87515
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117386
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: I8a17c36489946327113e63f80b952525ae4201a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117377
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I68629d4350c43c80fdd00f9fcb8af3733753fe43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117327
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
which is the spacing between expander indicator and expander label
Change-Id: Ib840cec6744bd7f0714d38b8296d2f17dc9a916d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117199
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
these are all fat fingered in somehow or another
Change-Id: I0864a5622a244d5e60b368ddc425fc5a9b019060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117176
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
make group leader (the one without a group set) always
active and make the group followers always not active
Change-Id: I8a9ec45e93bf0786ab2895278521027b428c8403
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117143
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
After upgrading to Ubuntu 20.04 I got this warning:
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
Change f-u-i per instructions on website above to fix this warning.
Change-Id: I4424b0ced49d81dceb33131e1df150387a89df4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116748
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
so there is either a standard indicator shown or one of a small subset
of named icons
a) adds an indicator to show the MenuButton provides a dropdown to the
spelling dialog when there are multiple user dictionaries the word could
be added to
b) use open-menu-symbolic instead of gear icon for the sidebar menu
Change-Id: If4f0842fb0f805dde45e375061f23d2aaea0990c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116757
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This may fix https://github.com/google/oss-fuzz/issues/5855
A similar recent fix was https://github.com/google/oss-fuzz/pull/5858
It is assumed that the oss-fuzz builder HDD is too slow, leading to a
timeout. Fix that by breaking the bash wildcard expansion into a for
loop.
I did not test this change.
Change-Id: I3db367d604c46b3d15c91f530fb103ca005b0bc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116642
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ife68cef7eeab0010c4d233c81e3bee808c2c1c28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116615
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iabbde5976380c9e39590ad25ed4359f21290485b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116494
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
but we have some uses of it, which all look accidental
Change-Id: Iccb12d904e8dc7410205735e49526b73bb81083e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116488
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2baa9e9334850cf72e8ea1e96a2177a1c052e589
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115868
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1608e03ff9f6fbc55987010e88897e034b690b3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I14b2c27a99e76b1141c7a7bd3d0edaf57737bee2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115544
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1cc0fd704be075a7c387363a49bd84b159831aca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115493
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5fc789258e605b2d74c6697dedd824d722ad53bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115217
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I44df06ab4bad1a5e0aaf5409590f5d7869f33482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114937
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
This will prevent bugs like tdf#141902 to happen
Change-Id: If81164c704ec17d3fee044aaa0ec9c16d474009e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114705
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Updated README.md contents to fix various issues
* Fixed source links by using [git:], processed by mkdocs scripts
* Added README.md for ios, setup_native, unotest
* Fixed issues with "underline" and "less than" sign
Change-Id: I3e52a1d3372586c390ee6c42a2ef48bbabc81398
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114248
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The m91 snapshot seems to cause a number of Vulkan problems.
My commit already worked around one, but there are apparently
others, such as very slow startup, or a failed Skia assertion
triggered by VCL Skia's copyArea().
This reverts commit 09d850e46903a528d4b08d3fdf03c3964d79fbc5.
Change-Id: I4f1832ba76db15cab8eccbe115d21c989da3c841
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114089
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I82050e9695b9aa49c33ee16d345bb64595b00bbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113978
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I4fe5ec4a05d841c1c3486d2f80e7220dc0a99c80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113892
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I734ac1832bafe0f4e5710b9b27bd03833179e2d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113800
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Headers are allowed to have one #if block that is not ignored,
on the assumption that it is the include guard. This shouldn't
be the case if the header uses #pragma once, obviously.
Change-Id: Ib0aa0933ce224ca4e3ecf209593852da0f4ca5ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113799
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The script depends also on generated sources in workdir, which
it may fail to find if they haven't been built before running
the script. Prefer to fail on errors rather than ignoring them.
Note that when using builddir != srcdir, the script requires
$WORKDIR to be set (done e.g. by the recommended
'make cmd cmd="./bin/update_pch.sh [..]"').
Change-Id: I93429c133bd0876730a850d944707880848201f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113798
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Previously, all of the README files have been renamed to README.md
and now, the contents of these files were changed to use Markdown
format. Other than format inconsistency, some README.md files lacked
information about modules, or were out of date. By using LibreOffice
/ OpenOffice wiki and other documentation websites, these files were
updated. Now every README.md file has a title, and some description.
The top-level README.md file is changed to add links to the modules.
The result of processing the Markdown format README.md files can be
seen at: https://docs.libreoffice.org/
Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Renaming all README files for all top level modules to README.md,
applying no content change at this stage to be able to track history
of the files. These files should be edited to use correct Markdown
syntax later.
Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
By convention, it should be the first include in C/CXX files;
so use of pch should not break that.
Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Including chrome/m89, which wasn't included before because of
tdf#140023.
Change-Id: I64f1de8e10eab2d92a9383ce8104be5afca40101
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111792
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
With the previous modifications to Qt Creator IDE integration,
this makes 'make qtcreator-ide-integration' work when run from
a separate build dir, and allows to use multiple build dirs for
the same source dir in parallel, each with its own set of
Qt Creator files referring to the specific build in their
build and run settings.
Change-Id: I5d85d0d280be5e5edca15760bcccfc793e1e4b2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111553
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
... as a preparation to make this work
for the srcdir != builddir case as well.
Change-Id: I87507b9866f97cdbdf848c6b187b3b8f17262b6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111552
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Create a new method 'get_file_path' which basically
does what 'get_header_extension' and 'get_source_extension'
did, but already concatenates the extension to the
input; call that one and rename other methods accordingly.
While at it, let 'get_source_extension' search for files
in srcdir instead of builddir, as another step in making
generation of qtcreator-ide-integration work properly for
the case where srcdir != builddir.
Change-Id: I1e34bfdb726192b4af21e9003205fa551545ae31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111551
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
They are overwritten when written with the new content
anyway, since opened with file mode 'w+', i.e. they're
truncated first.
This also simplifies handling the case where srcdir != builddir,
for which support will be added in a subsequent step.
Change-Id: I1dd3386cdf0b97a6299357d6c12ed2d7b6365eae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111550
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I2fe51ab0cdfca5c94bd520ed7f9096bc7c8f6fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111549
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
The variable is used outside of the try block
further down. While that works with how Python handles
variable scopes (and there is no exception before the
assignment happens), moving the variable outside makes
the context/scope clearer.
Change-Id: Iecfd0477ffb4515cf58736ee138fc8ca7273967f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111548
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
This makes bin/unpack-sources work on systems that do not have
GNU coreutils in PATH, such as macOS.
Change-Id: I54ed219eedf0f45c039edb6e486f3afe273dd51f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107936
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Generating *.pro.user files is not ideal; they're
supposed to hold user-specific settings for a project,
and thus also to persist manual changes made by the user
after initial import of the project.
Generate *.pro.shared files instead which are
meant to be used to share project settings. [1]
This just changes the file name of the generated
file for now, but leaves the content the same.
The result for the initial loading of the project from
a '*.pro' file is basically still the same from a user
perspective:
A new kit 'Replacement for "Desktop"' is generated on
the fly which contains the build and run settings
specified in the corresponding '*.pro.shared' file.
By using the '*.pro.shared' files, user-specific settings
made after initial import will no longer
be overwritten by running 'make qtcreator-ide-integration'
again, since the '*.pro.user' files are left as they are.
The '*.pro.shared' files generated here still contain
information specific to the local setup (like file paths).
For some more background on LO's Qt Creator IDE integration,
s. dev mailing list thread "Added some information about
Qt Creator IDE integration to the wiki" [2].
[1] https://doc.qt.io/qtcreator/creator-sharing-project-settings.html
[2] https://lists.freedesktop.org/archives/libreoffice/2021-February/thread.html#86800
Change-Id: Ia187bcbffe5297a1cdf6bfeaaabf7867003195e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111474
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
At least with current Qt Creator 4.14, no proper
names were shown for the build configurations in
the project's "Build" settings, but just integers.
Using the config key 'ProjectExplorer.ProjectConfiguration.DisplayName'
instead of 'ProjectExplorer.ProjectConfiguration.DefaultDisplayName'
in the *.user.pro file makes this work as intended, and "01-Global Build"
(and others) shows up as the name for the top-level 'lo.pro' project
and "1-Build vcl" for 'vcl.pro', etc.
Along with the two previous qtcreator-related commits,
this should generally (re)implement an easy way to
run unit tests etc. directly from the Qt Creator IDE
without having to set that up manually, which cloph
mentioned as missing in his FOSDEM talk today
("Using IDEs for LibreOffice development", [1]).
To use this, select the corresponding build configuration
by clicking on the "screen" icon on the bottom left,
then build the project (Ctrl+B or left-click on the
"hammer" icon on the bottom left).
I didn't check whether the single targets are still up
to date.
[1] https://fosdem.org/2021/schedule/event/lo_ideforlodevelopment/
Change-Id: I9965829db319a8b26f5ad82d3ffa723a28da7910
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110536
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I104fe6b7d82f224c340fcd95e3ffe52d7397919f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110540
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Fix indentation and drop some extra empty lines that are
automatically removed once the project is loaded in
Qt Creator and then closed anyway.
This will make it a little easier to compare what the initially
generated file looks like compared to the one as it is written
after (implicitly or explicitly) carrying out the configuration
in Qt Creator after loading the project.
Change-Id: I52173162efe635e6fb3e7f889c42ed67271c05b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110535
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Use the 'lib' instead of the 'app' template for the
qmake files in the subdirectories, which avoids
automatically creating a useless run configuration
for each subdirectory pointing to a non-existent
execuatable, like '<BUILDDIR>/accessibility/accessibility'
etc.
With this in place, I just get a single "Custom Executable"
run configuration running 'instdir/program/soffice.bin'
when opening the newly generated 'lo.pro' in Qt Creator 4.14.
Change-Id: I69a7f1b56b02849b217bf66f110d9ee1f61125ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110534
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
to ignore open bugs or performance issues
Change-Id: Id43ef8bae4936213a65fded3ce138bbf43de397e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110420
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Use findall since there might be more than 1 bugId in the summary
* put everything from 'source/core/' in others
Change-Id: I7d8d6e28f06a97415378c3d235b617ebc7441fbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110072
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
update the script to use python3, and run it
Change-Id: I9c2a86e1f7a2eb889dcf214f2a2f6a31ceb1f59e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109710
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
the gtk default is left aligned, change the vcl one to match and drop
the deprecated and unnecessary [x|y]align
Unfortunately on load glade's inline preview shows centered alignment, though
its "true" preview tool shows left alignment and unsetting and resetting
draw-indicator will update the preview to show the alignment which will
be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502
See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my
stab at making glade do the right thing.
Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie85ea2b8a2620d0a62f39b39ebbb2ac41ab85d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109756
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
And fix bin/find-unneeded-includes to not report noise on
PDFiumLibrary.cxx.
Change-Id: I93337e49a5656349089bdb790876bebe8505082c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109656
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I9be83856c0dd15552a042f009464c279bf239848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|