Age | Commit message (Collapse) | Author |
|
..and replace with debug header if multimap is used.
As seen in include/svx/SmartTagMgr.hxx
Change-Id: If239cd6e9471f74f3035c659077ed7515a9df473
Reviewed-on: https://gerrit.libreoffice.org/73367
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I786001d66e9b40df5c30e19ff2381c9ed6c7db94
|
|
Removal of those have to be decided manually:
1) If it would be removed to be replaced with an include, that's bad.
2) If the fwd decls is truly unused, that's good.
Focus on the mechanical part: removal of includes which are unused, and
where removal doesn't introduce a transitive dependency.
Verified that e.g. writerfilter/source/dmapper/DomainMapper.cxx reports
no removals now, but including e.g. filter/msfilter/rtfutil.hxx in
either writerfilter/source/dmapper/DomainMapper.cxx or
writerfilter/source/dmapper/DomainMapper.hxx triggers a removal hint.
Change-Id: I4c359318113ccba421a125984e23c9778567ea4e
Reviewed-on: https://gerrit.libreoffice.org/73240
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Verified that e.g. writerfilter/source/dmapper/DomainMapper.cxx used to
trigger advices to replace includes with forward-declarations, and now
that's gone.
See https://gerrit.libreoffice.org/#/c/72972/ for motivation, there are
cases where a forward-declaration depends on the version of the
external, while the include does not, so such changes have to be done
with more care.
Change-Id: I86d396ac743b3fc425868ffda26c0c9e85a00d0e
Reviewed-on: https://gerrit.libreoffice.org/73221
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ibf6c181ecfb219ba5d142236471af03f8d3b32c6
Reviewed-on: https://gerrit.libreoffice.org/73072
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
It's ridiculously un-cooperative, and if you accidentally run the script
from a static IP you won't be able to look at that bugzilla for a while,
which is tragic because it holds important historical info hostage.
Change-Id: I55887baceac82ad0a3bcedc3de9c9b3d0e02f9c3
Reviewed-on: https://gerrit.libreoffice.org/72220
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I02127cd8a023e87482eff4071eb81b30f39870fd
Reviewed-on: https://gerrit.libreoffice.org/72526
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ib0676472e5fe2b2f789dba62e9e1d985adb3ed23
Reviewed-on: https://gerrit.libreoffice.org/72525
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I9f86a6268c98a010585bd666e1ede66869c5d7ea
Reviewed-on: https://gerrit.libreoffice.org/72523
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
It's an external library, but it's a large C++ lib and it's built
using gbuild, so this helps too. Here with Clang it cuts build
time from ~2:40 to ~1:25 (and about halves the CPU user time).
Hopefully it also helps to reduce the build time for Windows gerrit builds.
Change-Id: Ieef0ea28e0fe1fd216592fca70410075d95ddc54
Reviewed-on: https://gerrit.libreoffice.org/72517
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I65b3461fd227e7e997b82a84631bbd5d00b28eb6
Reviewed-on: https://gerrit.libreoffice.org/72520
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
and remove corresponding suppressions.
Change-Id: I0dd88082ee0af4c5ee82590e894305fa53574c6b
Reviewed-on: https://gerrit.libreoffice.org/72133
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
This URL results in an error message and 0 results because "Changed" in
the UI translates to "delta_ts", not "changed" apparently.
Change-Id: I2bfdd682bb7fca229039970c209e7e409532059c
Reviewed-on: https://gerrit.libreoffice.org/72219
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I9c7f7d2f266950fac683bf5148dec741d7652585
Reviewed-on: https://gerrit.libreoffice.org/72194
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I3417f80621584553041eeb504d35cb4241a19b61
Reviewed-on: https://gerrit.libreoffice.org/72203
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
It's in GSTREAMER_1_0_LIBS on Fedora 30.
Change-Id: I0a9e5a53ee1bbd4ac4109ccbdbbd94b909b62118
Reviewed-on: https://gerrit.libreoffice.org/72174
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
As seen in tools/source/misc/cpuid.cxx
Change-Id: Ic596cca387efc1c310f65cbed141946be0742371
Reviewed-on: https://gerrit.libreoffice.org/71885
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
As seen in configmgr/source/modifications.hxx and
configmgr/source/partial.hxx
this replacement is not needed
Change-Id: I6a8d7bc37779f305fccb5d3c7df22fba4a4f73d0
Reviewed-on: https://gerrit.libreoffice.org/72013
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
There are now 4 levels of PCH support, the previous 'full' level
adding to PCH whatever the update_pch script finds useful,
and new levels 'system', which adds only external headers,
'base', which is 'system' and LO basic headers (sal, osl, rtl, vcl)
and 'normal', which is 'full' without headers from the module
built itself.
With Clang/GCC even 'system' still saves some time (10-15%) and since external
headers should rarely if even change, it should be without most
of the disadvantages of PCH. And even 'base' should be pretty easy
to use, as those headers should be rarely changed while developing,
thus avoiding the need for massive rebuilds. Using 'normal' or 'full'
does not seem to be worth it with Clang or GCC, but with MSVC that still
makes a difference, so keep(?) 'full' the default there.
The update_pch script unfortunately does not include as many system
headers as it could, since it includes only what is directly included
by the .cxx, but not what's included indirectly by .hxx files.
https://lists.freedesktop.org/archives/libreoffice/2019-May/082685.html
Change-Id: If83a07a1fc9b77d0134502b0d89348944f82806b
Reviewed-on: https://gerrit.libreoffice.org/71580
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
config_xxx.h headers are not system headers, and some module headers
as such helpids.h or scdllapi.h are neither.
Change-Id: I7ae1a3f1ada43de88eefe34c60e19f7ac703769d
Reviewed-on: https://gerrit.libreoffice.org/71579
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
As seen in sw/source/core/inc/layact.hxx
Change-Id: Icc4281cd57b0cd8310a1044f6106691a5d1cd3c4
Reviewed-on: https://gerrit.libreoffice.org/71884
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I059393357c3b0d91e30c16df066fb6dd8ba28ab9
|
|
As seen in tools/source/inet/inetmime.cxx
Change-Id: I3122e07a01020e84b5b75bc46dcaca33560b84bb
Reviewed-on: https://gerrit.libreoffice.org/71558
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I098e894d80c2b319307bf9e9eece7a59d2ff0bd0
Reviewed-on: https://gerrit.libreoffice.org/71810
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: Ic4d2538f15d6246d81fabe8347a8be157b69deb3
Reviewed-on: https://gerrit.libreoffice.org/70979
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia0dd6a96a039056f15e494baf844e11fb9b5e9aa
Reviewed-on: https://gerrit.libreoffice.org/70488
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
So it gives no false positives as currently seen in e.g.
include/sfx2/charmapcontrol.hxx
include/sfx2/docinsert.hxx
Change-Id: I087a949875df20c4ef25a10c80571bb57334cf80
Reviewed-on: https://gerrit.libreoffice.org/70400
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Sometimes, developers mention other bugs in the body as
related issues.
This might create mislead information in the release notes
E.g: https://wiki.documentfoundation.org/Releases/6.1.1/RC1
* Caolán is mentioned as fixer of i#66963 because the id is in
the body of 9c3d8b1c64c2ce5a2fd39aa785df45f6b1d6628b
which fixes tdf#98558
* M. Stahl is mentioned as fixer of tdf#112447 because the id is
in the body of 31e66bd07c1082bb375be8aaf7835f019351d9bb
This bug was fixed by Bjoern Michaelsen in
ce2fce9a41729774689080c8b5552b60c2e6ee2d
Change-Id: I8d0ee038741dbb27364a56a7fa9285f32839c37b
Reviewed-on: https://gerrit.libreoffice.org/69750
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: I58c1158dbd96ace17666177ef9b2d9f19309a2d6
Reviewed-on: https://gerrit.libreoffice.org/70228
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
As seen in include/sfx2/sidebar/Paint.hxx
this replacement is not needed
Change-Id: Idba8014a7effaec69c06891657cbd62546b7ac09
Reviewed-on: https://gerrit.libreoffice.org/70026
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Turns out plain dictionary requires keys to be unique.
So we need to store values as lists.
This way there are no more false positives for <set> as in
include/sfx2/linkmgr.hxx and include/sfx2/objsh.hxx
Thanks Miklos for the advice!
Change-Id: Ie2cfb63644d6cbd51171eb95e3bcdd9246343efa
Reviewed-on: https://gerrit.libreoffice.org/69953
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Previously this script did not find the untranslated liststore items
that tdf#124240 is about
Change-Id: Ie46d99d246eee316fdda95bdf2d1d3a9aacbc907
Reviewed-on: https://gerrit.libreoffice.org/69596
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
As seen in include/sfx2/dispatch.hxx IWYU proposes to replace
o3tl/span.hxx with fw declaration, but that won't compile
Change-Id: If5739075bd91511cf22a39f3382c424c21829053
Reviewed-on: https://gerrit.libreoffice.org/69397
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
As seen while cleaning sd/source/ui/dlg/TemplateScanner.cxx
Change-Id: I31a6892b4419947a411b2c4100281d4cf7c50f09
Reviewed-on: https://gerrit.libreoffice.org/68969
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Icd9f7ebab89d6c2b166b6f42fd7682e89127fd51
Reviewed-on: https://gerrit.libreoffice.org/68903
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Adding AdditionalOptions to nmake project settings allows IntelliSense
to know about used compiler switches; specifically, passing std switch
(currently -std:c++17) defines _MSVC_LANG macro [1] to proper value to
avoid false IntelliSense errors (e.g., for string_view).
[1] https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
Change-Id: I90309e6bf2a87257a0c81b1406e678af962eb587
Reviewed-on: https://gerrit.libreoffice.org/67805
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
As proposed in https://gerrit.libreoffice.org/#/c/67473/
Change-Id: Ibbc2d32dde2363502915cfeb036fa6f4ba568932
Reviewed-on: https://gerrit.libreoffice.org/67574
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I01f5a09e65091f460c28f6c18d683f5a3135762e
Reviewed-on: https://gerrit.libreoffice.org/67100
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If76e1acdcb601d70c956bcaf0392046430f4853e
Reviewed-on: https://gerrit.libreoffice.org/67086
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie64a300a73db666231ae7b37f15e5d7556e594bc
Reviewed-on: https://gerrit.libreoffice.org/67039
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I372918497b91bd2da0432df7b27795cbf29dc6b8
Reviewed-on: https://gerrit.libreoffice.org/66982
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I70613baada4f82e5e56f9a21547733c3a6907b53
Reviewed-on: https://gerrit.libreoffice.org/66908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
As seen while analysing
sw/source/core/inc/DocumentChartDataProviderManager.hxx
replacing o3tl/deleter.hxx with fw declaration does not work,
it compiles only when it is transitively included.
This also removes mistakenly added fw declarations and
now unnecessary IwyuFilter blacklist items
Change-Id: I2d631f0693dbfd0bb0e62218a525113042c9a907
Reviewed-on: https://gerrit.libreoffice.org/66750
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Found while checking include/vcl/fontcapabilities.hxx
Change-Id: Ib598978672d08d3cae7bf6f96d1b874ca13fcb5f
Reviewed-on: https://gerrit.libreoffice.org/66254
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Found while cleaning sd/source/ui/sidebar/PageMarginUtils.hxx
Change-Id: Iccbd45d9c53dd6561a6161f9949d6fb9d8539514
Reviewed-on: https://gerrit.libreoffice.org/65923
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I2b0be9bf13cb3feedecbe22c5c844d9328013b3a
|
|
Change-Id: I2bb8daba6878432c002471bdfa33652147c3b6f9
Reviewed-on: https://gerrit.libreoffice.org/65602
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Just merges some common code into setdefaults.
Change-Id: I2ba2c06425bcfe569fa147af713a064a145a2018
Reviewed-on: https://gerrit.libreoffice.org/65367
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
KDE4 is out of maintenance upstream since Nov. 2014, and binaries
provided by TDF have switched to KDE5 as the official backend.
Change-Id: I165465b56d3ba3a18912b203c06ae8fc6111c0c9
Reviewed-on: https://gerrit.libreoffice.org/60014
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Take system includes ('-isystem') into account
when generating the '*.pro' files for Qt Creator
using the 'qtcreator-ide-integration' make target.
Without this, Qt Creator is unable to find the
corresponding included files.
This also makes Qt Creator's ClangCodeModel
able to properly process files and display
actual problems, rather than always showing
a multitude of errors due to missing includes
while parsing the source/header files.
Change-Id: Ie513341e1074ceab9304ae9df73fac9a79329db8
Reviewed-on: https://gerrit.libreoffice.org/65129
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|