Age | Commit message (Collapse) | Author |
|
Change-Id: I2ed73a296b813de722156c69ac64cf9d6cff199d
Reviewed-on: https://gerrit.libreoffice.org/55197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>
|
|
Change-Id: I4bbea7e1af34bd5c30e3830ecb58af2b6a3a09d4
|
|
Change-Id: Ic2e6138b1ba1a8031a80e4e58f468b6c0f7a4de3
|
|
Change-Id: I51daa79f3f2772d054b7ece248a37b9e5cca4960
Reviewed-on: https://gerrit.libreoffice.org/55121
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This way it's easy to copy-paste the problematic command
for further investigation of IWYUs proposals
Change-Id: I9e7403f0f05e64e562441941f00127a62bf15265
Reviewed-on: https://gerrit.libreoffice.org/54560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
... so add it to whitelists.
Change-Id: Ia9f55ecfa9dcbc809827070e0ae6522f1e7ba2bf
Reviewed-on: https://gerrit.libreoffice.org/54607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Moves all platform specific code from CommonSalLayout into the
platform specific plugins. This way the vcl library won't depend
on the Qt5 libraries and the Qt5Font header can be moved into the
qt5 VCL plugin.
While at it, switch the CommonSalLayouts font reference from the
FontSelectPattern to the LogicalFontInstance and also add the
harfbuzz font handling to the instance.
Change-Id: Ida910b8d88837ea949a2f84394ccc0cfae153060
Reviewed-on: https://gerrit.libreoffice.org/47408
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
|
|
It turns out that VS IDE's "Peek definition" (and other functions that
navigate to sources) fail if the short ("DOS") path to the file is given
in project's includes: see issue at
https://developercommunity.visualstudio.com/content/problem/139659/vc-peek-definition-fails-to-navigate-to-windows-ki.html
This patch converts the include paths to full Windows paths, to avoid the
problem. Also, since IDE starts working correctly with this change, this
patch removes inclusion of "inherited" paths "$(IncludePath)", which are
the paths added by Visual Studio itself. Since we do specify all include
paths explicitly, that is not required, and avoids confusion.
Change-Id: Ide2d948f8c7b050b02f550342144fede4fcafb82
Reviewed-on: https://gerrit.libreoffice.org/53731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Makes completely no sense, the for already gives us the "broken" arguments
This reverts commit e0201bbb7f4e05bf3a4273eca6129e88a4d246f8.
|
|
as we have files with spaces now. E.g.
grep: /data/rene/git/LibreOffice/master/debian/tmp/usr/lib/libreoffice/help/media/icon-themes/svx/res/symphony/enlarge: No such file or directory
grep: font.png: No such file or directory
happens otherwise.
Change-Id: I13f8cab2aac751f7a0c2f673b5e958ed08657d52
|
|
Also check for not needed forward declarations.
Change-Id: I92759f3f40d9458fd192665b39b87a78d8b97e5a
Reviewed-on: https://gerrit.libreoffice.org/53418
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I9ff961e9d6558478e72098a74048a5957299a953
Reviewed-on: https://gerrit.libreoffice.org/52547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
This updates the gla11y tool
- mnemonic-widget is actually an alias for mnemonic_widget
- ditto for tooltip-text vs tooltip_text
- ditto for placeholder-text vs placeholder_text
- glade introduced a notation for specifying the role of a widget, which can
be used to make a label static for instance (thus not orphan).
- --help is fixed to use the standard formatting.
- Remove the documentation of unexisting -i option
- Add the documentation of -P option
- Add --help/-h and --version options for completeness.
Change-Id: I8510ba9c5a877c05edd3af305b4e7fe1f105acd5
Reviewed-on: https://gerrit.libreoffice.org/52973
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429
Reviewed-on: https://gerrit.libreoffice.org/52847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0ed97515a03a5633628a492ec7797fc3ade8a3d8
Reviewed-on: https://gerrit.libreoffice.org/52846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
I've used this script in the recent past to fix warnings in mostly
sw/inc/*.hxx. Hopefully sharing it creates interest for others to do
similar fixes in other modules.
Change-Id: I4c8b6a1e92b006d4fd56b403a25715f11964d639
Reviewed-on: https://gerrit.libreoffice.org/52289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I534a01d9cd8e507b8b277eb185dc96bcd9bd63fe
|
|
now that its a 32bit int, which isn't very helpful for me, too much
of a firehose right now
Change-Id: I15e96065c2e21afc632bd22c95cfb975c0f839ac
|
|
Change-Id: Ie5c6a26a2382f18690668bb1883926d44c07a57a
Reviewed-on: https://gerrit.libreoffice.org/52321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I62c24f0aa20dea1cca4ba77a71dbb247bc37a5b5
Reviewed-on: https://gerrit.libreoffice.org/51545
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
This updates gla11y with all heuristics to detect orphan labels and widgets
without too many false positives.
This updates gbuild to tell gla11y to only emit errors about undefined
targets and about orphan warnings for GtkScale (as was the case with
previous versions). More errors and warnings will be enabled progressively
later on.
Change-Id: I96580eb0eb8eb327f0f54563d7976a5148e9531a
Reviewed-on: https://gerrit.libreoffice.org/51161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Avoids VS warnings:
> smoketest\Library_smoketest.vcxproj.filters : warning : Unable to
> read the filters file "Library_smoketest.vcxproj.filters". Please
> unload the project "Library_smoketest.vcxproj" to be able to edit it.
> The required attribute "Include" is empty or missing from the element
> <Filter>.
Change-Id: I0f02e837823a5e7a0355fd0f895f00c63a5df6fc
Reviewed-on: https://gerrit.libreoffice.org/51684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
In other external projects using libtool, we fix that by patching configure,
resetting hardcode_libdir_flag_spec[_CXX] at the end of the linux*) case block
that sets the Linux-specific value. But here we run autoreconf in
ExternalProject_libassuan, so that patch in configure would be overwritten. The
relevant code in configure comes from autoconf boilerplate, so we cannot just do
the same patch in configure.ac. But we can reset hardcode_libdir_flag_spec
sufficiently late in configure.ac so that things still work as intended.
Disable tests that would build executabes linking against libgpgme.so, which in
turn links against the libassuan and libgpg-error libs, which would no longer be
found by the linker because of the dropped -rpath flags. (Alternatives might
be to pass in LD_LIBRARY_PATH or to link with --allow-shlib-undefined.)
Change-Id: I7e37abf802d213347bd80383b7980d85cf0762d4
Reviewed-on: https://gerrit.libreoffice.org/50960
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
In other external projects using libtool, we fix that by patching configure,
resetting hardcode_libdir_flag_spec[_CXX] at the end of the linux*) case block
that sets the Linux-specific value. But here we run autoreconf in
ExternalProject_libassuan, so that patch in configure would be overwritten. The
relevant code in configure comes from autoconf boilerplate, so we cannot just do
the same patch in configure.ac. But we can reset hardcode_libdir_flag_spec
sufficiently late in configure.ac so that things still work as intended.
Change-Id: Ic6c6123bcfe8bc2dac87812f919842519374abaa
Reviewed-on: https://gerrit.libreoffice.org/50959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
python2.6's internal xml parser is not enough for gla11y, but it can run
python-lxml fine.
Change-Id: I725471729c8e2f25ce60f1d92e08d87a96e171a5
Reviewed-on: https://gerrit.libreoffice.org/50686
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Things got massively worse with
f927fc06b8160c6db134b29dab510e2cd567e3f3 so disable for the moment
Change-Id: Ie8a03aa42d5c29bc6931c9c621d1b0427eeddab8
|
|
We need to pass the absolute path to gla11y for build outside source to
work. We however do not want to expose absolute paths in suppression files,
so we have to introduce a parameter that provides the common prefix to be
stripped.
Change-Id: Iaf652cb8d6c3646438f828a0949dfd811f964e77
Reviewed-on: https://gerrit.libreoffice.org/50568
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
|
|
Also add an accessibility test which does have a few existing issues, and
the corresponding suppression lines.
Change-Id: I7095cdc13e40501bbdf6e635c1e4f93f70bc1316
Reviewed-on: https://gerrit.libreoffice.org/50251
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
except on windows, where gla11y will resort to python's internal xml parser,
which does not provide line numbers.
This allows gla11y to be runnable on all systems.
Change-Id: Ica4eb90f59bddfcefd783fc2ed9c8c27357e7572
Reviewed-on: https://gerrit.libreoffice.org/50115
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ifcfb8ed6783f7d022e7c7f139e3f3bafa7b4b71a
Reviewed-on: https://gerrit.libreoffice.org/50088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
instead of copying the whole bunch around, now the scheme is to copy
each individual fuzzer and matching config around, so duplicate the
previously shared config for each one an
Change-Id: I479ea13abfab382b6aee23bc04d5f7e535b489c9
|
|
Change-Id: Iabefbc3873b45f58fb8e493d043b0e08a3f425f9
|
|
Change-Id: I413b01e93000f9f81ba6190811cea51c04f1d58b
|
|
This avoids build failures when a directory uses UIConfig but does not add
any ui file.
Change-Id: I63413f87fc5515ffb9e3dd9baf25c6a4ba70c2be
Reviewed-on: https://gerrit.libreoffice.org/50071
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
This is part of integrating an accessibility non-regression tool. This
adds checks in configure.ac for the presence of python lxml which we will
need, and adds support for calling the tool at build time, to check for
definite UI errors. For now, that only emits errors for missing or duplicate
accessibility relation targets, and senseless relations: a label being
mnemonic for several widgets.
Change-Id: Idda91b15b9a9e0322d16db33dfac8e03f2aa518c
Reviewed-on: https://gerrit.libreoffice.org/49856
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I219d556f8e124cfe426cc1ac3c54da34eb7ef790
Reviewed-on: https://gerrit.libreoffice.org/49925
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
That little amount of code hardly justifies a separate library.
Change-Id: Idbb039f38258bc12759fcf6d29328e1afe7443ab
Reviewed-on: https://gerrit.libreoffice.org/49391
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Iaa48657cdffc12b0e7bf1e39476e84445ea6fc3b
Reviewed-on: https://gerrit.libreoffice.org/49353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ie8c2389e8e0801b092abcfef751325cdf369b98d
|
|
The dependency of Library_vcl on qt5 libraries (via vcl/qt5/Qt5Font.cxx) is
there ever since b66a7cbd8491fe436126e11975c360f47ae346ed "QT5 first stab on
implementing CommonSalLayout", but no idea whether that is by design or is a
hack that should eventually be cleaned up.
Change-Id: I4cec702709b37069987ec68c035628b5172b3543
|
|
Change-Id: I345055bf56828fc597d14c654d4819e87630da2c
|
|
Change-Id: I7b0febee10a98809073f0bfd023d39d32684a566
|
|
Change-Id: Ibd308d94c7cd92ab5e2590554b54517d2ef898fe
|
|
...and apparently not supported on some tinderboxes like tb70 and tb71
Change-Id: I37dae3e7bbb0b9324adf04819fa87fb6a5b9f1d0
|
|
Change-Id: Ie08d3dfc6306c18da7b1a5c000a75a18917c1f70
Reviewed-on: https://gerrit.libreoffice.org/45529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
script for page https://wiki.documentfoundation.org/ListUiTests
Change-Id: I0081a4e1229105ef7387e70d76a5670a4f5de691
Reviewed-on: https://gerrit.libreoffice.org/47340
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I7a53859377e6228542be50fd26af6b0d6701384c
|
|
Change-Id: Iec0be65f57cac06756f2e8101d3edb89b126e92f
Reviewed-on: https://gerrit.libreoffice.org/48430
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
...reporting such delights as
> [CXX] sal/cppunittester/cppunittester.cxx
> In file included from workdir/UnpackedTarball/boost/boost/mpl/aux_/na_assert.hpp:23,
[...]
> from external/boost/include/boost/algorithm/string.hpp:25,
> from sal/cppunittester/cppunittester.cxx:60:
> workdir/UnpackedTarball/boost/boost/mpl/assert.hpp:188:21: error: unnecessary parentheses in declaration of ‘assert_arg’ [-Werror=parentheses]
> failed ************ (Pred::************
> ^
where boost/mpl/assert.hpp contains
> template< typename Pred >
> failed ************ (Pred::************
> assert_arg( void (*)(Pred), typename assert_arg_pred<Pred>::type )
> );
Change-Id: I6976b2cc23f1d309d27d3fde9098b10c9d877599
Reviewed-on: https://gerrit.libreoffice.org/48386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Iaad78e5f1100df1ca69d34bf7693e4a9feac17eb
Reviewed-on: https://gerrit.libreoffice.org/48084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|