summaryrefslogtreecommitdiff
path: root/canvas
AgeCommit message (Collapse)Author
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14loplugin:constantparamNoel Grandin
clean up the plugin a little, and try to catch params which are default constructed, which doesn't seem to be working yet Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12 Reviewed-on: https://gerrit.libreoffice.org/28861 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14tdf#88205 use list ctor for uno::Sequence a11y to canvasJochen Nitschke
Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18 Reviewed-on: https://gerrit.libreoffice.org/28866 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14loplugin:constantparam in chart2..connectivityNoel Grandin
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-24tdf#96505 get rid of long integer literals 'L'Asela Dasanayaka
Remove L from integer literals in module canvas all 0L, 1L, 2L , 7L and 8L Change-Id: Idd41a31857b4bb58ed8e7b6f4e727a73806098b1 Reviewed-on: https://gerrit.libreoffice.org/27817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2016-08-21Related: tdf#86473 git rid of special pixel snapping for rectanglesCaolán McNamara
Change-Id: Ia9ab5c58975df2de8c261d92a866cbe264d03205
2016-08-20Resolves: tdf#86473 approx 1 pixel high rectangular polygon not drawnCaolán McNamara
The other implementations of basically this in vcl/headless/svpgdi.cxx:AddPolygonToPath and vcl/quartz/salgdicommon.cxx:AddPolygonToPath hook this rounding foo off getAntiAliasB2DDraw FWIW Change-Id: Ideec049ec6ca04105721bf8acda44c31b2a73215
2016-08-05loplugin:countusersofdefaultparams in canvas,chart2Noel Grandin
Change-Id: Id66a706171b73affeb508812744028d9f30133af Reviewed-on: https://gerrit.libreoffice.org/27868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara
in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#100726: Improve readability of OUString concatenationnadith
this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-28tdf#101026 Create more correct replacement control vectorArmin Le Grand
Change-Id: I909adaab3dca3c1bac4331b164343cdbc1205df2 Reviewed-on: https://gerrit.libreoffice.org/27365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28update other places that read data from cairo image surfaceDavid Tardon
Change-Id: Icb8761e5ff89e1c0e0e034a751fe9a50ad5ab90a
2016-06-28Simplify some PutProperties callsStephan Bergmann
Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
2016-06-09tdf#96099 Remove various smart pointer typedefs in canvasMark Page
Change-Id: Ied6ec5f7830c53a339de985d173c1dec711ac8f7 Reviewed-on: https://gerrit.libreoffice.org/26092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-03Convert ComplexTextLayoutMode to scoped enumNoel Grandin
Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1 Reviewed-on: https://gerrit.libreoffice.org/25667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03loplugin:constantparamsNoel Grandin
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26canvas: error C2397: conversion from 'size_t' to 'BYTE' requires ...Michael Stahl
a narrowing conversion (at least other people's MSVC says so, mine doesn't complain) Change-Id: Ic87da76567778884b81361067075fd9325e2d276
2016-05-25canvas: replace BOOST_PP usageMichael Stahl
Change-Id: I46bb4aba6c08fb753b22242069ef0b00d4c77f12
2016-05-25Convert BMP_FORMAT to scoped enumNoel Grandin
Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19rename to two GetSystemData methods to find all call-sitesCaolán McNamara
anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13remove various crutches for boost::bind/boost::mem_fnMichael Stahl
These aren't used any more, and the C++11 std equivalents don't use get_pointer() overloads. Change-Id: Ib97a6a595863e21a1621c63709ea2b28f6550fde Reviewed-on: https://gerrit.libreoffice.org/24982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13convert EXCEPTION_ to scoped enumNoel Grandin
- simplify VCLExceptionSignal_impl - drop "minor" part of error code, nobody passes it in, and nobody checks it - rename Display to UserInterface, to prevent -Werror=shadow Change-Id: I503fd8a50ded30d59c30fb388796f6b1a0c058de Reviewed-on: https://gerrit.libreoffice.org/24892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26tdf#48066 render stroke-miterlimit correctly in SVG importRegina Henschel
The property stroke-miterlimit is transported to the renderers via a new member mfMiterMinimumAngle in class LineAttribute Several drawPolyLine methods are adapted. This patch does not include changes in MetaAction. Presentation mode, printing, and PDF-export is still wrong. Corrected LineJoinMiter to LineJoinBevel in canvas, that s closer to NONE. Removed DrawPolyLine method without MiterMinimumAngle and adapted calls accordingly. Change-Id: I6bcd24add5d85c4d9a39e3788e0682091c5fc9c4 Reviewed-on: https://gerrit.libreoffice.org/23946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2016-04-22Fix typosAndrea Gelmini
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Ie7f382fb47463d9bc315dc767c1d0550145ec935
2016-04-18- Removed the only-used-once FontLevelVector typedefRyan McCoskrie
Change-Id: I78bdd690cd80b7caee816b005790b0130dffefeb Reviewed-on: https://gerrit.libreoffice.org/24177 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#99165 initialize nLastX, nLastYArmin Le Grand
... even when inited in 1st loop run to avoid warning 'maybe-uninitialized' Change-Id: I67607767b8091d220efcf4c4ca70f570f955e297
2016-04-13loplugin:passstuffbyref in canvasNoel Grandin
Change-Id: Idde288ab4bb7935e5da2a84190fd4b398961d358
2016-04-13tdf#99165 always provide control points for beziersArmin Le Grand
Some graphic sub systems cannot handle cases where control points of bezier curves are not set and produce wrong geometry for fat line drawing when MITER or similar LineCap and/or LineJoin is used. To avoid that, provide the mathematically correct fallback control points instead. Change-Id: Iabc724e51fb89e702f858db820c920f7b5b7d302 Reviewed-on: https://gerrit.libreoffice.org/24031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-11fix copy assignment signaturesJochen Nitschke
get value by reference introduced in commit 8c2f2e1dd77cdce9bdf63beff5a79f91adc44630 and commit f9b200ce54cd67ddc04747f9676568a86e14d864 Change-Id: Iba84dd752f4cbdde9f3676c434d107efabe63a38 Reviewed-on: https://gerrit.libreoffice.org/23974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-07tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed the OSL_DEBUG_LEVEL > 1 conditionals with OSL_DEBUG_LEVEL > 0 or SAL_INFO macros Change-Id: Ia2a483ea0f992bf182a6beed2b4558a4fb7c5680 Reviewed-on: https://gerrit.libreoffice.org/23079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-07tdf#94306 replace boost::noncopyable in canvasJochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Some helper classes had boost/noncopyable.hpp included but didn't use it. Change-Id: I339f2c413a944649d9d63c046e8b7f7ee6e46791 Reviewed-on: https://gerrit.libreoffice.org/23866 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-25fix headless buildOliver Specht
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-03loplugin:unuseddefaultparams variousNoel Grandin
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546 Reviewed-on: https://gerrit.libreoffice.org/22852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-01-Werror,-WshadowStephan Bergmann
Change-Id: I007ea13a059d8b067e4819fb61f0ea2e15c638a5
2016-03-01-Werror,-Wnon-virtual-dtorStephan Bergmann
Change-Id: Ibeed52359852451b800e083ddc4c221dea41a294
2016-03-01-Werror,-Wunused-macrosStephan Bergmann
Change-Id: I0269ae5c13c75327648c0018007d78dbf37f1648
2016-02-25werror: declaration hides previous declarationDavid Ostrovsky
Change-Id: I0f8422a4f8c27ec253d917985d2593d8d87bb5f0 Reviewed-on: https://gerrit.libreoffice.org/22685 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-25werror: declaration hides previous declarationDavid Ostrovsky
Change-Id: Ia0fe8847f2a58fbccb25ecc6237f3b14a08da076 Reviewed-on: https://gerrit.libreoffice.org/22688 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-18 15:09:06 +0000