summaryrefslogtreecommitdiff
path: root/canvas
AgeCommit message (Collapse)Author
2015-11-20Adapt Windows-only codeStephan Bergmann
...to b8793748b0eaaa3fe405587fcb2a3021adab833b "Seems more natural to pass a homogenous list by initializer_list" Change-Id: I1c6816a442b57572a307251de1de5652a9d2a63a
2015-11-20loplugin:unusedfields in canvasNoel Grandin
Change-Id: Ic532ebf1f929044d72ee3abca29c8275cbe837ac Reviewed-on: https://gerrit.libreoffice.org/20078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-20Seems more natural to pass a homogenous list by initializer_listStephan Bergmann
...than by template parameter pack (even if that requires using ServiceDecl*, as initializer_list cannot take reference types) Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
2015-11-20loplugin:sallogareasStephan Bergmann
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-12Windows header sanitizationAshod Nakashian
Isolation of windows headers using prewin.h and postwin.h headers and making headers dependent on them more self contained. Conversion of TCHAR to WCHAR and LPCTSTR to LPCWSTR etc. and cleanup of unnecessary casts. Change-Id: I7eff5c477d9223a064bfb4d962ff6d61960ee69c Reviewed-on: https://gerrit.libreoffice.org/19901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-12Bin mesa_headers completelyTor Lillqvist
We don't need them in a MSVC or OS X compilation either. Change-Id: I00181fe0a047df09bbdfcce34c07eb2ebc45a2da
2015-11-12Avoid mesa_headers on X11, also link with -lGL only where necesssaryTor Lillqvist
The GLEW headers are enough, and what we actually use in these places. In addition to handling GL extension things in its dynamic fashion, GLEW headers also have declarations for standard, non-extension, OpenGL API, including xgl and wgl ones. Most likely we don't need mesa_headers on Windows or OS X either, and can drop them completely. Change-Id: Ic0d8d6238c862f8fe4a74e99e95344dcbf540980
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I9e064592c4ee18a600aadfa20b3c89ecafc818d4
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I72cad7217bdfc2a1f3339c604ea4dc55ff661e2a
2015-11-02Replaced boost::bind by std::bind in canvas/source/opengl/ogl_canvashelper.cxxMario J. Rugiero
Chose not to use lambdas instead because the number of arguments in these calls would have made it way too verbose, hurting readability. Change-Id: I8662a937ec10ca0fac6cd7e0d78b6268e8023ada Reviewed-on: https://gerrit.libreoffice.org/19707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-11-02Partial revert 'for_each -> range-based'Thorsten Behrens
There was a subtle change in semantics, the earlier loop was only iterating until aEnd, covering only unique elements of the vector. This partially reverts commit c04fd82433e9155ad61ebd92ca7b43a729a87890 Change-Id: I75c5f1b343c3fa8855f6d7f8f706b9259bc9f6df
2015-11-01boost::bind -> lambdas in canvas/source/simplecanvas/simplecanvasimpl.cxxMario J. Rugiero
Change-Id: If768595d3c3ec294d5a59ad42f26aacfd6e0fda3 Reviewed-on: https://gerrit.libreoffice.org/19708 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01boost::bind -> lambdas in canvas/source/vcl subtreeMario J. Rugiero
Change-Id: I2b2e746197b94222c73b78379d64086adfb5e693 Reviewed-on: https://gerrit.libreoffice.org/19712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01std::for_each -> range based for in canvas/source/tools/verifyinput.cxxMario J. Rugiero
Change-Id: I71c714a459ea81a268f93f8ffc5286eb532794ca Reviewed-on: https://gerrit.libreoffice.org/19711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01for_each -> range-based for in canvas/source/tools/spriteredrawmanager.cxxMario J. Rugiero
Change-Id: Ibe089e53488a9ba6baded637b17a1aeee0908f79 Reviewed-on: https://gerrit.libreoffice.org/19709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01boost::bind -> lambdas in canvas/source/tools/surface.cxxMario J. Rugiero
Change-Id: I9a9c4832cf18b10e15d2a4de8944b404b082e990 Reviewed-on: https://gerrit.libreoffice.org/19710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-31Replace boost::bind by lambdas in canvas/source/directx tree.Mario J. Rugiero
Change-Id: I1622f563b921a03234b9cb02de7c8abd00444129 Reviewed-on: https://gerrit.libreoffice.org/19703 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30tdf#93684 - Remove SalFrame::SyncRyan McCoskrie
Change-Id: Icae9cf0a17f9cdf9a671c7e7278019d6980602b1 Reviewed-on: https://gerrit.libreoffice.org/18453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-30tdf#92272: We need to twiddle the bytes from BGR to RGBTor Lillqvist
As far as I see, the surfaces created in the DX canvas are of D3DFMT_A8R8G8B8 or D3DFMT_X8R8G8B8 format, which means that the bytes (in memory order, on little-endian Windows) are B,G,R,A/X. So if the desired destination wants R,G,B,A, we need to swap the blue and red bytes. Let's hope this doesn't break anything else... Change-Id: I1b90d2cf95418f6557cac633ec6fce27599e8a61
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07eliminate typedef only being used onceNoel Grandin
Change-Id: I1e54968a67f3edce3b2297ea1932d5b07e2da643
2015-10-07inline ISurfaceProxySharedPtr typedefNoel Grandin
some places were not using the typedef anyhow Change-Id: Idf92ad63b05101832827113701a85eca48c084c6
2015-10-02Fix typosAndrea Gelmini
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3 Reviewed-on: https://gerrit.libreoffice.org/18939 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-18boost->stdCaolán McNamara
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14boost->stdCaolán McNamara
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c Reviewed-on: https://gerrit.libreoffice.org/18564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-13boost->stdCaolán McNamara
Change-Id: I9b4f884c6313a53fea543ea6f93175205351ad14 Reviewed-on: https://gerrit.libreoffice.org/18517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-11coverity#1323755 Using invalid iteratorCaolán McNamara
try and help coverity to know that aEnd and maFragments.end() are the same place Change-Id: I9ce4187d5ed15d0ae26b69bb360dbd47c2a6a185
2015-09-08tdf#94006 - need an explicit dispose for GLContext's SystemChildWindow.Michael Meeks
Previously we would get an explicit ~OpenGLContext - and potentially leave FMR's around for other OGC users, now we treat the other users properly - we need an explicit dispose() to get Window::dispose ordering right. Change-Id: I5edcbd73399b6db3dbcfb391570f364f9ab0c70d Reviewed-on: https://gerrit.libreoffice.org/18412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-09-08tdf#94006 - fix OpenGLContext mis-use in several places.Michael Meeks
gltf rendering, OpenGL canvas, GL transitions & GL capable (charts) Avoid GLX operations on un-initialized contexts. Change-Id: I7f523640f66ab656896181e5c865879234f6640e
2015-09-04canvas: simplify PageManager::nakedFragment loopsDaniel Robertson
Convert while loops and break statements in PageManager::nakedFragment into for loops Change-Id: I671f4eea140f26c2f451d54911d017325084bd08 Reviewed-on: https://gerrit.libreoffice.org/18138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-09-03tdf#93870 - GL accel. via VCL canvas for presentations when GL enabled.Michael Meeks
Change-Id: Ia31a88cb3d9e6baa987b22f77f407a3f592031f1 Reviewed-on: https://gerrit.libreoffice.org/18285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2015-08-30canvas: replace while loops with range-based forDaniel Robertson
Change-Id: Ide16bee666cf4df41646f9336a585e22a7fe53bd Reviewed-on: https://gerrit.libreoffice.org/18131 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17o3tl: rename compat_functional headerThorsten Behrens
After the cleanup, the stuff there really stands on its own (and the remaining usage of select1st/2nd is more descriptive than lambdas). Change-Id: I0aba131d5dc550189f8130d167dc94167e404540 Reviewed-on: https://gerrit.libreoffice.org/17806 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-16canvas: replace for_each with range-based for-loopDaniel Robertson
Replace ::std::for_each for a more readable range-based for loop in cases in which the function object to be applied by for_each is more readable as the body of a for loop. Change-Id: I5ea0f6a464855b8cc8af38f211bb784dd91eca0d Reviewed-on: https://gerrit.libreoffice.org/17775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-15canvas: whitespace/comments cleanupThorsten Behrens
The more redundant cases of whitespace/comments had to go... Change-Id: Id0bfab5f60f123c0a4d3d9f8468791e0d8046225
2015-08-15canvas: replace for_each with range-based for-loopDaniel Robertson
Replace ::std::for_each for a more readable range-based for loop in cases in which the function object to be applied by for_each is more readable as the body of a for loop. Change-Id: I6f96833d7f251d44e2308278bb92a7d49fd49bcd Reviewed-on: https://gerrit.libreoffice.org/17763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11tdf#92459 Cleanup unclear lambdasDaniel Robertson
Replace lambdas used to select the first/second member of a pair with the new simplified select1st/2nd from o3tl/compat_functional. There should be no side effects due to this change. Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89 Reviewed-on: https://gerrit.libreoffice.org/17656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11remove imgdebugNorbert Thiebaud
imgdbug.h ins included in canvs under some debugging flags but that header comes from http://billbaxter.com/projects/imdebug/ and is nowhere to be found in our source. the original project has been dead for a long while.. the last 'news' was that it was migrating to the now defunc 'berlios' hosting site. Change-Id: Idd030164f4ef0b28973530df69323cb952e99169 Reviewed-on: https://gerrit.libreoffice.org/17655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11tdf#92459 remove compat_functional from canvasDaniel Robertson
Replace all uses of deprecated features from the o3tl in compat_functional.hxx with lambda expressions in canvas. There should be no side effects due to this patch. Change-Id: Ia08ff1642a4f64035441dfdbac03c6fb09fa0443 Reviewed-on: https://gerrit.libreoffice.org/17586 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxxNorbert Thiebaud
also clean-up and 'standardize' the include sections of canvas' source code Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73 Reviewed-on: https://gerrit.libreoffice.org/17633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-10remove VERBOSE use from canvaNorbert Thiebaud
in preparation to kill --enable-verbose in configure.ac convert modules that use VERBOSE-YES/NO (uppercase) env variable to do things differently at compile time Convert canvas to use SAL_INFO/SAL_WARN mechanism instead of its home-grown 'verbose logging'. Change-Id: I2898d2309d421457839e3cd7078166c6da919882 Reviewed-on: https://gerrit.libreoffice.org/17619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-07-31canvas: replace boost::function with std::functionMichael Stahl
Change-Id: I1a4a3007a07a796d80d06ab7554953925bb8be3d