Age | Commit message (Collapse) | Author |
|
No longer needed after 269585d6b461b565fe75f77b6dbf219749edc5ab
"oox, sd: fix ever-increasing chart IDs when exporting to PPTX"
and b27b250f70f4651d387ef0646a9668950371e779
"sc: fix ever-increasing chart IDs when exporting to XLSX"
Also restored the documents modified in d913584909c2e0a235546a5f800baf45c3446d8b
"UnoApiXmlTest: merge parseExport from ChartTest" to ensure
only one chart was possible per document. Sample documents in unittests
can have more than one chart now, since the chart file name wouldn't
change
Kudos to Miklos Vajna for fixing the chart file names when exporting them
Change-Id: I10e2c44e41953a2d0d08bbb2a813134861e74660
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148461
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Disable since 7bb87abc0cc7b "fix upDown bar export to OOXML
We should not really export it as this leads to wrong import into MSO."
Change-Id: Ifcbb1200177b3cbd4966971c67d692c41e26827f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148128
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I43d896e1bd9c70198fc43185da2e1016fc7586c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148119
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Reuse existing mechanism to handle chart file names in tests.
See https://lists.freedesktop.org/archives/libreoffice/2023-February/089995.html
and 5f7861e6ce212f47420533aed302fa4b5510557d
"fix chart export tests correctly
we have a static counter that increments chart export file names. So
only the first exported file gets the file name chart1.xml and all the
following charts are incremented by one even if they are in a different
file."
Also add an assert to warn developers only 1 chart is allow per sample
document when parsing them.
Adapt a few tests to follow this rule and change file document
from testMultipleChart.docx to testExternalData.docx because
the name was misleading
Change-Id: Id7282049796f2b05492ab70b50c80065a99439be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148065
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This test should fail if oox/source/export/chartexport.cxx:970
is commented out
The reason is that the assert should have been
CPPUNIT_ASSERT(xmlXPathNodeSetGetLength(pXmlNodes));
instead.
Anyway, simplify it and just use assertXPath
Change-Id: Ie7ec10a70f7b447f92735d5c5b28d1074a9e4f98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148118
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I8f0017eccadf2ca5ea57ea3c1f8bea357b0c05f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147961
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I29efb96151d06fe19ec50a8c6cd363ae052d421f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147962
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Otherwise, it fails when scaling is 125% with
Test name: Chart2ImportTest2::testTdf146463
double equality assertion failed
- Expected: 4256
- Actual : 4330
- Delta : 30
Change-Id: I6cce69a00806208cbf168dfffc06ffb60f8a51bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147891
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I72b88eb4c369f45daa31c984b9e1021e66faafcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147880
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I6e9c18fa0195b2e8ae44ba2782c725f6cec8d471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147879
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Since f281d2d24c2a368c58d32b1b50acf83e0f056d90
"Actually we shouldn't always set Overlap flag on for all xlsx
charts..."
Change-Id: I3e68ff99b18033879d85e3b9d40afa5a3d25b14d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147878
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The test checks that the text shape width is smaller than the chart
wall. This test fails on HiDPI displays. For example:
--------------------
lode/dev/core/chart2/qa/extras/chart2import.cxx(2207) : error : Assertion
Test name: Chart2ImportTest::testFixedSizeBarChartVeryLongLabel
double equality assertion failed
- Expected: 4800
- Actual : 4632
- Delta : 100
Failures !!!
Run: 85 Failure total: 1 Failures: 1 Errors: 0
--------------------
Now, instead of testing the
exact value of the text shape width, I have used CPPUNIT_ASSERT_LESS()
to make sure that the above condition holds:
CPPUNIT_ASSERT_LESS(xChartWall->getSize().Width, xXAxis->getSize().Width)
This is done in two different tests:
* Chart2ImportTest::testFixedSizeBarChartVeryLongLabel()
* Chart2ImportTest::testAutomaticSizeBarChartVeryLongLabel()
Both tests are among those that can be invoked with:
cd chart2 && make CppunitTest_chart2_import
Change-Id: Ifb28fcf91da451aecdadff7a95aa810ef16fc510
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146815
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
It passes for me
Disabled in b4668f2c48db7 "disable the test" without giving
any reason why
Change-Id: I6a38e5e6f5da78df88ac805de058c3528bc1251c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147616
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ic2990ebc2e4a9a36dcd3f90c5f634ca7dd225d52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147491
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I909e6f334f4a659282141a97ccb3ffdea6ecc364
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147397
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Changes the postion calculation for pie charts, where the margin
min distance is now constant for pie charts, but unchanged for
other chart types.
This changes the positions of various pie charts used in tests,
which have been changed to the new value after the cases have been
checked.
Added a new test with all 3 use cases (chart area width equals
height, width is greater than height, width is less than height).
Change-Id: I51f98f336a7c64a3e6762144fc7dc8d9df80f696
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143179
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Both sfx2::XmlDump and css::qa::XDumper were (only) used to dump various data
from ChartModel and ChartView instances in debugging (e.g., F12 and Shift-F12 in
an SW_DEBUG=1 Writer) and testing scenarios. The problem with XmlDump was that
it was used as the target of a dynamic_cast from a UNO type, which is dangerous
(see the upcoming commit introducing loplugin:unocast for details). One fix
would have been to replace that dynamic_cast with a use of XUnoTunnel, and make
ChartModel and ChartView implement that. But those classes already implement
XDumper, so it looks more natural to use XDumper for that purpose too.
However, the information that was obtained via XDumper was rather different from
the information that was obtained via XmlDump. So make an incompatible change
to the (unpublished) XDumper, adding a kind parameter distinguishing the
original behavior of XDumper (kind == "shapes") from the original behavior of
XmlDump (kind == "").
Change-Id: Ia7379bedfc45ab62a298fdc2f030cebaf21c4885
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144145
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icb1ccc4b3d5fc16264d7700201d3884cc935e5ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144004
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I5be16135c563ed15acf45b93c59189531b832b37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143782
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I36c5356953208f6e92ac4a96aa4fa9473f655ab5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143779
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
When importing data from a cell range to use in a chart, if a cell is in
the totalsRow it is now ignored if it's the last row in the range.
Change-Id: Ie8c79b995c4d46b361492e8f7687894e2640392f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143488
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Id8ea0fcfef8598f163febe2aa2564b0ce9d0657f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143769
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
will be used in the following commit
Change-Id: I9d0925d0ef2bf93c01499a62b8eeb4153aceb9cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143768
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I81834b8316b19baad55122cc06a481d55fb6244a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143401
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I9d25adb68dac446c7e2e013684ceff48eaf23e52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143383
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I6d162307a32d18711908c1681c63c945574ba904
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143381
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
for that, create a new CppunitTest_chart2_uichart
in chart2
Change-Id: Ie4cdaff4a1dd623c7788ed7acdd5ef135f403e84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143305
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
SwModelTestBase does the same. this will help to make
SwModelTestBase inherit from UnoApiTest
Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Icdf2a5e7c0bd738f2cffbc0b7e99b1bd90a6dcce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141685
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: Icc292b40b3295e7890f81d448bb4907725f46970
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142245
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Add NumberText NatNum12 number formats, e.g. "One Hundred",
and currency formats, e.g. "One U.S. Dollar and Twenty Cents"
to number formatting dialog windows, i.e. Format Cells->Numbers
in Calc and Format Numbers in Writer (Edit Fields->Format->
Additional formats...).
Fix also bad English title case:
"One Euro *and* *Twenty-Two* cents" (not *And* and *Twenty-two*)
Details:
– svl: list NatNum12 NumberText currency codes in Currency
formats (i.e. after choosing Currency category).
– svx: Recognize bank symbol "CURRENCY" in NatNum12 parameters
defined in locale resource files. For example,
"[NatNum12 CURRENCY]" is converted to "[NatNum12 USD]" in
the number format dialog windows, using bank symbol of
the current locale settings.
Recognize compatible (old) bank symbol "CCC" in NatNum12
parameters defined in locale resource files. For example,
"[NatNum12 CCC]" is converted to "[NatNum12 DEM]" in
the number format dialog windows, using bank symbol of
the compatible currency of the German locale settings.
User-defined formats with arbitrary bank codes are
recognized as currency formats, e.g. modifying
"[NatNum12 USD]" to "[NatNum12 EUR]" in the dialog window
results a new currency format item.
– i18npool/*en_US.xml: define four Standard NatNum12 formats
(lower case, sentence case, title case, upper case) and
four Currency NatNum12 formats (title case, title case with
digits, upper case, upper case with digits).
– cui: use lower sample numbers for spell out formats:
– 100 for Standard:
One Hundred
one hundred
One hundred
ONE HUNDRED
– 1.2 for Currency:
One U.S. Dollar
ONE U.S. DOLLAR
One U.S. Dollar and Twenty Cents
ONE U.S. DOLLAR AND TWENTY CENTS
– i18npool: fix English title casing of NatNum12 conversions:
– Don't apply casing on "and", according to the title
case rules, for example:
"One Euro and One Cent" instead of
"One Euro And One Cent".
– Apply casing on the second element of the hyphenated
compound words:
"Twenty-One" instead of the bad "Twenty-one".
– add unit test for extended Number and Currency categories.
Note: according to the changes, update user-defined number format id in
chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
Change-Id: Ieaf9a8f75a4f197b858eaf67f83484df70295834
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141994
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
since 51d366712c55c61bea5169c238098d7007e4ce20
"ChartTest: inherit from UnoApiTest"
Change-Id: Ie4c3c25a3a854df6c7ac27e01c93ffb8f41f469c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141903
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Id100591517da48ec8e5cfd38f5c44ac0d7b16198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141888
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie826b66364f61bdab555228ca3a348f86b34847f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141824
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I8af95fd1fbe766a2a3bd19a7d9fa033649a635b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141610
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie826234aa9064b08b8f0647738b57c47ac0ed91a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141369
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2570815857fd170d9511ad507b17b102ca8ddabf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141283
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
And use an overloaded helper function with a better (?) unified name
to show that the result is not an O(U)String.
Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
which makes it easier to know what each variant requires
to stay on it's happy path
Change-Id: I3275a2543573367714bc78092e882f6535507285
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since it was running for quite a while compared to the others
Change-Id: Ia83a452fea67de425691f8ef66f23cde47fc0af8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140236
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic40dfeb742e97b90332dd711cfb582b6f102c8df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139958
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I601a5b3e649de0f4b02eea9289e175070b31781e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139806
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I6e74973b79cbefae3e311456989c78ea364a0aa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139795
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
It is really unfortunate that so much of our code depends on the
DPI, that should not.
Change-Id: Id1916677add508171490591a234f07a82a8e3f5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139648
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
In special case the legend keys are not series, but can be each
value of a series. This can't be done for the data table where so
this has been disabled.
This caused a crash when positioning the symbols, as in some cases
we got 0 symbols (due to another bug that didn't put the symbols
into the collection) or more symbols that there were series (and
the symbols couldn't be positioned correctly). With this change
we now get the correct number of symbols for the data table.
Also added the test document and test to open the document, to
make sure we don't crash anymore.
Change-Id: Idbebdd5295595a823b5420958e803b13258df035
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138697
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Full text of legend labels could overflow the chart area,
if the legend text was too long. If it's longer than
520 characters, strip it at the first space from the
500th character (or if there is no space, at the 500th
character). This results better XLSX interoperability, too.
Change-Id: I23a94f6baaf620b40e9b2819738eba5c5a921722
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137492
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
This change adds import and export code for the the chart's data
table properties to the ODF format for chart documents. The data
table properties are exported to a new element "data-table", which
then references a auto style with all the properties of a data
table + new data table specific properties: HBorder, VBorder,
Outline, Keys which are mapped to "show-horizontal-border",
"show-vertical-border", "show-outline" and "show-keys" chart
attributes.
Also adds a test for the import and export:
imports xlsx -> exports to ods -> imports ods
Change-Id: Id45d9369fd619959e4d6eba7ca51c8ddce9c8f56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138260
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Do not set the default border style for chart area in case of
pptx charts, if it is came from the MSO as an automtic line style.
regression from commit: 0dac43445b35da7e554dd4d7574c59611a0d0be1
(tdf#81437 XLSX import: fix missing chart border)
Change-Id: Iaaaecc1dffe80c3f1528851e707236f2f7228bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137993
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
|
|
Adds new service DataTable, which is reposible for the properties
of a data table for a chart. Also removes the existing properties
related to the data table from Diagram service, which were added
prematurely in the past, without a data table actually being
supported by the chart module.
Also adds an implementation of the DataTable service in chart2
module.
Change-Id: I0c6b32163745704c623d04baaf0ce0e208c107f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136789
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|