summaryrefslogtreecommitdiff
path: root/chart2/qa
AgeCommit message (Collapse)Author
2015-01-03fdo#83058 File corrupt due to data label position is invalid in chart.xmlPriyankaGaikwad
- File getting corrupted after RT due to data label position is invalid in chart.xml - LO must not export invalid label position property if chart type doesn't support that positioning in MS Office. - For clusterd bar chart XML Difference chart1.xml Original file <c:barChart> <c:grouping val="clustered" /> <c:ser> <c:dLbls> ... <c:dLbl> <c:dLblPos val="outEnd" /> </c:dLbl> ... </c:dLbls> </c:ser> </c:barChart> Roundtrip file <c:barChart> <c:grouping val="clustered" /> <c:ser> <c:dLbls> ... <c:dLbl> <c:dLblPos val="r" /> </c:dLbl> ... </c:dLbls> </c:ser> </c:barChart> Change-Id: I9cae11b8d198aaa70fb05cb3bf329cd898519170 Reviewed-on: https://gerrit.libreoffice.org/11141 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-12-22update the xml files with current reference filesMarkus Mohrhard
Change-Id: Ia1a392e41939485844ad1b518bcdd0d01a80febb
2014-12-18chart2: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
2014-12-10java: remove comment noiseNoel Grandin
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6 Reviewed-on: https://gerrit.libreoffice.org/13408 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05loplugin:unreffunStephan Bergmann
Change-Id: Id1a5a0756c2704a622eccecb32726a427e64b70d
2014-11-04Actually we shouldn't always set Overlap flag on for all xlsx charts...Kohei Yoshida
The correct fix unfortunately would require making the axis label layout smarter, to avoid overlapping of angled text label objects. Change-Id: I92198dbb90fd4a206ee226307992343d064f733a
2014-10-20chart2: fix temp file leaks in Chart2ExportTestMichael Stahl
Change-Id: Id128f19dee056189a34a02156fd0bf3ac14c2454
2014-10-20chart2: fix temp file leak caused by missing tearDown() between testsMichael Stahl
Change-Id: Ia4ee76743c640c0c5b92ec169e619f6c8788480e
2014-10-20Revert "at least fix the crash when calling SdXImpressDocument::disposeMichael Stahl
... for now" This reverts commit 599473a13e3c5ba669d995c913ad415bd674a16c. moggi says the unspecified crash happened with the tests following the comment in chart2import.cxx:75, but the tests run fine in valgrind now. The commit creates a memory leak in the CppunitTests as SfxBaseModel::dispose() returns early, because mbDisposed is set. Change-Id: I987dce6a4090784d166a4a3b2e7f9e2c0cddd289
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-11fdo#84647 : Fixed default value for TickLableSkip value.sushil_shinde
1. 'TextCanOverlap' property was stored as false if TickLableSkip is not equal to one. 2. For OOXML charts TickLableSkip can be between 1 to 999999999. 3. We can not apply zero or less than zero value to TickLableSkip. ( As per specification) 4. In axis model default value for TickLableSkip was zero which is incorrect. 5. Added unit test to check 'TextCanOverlap' property for chart. Change-Id: Ib3104b1d932f6e9376c149eabb201c8e9ad23da9 Reviewed-on: https://gerrit.libreoffice.org/11901 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-10loplugin:passstuffbyrefStephan Bergmann
Change-Id: If17bfdfdb51d5b9b8db563fccf09bb7608fcd0f8
2014-10-10fdo#54361: Add additional unit test case.Muthu Subramanian
Change-Id: Ifa3fd6f074d1957a468a1dad5dc2c223d38d24d4
2014-10-01chart2: fix the testDataLabelBordersDOCX on MacMichael Stahl
This test failed on Mac because it depends on the layout being finished, since for SwXTextEmbeddedObjects the corresponding SwVirtFlyDrawObj are inserted in the draw page not on import, but in layout. Change-Id: I731b9b92838252ff50135f97343357992bc1933f
2014-09-15Ensure we export correct label placement value for clustered bar chartsMiklos Vajna
This is similar to 7b8073906adca8dae24c04a23708a3f3d582218f (Ensure we export correct labal placement value for percent/stacked charts., 2014-08-07), in case a clustered bar chart has a top placement ("t" in OOXML), then MSO complains as well. Change-Id: Iffd991127784e0e732f6ae55de956a328a3a53e5
2014-09-11bnc#892610: OOXML import: Improve chart number formats.Matúš Kukan
If sourceLinked is used, do not set "PercentageNumberFormat" even if showPercent is true. The format string should be used for "NumberFormat". c8cc89ff802d86b1f3a69afe1b4835b7df7f70c7 unnecessarily disabled "LinkNumberFormatToSource". Use that for data labels but not for axis. Also, actually make attaching number format supplier work for Calc. Previously, non standard formats were added into wrong supplier, and they were thrown away later because it was attached too late. (See also ChartModel::attachNumberFormatsSupplier) Change-Id: Iaf9945abc3d82d0ac63d9f36b8888eb49f39ab57
2014-08-19java: no need to instantiate String objects directlyNoel Grandin
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-17remove executable bitsThomas Arnhold
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
2014-08-14java: remove commented out codeNoel Grandin
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-08java: remove redundant null checksNoel Grandin
Change-Id: Ia42e5ed715fbd3f5b84029a9844da55f307c6260
2014-08-08java: remove unused importsNoel Grandin
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08java: remove dead methodsNoel Grandin
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-07Another test for radar chart data label export.Kohei Yoshida
This one doesn't support label placement property either. Change-Id: If1f17a135eabd810033644e27db6b1e5c049daff
2014-08-07Write test for exporting data label positions for percent stack bar chart.Kohei Yoshida
Change-Id: Idebb56fc96828ec38d5c239c16e5b413a50c837f
2014-08-07Fix the test. It's bar3DChart not barChart.Kohei Yoshida
Change-Id: I8e504dfee81557a1965bb4bbce4ea975c13fe775
2014-08-07Write test for exporting data labels in area chart for OOXML.Kohei Yoshida
Change-Id: Icbb17f56643f7d89bf739b0f218b2ca8a6309d9a
2014-08-07Add test for default data label placement for line chart.Kohei Yoshida
Change-Id: I25cf48703a286470907ccc5415a0fab479aa4b8c
2014-08-07Write test for doughnut chart export of data labels to OOXML.Kohei Yoshida
We must not export label position properties for doughnut charts, else MS Office would think the file is corrupt. Change-Id: Icfab257ffb6da945b8add661e6455aa66cc475ab
2014-08-06Remove the 2nd argument which was added unintentionally.Kohei Yoshida
Change-Id: I264dba74bf4cab4beb97b33d3a71e82601119372
2014-08-06update the reference filesMarkus Mohrhard
Change-Id: I063100a632286b7fbec71c5fba00b9705972ac9f
2014-08-05Add test to ensure that we don't export label position attributes.Kohei Yoshida
At least for 3D bar chart, exporting this would choke MS Office. Change-Id: Ic6747f3c5502495d8cae734290183ff89b14fc70
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-04bnc#886540: Add test cases for chart background fill variance.Kohei Yoshida
"Automatic" fill in docx and xlsx should be solid white, whereas in pptx it is no fill (transparent). Change-Id: I7e64f2f895e4c4ed072a234e622a348599456f37
2014-08-04java: remove some casting in lib.TestParameters#getMSFNoel Grandin
where the return value is always cast to XMultiServiceFactory, so just do the cast in the method and avoid noise at the call sites. Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-07-29Add chart import, percentage number formats, unit test.Matúš Kukan
Change-Id: Id1b73c153f4b09ab94446452e7eb096b529473f4
2014-07-26bnc#885825: Write test for this.Kohei Yoshida
Originally it was a pptx document, but switched to docx because reloading an impress document in cppunit currently mysteriously crashes. Change-Id: I3e9ba6b9a4dc7d3c0ca1d59a073dc8a4cca4008c
2014-07-20add SAL_OVERRIDEDavid Tardon
Change-Id: I5c0f34f035765fcfd916b635ab18f5cb1bbcabb0
2014-07-19one more simplificationMarkus Mohrhard
Change-Id: I9aaf67872dde324f403598a7361cd4eda60b82b0
2014-07-19use the shared XPath test code in chart2Markus Mohrhard
Change-Id: Ia8481516eb3d53f406824cc2ef8873fe1cba3909
2014-07-07bnc#881025: Write test for this.Kohei Yoshida
Change-Id: Ifb1f83bbe5f9bb9ecb7fca26f883d1331052f10d
2014-07-07bnc#882383: Add chart unit test for GradientName property.Matúš Kukan
It needs to be set, so that the chart has colors. It was grey before. The bug was fixed already in aacfd5038d05a02f8b1eade3a5896d3d7e959f3d, which got pushed sooner, so this commit only changes the property name from 'INVALID' to 'FillTransparenceGradientName'. Change-Id: If06899258a4307d583480538338480ba5bb830b9
2014-07-03Test the import of data series values as well.Kohei Yoshida
There was a bug in there earlier that none of the tests didn't catch. Change-Id: I1f4ed1ba5e08e7842899a140163f9e165705569b
2014-07-03Better and more descriptive naming.Kohei Yoshida
Change-Id: Ic2e3b14399d2acc91c75922a25dc736b1605c320
2014-07-03bnc#812796: Write test for this.Kohei Yoshida
Right now, we skip hidden data series when importing OOXML charts into our internal data table. This of course means that if/when we add support for hidden columns in the internal data table, we may want to change this. Change-Id: Ida1b77821fbc2f8f937244576b52521b59d6ab89
2014-07-03fdo#54361:Add test case for the chart backgroundHeena Gupta
Change-Id: I03f0a45d821b14fe687b3ec7df98f9367adab1f2 Reviewed-on: https://gerrit.libreoffice.org/9978 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-02More fine-grained check of data series labels in the unit test.Kohei Yoshida
Change-Id: I6b23126816bb114407f2b75545094bc297ee7cc3