Age | Commit message (Collapse) | Author |
|
Change-Id: I384bf36a79adccdccdecb836b122958ce925c376
Reviewed-on: https://gerrit.libreoffice.org/36628
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
This changes tests so that we fill example data and create a new
pivot table from scratch, and create a new pivot chart using that
pivot table.
This enables that we test different cases without an example
document which creates a pivot table for us.
In addition add two test cases:
- pivot table with one column field and one data field
- pivot table with one row field and one data field (disabled, as
it currently crashes)
Change-Id: I8397a598857953e0b2d7da8dd91d7709a3495b71
Reviewed-on: https://gerrit.libreoffice.org/36625
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I95fa42f4ef0580734b605df859c1660b29adb8b2
Reviewed-on: https://gerrit.libreoffice.org/36499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I08cdd28aaae536fa8306446168dcdb977897dfcd
Reviewed-on: https://gerrit.libreoffice.org/36308
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I78a1d59e6814ad7f3e39fd720871189ccb0e22d1
|
|
This is a squashed commit of the pivot chart implementation.
Some of the changes:
- Add pivot chart specific (pivot table) data provider which
provides the data from a pivot table to the associated chart.
- When inserting a chart and the cursor is in a pivot table,
in that case insert a pivot chart
- Modify the pivot chart when the pivot table changes
- Collect and set the number format for the values
- isDataFromSpreadsheet check for the creation wizard
- In ChartView (and VLegend) check if the data provider is a
pivot chart data provider and get the pivot table field names
to create the buttons on the UI.
- Adds the functionallity to show a filter pop-up (from calc)
when clicking on row / column / page field buttons.
- Remove (X)PopupRequest as we won't need it.
- Add ODF import/export for pivot charts:
+ Added loext:data-pilot-source attribute on chart:chart
which is the internal name of the pivot table with which the
pivot chart is associated with. If the element is present, then
the it means the chart is a pivot chart, else it is a normal
chart
+ Added service to create pivot chart data provider through UNO
+ Add new methods to XPivotChartDataProvider to create value and
label data sequences separately from the data source, which is
needed for pivot chart import
+ When importing defer setting the data provider until a later
time when we know if we are creating a chart od a pivot chart
- Pivot chart ODF round-trip test
- Add table pivot chart supplier API:
This adds the XTablePivotChartSupplier and related interfaces so
we can access, create, delete pivot charts from UNO in a sheet
document. With this we now distinguish between normal charts
and pivot charts. This was mainly needed because we can't extend
the "published" interfaces of TableChartSupplier.
- Added an extensive test, which uses the API to create a new
pivot chart when there was none, and checks that the pivot chart
updates when the pivot table updates.
Change-Id: Ia9ed96fd6b1d342e61c2f7f9fa33a5e03dda21af
Reviewed-on: https://gerrit.libreoffice.org/36023
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I05d4eed55f5deba4b1802389d1ba94582d30550f
Reviewed-on: https://gerrit.libreoffice.org/35917
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
To re-integrate the fixes in revert commit
ab92c84dfe600f320f37b6126cab11385a6fbdd1
we have also to update the binary ods,
to avoid break of "make check".
Change-Id: Ic044d43c6c3c3d9fc3e003c282fac4ba888a0115
Reviewed-on: https://gerrit.libreoffice.org/35685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e
Reviewed-on: https://gerrit.libreoffice.org/35617
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This reverts commit 4f786274be8f9b01b34ad0772bcf718d5259bdc0.
|
|
On linux it was not a problem. On Windows there were some
random failures, but that might be fixed by using
Liberation Mono font.
Change-Id: Iae2684b302b3380c3a63b1fa80b1d0585454ed56
Reviewed-on: https://gerrit.libreoffice.org/35241
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Make sure the default is for kerning to be enable, and honor the setting
to disable it.
This also updates the expectations for chart2_xshape tests for file that
had kerning disabled and was previously ignored.
Change-Id: Icf6bb75e71cae43868fba323ca3c61e4a3e81523
Reviewed-on: https://gerrit.libreoffice.org/34169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: Ic7583e06cbb287805a11b148b40b6e5eda22c6eb
|
|
Same code which was added to the method
DrawingFragment::onEndElement() in
d178d7bef193565a7d6aacbc37a58dfc4bd7b316
A shape's size and position inside a chart object
are primarily defined by <cdr:from> and <cdr:to> tags in
drawing.xml, but in the same file we also have
an <a:xfrm> tag which is used for the same thing
(defining size and postion) in general. Testing with
MSO it seems it ignores what values are set to <a:xfrm> and
uses only the <cdr:from> and <cdr:to> values.
The test document showing this problem must be created
an earlier version of MSO, becuase <a:xfrm> is set to some
random values. Editing the chart and saving it with MSO
2013 the <a:xfrm> values are set consistently with
<cdr:from> and <cdr:to> pair.
Change-Id: Icbaff78e5a6fcea36678c3b3755c97f57976b626
Reviewed-on: https://gerrit.libreoffice.org/35069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Liberation Mono is a bundled, monospaced font, which
is better for testing, shows smaller differences.
Change-Id: If56597cede90fc81c722a69fd71e099d22a65d1f
Reviewed-on: https://gerrit.libreoffice.org/34618
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Iea0f7f6cfaee546c3478b936053659b3ecd27e6c
Reviewed-on: https://gerrit.libreoffice.org/34617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Ib481c05ac6f0f60d394e5380aa9cef46b4a0c65f
|
|
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7.
Caused some problems, need to be broken down.
Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52
Reviewed-on: https://gerrit.libreoffice.org/34534
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
|
|
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447
Reviewed-on: https://gerrit.libreoffice.org/34476
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
|
|
Change-Id: Idf59d552582035d3988e761a5024887a2540e692
|
|
Must be the same problem which makes failing
some of the Chart2DumpTest' test cases.
So disable it for now, until we find out what
the root of this problem is.
Change-Id: I02efffa1e33d264f62802cb43629cc0a13fd74f9
|
|
Change-Id: I2271cb393ad5268d1c579fb2f9c5e1e73a42c8f3
|
|
On different systems different separator is used
(e.g. coma, space).
Plus tdf#106068 can explain why some of the tests failes
on mac, so disable only these tests.
Change-Id: Id0fa8938d93dd9d4843d42426d369dcdfa1daef1
Reviewed-on: https://gerrit.libreoffice.org/34378
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
It's still failing randomly on Windows tinderboxes.
Change-Id: Idcb7e24d5d11ddc94ead74a2308d43c60de7b430
|
|
Test fails on mac with large differences.
Change-Id: I57bc58ad0b0d819533858992f032bfd763874d99
Reviewed-on: https://gerrit.libreoffice.org/34362
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
ChartWallTest used to be the most instable so don't
check position and size in this case.
AxisLabelTest also failing some times, so use a bigger
delta for it.
Change-Id: I230b7e0f527bae5661af1376486a9780e475f952
Reviewed-on: https://gerrit.libreoffice.org/34348
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I2b1a928d8487a134c0a266c5d7453690d19fde13
Reviewed-on: https://gerrit.libreoffice.org/34346
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Iac7bfd3d22e2186b90c525a6b5bc2a1605ae9aa3
Reviewed-on: https://gerrit.libreoffice.org/34338
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Let's see random test failures are related to calc.
Change-Id: I9164a900b8a7d631df75ba4064d8423400cf34bc
Reviewed-on: https://gerrit.libreoffice.org/34337
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Ie6dbc4a005f1840dc6b324a99406283676580b96
Reviewed-on: https://gerrit.libreoffice.org/34315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Id505edb3ca1b03817d3a98e6102d79df901a3dc2
Reviewed-on: https://gerrit.libreoffice.org/34308
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I06445065d138788652759b172436a7deb5f6c5c7
|
|
Changing font to a bundled one does not solve the issue.
Change-Id: I2606657a78115bc9b01cda9f0825b55ecfad3ab8
|
|
...by increasing the deltas to whatever ridiculously large values happen to make
the test pass. Tamás said he'll take a look later.
Change-Id: Ia839608ef3899dfca71886ccf57c31d4eb8bd72d
|
|
Change-Id: I87ca8286f586d5811e4db22ebe4df0317fab567f
|
|
Change-Id: I517fbb53db888276805e3c0d215337425d6cace1
|
|
Change-Id: I936c24c4b1d6854fcfec86dc2642ef57a241b8ea
Reviewed-on: https://gerrit.libreoffice.org/34225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Let's see whether this caused the position and size
differences between different machines.
Change-Id: I6cf0a2fff86d7ce8613d4ca4bbcfe6e001bd9f49
Reviewed-on: https://gerrit.libreoffice.org/34226
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I9f682f976e22407cd47c61bd2874ddf7f6fbc144
Reviewed-on: https://gerrit.libreoffice.org/34188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c
Reviewed-on: https://gerrit.libreoffice.org/34199
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
|
|
Change-Id: If4b8b207ba4ab379977d1a64c572187f48c4b9b4
Reviewed-on: https://gerrit.libreoffice.org/34186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I2bbb2fb5470af3026441102980f026bc9ad753b0
|
|
Allow 1 point difference.
Change-Id: Ib7d6ca0db773872469f5fc5a0d0dadb4a101c7df
Reviewed-on: https://gerrit.libreoffice.org/34184
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I16b7da66c6a6bab160212c47a75ce22951f85f87
Reviewed-on: https://gerrit.libreoffice.org/34181
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Some of tinderboxes shows these values can be variable
among machines.
Change-Id: I867cc5d124e537d5de16e2b8275f8eb6fdfde447
Reviewed-on: https://gerrit.libreoffice.org/34178
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
A hibrid of dumper tests (xmlDump) and simple CppUnit tests.
Advantages:
* Easy to add a new test case
** Add a new test file and generate the reference
** Similar to dumper tests
* Easy to find out the root of the problem when test fails
** Assertion is not coming somewhere from an XML file
** Assertion are placed in the code, so if you read and
understand that code, you can find out easier why the test fails.
** Similar to simple CppUnit tests.
* One test checks only one smaller part of the whole document
** e.g. legend, chart data, grid
Change-Id: I7bba5a37efcc62d6358c84acece91963243a914f
Reviewed-on: https://gerrit.libreoffice.org/34154
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
The 16-bit things that make up the UTF-16 encoding are called "code
units".
Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
|
|
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61
Reviewed-on: https://gerrit.libreoffice.org/33867
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I4e04b13538d1242ea38d1400df0ced813171bc5e
|
|
Change-Id: Iaf69f87564ff0f9f8aab6fafb833714426c8bc30
|