summaryrefslogtreecommitdiff
path: root/chart2/source/controller/main/ChartController.cxx
AgeCommit message (Collapse)Author
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-20use rtl::Reference in TheModelRefNoel Grandin
instead of manual acquire/release Change-Id: I7a5ae0337fc8fa1465ac716050e7187aa1accb87
2016-12-21convert EnumContext::Context to scoped enumNoel Grandin
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3 Reviewed-on: https://gerrit.libreoffice.org/32272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:expandablemethods in chart2Noel Grandin
Change-Id: Ie6650628683ec7c67359351eec0e09033f2b50cb Reviewed-on: https://gerrit.libreoffice.org/30750 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21Only call getChartType when the return value is actually usedStephan Bergmann
Change-Id: I687ef0ce7013bce08caa25e1e6035507b814e20a
2016-10-21Minor improvement of previous commitStephan Bergmann
Change-Id: I1ab0d8756be5f8bf60c6bac3e9217db71e8e05a3
2016-10-21Avoid crash with empty Chart documentStephan Bergmann
In a fresh Writer document, "Insert - Object - OLE Object... - Create new - LibreOffice 5.3 Chart - OK", then left-clicking into the empty Chart are, caused an unhandled (or rather, handled by desktop's FatalError) RuntimeException since 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320". Change-Id: I7ff53a84e4b06b20409d09e6010bac80e5a7c4b2
2016-10-11avoid crashes on broken charts, related tdf#98690Markus Mohrhard
Change-Id: If81f963babc15fc549d9daa904fd9836ea02ecef
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-08-30convert ActionDescriptionProvider::ActionType to scoped enumNoel Grandin
and remove an unused constant Change-Id: I8d46d16d3f575aa416bfc5a965986ee5dfb1f93c
2016-08-19convert SdrDragMode to scoped enumNoel Grandin
Change-Id: I244132d2240a46f42f14d453e5987968d274e907
2016-07-16no need for this temporary OStringMarkus Mohrhard
Change-Id: I8b5d69f7e64a83e52a41c285f5ef186a666ccd55
2016-07-13chart2: cleanup local var assignmentsJochen Nitschke
and remove comments about a gcc 3.3 workaround. some comments went obsolete with other commits like 367105e0248c7b80b60b2554d04f5f248b4259b3 Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced Reviewed-on: https://gerrit.libreoffice.org/27127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28loplugin:singlevalfields in chart2Noel Grandin
Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6 Reviewed-on: https://gerrit.libreoffice.org/26708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27GSoC notebookbar: switching tabs depending on contextSzymon Kłos
+ sfx2::sidebar::EnumContext moved to the vcl module + TabPage contains vector with context values + vcl builder reads control's contexts from the "class" mark + ContextTabControl shows tabs depending on context Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d Reviewed-on: https://gerrit.libreoffice.org/26447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-10Missing break in switchStephan Bergmann
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM falling through to the default break case. Then 14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines, tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE, OBJECTTYPE_DATA_AVERAGE_LINE block in between. Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-04-25no need to copy the list of available commands on every callNoel Grandin
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25Kill comphelper::MakeSetStephan Bergmann
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3 Reviewed-on: https://gerrit.libreoffice.org/24343 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
2016-04-14tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the problem of multiple debug levels Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad Reviewed-on: https://gerrit.libreoffice.org/22616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-12clang-tidy performance-unnecessary-value-param in chart2Noel Grandin
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:constantparam in chart2Noel Grandin
Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09 Reviewed-on: https://gerrit.libreoffice.org/23833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-14com::sun::star->css in chart2Noel Grandin
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
2016-01-06Fix typosAndrea Gelmini
Change-Id: Ie0578dcca6cbf4edb62544109d616a081888f369 Reviewed-on: https://gerrit.libreoffice.org/21140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-24loplugin:unusedfieldsNoel Grandin
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-23loplugin:unusedfields in chart2Noel Grandin
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-27Replace boost::bind by lambdas in chart2 tree.Mario J. Rugiero
Change-Id: Ida56649f15b58b3b11b3d43c5017fd5ebd9a2cf1 Reviewed-on: https://gerrit.libreoffice.org/19606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-17coverity#1327446 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib409b7fe4244b89f8767b20adcfae060f121b2f2
2015-10-10use trendline context for trendlines, tdf#94931, tdf#94934Markus Mohrhard
Change-Id: I0cb9cdec33924e560b24744cc78d632025a189fc
2015-10-09correctly dispose the chart sidebar when leaving chart, tdf#94292Markus Mohrhard
This is a much better approach than my old one that tried to use the correct XModel with the chart sidebar. Now everytime we leave the chart edit mdoe we destroy the chart sidebar panels and recreate them when we go back to chart edit mode. As a result we no longer need to have worry that much about using the correct ChartModel and about the lifecycle of the ChartModel. Change-Id: Ie85ad82968e20a81f059d4bd930a83a70da35fc9
2015-10-07remove another custom refcounting base classNoel Grandin
Change-Id: Icd8a8d79da0ada68e9ee869c3c2a7b93db5b2733
2015-10-03don't show area and line panel in pie chart Chart selection, tdf#94320Markus Mohrhard
Change-Id: I0eacedbb3d96a059278bab0ef98a66ed49b827fc
2015-09-30Fix typosAndrea Gelmini
Change-Id: Icf15b5ea2e5b9cd62645bab2f9ccaada948322a7 Reviewed-on: https://gerrit.libreoffice.org/18940 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-27gcc3 is not supported anymore, so remove thatMarkus Mohrhard
Change-Id: Iddc481e13d40a6399a4a23a45c812b34a3a109f6
2015-09-15remove chart sidebar when leaving chart edit modeMarkus Mohrhard
Change-Id: Ie6fc01b2a610fb861ddade996ebb8480be217085
2015-09-09convert Link<> to typedNoel Grandin
Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b
2015-07-30small fix to reduce UnknownPropertyException in chart2Markus Mohrhard
accidently introduced with f1531cdaaebe706d909dc6ddde439ccb5f4ad36d Change-Id: I292097c5f61ecb32a28a90e9f5be48fcfd6bcd7b
2015-07-26update gradients in sidebar as wellMarkus Mohrhard
Change-Id: I0dc737c133e905d75fab23457fb86c8d2b724ce8
2015-07-26handle more than one chart with chart sidebarMarkus Mohrhard
Change-Id: I4998904a9273f2c67114a246d7f234843602573c
2015-07-17add chart sidebar axis panelMarkus Mohrhard
Change-Id: Ia0f75c09f11c5751428a19fca33b39a54cdbb249
2015-07-16generate correct sidebar context strings for chartsMarkus Mohrhard
Change-Id: I92adf79c461f3536475da318e03b60f2e1adc08f
2015-07-16enable the chart sidebar againMarkus Mohrhard
Change-Id: I0ad9d962436562aa1026c50e5ec16f844f889eef
2015-07-16remove my accidently committed debug messagesMarkus Mohrhard
Change-Id: Ia890837520b57291ae119de30dc7586b65e30b81
2015-07-13disable newly unused code since last disableCaolán McNamara
Change-Id: I9f0abc3963ac4687e29fc629f1b9e9bb1fffaf8a
generated by cgit (git 2.34.1) at 2024-08-16 22:16:43 +0000