summaryrefslogtreecommitdiff
path: root/chart2/source/tools/ObjectIdentifier.cxx
AgeCommit message (Collapse)Author
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): chart2Stephan Bergmann
Change-Id: I9fb8e2853b5ddb1f9fe589f4e47828025ea52915 Reviewed-on: https://gerrit.libreoffice.org/76692 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-19loplugin:referencecasting in canvas..chart2Noel Grandin
Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc Reviewed-on: https://gerrit.libreoffice.org/75935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-20lok: chart: constrained dragging of pie segmentsMarco Cecchetti
The extra information for the graphic selection is now formatted according to JSON syntax so that is easier to parse. Information for allowing the client to performa constrained dragging of a pie segment is appended when needed to the graphic selection message. A polygon approximation of the pie segment in svg format is attached too to the graphic selection message. Core now is able to handle a specific msg from the client with data about the new pie segment offset computed by the client on drag end. This information is dispatched by the chart controller to a specific method: executeDispatch_LOKPieSegmentDragging. Change-Id: I42e7742508fa3a453383bf7b95e47df169f24834 Reviewed-on: https://gerrit.libreoffice.org/70568 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: chart: informing the client about selection handling propertiesMarco Cecchetti
We hijack the chart CID protocol (CID:/classification/ObjectID) by inserting information about selection handling properties (draggable, resizable, rotatable) btw the classification section and the ObjectID section. This new section has the form: /Draggable=?:Resizable=?:Rotatable=? where in place of '?' there is 0 or 1. The hijacking occurs at the ChartController.getSelection method which is available through the XSelectionSupplier interface. Change-Id: Iaf920fe68e59c2595000e43d3fc1f976632cef18 Reviewed-on: https://gerrit.libreoffice.org/70567 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-03-12Simplify containers iterations in chart2, cli_ure, comphelper, configmgrArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76 Reviewed-on: https://gerrit.libreoffice.org/69010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Meryem Ezber
Change-Id: I4446858ed30df4adffbf18ab609c95690cff99c0 Reviewed-on: https://gerrit.libreoffice.org/67668 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-11tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Meryem Ezber
Change-Id: Icfedb77943721f0ed7504ec68c3b63c4709352bc Reviewed-on: https://gerrit.libreoffice.org/67615 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2018-12-29Do not use indexing for single getToken call, simplifyMatteo Casalin
Change-Id: I8ee0ccbbc596a4edd0da50e8bbcf573afc9bb53b Reviewed-on: https://gerrit.libreoffice.org/65665 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-10-09tdf#42949 Fix IWYU warnings in chart2/source/tools/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I804895a4dd2d98707f0d1bbbc9bb78782b07a397 Reviewed-on: https://gerrit.libreoffice.org/61505 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06loplugin:simplifyconstruct in canvas..cuiNoel Grandin
Change-Id: I02eba1df117a9d0df42bcac13c3251cb4fa6da14 Reviewed-on: https://gerrit.libreoffice.org/60074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28tdf#42949 Fix IWYU warnings in chart2/source/inc/[l-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some only-recently analyzed files were cleaned. Also tried harder to use more fw decls instead of blacklisting Change-Id: Ie4f8eb7065e44a2b5208d6da4fa8e3681a31820b Reviewed-on: https://gerrit.libreoffice.org/59420 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-26chart2: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by removing explicitly user-provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non-deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already inline, so why bother with non-inline functions.) Change-Id: If96d3b6ca79416127933e7f22e3628361604efe1 Reviewed-on: https://gerrit.libreoffice.org/58069 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-09use more DBG_UNHANDLED_EXCEPTIONNoel Grandin
so we get nice logs of the exception dynamic type for UNO exceptions. Change-Id: Ic0b10dc14d354a2c9a0591b3a51d2f1640d54bdb Reviewed-on: https://gerrit.libreoffice.org/52465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14Fix typosAndrea Gelmini
Change-Id: Icc5fc590a6a90e30afa5f61028d4dd0279fbe120 Reviewed-on: https://gerrit.libreoffice.org/47861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-12More loplugin:cstylecast: chart2Stephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I745557506326b2b0ce66d0058ebf85e5ed2a0952
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-03inline ASSERT_EXCEPTION macro in chart2Noel Grandin
Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c Reviewed-on: https://gerrit.libreoffice.org/44246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: chart2Stephan Bergmann
Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
2017-08-01loplugin:checkunusedparamsNoel Grandin
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28loplugin:checkunusedparams more part3Noel Grandin
Change-Id: I621fcf7ceb27238ca86d2299dfb2b8ed03c270fd Reviewed-on: https://gerrit.libreoffice.org/40509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-13use more OUString::operator== in a*..chart2Noel Grandin
Change-Id: Ifb5608abebffd9687ed55e8c74f9be54a749111d Reviewed-on: https://gerrit.libreoffice.org/39887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-23loplugin:comparisonwithconstant in chart2Noel Grandin
Change-Id: I95787007b26cdcf0d5d1617ecd0e55d377b551d7 Reviewed-on: https://gerrit.libreoffice.org/37941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19clang-tidy readability-simplify-boolean-expr in accessibility..cuiNoel Grandin
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc Reviewed-on: https://gerrit.libreoffice.org/36677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-15Fix typosAndrea Gelmini
Change-Id: I0238202c0dc0380b0e33a9c4567a9513c0afbe91 Reviewed-on: https://gerrit.libreoffice.org/36556 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03makeAny->Any in basctl..chart2Noel Grandin
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61 Reviewed-on: https://gerrit.libreoffice.org/33867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-08-30no point in these dtors being virtualCaolán McNamara
nothing inherits from these classes Change-Id: Ic887ac8a046b8697e310e19b6e7fdf9efae8f074
2016-08-30default assignment operator is fineCaolán McNamara
Change-Id: I0b63abbfe7d29c35cf7c7dd047527b20ad46c538
2016-08-01tdf#100726: Improve readability of OUString concatenationnadith
this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-04-25Kill comphelper::MakeMapStephan Bergmann
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823 Reviewed-on: https://gerrit.libreoffice.org/24344 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: Iff591fb7cd434805998fdd14b94c4dd9654ba55e
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-07-02remove whitespacesMarkus Mohrhard
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-06-26Track all uses of ErrorBarX and ErrorBarY UNO property names.Kohei Yoshida
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-05-07Reference can be removedJulien Nabet
See http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4107883.html Change-Id: I4d29b9d80f8142792f948c6797006fe7e698a2a4
2014-05-06Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part2 + fix some errorsJulien Nabet
Change-Id: I9c889d718a9c91eb4c2bde2389a21dd754cbef36
2014-05-05Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part2Julien Nabet
Change-Id: Ibca921eff3647507ffb7e9011a84aeefbec58d7a
2014-04-21remove comments why a file gets includedThomas Arnhold
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-15chart2: sal_Bool->boolNoel Grandin
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2013-11-19use ChartModel instead of XModel in a few placesMarkus Mohrhard
This allows us easier implementation of some advanced features. Mainly the 4D chartting will now be able to work without several ugly layers of UNO. Change-Id: I74d07229eaef921c508f3bab8fae6d6075ad737a
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-07-29fdo#62475 removed pointless commentsJelle van der Waa
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa Reviewed-on: https://gerrit.libreoffice.org/5148 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-06-17fdo#43460 chart2: use isEmpty()Jelle van der Waa
Change-Id: Ia74923ed8f00adfa3f7758edb4e5755fedb0ec8a Reviewed-on: https://gerrit.libreoffice.org/4315 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
generated by cgit (git 2.34.1) at 2024-07-08 05:38:47 +0000