summaryrefslogtreecommitdiff
path: root/chart2/source
AgeCommit message (Collapse)Author
2024-10-22cid#1545605 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545841 COPY_INSTEAD_OF_MOVE cid#1554682 COPY_INSTEAD_OF_MOVE cid#1554686 COPY_INSTEAD_OF_MOVE cid#1554715 COPY_INSTEAD_OF_MOVE cid#1554750 COPY_INSTEAD_OF_MOVE cid#1554759 COPY_INSTEAD_OF_MOVE cid#1554770 COPY_INSTEAD_OF_MOVE cid#1554779 COPY_INSTEAD_OF_MOVE cid#1554794 COPY_INSTEAD_OF_MOVE cid#1554800 COPY_INSTEAD_OF_MOVE cid#1554826 COPY_INSTEAD_OF_MOVE cid#1554836 COPY_INSTEAD_OF_MOVE cid#1554862 COPY_INSTEAD_OF_MOVE cid#1554865 COPY_INSTEAD_OF_MOVE cid#1554872 COPY_INSTEAD_OF_MOVE cid#1554883 COPY_INSTEAD_OF_MOVE cid#1554906 COPY_INSTEAD_OF_MOVE cid#1554921 COPY_INSTEAD_OF_MOVE cid#1554926 COPY_INSTEAD_OF_MOVE cid#1554946 COPY_INSTEAD_OF_MOVE cid#1554956 COPY_INSTEAD_OF_MOVE cid#1554970 COPY_INSTEAD_OF_MOVE cid#1554986 COPY_INSTEAD_OF_MOVE cid#1554991 COPY_INSTEAD_OF_MOVE cid#1555013 COPY_INSTEAD_OF_MOVE cid#1555037 COPY_INSTEAD_OF_MOVE cid#1555050 COPY_INSTEAD_OF_MOVE cid#1555057 COPY_INSTEAD_OF_MOVE cid#1555066 COPY_INSTEAD_OF_MOVE cid#1555067 COPY_INSTEAD_OF_MOVE cid#1555083 COPY_INSTEAD_OF_MOVE cid#1555097 COPY_INSTEAD_OF_MOVE cid#1555135 COPY_INSTEAD_OF_MOVE cid#1555140 COPY_INSTEAD_OF_MOVE cid#1555146 COPY_INSTEAD_OF_MOVE cid#1555148 COPY_INSTEAD_OF_MOVE cid#1555149 COPY_INSTEAD_OF_MOVE cid#1555155 COPY_INSTEAD_OF_MOVE cid#1555157 COPY_INSTEAD_OF_MOVE cid#1555168 COPY_INSTEAD_OF_MOVE cid#1555195 COPY_INSTEAD_OF_MOVE cid#1555196 COPY_INSTEAD_OF_MOVE cid#1555237 COPY_INSTEAD_OF_MOVE Change-Id: I90531c19c28dca77fe99c72efdfc0972c311da98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21tdf#163486: PVS: Two similar code fragments were foundXisco Fauli
Since commit 44569a657c4282757443ae06efc6441e571a0409 Author: Release Engineers <releng@openoffice.org> Date: Thu Jul 2 19:17:43 2009 +0000 CWS-TOOLING: integrate CWS bubblechart V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'. Change-Id: I8a3515e2c3de97f82547786a8428f47c503335ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175321 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-21tdf#163486: PVS: Two similar code fragments were foundXisco Fauli
Since commit 4c2701d4cc8b27eed56172b4188b61efb8783c55 Author: Vladimir Glazounov <vg@openoffice.org> Date: Tue May 22 17:53:11 2007 +0000 INTEGRATION: CWS chart2mst3 (1.1.4); FILE ADDED V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'. Change-Id: I24a904ee2e0fa81eb50756545d4b1127b93579fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175322 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-20cid#1633319 Resource leakCaolán McNamara
Change-Id: Icdbc973b6c0d40366a1a261706e21bbb50a8826e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175258 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-18tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: Ibe65f4eca6009e8be4355974cdf33b5cabbe03e5 V1037: Two or more case-branches perform the same actions. Check lines: 54, 60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175144 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-18SW: extract transform charts (using dialog code)Attila Szűcs
Implemented chart data extraction, and transformation added insert/delete/modify row/column, and the ability to set resize data table setcolumndesc / setrowdesc .. for 1 descriptor, or with multiple descriptor to set set 1 cell value, or set the whole table cells values. it will resize the table, but you can still use partial arrays like "data": [ [ 1,2,3,4 ], [ 2,3,4,5 ], [ 3 ], [ 4,5,6,7 ], [ 2,2,1 ], [ 5,6,7,8 ] ], that means the 3. row 2,3,4th cell will not be overwritten. for insert column, it call codes from DataBrowserModel. (used by dialog code) added tests, fixed a contentcontrol date problem 2. commit (made by Caolan) squashed into 1. commit: WIP hack this to link move stuff from chartcontroller to chartcore and adjust visibility until it links at least Change-Id: I5529f4da33f046eef7e947d755e29486fa966274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172849 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175121 Tested-by: Jenkins
2024-10-18tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: I4afca4f9d7eb8968dc7a2465222f7c2060f10bd4 V1037: Two or more case-branches perform the same actions. Check lines: 178, 194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175055 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#163486: PVS: Expression is always falseXisco Fauli
V547: Expression 'aMDHelper.ISSET_Storage' is always false. Change-Id: Ibdeb820b606301f729bf09a3641ab44d726e356c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175095 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 422, 426. Change-Id: Ib2bcd4b170b827c325628e0e7eabe6a19ca399ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175086 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 507, 520. Change-Id: Ia376cad05bd4327662cd3b7adcbe43e25270da2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175084 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 406, 410. V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 410, 418. Change-Id: I971f243870a96f7195d2819f2a0a44bb63840fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175083 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17cid#1557492 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I6fd226cad714fab0eb0f8c0806dcf73c2ff20426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-16crashtesting: assert on fdo87790-1.odsCaolán McNamara
and gnome704765-1.ods Change-Id: I037b3c7d1f3887634ead05e5464435ae0fbeea60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175028 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-15cid#1557492 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I093583db8ca8d244d05e8df365c35cdf3b4d6fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-14cid#1554844 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554878 COPY_INSTEAD_OF_MOVE cid#1554907 COPY_INSTEAD_OF_MOVE cid#1555082 COPY_INSTEAD_OF_MOVE cid#1555224 COPY_INSTEAD_OF_MOVE cid#1555301 COPY_INSTEAD_OF_MOVE cid#1555378 COPY_INSTEAD_OF_MOVE cid#1555395 COPY_INSTEAD_OF_MOVE cid#1555452 COPY_INSTEAD_OF_MOVE cid#1555466 COPY_INSTEAD_OF_MOVE cid#1555514 COPY_INSTEAD_OF_MOVE cid#1555566 COPY_INSTEAD_OF_MOVE cid#1555753 COPY_INSTEAD_OF_MOVE cid#1555782 COPY_INSTEAD_OF_MOVE cid#1555825 COPY_INSTEAD_OF_MOVE cid#1555842 COPY_INSTEAD_OF_MOVE cid#1555891 COPY_INSTEAD_OF_MOVE cid#1555917 COPY_INSTEAD_OF_MOVE cid#1555961 COPY_INSTEAD_OF_MOVE cid#1556021 COPY_INSTEAD_OF_MOVE cid#1556055 COPY_INSTEAD_OF_MOVE cid#1556307 COPY_INSTEAD_OF_MOVE cid#1556349 COPY_INSTEAD_OF_MOVE cid#1556436 COPY_INSTEAD_OF_MOVE cid#1556665 COPY_INSTEAD_OF_MOVE cid#1556696 COPY_INSTEAD_OF_MOVE cid#1556718 COPY_INSTEAD_OF_MOVE cid#1556775 COPY_INSTEAD_OF_MOVE cid#1556835 COPY_INSTEAD_OF_MOVE cid#1556877 COPY_INSTEAD_OF_MOVE cid#1556994 COPY_INSTEAD_OF_MOVE cid#1557010 COPY_INSTEAD_OF_MOVE cid#1557074 COPY_INSTEAD_OF_MOVE cid#1557111 COPY_INSTEAD_OF_MOVE cid#1557142 COPY_INSTEAD_OF_MOVE cid#1557163 COPY_INSTEAD_OF_MOVE cid#1557164 COPY_INSTEAD_OF_MOVE cid#1557214 COPY_INSTEAD_OF_MOVE cid#1557254 COPY_INSTEAD_OF_MOVE cid#1557322 COPY_INSTEAD_OF_MOVE cid#1557327 COPY_INSTEAD_OF_MOVE cid#1557492 COPY_INSTEAD_OF_MOVE cid#1557565 COPY_INSTEAD_OF_MOVE cid#1557663 COPY_INSTEAD_OF_MOVE cid#1557798 COPY_INSTEAD_OF_MOVE Change-Id: I2ae9c184dcc18d44a65437e18c49e16b27f4d81d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08cid#1632259 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1632258 COPY_INSTEAD_OF_MOVE cid#1632257 COPY_INSTEAD_OF_MOVE cid#1632256 COPY_INSTEAD_OF_MOVE cid#1632255 COPY_INSTEAD_OF_MOVE cid#1632254 COPY_INSTEAD_OF_MOVE cid#1632253 COPY_INSTEAD_OF_MOVE cid#1632252 COPY_INSTEAD_OF_MOVE cid#1632251 COPY_INSTEAD_OF_MOVE cid#1632250 COPY_INSTEAD_OF_MOVE cid#1632249 COPY_INSTEAD_OF_MOVE cid#1632248 COPY_INSTEAD_OF_MOVE cid#1632247 COPY_INSTEAD_OF_MOVE cid#1632246 COPY_INSTEAD_OF_MOVE cid#1632245 COPY_INSTEAD_OF_MOVE cid#1632244 COPY_INSTEAD_OF_MOVE cid#1632243 COPY_INSTEAD_OF_MOVE cid#1632242 COPY_INSTEAD_OF_MOVE cid#1632241 COPY_INSTEAD_OF_MOVE cid#1632240 COPY_INSTEAD_OF_MOVE cid#1632239 COPY_INSTEAD_OF_MOVE cid#1632238 COPY_INSTEAD_OF_MOVE cid#1632237 COPY_INSTEAD_OF_MOVE cid#1632236 COPY_INSTEAD_OF_MOVE cid#1632235 COPY_INSTEAD_OF_MOVE cid#1632234 COPY_INSTEAD_OF_MOVE cid#1632233 COPY_INSTEAD_OF_MOVE cid#1632232 COPY_INSTEAD_OF_MOVE cid#1632231 COPY_INSTEAD_OF_MOVE cid#1558073 COPY_INSTEAD_OF_MOVE cid#1557945 COPY_INSTEAD_OF_MOVE cid#1557916 COPY_INSTEAD_OF_MOVE cid#1557898 COPY_INSTEAD_OF_MOVE cid#1557808 COPY_INSTEAD_OF_MOVE Change-Id: Ibf417c154255fe3b0598127df5b5805ed543c8d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174660 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06cid#1608393 silence Overflowed constantCaolán McNamara
this code seems to be duplicated in sw/source/core/unocore/XMLRangeHelper.cxx too Change-Id: Ib41edfa33a72f32dff1f6720e6b0f356e9773f18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174556 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-01loplugin:constantparamNoel Grandin
Change-Id: I114331d1cb7860087d5f5bee77af771e537b0616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-01loplugin:unusedmethodsNoel Grandin
Change-Id: I3897ccb3349874672b778835b9c15642cb1a14f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-29avoid temporary OUString in lcl_getSingleCellAddressFromXMLStringNoel Grandin
Change-Id: I3ec79a4ae0259babb8aa472c338cc78910abc800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-25cid#1606887 Data race conditionCaolán McNamara
and cid#1607140 Data race condition Change-Id: Ie27b42012b945bfad0c7344c734dc0b8f0816e70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173898 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-22tdf#163084: add Histogram chart in sidebarJulien Nabet
Change-Id: I7f5d2f22c340d4f04b6c04fac04079ae2a29b32c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173767 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-09-21no need for a template hereNoel Grandin
it is instantiated only once Change-Id: I0545219a390eb382bcffd3b1a551245f54c47f90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-15cid#1607343 silence Overflowed constantCaolán McNamara
and cid#1607447 Overflowed constant Change-Id: If9be20f1e6a42343844c887c1e16d4c066ff3949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173365 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-13use more concrete UNO types in chart2Noel Grandin
Change-Id: Id2d58ad76b6e8ff569bd7b65f86a7fdd0152f3d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-12use more concrete UNO class in chart2Noel Grandin
Change-Id: Ifbdcf39f6f621dc63746a8c389a19c52aab847b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173264 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-27tdf#90733 - support invertIfNegative for bar and bubble chartKurt Nordback
Extend the existing initial support for the OOXML invertIfNegative tag to pass the data down into bar and bubble chart rendering. Also add corresponding unit tests. This does not include a UI control to select/deselect the invert-if- negative option, nor support for export of the flag to OOXML, nor any support in ODF. Change-Id: I45b24b816edc379c9b431e86269dd5ff37977b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-24Resolves: tdf#162597 'ok' in chart range dialog doesn't commit datarangeCaolán McNamara
so nothing happens. since: commit 4965b055b5998dc345ecaeb80fc8c3874b19e2a5 CommitDate: Fri Feb 16 12:08:55 2024 +0100 Chart: Make Data Range Dialog Async async conversion missed that there is a DataSourceDialog::run override so the use of asyncRun means the body of that isn't run. To keep things simple we can add an explicit 'ok' handler and move the special dialog ok code into that instead, so all the existing asyncRun's used with this dialog run the same code originally called in the previous non-async case. Change-Id: Ibdb4b764b1a1e48c01ee1528bc260f694e840221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-19cid#1557694 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557162 COPY_INSTEAD_OF_MOVE cid#1556896 COPY_INSTEAD_OF_MOVE cid#1556893 COPY_INSTEAD_OF_MOVE cid#1556873 COPY_INSTEAD_OF_MOVE cid#1556872 COPY_INSTEAD_OF_MOVE cid#1556789 COPY_INSTEAD_OF_MOVE cid#1556570 COPY_INSTEAD_OF_MOVE cid#1556519 COPY_INSTEAD_OF_MOVE cid#1556516 COPY_INSTEAD_OF_MOVE cid#1556451 COPY_INSTEAD_OF_MOVE cid#1556396 COPY_INSTEAD_OF_MOVE cid#1556237 COPY_INSTEAD_OF_MOVE cid#1556113 COPY_INSTEAD_OF_MOVE cid#1556094 COPY_INSTEAD_OF_MOVE cid#1555991 COPY_INSTEAD_OF_MOVE cid#1555982 COPY_INSTEAD_OF_MOVE cid#1555885 COPY_INSTEAD_OF_MOVE cid#1555702 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555450 COPY_INSTEAD_OF_MOVE cid#1555327 COPY_INSTEAD_OF_MOVE cid#1555145 COPY_INSTEAD_OF_MOVE Change-Id: I38cc1a38e8cb2c33f33e0fc3afd34a0fb39e5ec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-17chart2: move histogram calcualtion into HistogramChartTypeTomaž Vajngerl
Histogram is special in the way that the input data is not the data that is being shown in the chart - it needs to be calculated separately usign the input data. First we put the calculation in the (Histogram)DataInterpreter but that is not a very good place to calculate as we don't have the access to the chart properties and can't influence the calculation with it. This change puts the calculation into (Histogram)ChartType instead and will trigger the calculation when the data is requested. This is the first case of such a thing where we calculate the data on demand from the input data, so we will probably need further changes the chart code to better support calculated data sequences. Change-Id: Ia66f9d245f7d42973c728e1dd9a406b66eb2610a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171952 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-08-17tdf#161230 - Pie-of-pie and bar-of-pie chart data labels are misalignedKurt Nordback
Implementing label support for of-pie charts. This involves using the existing pie label code with an added horizontal shift, and adding special (simple) handling for the bars in bar-of-pie. This also fixes tdf#161228 Change-Id: Ifc7c1f28548caf216aba5c7dc411d05a0c9d8726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169566 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-16cid#1557618 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557535 COPY_INSTEAD_OF_MOVE cid#1557520 COPY_INSTEAD_OF_MOVE cid#1557513 COPY_INSTEAD_OF_MOVE cid#1557503 COPY_INSTEAD_OF_MOVE cid#1557487 COPY_INSTEAD_OF_MOVE cid#1557483 COPY_INSTEAD_OF_MOVE cid#1557479 COPY_INSTEAD_OF_MOVE cid#1557474 COPY_INSTEAD_OF_MOVE cid#1557461 COPY_INSTEAD_OF_MOVE cid#1557446 COPY_INSTEAD_OF_MOVE cid#1557445 COPY_INSTEAD_OF_MOVE cid#1557441 COPY_INSTEAD_OF_MOVE cid#1557435 COPY_INSTEAD_OF_MOVE cid#1557433 COPY_INSTEAD_OF_MOVE cid#1557429 COPY_INSTEAD_OF_MOVE cid#1557375 COPY_INSTEAD_OF_MOVE cid#1557372 COPY_INSTEAD_OF_MOVE cid#1557356 COPY_INSTEAD_OF_MOVE cid#1557350 COPY_INSTEAD_OF_MOVE cid#1557344 COPY_INSTEAD_OF_MOVE cid#1557339 COPY_INSTEAD_OF_MOVE cid#1557332 COPY_INSTEAD_OF_MOVE cid#1557330 COPY_INSTEAD_OF_MOVE cid#1557328 COPY_INSTEAD_OF_MOVE cid#1557323 COPY_INSTEAD_OF_MOVE cid#1557315 COPY_INSTEAD_OF_MOVE cid#1557313 COPY_INSTEAD_OF_MOVE cid#1557304 COPY_INSTEAD_OF_MOVE cid#1557297 COPY_INSTEAD_OF_MOVE cid#1557291 COPY_INSTEAD_OF_MOVE cid#1557290 COPY_INSTEAD_OF_MOVE cid#1557271 COPY_INSTEAD_OF_MOVE cid#1557266 COPY_INSTEAD_OF_MOVE cid#1557262 COPY_INSTEAD_OF_MOVE cid#1557259 COPY_INSTEAD_OF_MOVE cid#1557246 COPY_INSTEAD_OF_MOVE cid#1557242 COPY_INSTEAD_OF_MOVE cid#1557241 COPY_INSTEAD_OF_MOVE cid#1557236 COPY_INSTEAD_OF_MOVE cid#1557228 COPY_INSTEAD_OF_MOVE cid#1557225 COPY_INSTEAD_OF_MOVE cid#1557221 COPY_INSTEAD_OF_MOVE cid#1557217 COPY_INSTEAD_OF_MOVE cid#1557213 COPY_INSTEAD_OF_MOVE cid#1557211 COPY_INSTEAD_OF_MOVE cid#1557209 COPY_INSTEAD_OF_MOVE cid#1557205 COPY_INSTEAD_OF_MOVE cid#1557204 COPY_INSTEAD_OF_MOVE cid#1557193 COPY_INSTEAD_OF_MOVE cid#1556082 COPY_INSTEAD_OF_MOVE Change-Id: I07f195a79a69d4bac0d14317854efc88d6fe94d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-11cid#1558088 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1558080 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558055 COPY_INSTEAD_OF_MOVE cid#1558043 COPY_INSTEAD_OF_MOVE cid#1558039 COPY_INSTEAD_OF_MOVE cid#1558015 COPY_INSTEAD_OF_MOVE cid#1558014 COPY_INSTEAD_OF_MOVE cid#1558009 COPY_INSTEAD_OF_MOVE cid#1558002 COPY_INSTEAD_OF_MOVE cid#1557998 COPY_INSTEAD_OF_MOVE cid#1557996 COPY_INSTEAD_OF_MOVE cid#1557990 COPY_INSTEAD_OF_MOVE cid#1557986 COPY_INSTEAD_OF_MOVE cid#1557980 COPY_INSTEAD_OF_MOVE cid#1557971 COPY_INSTEAD_OF_MOVE cid#1557968 COPY_INSTEAD_OF_MOVE cid#1557967 COPY_INSTEAD_OF_MOVE cid#1557961 COPY_INSTEAD_OF_MOVE cid#1557959 COPY_INSTEAD_OF_MOVE cid#1557958 COPY_INSTEAD_OF_MOVE cid#1557956 COPY_INSTEAD_OF_MOVE cid#1557953 COPY_INSTEAD_OF_MOVE cid#1557949 COPY_INSTEAD_OF_MOVE cid#1557947 COPY_INSTEAD_OF_MOVE cid#1557940 COPY_INSTEAD_OF_MOVE cid#1557931 COPY_INSTEAD_OF_MOVE cid#1557930 COPY_INSTEAD_OF_MOVE cid#1557915 COPY_INSTEAD_OF_MOVE cid#1557913 COPY_INSTEAD_OF_MOVE cid#1557910 COPY_INSTEAD_OF_MOVE cid#1557886 COPY_INSTEAD_OF_MOVE cid#1557884 COPY_INSTEAD_OF_MOVE cid#1557880 COPY_INSTEAD_OF_MOVE cid#1557875 COPY_INSTEAD_OF_MOVE cid#1557871 COPY_INSTEAD_OF_MOVE cid#1557862 COPY_INSTEAD_OF_MOVE cid#1557847 COPY_INSTEAD_OF_MOVE cid#1557845 COPY_INSTEAD_OF_MOVE cid#1557844 COPY_INSTEAD_OF_MOVE cid#1557843 COPY_INSTEAD_OF_MOVE cid#1557838 COPY_INSTEAD_OF_MOVE cid#1557835 COPY_INSTEAD_OF_MOVE cid#1557834 COPY_INSTEAD_OF_MOVE cid#1557828 COPY_INSTEAD_OF_MOVE cid#1557823 COPY_INSTEAD_OF_MOVE cid#1557817 COPY_INSTEAD_OF_MOVE cid#1557813 COPY_INSTEAD_OF_MOVE cid#1557812 COPY_INSTEAD_OF_MOVE Change-Id: I55d4a920daa2d148683419169eb828325fd3c757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171732 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-08cid#1607356 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607117 COPY_INSTEAD_OF_MOVE cid#1607089 COPY_INSTEAD_OF_MOVE cid#1606977 COPY_INSTEAD_OF_MOVE cid#1606899 COPY_INSTEAD_OF_MOVE cid#1606785 COPY_INSTEAD_OF_MOVE cid#1606769 COPY_INSTEAD_OF_MOVE cid#1606740 COPY_INSTEAD_OF_MOVE cid#1606738 COPY_INSTEAD_OF_MOVE cid#1606675 COPY_INSTEAD_OF_MOVE cid#1606533 COPY_INSTEAD_OF_MOVE cid#1558100 COPY_INSTEAD_OF_MOVE cid#1558098 COPY_INSTEAD_OF_MOVE cid#1558083 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558074 COPY_INSTEAD_OF_MOVE Change-Id: Ica17dec2c2102ef85283fd883a0a4e64aec307c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171620 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-07cid#1557545 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557556 COPY_INSTEAD_OF_MOVE cid#1557583 COPY_INSTEAD_OF_MOVE cid#1557587 COPY_INSTEAD_OF_MOVE cid#1557591 COPY_INSTEAD_OF_MOVE cid#1557598 COPY_INSTEAD_OF_MOVE cid#1557600 COPY_INSTEAD_OF_MOVE cid#1557653 COPY_INSTEAD_OF_MOVE Change-Id: I050bed7c088678e1d767d6edbe656eab2aee235d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06cid#1555415 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555497 COPY_INSTEAD_OF_MOVE cid#1555542 COPY_INSTEAD_OF_MOVE cid#1555543 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555693 COPY_INSTEAD_OF_MOVE cid#1555719 COPY_INSTEAD_OF_MOVE cid#1555757 COPY_INSTEAD_OF_MOVE cid#1555795 COPY_INSTEAD_OF_MOVE cid#1555826 COPY_INSTEAD_OF_MOVE cid#1555847 COPY_INSTEAD_OF_MOVE cid#1555851 COPY_INSTEAD_OF_MOVE cid#1555863 COPY_INSTEAD_OF_MOVE cid#1555865 COPY_INSTEAD_OF_MOVE cid#1555867 COPY_INSTEAD_OF_MOVE cid#1555869 COPY_INSTEAD_OF_MOVE cid#1555879 COPY_INSTEAD_OF_MOVE cid#1555890 COPY_INSTEAD_OF_MOVE cid#1555893 COPY_INSTEAD_OF_MOVE cid#1555900 COPY_INSTEAD_OF_MOVE cid#1555922 COPY_INSTEAD_OF_MOVE cid#1555925 COPY_INSTEAD_OF_MOVE Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-04tdf#82716 Implement Correct Calculation for Histogram Chartvarshneydevansh
- Add Scott's rule for bin width calculation - Correct upper and lower limit for the Bin Range in the X-Axis This commit introduces Scott's Reference Rule as we are currently using the sqrt for histogram calculation, improving bin width determination and overall histogram accuracy. Change-Id: I4a430416e365781ebef8b1e0872dd4ed50492b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170526 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-07-31cid#1555587 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555589 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555596 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555608 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555620 COPY_INSTEAD_OF_MOVE cid#1555623 COPY_INSTEAD_OF_MOVE cid#1555625 COPY_INSTEAD_OF_MOVE cid#1555626 COPY_INSTEAD_OF_MOVE cid#1555634 COPY_INSTEAD_OF_MOVE cid#1555638 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555682 COPY_INSTEAD_OF_MOVE cid#1555686 COPY_INSTEAD_OF_MOVE cid#1555702 COPY_INSTEAD_OF_MOVE cid#1555710 COPY_INSTEAD_OF_MOVE cid#1555750 COPY_INSTEAD_OF_MOVE cid#1555752 COPY_INSTEAD_OF_MOVE cid#1555761 COPY_INSTEAD_OF_MOVE cid#1555762 COPY_INSTEAD_OF_MOVE cid#1555771 COPY_INSTEAD_OF_MOVE cid#1555772 COPY_INSTEAD_OF_MOVE cid#1555784 COPY_INSTEAD_OF_MOVE cid#1555785 COPY_INSTEAD_OF_MOVE Change-Id: Ib9724230c05b2027b4edf64e6a0bb5e22a270a88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-31cid#1555417 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555423 COPY_INSTEAD_OF_MOVE cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555436 COPY_INSTEAD_OF_MOVE cid#1555440 COPY_INSTEAD_OF_MOVE cid#1555443 COPY_INSTEAD_OF_MOVE cid#1555454 COPY_INSTEAD_OF_MOVE cid#1555459 COPY_INSTEAD_OF_MOVE cid#1555461 COPY_INSTEAD_OF_MOVE cid#1555468 COPY_INSTEAD_OF_MOVE cid#1555477 COPY_INSTEAD_OF_MOVE cid#1555484 COPY_INSTEAD_OF_MOVE cid#1555511 COPY_INSTEAD_OF_MOVE cid#1555515 COPY_INSTEAD_OF_MOVE cid#1555519 COPY_INSTEAD_OF_MOVE cid#1555534 COPY_INSTEAD_OF_MOVE cid#1555537 COPY_INSTEAD_OF_MOVE cid#1555544 COPY_INSTEAD_OF_MOVE cid#1555553 COPY_INSTEAD_OF_MOVE cid#1555559 COPY_INSTEAD_OF_MOVE cid#1555561 COPY_INSTEAD_OF_MOVE cid#1555563 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555568 COPY_INSTEAD_OF_MOVE cid#1555571 COPY_INSTEAD_OF_MOVE cid#1555580 COPY_INSTEAD_OF_MOVE Change-Id: Ia42a78bffddc80d0e82144f4db51dc6e4d2e9a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29Prevent rtl::Reference -> css::uno::Reference -> rtl::Reference implicit pathMike Kaganski
Replace up-casting conversion constructor with respective conversion operator, similar to existing css::uno::Reference conversion operator. Thic change will not allow code like rtl::Reference<Foo> foo; rtl::Reference<Foo> bar(foo, uno::UNO_QUERY_THROW); which was possible because compiler could use temporary css::uno::Reference. Change-Id: I54b79af3e2508b26e9cd59f2cc7e2ae92f6efbbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171166 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-29tdf#161090 - Spec how many / which values are in remainder of-Pie chartKurt Nordback
This commit moves bar-of-pie and pie-of-pie chart types into a separate line in the chart type selection UI from 'plain' pie chart types. This allows for separate UI controls, including a spin button added in this commit for of-pie types to specify the number of entries to be included in the composite wedge and broken out in the right-hand subchart. Per discussion in this and related bugs, this may not be the long-term best approach for specifying which entries go into the composite, and it still only allows for the last entries in the composite. But it is a step towards allowing greater control. I've also changed the default number in the composite from 3 to 2, to better match MSO. I/O of the 'number in the composite wedge' parameter is not included in this commit. Implementing that for ODF and OOXML perhaps should be a separate bug or bugs. Change-Id: If4afc1417ea94c15e86a9a4dfe967a6f8ecb7ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168690 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-07-26tdf#162136: fix crash when formatting data series in Histogram chartJulien Nabet
Change-Id: Idc05b82363eca3066b291f05a7e05be4996d28a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171065 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-25Related tdf#162136: typo GapWidthSequence instead of GapwidthSequenceJulien Nabet
Fixes the crash with bt: 8 0x00007fd839b91fef in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=0x5578a9fb8b08, nHandle=-1) at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:553 9 0x00007fd839b8e1c9 in cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&) (this=0x5578a9fb8b08, rPropertyName="GapwidthSequence") at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:277 10 0x00007fd7ef4e19e5 in chart::wrapper::SeriesOptionsItemConverter::ApplySpecialItem(unsigned short, SfxItemSet const&) (this=0x5578a3989070, nWhichId=77, rItemSet=SfxItemSet of pool 0x5578a9fde810 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx:212 11 0x00007fd7ef4d3939 in chart::wrapper::ItemConverter::ApplyItemSet(SfxItemSet const&) (this=0x5578a3989070, rItemSet=SfxItemSet of pool 0x5578a9fde810 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/ItemConverter.cxx:186 12 0x00007fd7ef4ba805 in chart::wrapper::DataPointItemConverter::ApplyItemSet(SfxItemSet const&) (this=0x5578a3767050, rItemSet=SfxItemSet of pool 0x5578a9fde810 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx:291 13 0x00007fd7ef532167 in chart::ChartController::executeDlg_ObjectProperties_withUndoGuard(std::shared_ptr<chart::UndoGuard>, rtl::OUString const&, bool)::$_0::operator()(int) const (this=0x5578a3916fb0, nResult=1) at /home/julien/lo/libreoffice/chart2/source/controller/main/ChartController_Properties.cxx:801 but not the following one: 8 0x00007f06e6d91fef in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=0x561ec293bb88, nHandle=-1) at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:553 9 0x00007f06e6d8e1c9 in cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&) (this=0x561ec293bb88, rPropertyName="OverlapSequence") at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:277 10 0x00007f06a4ce19e5 in chart::wrapper::SeriesOptionsItemConverter::ApplySpecialItem(unsigned short, SfxItemSet const&) (this=0x561ebb729a90, nWhichId=76, rItemSet=SfxItemSet of pool 0x561ec2921fb0 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx:212 11 0x00007f06a4cd3939 in chart::wrapper::ItemConverter::ApplyItemSet(SfxItemSet const&) (this=0x561ebb729a90, rItemSet=SfxItemSet of pool 0x561ec2921fb0 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/ItemConverter.cxx:186 12 0x00007f06a4cba805 in chart::wrapper::DataPointItemConverter::ApplyItemSet(SfxItemSet const&) (this=0x561ebc2cdd90, rItemSet=SfxItemSet of pool 0x561ec2921fb0 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx:291 13 0x00007f06a4d32167 in chart::ChartController::executeDlg_ObjectProperties_withUndoGuard(std::shared_ptr<chart::UndoGuard>, rtl::OUString const&, bool)::$_0::operator()(int) const (this=0x561ec2939c20, nResult=1) at /home/julien/lo/libreoffice/chart2/source/controller/main/ChartController_Properties.cxx:801 Change-Id: I53d8f9130a0a6cc17214c881398a6679a92606cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170902 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-07-24cid#1556131 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556135 COPY_INSTEAD_OF_MOVE cid#1556146 COPY_INSTEAD_OF_MOVE cid#1556164 COPY_INSTEAD_OF_MOVE cid#1556171 COPY_INSTEAD_OF_MOVE cid#1556177 COPY_INSTEAD_OF_MOVE cid#1556181 COPY_INSTEAD_OF_MOVE cid#1556182 COPY_INSTEAD_OF_MOVE cid#1556183 COPY_INSTEAD_OF_MOVE cid#1556192 COPY_INSTEAD_OF_MOVE cid#1556201 COPY_INSTEAD_OF_MOVE cid#1556208 COPY_INSTEAD_OF_MOVE cid#1556215 COPY_INSTEAD_OF_MOVE cid#1556224 COPY_INSTEAD_OF_MOVE cid#1556227 COPY_INSTEAD_OF_MOVE cid#1556228 COPY_INSTEAD_OF_MOVE cid#1556238 COPY_INSTEAD_OF_MOVE cid#1556246 COPY_INSTEAD_OF_MOVE cid#1556247 COPY_INSTEAD_OF_MOVE cid#1556288 COPY_INSTEAD_OF_MOVE cid#1556293 COPY_INSTEAD_OF_MOVE cid#1556305 COPY_INSTEAD_OF_MOVE cid#1556310 COPY_INSTEAD_OF_MOVE cid#1556317 COPY_INSTEAD_OF_MOVE cid#1556321 COPY_INSTEAD_OF_MOVE cid#1556322 COPY_INSTEAD_OF_MOVE cid#1556331 COPY_INSTEAD_OF_MOVE cid#1556339 COPY_INSTEAD_OF_MOVE cid#1556342 COPY_INSTEAD_OF_MOVE cid#1556351 COPY_INSTEAD_OF_MOVE cid#1556358 COPY_INSTEAD_OF_MOVE cid#1556370 COPY_INSTEAD_OF_MOVE cid#1556379 COPY_INSTEAD_OF_MOVE cid#1556390 COPY_INSTEAD_OF_MOVE cid#1556423 COPY_INSTEAD_OF_MOVE cid#1556532 COPY_INSTEAD_OF_MOVE cid#1556561 COPY_INSTEAD_OF_MOVE cid#1556662 COPY_INSTEAD_OF_MOVE cid#1556704 COPY_INSTEAD_OF_MOVE cid#1556730 COPY_INSTEAD_OF_MOVE cid#1556988 COPY_INSTEAD_OF_MOVE cid#1557071 COPY_INSTEAD_OF_MOVE cid#1557081 COPY_INSTEAD_OF_MOVE cid#1557177 COPY_INSTEAD_OF_MOVE Change-Id: I2c723f0fe9a4eefa62a68f47049ed690d06eb0ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-23cid#1555167 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555172 COPY_INSTEAD_OF_MOVE cid#1555184 COPY_INSTEAD_OF_MOVE cid#1555188 COPY_INSTEAD_OF_MOVE cid#1555197 COPY_INSTEAD_OF_MOVE cid#1555209 COPY_INSTEAD_OF_MOVE cid#1555211 COPY_INSTEAD_OF_MOVE cid#1555215 COPY_INSTEAD_OF_MOVE cid#1555216 COPY_INSTEAD_OF_MOVE cid#1555217 COPY_INSTEAD_OF_MOVE cid#1555218 COPY_INSTEAD_OF_MOVE cid#1555222 COPY_INSTEAD_OF_MOVE cid#1556674 COPY_INSTEAD_OF_MOVE cid#1555229 COPY_INSTEAD_OF_MOVE cid#1555233 COPY_INSTEAD_OF_MOVE cid#1555234 COPY_INSTEAD_OF_MOVE cid#1555242 COPY_INSTEAD_OF_MOVE cid#1555250 COPY_INSTEAD_OF_MOVE cid#1555251 COPY_INSTEAD_OF_MOVE cid#1555254 COPY_INSTEAD_OF_MOVE cid#1555304 COPY_INSTEAD_OF_MOVE cid#1555307 COPY_INSTEAD_OF_MOVE cid#1555317 COPY_INSTEAD_OF_MOVE cid#1555329 COPY_INSTEAD_OF_MOVE cid#1555340 COPY_INSTEAD_OF_MOVE cid#1555347 COPY_INSTEAD_OF_MOVE cid#1555352 COPY_INSTEAD_OF_MOVE cid#1555358 COPY_INSTEAD_OF_MOVE cid#1555363 COPY_INSTEAD_OF_MOVE cid#1555365 COPY_INSTEAD_OF_MOVE cid#1555367 COPY_INSTEAD_OF_MOVE cid#1555374 COPY_INSTEAD_OF_MOVE cid#1555380 COPY_INSTEAD_OF_MOVE Change-Id: I343194c10749488a1143e2517ee0638ab19da218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-22cid#1608424 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607592 COPY_INSTEAD_OF_MOVE cid#1607487 COPY_INSTEAD_OF_MOVE cid#1607480 COPY_INSTEAD_OF_MOVE cid#1607444 COPY_INSTEAD_OF_MOVE cid#1607369 COPY_INSTEAD_OF_MOVE cid#1607356 COPY_INSTEAD_OF_MOVE cid#1607342 COPY_INSTEAD_OF_MOVE cid#1607329 COPY_INSTEAD_OF_MOVE cid#1607327 COPY_INSTEAD_OF_MOVE cid#1607303 COPY_INSTEAD_OF_MOVE cid#1607284 COPY_INSTEAD_OF_MOVE Change-Id: Ia2d5d4e2de8ca96a9557df5266754e52efa4f60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170826 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-21Remove duplicated includeAndrea Gelmini
Change-Id: Ie0ab653d1301b6cc401738fb35e51f49b4e526ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170811 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-07-21tdf#82716 Add initial implementation of the Histogram Chartvarshneydevansh
- Add the Histogram selection to the UI - Histogram bars showing with No Gap - Convert X and Y axis to group data into bins and frequency - Adjusted failing UI test (tdf138556) as a new chart type was added Change-Id: Id1f161adac943ead5e17c7fbb7e14c9ab7f1655e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167068 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-07-20cid#1554791 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554819 COPY_INSTEAD_OF_MOVE cid#1554837 COPY_INSTEAD_OF_MOVE cid#1554881 COPY_INSTEAD_OF_MOVE cid#1554882 COPY_INSTEAD_OF_MOVE cid#1554884 COPY_INSTEAD_OF_MOVE cid#1554891 COPY_INSTEAD_OF_MOVE cid#1554892 COPY_INSTEAD_OF_MOVE cid#1554897 COPY_INSTEAD_OF_MOVE cid#1554904 COPY_INSTEAD_OF_MOVE cid#1554918 COPY_INSTEAD_OF_MOVE cid#1554928 COPY_INSTEAD_OF_MOVE cid#1554931 COPY_INSTEAD_OF_MOVE cid#1554944 COPY_INSTEAD_OF_MOVE cid#1554945 COPY_INSTEAD_OF_MOVE cid#1554959 COPY_INSTEAD_OF_MOVE cid#1554960 COPY_INSTEAD_OF_MOVE cid#1554963 COPY_INSTEAD_OF_MOVE cid#1554966 COPY_INSTEAD_OF_MOVE cid#1554969 COPY_INSTEAD_OF_MOVE cid#1554973 COPY_INSTEAD_OF_MOVE cid#1555011 COPY_INSTEAD_OF_MOVE cid#1555012 COPY_INSTEAD_OF_MOVE cid#1555015 COPY_INSTEAD_OF_MOVE cid#1555044 COPY_INSTEAD_OF_MOVE cid#1555051 COPY_INSTEAD_OF_MOVE cid#1555055 COPY_INSTEAD_OF_MOVE cid#1555063 COPY_INSTEAD_OF_MOVE cid#1555068 COPY_INSTEAD_OF_MOVE cid#1555073 COPY_INSTEAD_OF_MOVE cid#1555074 COPY_INSTEAD_OF_MOVE cid#1555078 COPY_INSTEAD_OF_MOVE cid#1555080 COPY_INSTEAD_OF_MOVE cid#1555091 COPY_INSTEAD_OF_MOVE cid#1555099 COPY_INSTEAD_OF_MOVE cid#1555101 COPY_INSTEAD_OF_MOVE cid#1555121 COPY_INSTEAD_OF_MOVE cid#1610739 COPY_INSTEAD_OF_MOVE cid#1608424 COPY_INSTEAD_OF_MOVE cid#1608059 COPY_INSTEAD_OF_MOVE cid#1607952 COPY_INSTEAD_OF_MOVE cid#1607653 COPY_INSTEAD_OF_MOVE cid#1607614 COPY_INSTEAD_OF_MOVE cid#1607592 COPY_INSTEAD_OF_MOVE Change-Id: Ie9f922a9fe1b8001dfab31e2741fe8bd5558e442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-17Resolves: tdf#158753 GtkAssistant loses current page on hide+showCaolán McNamara
gtk_assistant_unmap ... { ... priv->current_page = NULL; ... } gtk_assistant_map { page_num = 0; ... set_current_page (assistant, page_num) ... } It doesn't automatically restore itself to the page it was on when it was hidden, so do that explicitly. Change-Id: If23b255193c4a65b286e036c8796d9d8a2ffcb5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170611 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins