summaryrefslogtreecommitdiff
path: root/chart2/source
AgeCommit message (Collapse)Author
2017-03-25Fix typosAndrea Gelmini
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e Reviewed-on: https://gerrit.libreoffice.org/35617 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24fix for regression from 522e9c65: dont make all charts disappearBjoern Michaelsen
Change-Id: Ica8a8c8cfd1f0743c4ad9421f3cac9aa92645838 Reviewed-on: https://gerrit.libreoffice.org/35650 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-24when getting the naked VCL Window from UNO: hold the solar mutexBjoern Michaelsen
Change-Id: Ia3513d67e09cdc9748a24aeffce0ec59cab30cc9 Also: fix some obvious violations of the above. Reviewed-on: https://gerrit.libreoffice.org/35605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-24UNO objects should never hold a VclPtr they dont own on heap ...Bjoern Michaelsen
... so admit that the VclPtr that ChartController used to have is really owned by m_xViewWindow, and get fetch that (stack-scoped only) from there. Change-Id: Ib9e2cd20201ebe5019c3607a8c65cb1a9856812f Reviewed-on: https://gerrit.libreoffice.org/35603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they dont even need it. Change-Id: If9d00da3110328d88e832f12b8717a93f91393aa Reviewed-on: https://gerrit.libreoffice.org/35602 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they tend try to own our private parts. Lets be honest here. Also remove pointless repeated private:s. Change-Id: Idaa7621fbe812ef25f13bba1882a16cca4de9d61 Reviewed-on: https://gerrit.libreoffice.org/35600 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they tend try to own our private parts. Lets be honest here. Also remove pointless dynamic_casts. Change-Id: Ie6ef8a0c07a72aaa15e374e5ec6841520c0fafb1 Reviewed-on: https://gerrit.libreoffice.org/35599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typosAndrea Gelmini
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085 Reviewed-on: https://gerrit.libreoffice.org/35413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17cleanup itempool includesJochen Nitschke
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10 Reviewed-on: https://gerrit.libreoffice.org/35313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-16remove unused defines from HRC files in chart2Noel Grandin
Change-Id: I8ce5b900353034c4ad1424375bed0ea0c9db36b1 Reviewed-on: https://gerrit.libreoffice.org/35255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14Revert "loplugin:implicitboolconversion"Tor Lillqvist
This is not needed; the problem was in the Fedora 25 epoxy headers: They got badly broken in an update, and should not be used from C++ code. If you use Fedora 25, make sure to use --without-system-epoxy for now. See https://bugzilla.redhat.com/show_bug.cgi?id=1431994 This reverts commit cbb2e6b76868d5c67a713b68310b44be59bfab3e. Change-Id: I55c77ff279f1716004ac77cd3a08c4bb3fdf644b
2017-03-14loplugin:implicitboolconversionTor Lillqvist
For some reason this was not detected earlier, but now when the epoxy headers in f25 were updated, it is. Change-Id: I7be830153792414b0f913aaaecb2a1336ebf6fce
2017-03-13cppcheck: unsignedLessThanZeroJochen Nitschke
some stuff cppcheck missed in this file. plus use empty() and front() Change-Id: I612078d503c555afd681526f95d17502ffd585ba Reviewed-on: https://gerrit.libreoffice.org/35094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-12cppcheck: unsignedLessThanZeroJulien Nabet
Change-Id: I5c41c06f9bfa6c23a6984d2f7f5b118a13065da9 Reviewed-on: https://gerrit.libreoffice.org/35088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-05Revert "tdf#99352: ensure ChartController is disposing its VclPtrs on DeInitVCL"Markus Mohrhard
The original patch crashes charts on disposing, e.g. during the UI testing. This reverts commit 926c0d73e82bb1d5644c49fb95c56e241b6c8f34. Change-Id: I93cb5c41e3705a487d2547b55eac761c6952049c Reviewed-on: https://gerrit.libreoffice.org/34900 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03tdf#99352: ensure ChartController is disposing its VclPtrs on DeInitVCLBjoern Michaelsen
Change-Id: I46851debe8a0bdc1ff871ee9ba34ca41f89b844b Reviewed-on: https://gerrit.libreoffice.org/34841 Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524 Reviewed-on: https://gerrit.libreoffice.org/34808 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27chart: use c++11 for-statement in VSeriesPlotterTomaž Vajngerl
This makes the code much more readable.. Change-Id: Ic9078daffeba28984749c61d059701b3cdcca8bd Reviewed-on: https://gerrit.libreoffice.org/34687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-24makeAny->Any in cppuhelper..cuiNoel Grandin
Change-Id: Ia54e6e9b71df68bd04c304a0bb02da8ebac74420 Reviewed-on: https://gerrit.libreoffice.org/34603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: chart2Stephan Bergmann
Change-Id: I9012f97b188195140504dacb262c212d46df675a
2017-02-20SvNumberFormatter::GetType() does not include NumberFormat::DEFINEDEike Rathke
... so masking it out is unnecessary. Change-Id: I4b25ced640f9287c4db52a6257020fce4e4c1303
2017-02-20cppcheck: redundantAssignmentJochen Nitschke
since commit ce92b5da976122a9120fbb499f7a823ed67a4d01 Change-Id: I27b4c8337ad229c2ad93e294c9159baa3c2567b8 Reviewed-on: https://gerrit.libreoffice.org/34439 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17convert StackMode to scoped enumNoel Grandin
and drop unused AMBIGUOUS enumerator Change-Id: I71954d75a64928061c0e520beb47f979c53ee5a8
2017-02-17drop enum NormalAxisNoel Grandin
since we only ever use the Z enumerator Change-Id: Ia162a6be650704649f5232fff0fa229c7b346450
2017-02-17convert PropertyType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I61d2a46ed84ce4163757a2da58162c72b1b0950f
2017-02-17convert GraphicObjectType to scoped enumNoel Grandin
and drop unused FILL_PROPERTIES enumerator Change-Id: I302d9d1d997c4fc491f7950b220060740f831539
2017-02-17convert AccessibleBase::EventType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I1ce08b16d587edcaee214b40798fe53fa3fc7923
2017-02-17drop TimeBasedMode enumNoel Grandin
since we only ever use the AUTOMATIC enumerator Change-Id: I1370bf30ea31d0631e56524638ee843f18583933
2017-02-15Drop :: prefix from std in c*/Tor Lillqvist
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-13chart2: remove unneeded includesTomaž Vajngerl
Change-Id: I49e15f57e8eddb53dbf4d1b7ddbf6d33fed116f2 Reviewed-on: https://gerrit.libreoffice.org/34172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-13-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I5251e187e4923c05795a993194375f509c909e05
2017-02-12chart2: simplify and/or clean-up and c++11 featuresTomaž Vajngerl
Change-Id: I4550d04ae4bf6e45f24e34dfb2babc0fdef8ba5a Reviewed-on: https://gerrit.libreoffice.org/34006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12[API CHANGE] Add PopupRequest - a callback to open a pop-up win. in calcTomaž Vajngerl
Change-Id: Iea600e229deb69d1638a1a649008fc4738a5934a Reviewed-on: https://gerrit.libreoffice.org/34005 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12chart2: layout buttons in charts when data is presentTomaž Vajngerl
This commit layouts the buttons in the chart when there is data present. Currently this never shows them as other infrastructure needs to be present to get the PT data. Change-Id: If33c726eb057b2b938ccb3c00f0d5b671416f355 Reviewed-on: https://gerrit.libreoffice.org/34004 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12chart2: simple button (view) to add to a chartTomaž Vajngerl
Change-Id: I2001efe1e7eb9e92edb8f5e78535cea0e78935ad Reviewed-on: https://gerrit.libreoffice.org/34003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12Various typos about propertyJulien Nabet
Change-Id: I7585a1346fb19a886240db8dd393554efee862cc Reviewed-on: https://gerrit.libreoffice.org/34174 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12"Unicode" is a proper noun and should not be used in pluralTor Lillqvist
The 16-bit things that make up the UTF-16 encoding are called "code units". Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
2017-02-08The string "###" can be written as such, no need for a Special Const VariableTor Lillqvist
Change-Id: Ib9737acc8e0a9845fc03ed2c7de7969cef41f27c
2017-02-08A newline is not that special or hard to rememberTor Lillqvist
Change-Id: I2960a59283a5a04c5c804a57e43bdb633c0e45cf
2017-02-08remove unused SCHATTR_DIAGRAM_STYLENoel Grandin
and associated SvxChartStyleItem and SvxChartStyle Change-Id: I1564a4583125dd32af71e4eff338dfcefc6517c4 Reviewed-on: https://gerrit.libreoffice.org/33988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07fix oss-fuzz buildCaolán McNamara
Change-Id: I0e292bcca27035b316bcf0c93dbd6c87e3f93e3b
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06OpenGLWindow typeinfo unavailable without HAVE_FEATURE_OPENGLCaolán McNamara
Change-Id: Ie06c1121502db9b1a869f657f70d3b45db610e2f
generated by cgit (git 2.34.1) at 2025-02-03 22:29:50 +0000