summaryrefslogtreecommitdiff
path: root/chart2/source
AgeCommit message (Collapse)Author
2017-04-16cppcheck: arrayIndexThenCheckJulien Nabet
Change-Id: Ie3ca646fae94ff5a06a29fc2823a1cacafc3deb1 Reviewed-on: https://gerrit.libreoffice.org/36575 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-15Fix typosAndrea Gelmini
Change-Id: I0238202c0dc0380b0e33a9c4567a9513c0afbe91 Reviewed-on: https://gerrit.libreoffice.org/36556 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: chart2Stephan Bergmann
Change-Id: I21dd484a2d337d16f59d5a747afaee230a1e7c89
2017-04-06loplugin:useuniqueptrStephan Bergmann
Change-Id: I33aafc7351c5fdc2c677d0be123f666211255ccb
2017-04-06loplugin:redundantcast check for c-style float castsNoel Grandin
Change-Id: I86b6f58887cb398a80698f8d8564b5bc3f55eabb Reviewed-on: https://gerrit.libreoffice.org/36198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:useuniqueptr extend to catch more localvar casesNoel Grandin
i.e. where the code looks like { foo * p = new foo; ... delete p; return ...; } Change-Id: Id5f2e55d0363fc62c72535a23faeaaf1f0ac6aee Reviewed-on: https://gerrit.libreoffice.org/36190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:redundantcast find cstyle double castsNoel Grandin
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8 Reviewed-on: https://gerrit.libreoffice.org/36187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:redundantcast find c-style bool castsNoel Grandin
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04tdf#83257 [API-CHANGE] Pivot chart implementationTomaž Vajngerl
This is a squashed commit of the pivot chart implementation. Some of the changes: - Add pivot chart specific (pivot table) data provider which provides the data from a pivot table to the associated chart. - When inserting a chart and the cursor is in a pivot table, in that case insert a pivot chart - Modify the pivot chart when the pivot table changes - Collect and set the number format for the values - isDataFromSpreadsheet check for the creation wizard - In ChartView (and VLegend) check if the data provider is a pivot chart data provider and get the pivot table field names to create the buttons on the UI. - Adds the functionallity to show a filter pop-up (from calc) when clicking on row / column / page field buttons. - Remove (X)PopupRequest as we won't need it. - Add ODF import/export for pivot charts: + Added loext:data-pilot-source attribute on chart:chart which is the internal name of the pivot table with which the pivot chart is associated with. If the element is present, then the it means the chart is a pivot chart, else it is a normal chart + Added service to create pivot chart data provider through UNO + Add new methods to XPivotChartDataProvider to create value and label data sequences separately from the data source, which is needed for pivot chart import + When importing defer setting the data provider until a later time when we know if we are creating a chart od a pivot chart - Pivot chart ODF round-trip test - Add table pivot chart supplier API: This adds the XTablePivotChartSupplier and related interfaces so we can access, create, delete pivot charts from UNO in a sheet document. With this we now distinguish between normal charts and pivot charts. This was mainly needed because we can't extend the "published" interfaces of TableChartSupplier. - Added an extensive test, which uses the API to create a new pivot chart when there was none, and checks that the pivot chart updates when the pivot table updates. Change-Id: Ia9ed96fd6b1d342e61c2f7f9fa33a5e03dda21af Reviewed-on: https://gerrit.libreoffice.org/36023 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-02coverity#1403662 Mixing enum typesCaolán McNamara
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947 Reviewed-on: https://gerrit.libreoffice.org/36020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-31use actual UNO enums in chart2Noel Grandin
Change-Id: I05d4eed55f5deba4b1802389d1ba94582d30550f Reviewed-on: https://gerrit.libreoffice.org/35917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28it makes no sense for CC to leak resources when its unaware of modelBjoern Michaelsen
- if the UNO_QUERY_THROW cast throws, this skips all of the disposing (and thus leaks) - the whole try-catch-ignore case has been there since early c6b95527 - even in that commit message, no sane justification has been given - apparently the try-block was Java-style "catch exceptions until it runs" cargo-cult - this change is still the more conservative change: probably the whole try-catch framing should be removed Change-Id: Ie3a71e48eb056afd8a844e19898dc1555de4297e Reviewed-on: https://gerrit.libreoffice.org/35690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-26Remove obsolete codeBjoern Michaelsen
now that the ChartController doesnt own the VCL window anymore. Change-Id: I2fefa73181a61b2a7828b36e70480b59aa7838f4 Reviewed-on: https://gerrit.libreoffice.org/35640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e Reviewed-on: https://gerrit.libreoffice.org/35617 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24fix for regression from 522e9c65: dont make all charts disappearBjoern Michaelsen
Change-Id: Ica8a8c8cfd1f0743c4ad9421f3cac9aa92645838 Reviewed-on: https://gerrit.libreoffice.org/35650 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-24when getting the naked VCL Window from UNO: hold the solar mutexBjoern Michaelsen
Change-Id: Ia3513d67e09cdc9748a24aeffce0ec59cab30cc9 Also: fix some obvious violations of the above. Reviewed-on: https://gerrit.libreoffice.org/35605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-24UNO objects should never hold a VclPtr they dont own on heap ...Bjoern Michaelsen
... so admit that the VclPtr that ChartController used to have is really owned by m_xViewWindow, and get fetch that (stack-scoped only) from there. Change-Id: Ib9e2cd20201ebe5019c3607a8c65cb1a9856812f Reviewed-on: https://gerrit.libreoffice.org/35603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they dont even need it. Change-Id: If9d00da3110328d88e832f12b8717a93f91393aa Reviewed-on: https://gerrit.libreoffice.org/35602 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they tend try to own our private parts. Lets be honest here. Also remove pointless repeated private:s. Change-Id: Idaa7621fbe812ef25f13bba1882a16cca4de9d61 Reviewed-on: https://gerrit.libreoffice.org/35600 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23Lets not call 1/2 of everyone we know friend...Bjoern Michaelsen
...esp. when they tend try to own our private parts. Lets be honest here. Also remove pointless dynamic_casts. Change-Id: Ie6ef8a0c07a72aaa15e374e5ec6841520c0fafb1 Reviewed-on: https://gerrit.libreoffice.org/35599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typosAndrea Gelmini
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085 Reviewed-on: https://gerrit.libreoffice.org/35413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17cleanup itempool includesJochen Nitschke
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10 Reviewed-on: https://gerrit.libreoffice.org/35313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-16remove unused defines from HRC files in chart2Noel Grandin
Change-Id: I8ce5b900353034c4ad1424375bed0ea0c9db36b1 Reviewed-on: https://gerrit.libreoffice.org/35255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14Revert "loplugin:implicitboolconversion"Tor Lillqvist
This is not needed; the problem was in the Fedora 25 epoxy headers: They got badly broken in an update, and should not be used from C++ code. If you use Fedora 25, make sure to use --without-system-epoxy for now. See https://bugzilla.redhat.com/show_bug.cgi?id=1431994 This reverts commit cbb2e6b76868d5c67a713b68310b44be59bfab3e. Change-Id: I55c77ff279f1716004ac77cd3a08c4bb3fdf644b
2017-03-14loplugin:implicitboolconversionTor Lillqvist
For some reason this was not detected earlier, but now when the epoxy headers in f25 were updated, it is. Change-Id: I7be830153792414b0f913aaaecb2a1336ebf6fce
2017-03-13cppcheck: unsignedLessThanZeroJochen Nitschke
some stuff cppcheck missed in this file. plus use empty() and front() Change-Id: I612078d503c555afd681526f95d17502ffd585ba Reviewed-on: https://gerrit.libreoffice.org/35094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-12cppcheck: unsignedLessThanZeroJulien Nabet
Change-Id: I5c41c06f9bfa6c23a6984d2f7f5b118a13065da9 Reviewed-on: https://gerrit.libreoffice.org/35088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-05Revert "tdf#99352: ensure ChartController is disposing its VclPtrs on DeInitVCL"Markus Mohrhard
The original patch crashes charts on disposing, e.g. during the UI testing. This reverts commit 926c0d73e82bb1d5644c49fb95c56e241b6c8f34. Change-Id: I93cb5c41e3705a487d2547b55eac761c6952049c Reviewed-on: https://gerrit.libreoffice.org/34900 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03tdf#99352: ensure ChartController is disposing its VclPtrs on DeInitVCLBjoern Michaelsen
Change-Id: I46851debe8a0bdc1ff871ee9ba34ca41f89b844b Reviewed-on: https://gerrit.libreoffice.org/34841 Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524 Reviewed-on: https://gerrit.libreoffice.org/34808 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27chart: use c++11 for-statement in VSeriesPlotterTomaž Vajngerl
This makes the code much more readable.. Change-Id: Ic9078daffeba28984749c61d059701b3cdcca8bd Reviewed-on: https://gerrit.libreoffice.org/34687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-24makeAny->Any in cppuhelper..cuiNoel Grandin
Change-Id: Ia54e6e9b71df68bd04c304a0bb02da8ebac74420 Reviewed-on: https://gerrit.libreoffice.org/34603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: chart2Stephan Bergmann
Change-Id: I9012f97b188195140504dacb262c212d46df675a
2017-02-20SvNumberFormatter::GetType() does not include NumberFormat::DEFINEDEike Rathke
... so masking it out is unnecessary. Change-Id: I4b25ced640f9287c4db52a6257020fce4e4c1303
2017-02-20cppcheck: redundantAssignmentJochen Nitschke
since commit ce92b5da976122a9120fbb499f7a823ed67a4d01 Change-Id: I27b4c8337ad229c2ad93e294c9159baa3c2567b8 Reviewed-on: https://gerrit.libreoffice.org/34439 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17convert StackMode to scoped enumNoel Grandin
and drop unused AMBIGUOUS enumerator Change-Id: I71954d75a64928061c0e520beb47f979c53ee5a8
2017-02-17drop enum NormalAxisNoel Grandin
since we only ever use the Z enumerator Change-Id: Ia162a6be650704649f5232fff0fa229c7b346450
2017-02-17convert PropertyType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I61d2a46ed84ce4163757a2da58162c72b1b0950f
2017-02-17convert GraphicObjectType to scoped enumNoel Grandin
and drop unused FILL_PROPERTIES enumerator Change-Id: I302d9d1d997c4fc491f7950b220060740f831539
2017-02-17convert AccessibleBase::EventType to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I1ce08b16d587edcaee214b40798fe53fa3fc7923
generated by cgit (git 2.34.1) at 2025-02-01 20:03:58 +0000