summaryrefslogtreecommitdiff
path: root/chart2/source
AgeCommit message (Collapse)Author
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07fdo#39440 reduce scope of local variablesŁukasz Hryniuk
Beside scope changes, it fixes lack of initialization in a few places. Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2 Reviewed-on: https://gerrit.libreoffice.org/13755 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-03fdo#39440 reduce scope of local variablesŁukasz Hryniuk
Change-Id: Iabcd57c5f11a53db9fc6fab3606a9ab36c94fcc0 Reviewed-on: https://gerrit.libreoffice.org/13722 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-24bnc#830738 Now all axis labels of a chart are displaied.Marco Cecchetti
Problem: Some axis labels of a chart are missing, when they should not. Analysis and solution: The current implementation is affected by the following issues: 1) When the method switches to the 45-degrees layout the `nRhythm` parameter is not reset to 1. 2) The bounding boxes computed by the `doesOverlap` test routine for the 45-degrees layout are wrong. Because of the first issue only one label every `nRhythm` is showed even if in the 45-degrees layout no overlap occurs. The second issue is located inside the `lcl_getRotatedPolygon` routine which is used by the `doesOverlap` routine for building a polygon representing the bb for a text label. The polygon is created in the following way: a new rectangle is created: the top-left vertex is placed at axes origin and it is initialized with the same width and height of the bb of the passed text label. Later several transformations are performed on the new rectangle: 1) the rectangle is rotated by a 45-degrees angle respect with its center; 2) the rectangle is translated by a vector equals to the top-left vertex of the bb of the passed text label. There are 2 errors in this sequence of transformations: 1) The `B2DHomMatrix` class used for representing the transformation, performs rotations in the positive direction (from the X axis to the Y axis). However since the coordinate system used by the chart has the Y-axis pointing downward, a rotation in the positive direction means a clockwise rotation. On the contrary text labels are rotated counterclockwise. This can be easily fixed by using the opposite angle. 2) Rotating the rectangle respect with its center is wrong since the fixed point of the rotation must be the top-left corner of the rectangle: in this way when the final translation is performed the top-left vertex of the transformed rectangle will be coincident with the top-left vertex of the text label bb, and so the transformed rectangle will be coincident with the text label bb. Change-Id: Ia8072c3d5bd6c1a11f66c33d45d56e55634edf4c
2014-12-18fix buildCaolán McNamara
Change-Id: I920227cd175dace306ebb16a8e476f483cf11a7a
2014-12-18chart2: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
2014-12-18bCategoriesUsed is always false at this pointLionel Elie Mamane
Change-Id: I7e6851ce3f24ef3c5051eb7431b6aa1df845836d
2014-12-15chart2: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ia5a340049f787d7173140482853730a00d5d12df
2014-12-09changed timers to idleJennifer Liebel
Change-Id: Ibdecb970f7e6119929ec172e56d986c682008487
2014-12-09fix buildCaolán McNamara
Change-Id: Iaeb995ef4dad03babb5df1b034a476d90681768a
2014-12-09fix build under gccNoel Grandin
after my commit feb92a5 "inline some strings, they don't need to be in a shared header file" Change-Id: I60a6fa11d56f3d4648dbedeca062ab27206f2a02
2014-12-09inline some strings, they don't need to be in a shared header fileNoel Grandin
Change-Id: I058489d207510024ce722c4d03f9aac628b120b5
2014-12-09inline UNO helper macrosNoel Grandin
Change-Id: Ia401dd2f51108d2f3b08cd3d6d433a12ac17ee74
2014-12-09inline UNO helper macro APPHELPER_SERVICE_FACTORY_HELPERNoel Grandin
Change-Id: Ib416efb59ae166bb8d55dd7f3c84b7e5f72864e8
2014-12-09use cppuhelper::suppportsService helper method in chart2Noel Grandin
Change-Id: Ica22513d84061e57c2c3d0fb3b6411c7b0572099
2014-12-06reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I864a4e84326633d33f09324247cbe439fba801c8 Reviewed-on: https://gerrit.libreoffice.org/13336 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-28chart2: ChartController: fix CommandDispatchContainer access lockingMichael Stahl
crashes on concurrent setModel() and getDispatchForURL() in JunitTest_chart2_unoapi: Thread 13: 7 in (anonymous namespace)::Frame::isActionLocked (this=0x2b66c0e4a090) at /home/tinderbox/master/framework/source/services/frame.cxx:2596 8 in (anonymous namespace)::Frame::close (this=0x2b66c0e4a090, bDeliverOwnership=0 '\000') at /home/tinderbox/master/framework/source/services/frame.cxx:1772 9 in chart::ChartController::notifyClosing (this=0x2b668ae41058, rSource=...) at /home/tinderbox/master/chart2/source/controller/main/ChartController.cxx:872 10 in apphelper::CloseableLifeTimeManager::impl_doClose (this=0x2b669a0b1d08) at /home/tinderbox/master/chart2/source/tools/LifeTime.cxx:360 11 in apphelper::CloseableLifeTimeManager::g_close_endTryClose_doClose (this=0x2b669a0b1d08) at /home/tinderbox/master/chart2/source/tools/LifeTime.cxx:311 12 in chart::ChartModel::close (this=0x2b669a0b1c28, bDeliverOwnership=1 '\001') at /home/tinderbox/master/chart2/source/model/main/ChartModel.cxx:659 Thread 1: 4 in std::__debug::map<rtl::OUString, com::sun::star::uno::Reference<com::sun::star::frame::XDispatch>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> > > >::find (this=0x2b668ae41248, __x=...) at /usr/include/c++/4.8.3/debug/map.h:382 No locals. 5 in chart::CommandDispatchContainer::getDispatchForURL (this=0x2b668ae41248, rURL=...) at /home/tinderbox/master/chart2/source/controller/main/CommandDispatchContainer.cxx:80 6 in chart::ChartController::queryDispatch (this=0x2b668ae41058, rURL=..., rTargetFrameName=...) at /home/tinderbox/master/chart2/source/controller/main/ChartController.cxx:1003 No locals. 7 in framework::DispatchProvider::implts_queryFrameDispatch (this=0x2b66a3fd21e8, xFrame=..., aURL=..., sTargetFrameName=..., nSearchFlags=0) at /home/tinderbox/master/framework/source/dispatch/dispatchprovider.cxx:374 8 in framework::DispatchProvider::queryDispatch (this=0x2b66a3fd21e8, aURL=..., sTargetFrameName=..., nSearchFlags=0) at /home/tinderbox/master/framework/source/dispatch/dispatchprovider.cxx:111 9 in framework::InterceptionHelper::queryDispatch (this=0x2b668a61bc08, aURL=..., sTargetFrameName=..., nSearchFlags=0) at /home/tinderbox/master/framework/source/dispatch/interceptionhelper.cxx:78 10 in (anonymous namespace)::Frame::queryDispatch (this=0x2b66c0e4a090, aURL=..., sTargetFrameName=..., nSearchFlags=0) at /home/tinderbox/master/framework/source/services/frame.cxx:2227 11 in svt::ToolboxController::bindListener (this=0x2b66c0f72740) at /home/tinderbox/master/svtools/source/uno/toolboxcontroller.cxx:529 12 in svt::ToolboxController::update (this=0x2b66c0f72740) at /home/tinderbox/master/svtools/source/uno/toolboxcontroller.cxx:232 13 in framework::ToolBarManager::UpdateControllers (this=0x2b669a0a1728) at /home/tinderbox/master/framework/source/uielement/toolbarmanager.cxx:440 14 in framework::ToolBarManager::AsyncUpdateControllersHdl (this=0x2b669a0a1728) at /home/tinderbox/master/framework/source/uielement/toolbarmanager.cxx:2110 15 in framework::ToolBarManager::LinkStubAsyncUpdateControllersHdl (pThis=0x2b669a0a1728, pCaller=0x2b669a0a1890) at /home/tinderbox/master/framework/source/uielement/toolbarmanager.cxx:2097 16 in Link::Call (this=0x2b669a0a18b0, pCaller=0x2b669a0a1890) at /home/tinderbox/master/include/tools/link.hxx:139 17 in Timer::Timeout (this=0x2b669a0a1890) at /home/tinderbox/master/vcl/source/app/timer.cxx:276 Change-Id: I17ef63db8f7c288460e00031e8e8a5c3e4d086b3
2014-11-25Remove ptr_deque.hpp header include from vcl/outdev.hxx.Kohei Yoshida
This header is also a very high impact header. Change-Id: Iab63f2ec2edebc14b47820c6377a7f83131cfd06
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17coverity#1242824 Unused valueCaolán McNamara
Change-Id: I5f53e538f8f76c337cda8b90fcf4ed717ed2476e
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10callcatcher: unused codeCaolán McNamara
Change-Id: I2ead5d998c3b1b3cde1222fee6f072bf09ab0021
2014-11-10prevent crash with empty chart sceneMarkus Mohrhard
Change-Id: I9eb8adf887532c62af6efeac5b0eeec1419b7252
2014-11-09OpenGL ES does not support double and glPolygonModeMarkus Mohrhard
Change-Id: I623babba561dc0a126c6884a70a33ad4a78ef63f Reviewed-on: https://gerrit.libreoffice.org/12187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07use css:: prefix to tidy up chart2 UNO macrosNoel Grandin
Change-Id: I8dbe23bfec15fbc905407f64a3a87a5c75dbcd54
2014-11-05changed some timer to idleJennifer Liebel
Change-Id: Ifd5e2d87732d3e537c7754e52be24ef768ecb8d9
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04Avoid re-constructing chart shapes when it's not in visible range.Kohei Yoshida
The re-construction will be deferred until it becomes visible again. Change-Id: I364ea8d38d48078dfd803b0e5bb20bfc8a2913ba
2014-11-04Modify the tick iterator strategy to use fewer ticks.Kohei Yoshida
To pre-determine the size of the largest text label object, auto-staggering strategy etc. In theory (if I read the code correctly) we could achieve the same thing by using only 3 ticks rather than 5. Change-Id: Iee51588061e482c724ee4fb666c51c2a6b636e8c
2014-11-04Let's use size_t for the index.Kohei Yoshida
This removes unnecessary static_cast's and check for negative values which, from what I've read from the code, never happens. Change-Id: I9d9e1de5b091df335dd3b7eeb34e4e8f98de0fbd
2014-11-04Some code sharing.Kohei Yoshida
Change-Id: If80c4b0ceec5e0afd55d12ebe7511fb4f40b4797
2014-11-04Create a variant of createTextShapes for simpler use cases.Kohei Yoshida
So that we can do more aggressive optimization without breaking the other cases. Change-Id: I5d4ceb2a3b7f041f752a570827815236e9de58db
2014-11-04These methods can be private rather than protected.Kohei Yoshida
Change-Id: I56f1296f5a2df67ae9386ae9f30761aee0fde7f3
2014-11-04More method descriptions.Kohei Yoshida
I'm starting to "get" this axis label layout code. Change-Id: I797a92698cb81a1b9325f81b5275cb033cb7c342
2014-11-04More method descriptions.Kohei Yoshida
Change-Id: I465e991c83cd5b711d73afd9407596ef1df70f27
2014-11-04Standard way of writing class description.Kohei Yoshida
Change-Id: I5572f4417a05132e46a4560088f519cdadfdaec1
2014-11-04Code annotation.Kohei Yoshida
Change-Id: I41067bf7503c591ce869ecfde111b049143bbb9a
2014-11-04Add const to read-only variables.Kohei Yoshida
Change-Id: Ie5782e6f450db91e1a66693163fba2b83441e9ae
2014-11-04Mark these methods const.Kohei Yoshida
Change-Id: Idf53b85d962406caf9ca1df636fffd8b3459baf5
generated by cgit (git 2.34.1) at 2025-01-04 09:40:17 +0000