summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2019-04-01tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48 Reviewed-on: https://gerrit.libreoffice.org/70017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-27Remove unused using declarations in directories [a-d]*Gabor Kelemen
Found with: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96 Reviewed-on: https://gerrit.libreoffice.org/69601 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-27Fix typoAndrea Gelmini
Change-Id: I10ca33b2d604ba0dde074327ca3e6d7655105dd0 Reviewed-on: https://gerrit.libreoffice.org/69782 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25tdf#124112 Insert drawing object in chart crashes LibreOfficeNoel Grandin
regression from commit 6be7e2e9dd8027d284f1b00ef6e3b4654eec7d79 Date: Thu Aug 30 13:54:33 2018 +0200 pass SdrUndoAction around by std::unique_ptr Looks like previously this memory was just leaked, so fix that and the crash Change-Id: I5eb5c104dccd82cef30af533ce1fe8546ced0ea0 Reviewed-on: https://gerrit.libreoffice.org/69648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-20weld SwFieldEditDlgCaolán McNamara
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66 Reviewed-on: https://gerrit.libreoffice.org/69463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20tdf#42949 Fix IWYU warnings in include/drawinglayer/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8daf57df5b8f9c609d4f3ca44bae7366addceb6c Reviewed-on: https://gerrit.libreoffice.org/69151 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-20tdf#123504: improve unit test robustnessMike Kaganski
... since the values are unstable for charts. Just use reasonable lower bounds. Change-Id: I9510d834a3905c188b52313e267998a4c73f8aa2 Reviewed-on: https://gerrit.libreoffice.org/69458 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-19tdf#123504: 0 and 360 are different angles in chartsMike Kaganski
This partly reverts commit 81302f33073e7629d724ed269f1fa21dad29e141. Change-Id: I40cbe739eb4497b8217aca56a2c3661ed1e491f4 Reviewed-on: https://gerrit.libreoffice.org/69440 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-19Resolves: tdf#124111 Cannot enter negative numberCaolán McNamara
Change-Id: I9b08595f5dc7ca0bd3e86891330dd1caa0446e63 Reviewed-on: https://gerrit.libreoffice.org/69417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-19Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: I4a949aeba3302fb86f371309a49dfdd53e65cbdf Reviewed-on: https://gerrit.libreoffice.org/69405 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-18tdf#81437 XLSX import: fix missing chart borderBalazs Varga
of MSO 2007/2010 documents with "automatic" chart area formatting, setting also the default 0.75 pt border width and light gray border color. Note: MSO 2007/2010 and MSO 2013/2016 have different "automatic" border colors. This fix uses the last, light gray version instead of the dark one. Change-Id: I579f3745d5fcb2a36e1b4d519320631d20e60fd4 Reviewed-on: https://gerrit.libreoffice.org/69341 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-16clarify that set_visible(true/false) is just show/hideCaolán McNamara
ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-14loplugin:unusedfieldsNoel Grandin
Change-Id: Id6792f0955a25533d33f6da6ed8c3e993f578c3f Reviewed-on: https://gerrit.libreoffice.org/69170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-13Resolves: tdf#123694 we need the controller, not the tabpage parentCaolán McNamara
Change-Id: Ib390abaec648a1e06fcc35f83cb170fc654cf021 Reviewed-on: https://gerrit.libreoffice.org/69203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12Simplify containers iterations in chart2, cli_ure, comphelper, configmgrArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76 Reviewed-on: https://gerrit.libreoffice.org/69010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-12tdf#115012 XLSX chart import: workaround for no gapLászló Németh
DispBlanksAs=gap mode of OOXML is different from treat-empty-cells=leave-gap mode of OpenDocument, because formulas with no numerical values and strings are no gaps in OOXML line charts, but zeroes. When the data source of the line charts contains formulas with no numerical values or strings, but it doesn't contain empty cells, as a workaround, the charts will be imported with the treat-empty-cells=use-zero setting to get the same line chart as in MSO. Note: now result of ScChart2DataSequence::getData(), a sequence of Any values contains UNO void values for empty cells instead empty strings, allowing the distinction of the empty cells and cells with empty string values. Change-Id: If9a101d66b5b750051928fa7b10b05cea6040071 Reviewed-on: https://gerrit.libreoffice.org/69054 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-09loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb2c9a2d1d7dcc0ed3e8458c1a13933ccababd4c Reviewed-on: https://gerrit.libreoffice.org/68939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06sync chart2 ui files with swriter ui filesandreas kainz
Change-Id: I5c31fd0aef8d3a3e2ce4bcc6942f9cc06edff858 Reviewed-on: https://gerrit.libreoffice.org/68791 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04simplify UNO getTypes methodsNoel Grandin
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unnecessaryoverride look for more patternsNoel Grandin
like bool Foo::bar() { b = Super::bar(); return b; } Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7 Reviewed-on: https://gerrit.libreoffice.org/68418 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:simplifybool improve search for negated operatorNoel Grandin
Change-Id: Id6ac35fefa5c3e1f64c222713791e849b3cb4d34 Reviewed-on: https://gerrit.libreoffice.org/68379 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25loplugin:unusedfields in variousNoel Grandin
Change-Id: I31d0e6c3559af2e322fb474b97f3bbf4d5064831 Reviewed-on: https://gerrit.libreoffice.org/68280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19tdf#42949 Fix IWYU warnings in include/framework/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia9616f644a68ec6da22e646ba0d919a3489a9481 Reviewed-on: https://gerrit.libreoffice.org/67745 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-18Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: Ib09622d0fd01546f3020a2fd40e5e89a33517277 Reviewed-on: https://gerrit.libreoffice.org/67946 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-15These items are of type SfxUInt32ItemStephan Bergmann
...see include/svx/svxids.hrc for SID_ATTR_NUMBERFORMAT_VALUE and chart2/source/inc/chartview/ChartSfxItemIds.hxx for SCHATTR_AXIS_CROSSING_MAIN_AXIS_NUMBERFORMAT, and as reported by -fsanitize=vptr in sc/qa/uitest/chart/tdf122398.py recently added to UITest_chart (<https://ci.libreoffice.org/job/lo_ubsan/1188/>). Change-Id: Ic1e2f3390bd54b722730e6dd7962d613587774b1 Reviewed-on: https://gerrit.libreoffice.org/67884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15tdf#97575 Chart OOXML: Export ShapeProps of Error BarsBalazs Varga
Export the shapeProps (fillstyle, linestyle, linewidth, linecolor etc.) of the Error Bars to OOXML. Change-Id: Iff74fa463fdd0fb6ed95e4d1bf0d3e906349860c Reviewed-on: https://gerrit.libreoffice.org/67825 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-14Removed executable permission on docx fileAndrea Gelmini
Change-Id: I9908b65280ae4e468a73932e9e560e8a4b0f01f4 Reviewed-on: https://gerrit.libreoffice.org/67799 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13tdf#123400 OOXML Chart: Export Data Label SeparatorBalazs Varga
Export the data label separator XML tag and the separated character to OOXML. Change-Id: I9b3bcb588e42a42494107ebde70f4a72492cfac4 Reviewed-on: https://gerrit.libreoffice.org/67753 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-12Removed executable permission on docx fileAndrea Gelmini
Change-Id: I66dcbda8d91d05229b2c6c9185a4d02ce5361294 Reviewed-on: https://gerrit.libreoffice.org/67742 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-12tdf#122226 OOXML Chart Import: data label new line separatorBalazs Varga
Set the data label separator to "new line" if there is not present explicit point separator, just like in MS Office. Change-Id: I9ee0fb9f98fc1bb322892616af50954f4f8db0f9 Reviewed-on: https://gerrit.libreoffice.org/67533 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-11Resolves: tdf#123231 spin-button focus loss triggers changing active radioCaolán McNamara
Change-Id: I6562631df4225d5aa4fe650c40be7c0424eb5621 Reviewed-on: https://gerrit.libreoffice.org/67689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Meryem Ezber
Change-Id: I4446858ed30df4adffbf18ab609c95690cff99c0 Reviewed-on: https://gerrit.libreoffice.org/67668 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-11tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Meryem Ezber
Change-Id: Icfedb77943721f0ed7504ec68c3b63c4709352bc Reviewed-on: https://gerrit.libreoffice.org/67615 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-11tdf#120703 PVS: remove obsolete check (leftover from static removal)Mike Kaganski
V560 A part of conditional expression is always true: !pSymbolList. In commit a2cd17d19085d739b979445d7f9ec7158b89df49, pSymbolList and xSymbols were made non-static. The check below was left though. Actually, I don't know if that was a safe move, since it's unclear how the lifetime of the returned pointer is managed now to prevent use-after-free. Change-Id: Ia51a9790503694f909ce7953337d3caaebfabfc1 Reviewed-on: https://gerrit.libreoffice.org/67512 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I62cb3b8927d664b3d5359ee6ac7db30d354f4821 Reviewed-on: https://gerrit.libreoffice.org/67496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-09Fix typoAndrea Gelmini
Change-Id: I72fafb21ac51de7537622b5265af266073cdb293 Reviewed-on: https://gerrit.libreoffice.org/67576 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-08loplugin:indentation in canvas..chart2Noel Grandin
Change-Id: I9ef57a2e9aaf298f4cfd029aa9b8143871b1bc21 Reviewed-on: https://gerrit.libreoffice.org/67526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-03Fix typoAndrea Gelmini
Change-Id: Iaaae552001af05d0d9cfd5d942876ae488d89e3b Reviewed-on: https://gerrit.libreoffice.org/67299 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-19 05:11:55 +0000