summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2017-01-10loplugin:nullptrKhaled Hosny
Change-Id: Iaf69f87564ff0f9f8aab6fafb833714426c8bc30
2017-01-10loplugin:unusedfieldsNoel Grandin
Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1 Reviewed-on: https://gerrit.libreoffice.org/32873 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-05This lock seems uselessTamás Zolnai
m_pCurrentMainType->commitToModel creates the same lock. Change-Id: Iaecf6b3392ce7b1371623f962b0fdc58f8ddaa07
2017-01-05I miss empty lines from between these function definitionsTamás Zolnai
Change-Id: Icec3a948a92bf54bfc442b34cf806e053a9096f3
2017-01-05m_bDoLiveUpdate is always trueTamás Zolnai
Change-Id: I169027a02bd4e0e5c2e0011e6aca4d6063547ca0
2017-01-05Remove useless explicit bool conversionTamás Zolnai
Change-Id: I81caa89fe2ebfb88ce4eb36b8edb9460e9aca9c8
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-21ODR violation (base class must be the same across compilation units)Stephan Bergmann
Change-Id: I6e386574d0366ef75f24811266134d93b28dc3a5
2016-12-21No apparent reason for an unnamed namespace in an include file hereStephan Bergmann
Change-Id: I56f21c94086b34f766e3f2745f5a1291af676984
2016-12-21convert EnumContext::Context to scoped enumNoel Grandin
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3 Reviewed-on: https://gerrit.libreoffice.org/32272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21Recreate the reference files, againKhaled Hosny
After the rounding change in 9eb4b14ffa57cd7bbdf0fc43096f5f1e65c8e388. Change-Id: I0836ba34f23d256075611e9fae1658cf4d737a89 Reviewed-on: https://gerrit.libreoffice.org/32242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-21Add move column right and move row up in DataTablebansan85
Change-Id: Ib224a99636dfbb4451aa26263573af2f3d31b84a Reviewed-on: https://gerrit.libreoffice.org/32265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-18recreate the reference filesMarkus Mohrhard
Change-Id: I24c5943cbb371717e3354fe292800abd1536129e Reviewed-on: https://gerrit.libreoffice.org/32139 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-18add missing component fileMarkus Mohrhard
Change-Id: Ica945030f955cb192cee44a0f97f4f9d881bf9a0 Reviewed-on: https://gerrit.libreoffice.org/32138 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-18-Werror,-Wunused-functionTor Lillqvist
Change-Id: Ia6c8c807c90931da4a5f3cab79d178f88bce290e
2016-12-17Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann
...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-17fix !HAVE_FEATURE_UI buildCaolán McNamara
Change-Id: I5df340811b98c87f8b64fbaca469e2cd4535b81f
2016-12-13post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13Fix fallout from 60b1c95cc47831246f097ee13dda8bcd71c57eb4Tor Lillqvist
Change-Id: I77722619a249616ab59af0eeaeb075e89040c715
2016-12-13Revert "verify SolarMutex when ref-counting VclPtr" seriesNoel Grandin
This reverts the following commits: commit 722f4e1d86710f2facd37d7e040df9e1fd585e26 tdf#104573 - Assertion failed: SolarMutex not locked commit f04ec99f5e6a543b8191ced61db4710c3c0de356 tdf#104573 - Assertion failed: SolarMutex not locked commit 71b1e3ff6374c23e65200d3bcafca387d29af04f tdf#104573 - Assertion failed: SolarMutex not locked when trying commit e794ce1eef6730e5a46d5fb0aa6db2895ede85e7 verify that we hold the SolarMutex when ref-counting VclPtr IRC discussion: <noelgrandin> sberg, maybe I should revert this whole "VclPtr assert" series, I don't have mental bandwidth to sort this out properly now <sberg> noelgrandin, what I fear is that you'll end up adding lots of SolarMutex locks to small places, where the proper fix would be to add it further out; and once such a dreaded recursive SolarMutex lock is in place (but needlessly so, once the proper fix is done), it's hard to clean that up again <noelgrandin> sberg, yeah, in that case I'll just remove all of this, leave it for another day Change-Id: Ie4f84b72b79a1b7e80164b5c7693af398c2c569a Reviewed-on: https://gerrit.libreoffice.org/31946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13change from glew to epoxyCaolán McNamara
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12loplugin:staticmethodsTor Lillqvist
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
2016-12-12loplugin:unreffun and loplugin:externandnotdefinedTor Lillqvist
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
2016-12-11AccessibleEventNotifier AccessibleBase (chart2)Julien Nabet
See https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c876d497dd3320cbc06cf21b7b14ab859755bac This one fixes tdf#104551 Change-Id: Idd173bcb85655ec1b210fa00510fbabba0f5d867 Reviewed-on: https://gerrit.libreoffice.org/31844 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-10tdf#104534: Retrieve list of patternsJulien Nabet
using same way as gradients, bitmap, etc. Change-Id: I49788d5af163aa6f06a12c87ee08e6599fc940c8 Reviewed-on: https://gerrit.libreoffice.org/31833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-08verify that we hold the SolarMutex when ref-counting VclPtrNoel Grandin
Change-Id: If0c5a8c99f0f853c9ecad0f1a4a7299d69805b34 Reviewed-on: https://gerrit.libreoffice.org/31755 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08Try to fix a --disable-gui problemTor Lillqvist
Change-Id: I7fa187b0dea7f058f7486fe2c2e16693f21c063c
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-01tdf#102621: import empty chart cells as NaN instead of 0Jean-Tiare Le Bigot
Change-Id: I574c3f719e52bc2244597532783130564621a891 Reviewed-on: https://gerrit.libreoffice.org/31303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-29Drop a bunch of font metrics flagsKhaled Hosny
These flags mean nothing these days, there are either always true or always false, since we no longer support bitmap or Type 1 fonts. Change-Id: Ie14ca480225a6346d868a44e58e7666c3a06931d Reviewed-on: https://gerrit.libreoffice.org/31346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-23loplugin:unnecessaryoverride (dtors) in chart2Stephan Bergmann
Change-Id: I013fd81467b353262e8de554a06a0b24e4deca6d
2016-11-21add missing depDavid Tardon
Change-Id: I7ebf3d83833424a089a6befb1fe038fdd85ead35
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18loplugin:unusedmethodsNoel Grandin
Change-Id: I567c672a0606ac11c0f269fcf5cc3906684e23f9 Reviewed-on: https://gerrit.libreoffice.org/30950 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15Revert some chart2 shader-affecting changesNoel Grandin
from commit 8d4a306eb04742f499ab693e7f8ebd3ae3c01415 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 11:26:59 2016 +0200 loplugin:unusedfields and commit c79b7fd8d4e6e029cf8e6bfb2c7e10b52a4d5781 Author: Noel Grandin <noel@peralex.com> Date: 2015-11-20 10:41:00 (GMT) loplugin:unusedfields in chart2 Change-Id: I6b61aa9c6abb1d51e96d5eb6c623d86fd6fd5b82
2016-11-15loplugin:unusedfieldsNoel Grandin
Change-Id: I1400ca0af2c357dff06e5f733ec62b13d6a96461 Reviewed-on: https://gerrit.libreoffice.org/30861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14coverity#703927 Unchecked return valueCaolán McNamara
make these less odd and simply return the thing they selected, rather than a bool that indicates that the rpObj arg was successfully set to non-null, so there's one flag to check not two which both mean the same thing. Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50 Reviewed-on: https://gerrit.libreoffice.org/30794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11loplugin:expandablemethods in chart2Noel Grandin
Change-Id: Ie6650628683ec7c67359351eec0e09033f2b50cb Reviewed-on: https://gerrit.libreoffice.org/30750 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-04 11:24:08 +0000