summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2015-01-24Allow for null xModel in TitleHelper::getTitleStephan Bergmann
Witnessed a JunitTest_chart2_unoapi failure where (deep within Idle::Timeout) chart::impl::ModelState::update is apparently called with a null xModel. All the code called from there appears to be careful to handle a null xModel, except for chart::TitleHelper::getTitle, which---presumably by accident---stopped doing so with 401f01caf5b357ac6c15b37a89c0a9aaeb46f4e4 "use ChartModel instead of XModel in a few places." Change-Id: I5788b5e41a6d68fe193cb214d736ee54c4c581d7 (cherry picked from commit 6acfc822566ca3c7d9fdd4af37ad5104a00d5d35) Reviewed-on: https://gerrit.libreoffice.org/14127 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-13fix range input in chart data source dialogMarkus Mohrhard
Change-Id: I9c139c6298d25c7a7072d0d0538f1945518d36f2 Reviewed-on: https://gerrit.libreoffice.org/13402 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-23Resolves: fdo#84885 chart wizard dialog cut offCaolán McNamara
Change-Id: Ie24687cd1c54b1fed04745c83f507c17a5574175 (cherry picked from commit f9c242674094eba7ac19bd279f611dba0a8e5571) Reviewed-on: https://gerrit.libreoffice.org/12052 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-10-14fdo#77319: set spinbox value AFTER adjusting no. of decimal placesKatarina Behrens
Doing it the other way round truncates the values Change-Id: Ieb14c9d1b9dde496eac24737aced7c8da8ce1346 Reviewed-on: https://gerrit.libreoffice.org/11865 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-23Missing include dirStephan Bergmann
Change-Id: Id1d1ed3639548b335dff2d9fa5689b90f1ae5f61 (cherry picked from commit af70a45633b34eaae4eb4577b763dadfc48c74b6)
2014-09-12bnc#892610: OOXML import: Improve chart number formats.Matúš Kukan
If sourceLinked is used, do not set "PercentageNumberFormat" even if showPercent is true. The format string should be used for "NumberFormat". c8cc89ff802d86b1f3a69afe1b4835b7df7f70c7 unnecessarily disabled "LinkNumberFormatToSource". Use that for data labels but not for axis. Also, actually make attaching number format supplier work for Calc. Previously, non standard formats were added into wrong supplier, and they were thrown away later because it was attached too late. (See also ChartModel::attachNumberFormatsSupplier) (cherry picked from commit d22a4d945ccf1456fbdb2c39802d956afa583a2a) Conflicts: chart2/qa/extras/chart2import.cxx oox/source/drawingml/chart/chartconverter.cxx Change-Id: Iaf9945abc3d82d0ac63d9f36b8888eb49f39ab57 Reviewed-on: https://gerrit.libreoffice.org/11414 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-08-06bnc#886540: Let's not push the available area down when no titles are there.Kohei Yoshida
This improves visual layout compability with MS Office chart & looks better. Change-Id: I348ea81152eca4e3bba9e0d9460448d9314738ad (cherry picked from commit b398ed8e3f95b75705bb2e53d49589ef7fdbb1c7) Reviewed-on: https://gerrit.libreoffice.org/10770 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-08-04hate that stupid auto_ptr deprecation warningMichael Stahl
Change-Id: I8b290b61d7f081d5b2b72805968a374c91721cc3
2014-08-01fdo#75380: Let's not always set the line style to NONE here.Kohei Yoshida
This one line guarantees that no matter what the real line style is, it will be ignored. Change-Id: I3bceaf49ce13ddb42ceb56750d8a4ccfef54033b (cherry picked from commit 6053491532a5d9954caaa4abf09af30850f0cb94) Reviewed-on: https://gerrit.libreoffice.org/10671 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-30bnc#885825: Handle ODF import and export of data label border properties.Kohei Yoshida
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139 (cherry picked from commit 6c2c974dd3f0b21a23bc3bc5560487d28bbe0fad) Reviewed-on: https://gerrit.libreoffice.org/10563 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-30bnc#885825: Support borders around data labels.Kohei Yoshida
(cherry picked from commit f1531cdaaebe706d909dc6ddde439ccb5f4ad36d) Conflicts: chart2/inc/unonames.hxx chart2/source/model/main/DataPointProperties.cxx Change-Id: Ib141413e523cbf73746876f727e9f80dda9f5f7c Reviewed-on: https://gerrit.libreoffice.org/10561 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-24fdo#81547: prevent crash by reading relevant .ui fileKatarina Behrens
instead of no longer existing resource. Additionally, tweak widget visibility so that only relevant widgets are shown in Data series properties -> Layout tab. This is achieved by setting initial status of most of the widgets in .ui file to hidden, as *ResourceGroup::showControls() methods will take care of showing them when appropriate Change-Id: Iacbc689fb410b30515e433bcf4a96c087047ca73 Reviewed-on: https://gerrit.libreoffice.org/10496 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-14remove now unused dialogMarkus Mohrhard
Change-Id: I42c340a6aee016e37ee558d46a8eab101837e9c5 Reviewed-on: https://gerrit.libreoffice.org/10074 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-14show the property mapping sequences by defaultMarkus Mohrhard
Change-Id: I32417ed53e491a66f700e77ae0fff2154fa5441c Reviewed-on: https://gerrit.libreoffice.org/10073 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-14disable 3D OpenGL chartMarkus Mohrhard
feature is not ready for the release Change-Id: Ibca7d1db4f8eb4e7130e2b05fb86706135a41b1c Reviewed-on: https://gerrit.libreoffice.org/10261 Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-07-11extract common codeMarkus Mohrhard
Change-Id: I9327f232f1edb9ef052eb7868ac60774f3b6e4cf Reviewed-on: https://gerrit.libreoffice.org/10072 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10we need to make sure the context is currentMarkus Mohrhard
Change-Id: Ia3d9df493899949f8de096f1cb0a3b63bffac0eb Reviewed-on: https://gerrit.libreoffice.org/10184 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-07-07chart2: add some locking to chart::ChartType UNO serviceMichael Stahl
On the libreoffice-4-3 branch, chart2_unoapi crashed with what looks like a corrupted ChartType::m_aDataSeries triggering STL assertions. Try to protect the mutable members with SolarMutex guards. Change-Id: I3f2edd36b8ecf37ef60239415f70abfc8b59244d (cherry picked from commit 6cad548ee21f19b816726a03995b9bc8905757f8) Reviewed-on: https://gerrit.libreoffice.org/10085 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-05don't forget glewInitMarkus Mohrhard
Change-Id: Ifc1c995f50fe34dbb072345aab37190d3a57e074 Reviewed-on: https://gerrit.libreoffice.org/10094 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2014-07-04fdo#78908 Revert "Merge back branch alg_writerframes to trunk"Miklos Vajna
This reverts commit 6e61ecd09679a66060f932835622821d39e92f01. Better not to have this on libreoffice-4-3 without 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Conflicts: cui/source/inc/backgrnd.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tparea.cxx include/basegfx/numeric/ftools.hxx include/svx/svxids.hrc include/svx/unoshprp.hxx sc/source/ui/drawfunc/drawsh.cxx sd/source/ui/func/fuarea.cxx sfx2/source/dialog/tabdlg.cxx sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/swatrset.hxx sw/inc/unobrushitemhelper.hxx sw/qa/extras/rtfexport/rtfexport.cxx sw/source/core/attr/format.cxx sw/source/core/attr/swatrset.cxx sw/source/core/doc/docfly.cxx sw/source/core/doc/notxtfrm.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/fntcache.cxx sw/source/core/uibase/shells/frmsh.cxx sw/source/core/unocore/unobrushitemhelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unostyle.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx Also: Revert "cppcheck: Prefer prefix ++/-- operators for non-primitive types" This reverts commit 80ec4885e97b3fcb34b93e71ced52a4aab43ce93. Revert "WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'" This reverts commit d5d10b03b1f3e4bf784ad35254cb55d719a8c1b3. Revert "i#124638 support for DrawingLayre FillStyle for GraphicFrames and ..." This reverts commit 4a0b5e569d070c286daefb0fdfe45c0dd15d241c. Revert "svx: fix SID_OFFER_IMPORT and SID_ATTR_CHAR_GRABBAG having the same SID" This reverts commit b66d87086804460c1986df1b832fd6b2ea075a90. Revert "SwXStyle::getPropertyValue: don't try to read a float into a sal_Int32" This reverts commit 1e3c7b854baac2502bed72ff8e3e1b21b507735b. Revert "SwXTextFrame: also restore semi-lost BackColorTransparency property" This reverts commit 102bb87ca1a5dee3a09442bf503a54bb703c79ea. Revert "SwXTextFrame: restore semi-lost BackColor property" This reverts commit 5ce92b73ce06c805c66e53c48aa2c70c722aaf60. Revert "DocxAttributeOutput: port to FillAttributes" This reverts commit ec221b7339f8fe5520926ef85b450daa94392780. Revert "MSWordExportBase::OutputItemSet: handle fill attributes as frame ones" This reverts commit 84c40768f8acb0342dcfa223133497f57620fc14. Revert "sw: put getSvx* and setSvx* to a namespace, now that these are public" This reverts commit ebf960960a69c1edb5da1994c330ddddbecac44d. Revert "sw: fix DOC/DOCX/RTF export of TextFrame background color" This reverts commit c7837b8caad61b8c0dfd3704a133cdeaffd69b06. Revert "sw: still use SvxBrushItem for page style background" This reverts commit e826950e9d7736a6e3f9042755ba1b528f58a505. Revert "cui: unused code in SvxAreaTabPage::ClickBitmapHdl_Impl" This reverts commit 2032e9f5d7683e49b8753d7c7362899c690005b6. Revert "cui: unused code in SvxAreaTabPage::ClickGradientHdl_Impl" This reverts commit f4fa202b31277276dc4f05046c82152c0830ef21. Revert "cui: unused code in SvxAreaTabPage::ClickColorHdl_Impl" This reverts commit 1478e89e08a54f02a137c74c0cde6ae75e80d9f3. Revert "cui: unused code in SvxAreaTabPage::ClickHatchingHdl_Impl()" This reverts commit e9c9f3f793a91525ac4fb74f8791ba74222515e4. Revert "svx: fix Writer's insert -> frame crash" This reverts commit 831b8751fc9f423fd4e459623e54801c0a020eb3. Revert "sw: adapt frame/templatedialog4.ui to FillAttributes" This reverts commit 55916fc50a5b2d6273bca8c9ef6253011cf4fdbc. Revert "-Werror,-Wunused-variable" This reverts commit d0542fe7251d9c6538331b22a4b5e2e294a92e97. Revert "loplugin:implicitboolconversion,literaltoboolconversion" This reverts commit 47862e75de51a4ac7476acff773b504fdc0d6e76. Revert "loplugin:saloverride" This reverts commit be89e8b8ac19c0feca8850ccaddd90205c63dbe5. Revert "loplugin:literaltoboolconversion" This reverts commit 355b31fe347479f63906e41300042ec5cb38837c. Revert "-Werror,-Wunused-private-field" This reverts commit df9d13dd2e754184a4c6e321b8910ee1bc0cafa1. Revert "-Werror,-Wunused-const-variable" This reverts commit d757a98001a65baf4066c2eda037a08ab1beda46. Revert "unused XFillStyleItem ctor" This reverts commit b735fe1d67e6ad7ad448e448f237dcabef1a1c38. Revert "unused XGradient::VclGradient" This reverts commit 5bbc90be755aae4b87125f9d748828d74efe645d. Revert "fix "transparency" of floating tables in docx import (fdo#77723)" This reverts commit 313b59d787357ef3da34e2833fefcf1143b09b5e. Change-Id: If855b090f94288d384f8733f88ef1172e68c50a6 Reviewed-on: https://gerrit.libreoffice.org/10077 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-04Make OpenGL 2D rendering working again.Markus Mohrhard
Change-Id: I29101aee77ac37f5a8e1b929793d7554bc425b26 Reviewed-on: https://gerrit.libreoffice.org/10075 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-03More fine-grained check of data series labels in the unit test.Kohei Yoshida
Change-Id: I6b23126816bb114407f2b75545094bc297ee7cc3 (cherry picked from commit bdad8d9051c207b2eff0d5a7842da83e6119a600) Reviewed-on: https://gerrit.libreoffice.org/10041 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-03bnc#812796: Correctly handle static value array for OOXML charts.Kohei Yoshida
We need to pass the role of the data sequence in order to avoid unreliable guess work when importing static value array. Also, not all Excel's scatter plots have real numeric X values; some have textural X values in which case Excel switch to generating 1, 2, 3, ... as X values. When importing to our chart implementation, using "categories" role in such cases instead of "values-x" results in a more faithful chart rendering. (cherry picked from commit 6c4e21a234f12e1310ba06f9859e08b424acf8bf) Conflicts: chart2/source/inc/InternalDataProvider.hxx chart2/source/tools/InternalDataProvider.cxx Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78 Reviewed-on: https://gerrit.libreoffice.org/10040 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-30fdo#79151: No need to offset column index by category labels.Kohei Yoshida
In fact, doing so would lead to a corrupt internal data table. The internal data stores category labels separately from the column data, so there is no reason why we need to offset for category labels here. (cherry picked from commit ecde8155fefcdacb08177a10a4eddc24f6675b0b) Conflicts: chart2/source/controller/dialogs/DataBrowserModel.cxx Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805 Reviewed-on: https://gerrit.libreoffice.org/9927 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-30Flush modified data to the model when pressing OK in the data table dialog.Kohei Yoshida
This dialog used to have no OK / Cancel buttons, and the data would get flushed when the dialog got dismissed. This behavior got lost during the dialog conversion. Also, SaveModified() does check whether or not the data table is modified. No need to call IsModified() before calling SaveModified(). Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c (cherry picked from commit 483a4b546c850e82a2d1d304238d4830ac6b441f) Reviewed-on: https://gerrit.libreoffice.org/9940 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23XY chart needs to set the X value property, fdo#79144Markus Mohrhard
Change-Id: Ib17b564c187dfec8abb7a17b2602f814362dd34f
2014-06-23fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida
(cherry picked from commit 1d38cb365543924f9c50014e6b2227e77de1d0c9) Conflicts: sd/source/ui/view/sdview3.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a Reviewed-on: https://gerrit.libreoffice.org/9836 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-23don't try to set property mapping if there is no valueMarkus Mohrhard
Change-Id: I422d651e303553e2ce30895b44b8d96664418c19 Reviewed-on: https://gerrit.libreoffice.org/9850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23fdo#80295 - Mismatched icons in Chart Data Table dialogJoren De Cuyper
Change-Id: I31d9ea145e8c01a0e81507534e2cf6c584174048 Reviewed-on: https://gerrit.libreoffice.org/9844 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-22Use define constant to keep track of all NumberFormat property usage.Kohei Yoshida
Change-Id: I2a544922e03ec8253290ac8bf5a89c9cdd72d8dd (cherry picked from commit 2538e30ccc2e98de92de5157ca523fdb347eb537) Reviewed-on: https://gerrit.libreoffice.org/9835 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-21fdo#79028: ungroup widgets and Show() them correctlyKatarina Behrens
Showing the whole box (m_pBxMain) shows all children widgets, but that's not what we want as different widgets must be exposed in case of date vs. non-date axis. m_pMt_MainDateStep was then visible at all times, thus bWasDateAxis was always true and m_pFmtFldStepMain value got unintentionally reset Change-Id: I4be0b18f181a45fe6bd3cac0594d6a34d875293e
2014-06-17Allow building with more recent glm versionsTomáš Chvátal
Use glm::scale(glm::vec3(x, y, z)) instead of glm::scale(x, y, z) Cherry-pick of: 7da3ce7cdb05bcced9ba61724e33d7a395e44e10 Change-Id: Ib9ad6b57cb6b74c8c43c9f6b48f312bfc499ffbe Reviewed-on: https://gerrit.libreoffice.org/9808 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2014-06-12fdo#77506: Enable this check.Kohei Yoshida
Change-Id: Ib4ad7c1a1583b9fde1a06dc8e355442f10bb9bec (cherry picked from commit 10f8d24540a4145af3ec629f7eb724849ca53d22)
2014-06-12fdo#77506: (finally) write a unit test for this.Kohei Yoshida
I've switched from using a Draw document to Writer document due to some instability with Draw instance in our cppunit run. The bug is reproducible either way. The test is disabled for now, since the bug has yet to be fixed. (cherry picked from commit 56ca1b76963c44318a4f5577e15cfa5e7e1cd2a2) Conflicts: chart2/qa/extras/chart2export.cxx Change-Id: I49e0417e1ecbc70f40aab8531237ae98ae58bdd3
2014-06-12Remove this.Kohei Yoshida
Change-Id: Ie2c64d3254dba35ba3fcb1af2566de84b8b300e2 (cherry picked from commit 7d10da2174eac4afd189ee2e9bfb031d315763c1)
2014-06-12New unit test for Draw document with chart. Disabled due to weird crash.Kohei Yoshida
No idea why it crashes whatsoever.... Change-Id: Ic46d5a98f21cacb03adb3bc0d6da239bde5d8ce2 (cherry picked from commit 81d2c208a4e6f9df87e2ee70c6e6da146742178a)
2014-06-10Consistent naming please.Kohei Yoshida
Change-Id: I8a7e1d0a42aacdc7dcaeda0f7e51db78727f4b54 (cherry picked from commit 6f6d81c3b6f83956e7e01f99cc0314c675e56ffa)
2014-06-10fdo#79676: Write unit test for this.Kohei Yoshida
Added a whole bunch of missing component files for handling flat ODF. Change-Id: Ib9d84be14327a1fd9ff64573ba1f6ba90e0bfc56 (cherry picked from commit 9455b4eb4b0ca3909941f8f394afc509d041f860)
2014-06-10fdo#79676: Initialize with a default chart only from the UI.Kohei Yoshida
When creating an embedded chart object during import, we don't want to create a default chart which would only mess up the chart data. With this change, ChartModel::initNew() is a no-op. Change-Id: Id29659c3885ec1e06bed26d2c851123fb63072cc (cherry picked from commit c5539bb585370f095cb6c09e38a7dd005d237295)
2014-06-07Lsan: fix memory leaksMarkus Mohrhard
Change-Id: I010c7c194bf0680a499077b6b364498a09542764
2014-06-07remove unused variableMarkus Mohrhard
Change-Id: Ib79f0c525608d279eebe820bfc82e84dd3518c29
2014-06-07Lsan: fix memory leaksMarkus Mohrhard
Change-Id: I35adb022f12c6833f4f29b2e8dad44394a2c4be5
2014-06-07Lsan: fix invalid memory accessMarkus Mohrhard
The chart object can be destroyed after the context. Change-Id: I5ae370638f296ea314ee11680e0a8d81a8fdbe69
2014-06-06fdo#78860: Swap the logic here: Disable -> Enable.Kohei Yoshida
Because the UNO property logic had been swapped earlier. Change-Id: I35af3e8cee3c4cbc8da43d7bc478f506048887b0 (cherry picked from commit c4ac853409afcb451bed0d044d36131a08e8e403)
2014-06-02Resolves: fdo#79506 Some numbers are marked as translatableJulien Nabet
Exception: http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.src#55 Cherry-picked from acdff9f9763847c992e0853022896cff781c5ffe Change-Id: Iecfe49b51ed68de00f1b5adfb5bca9fa793fb1f9 Reviewed-on: https://gerrit.libreoffice.org/9614 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-05-29chart2: Fix using the last shapeMaxim Monastirsky
Clicking a shape button works only for the default shape, not for the last used one. Steps to reproduce: 1) Click on the drop-down arrow of one of the shape buttons, and select a shape. Notice that the button icon updates with the last selected shape. 2) Click on another button. 3) Click on the first button, and try to draw something. The button doesn't work anymore. Only opening the sub toolbar and selecting the shape there will work. The problem is in ToolboxController::execute that requires the command to be in the listener map, but we didn't register sub commands (like .uno:SymbolShapes.sun). Instead of doing that, we'll try some generic solution. (Note that calling the corresponding method from SvxTbxCtlCustomShapes like we do in other methods here won't work, because ChartController::queryDispatch checks for the "_self" target, but SfxToolBoxControl::Dispatch doesn't provide it.) Change-Id: I5be3dfd3ee3ca9ab9d8080929173dbe5984f61a0 (cherry picked from commit 209eea5457fc40d9f013fb1c041f184b8dd4676a)
2014-05-21-Werror,-Wunused-variableStephan Bergmann
Change-Id: Ie7919740e7e95eb53f7a719e3dc2b114c6fd3862
2014-05-21remove second part of the debug outputMarkus Mohrhard
Change-Id: Ie691746b4621a90d2b7abbfbc75367780574032f
2014-05-21remove debug outputMarkus Mohrhard
Change-Id: Ib77911177ec4d2f5b1f7c7ff75db30b6104f0682
2014-05-21improve the text rendering a little bit moreMarkus Mohrhard
Change-Id: I7662b77df94c439678d17fe31e611272d1802981
generated by cgit (git 2.34.1) at 2024-07-02 19:14:27 +0000