Age | Commit message (Collapse) | Author |
|
some stuff cppcheck missed in this file.
plus use empty() and front()
Change-Id: I612078d503c555afd681526f95d17502ffd585ba
Reviewed-on: https://gerrit.libreoffice.org/35094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Fixes "Random Config" tb run #289
Change-Id: Ib1d672ac0a68e977f8d32f87c730ff1b0822f32c
Reviewed-on: https://gerrit.libreoffice.org/35109
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I5c41c06f9bfa6c23a6984d2f7f5b118a13065da9
Reviewed-on: https://gerrit.libreoffice.org/35088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ic7583e06cbb287805a11b148b40b6e5eda22c6eb
|
|
Same code which was added to the method
DrawingFragment::onEndElement() in
d178d7bef193565a7d6aacbc37a58dfc4bd7b316
A shape's size and position inside a chart object
are primarily defined by <cdr:from> and <cdr:to> tags in
drawing.xml, but in the same file we also have
an <a:xfrm> tag which is used for the same thing
(defining size and postion) in general. Testing with
MSO it seems it ignores what values are set to <a:xfrm> and
uses only the <cdr:from> and <cdr:to> values.
The test document showing this problem must be created
an earlier version of MSO, becuase <a:xfrm> is set to some
random values. Editing the chart and saving it with MSO
2013 the <a:xfrm> values are set consistently with
<cdr:from> and <cdr:to> pair.
Change-Id: Icbaff78e5a6fcea36678c3b3755c97f57976b626
Reviewed-on: https://gerrit.libreoffice.org/35069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639
Reviewed-on: https://gerrit.libreoffice.org/34941
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The original patch crashes charts on disposing, e.g. during the UI testing.
This reverts commit 926c0d73e82bb1d5644c49fb95c56e241b6c8f34.
Change-Id: I93cb5c41e3705a487d2547b55eac761c6952049c
Reviewed-on: https://gerrit.libreoffice.org/34900
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
...from function definitions occurring within class definitions. Done with
a rewriting Clang plugin (to be pushed later).
Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I46851debe8a0bdc1ff871ee9ba34ca41f89b844b
Reviewed-on: https://gerrit.libreoffice.org/34841
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524
Reviewed-on: https://gerrit.libreoffice.org/34808
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This makes the code much more readable..
Change-Id: Ic9078daffeba28984749c61d059701b3cdcca8bd
Reviewed-on: https://gerrit.libreoffice.org/34687
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Liberation Mono is a bundled, monospaced font, which
is better for testing, shows smaller differences.
Change-Id: If56597cede90fc81c722a69fd71e099d22a65d1f
Reviewed-on: https://gerrit.libreoffice.org/34618
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Iea0f7f6cfaee546c3478b936053659b3ecd27e6c
Reviewed-on: https://gerrit.libreoffice.org/34617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Ia54e6e9b71df68bd04c304a0bb02da8ebac74420
Reviewed-on: https://gerrit.libreoffice.org/34603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib481c05ac6f0f60d394e5380aa9cef46b4a0c65f
|
|
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7.
Caused some problems, need to be broken down.
Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52
Reviewed-on: https://gerrit.libreoffice.org/34534
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
|
|
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447
Reviewed-on: https://gerrit.libreoffice.org/34476
Reviewed-by: jan iversen <jani@libreoffice.org>
Tested-by: jan iversen <jani@libreoffice.org>
|
|
Change-Id: Idf59d552582035d3988e761a5024887a2540e692
|
|
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c
Reviewed-on: https://gerrit.libreoffice.org/34508
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9012f97b188195140504dacb262c212d46df675a
|
|
... so masking it out is unnecessary.
Change-Id: I4b25ced640f9287c4db52a6257020fce4e4c1303
|
|
Must be the same problem which makes failing
some of the Chart2DumpTest' test cases.
So disable it for now, until we find out what
the root of this problem is.
Change-Id: I02efffa1e33d264f62802cb43629cc0a13fd74f9
|
|
since commit ce92b5da976122a9120fbb499f7a823ed67a4d01
Change-Id: I27b4c8337ad229c2ad93e294c9159baa3c2567b8
Reviewed-on: https://gerrit.libreoffice.org/34439
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2271cb393ad5268d1c579fb2f9c5e1e73a42c8f3
|
|
On different systems different separator is used
(e.g. coma, space).
Plus tdf#106068 can explain why some of the tests failes
on mac, so disable only these tests.
Change-Id: Id0fa8938d93dd9d4843d42426d369dcdfa1daef1
Reviewed-on: https://gerrit.libreoffice.org/34378
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
It's still failing randomly on Windows tinderboxes.
Change-Id: Idcb7e24d5d11ddc94ead74a2308d43c60de7b430
|
|
Test fails on mac with large differences.
Change-Id: I57bc58ad0b0d819533858992f032bfd763874d99
Reviewed-on: https://gerrit.libreoffice.org/34362
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
and drop unused AMBIGUOUS enumerator
Change-Id: I71954d75a64928061c0e520beb47f979c53ee5a8
|
|
since we only ever use the Z enumerator
Change-Id: Ia162a6be650704649f5232fff0fa229c7b346450
|
|
and drop unused enumerators
Change-Id: I61d2a46ed84ce4163757a2da58162c72b1b0950f
|
|
and drop unused FILL_PROPERTIES enumerator
Change-Id: I302d9d1d997c4fc491f7950b220060740f831539
|
|
and drop unused enumerators
Change-Id: I1ce08b16d587edcaee214b40798fe53fa3fc7923
|
|
since we only ever use the AUTOMATIC enumerator
Change-Id: I1370bf30ea31d0631e56524638ee843f18583933
|
|
ChartWallTest used to be the most instable so don't
check position and size in this case.
AxisLabelTest also failing some times, so use a bigger
delta for it.
Change-Id: I230b7e0f527bae5661af1376486a9780e475f952
Reviewed-on: https://gerrit.libreoffice.org/34348
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I2b1a928d8487a134c0a266c5d7453690d19fde13
Reviewed-on: https://gerrit.libreoffice.org/34346
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Iac7bfd3d22e2186b90c525a6b5bc2a1605ae9aa3
Reviewed-on: https://gerrit.libreoffice.org/34338
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Let's see random test failures are related to calc.
Change-Id: I9164a900b8a7d631df75ba4064d8423400cf34bc
Reviewed-on: https://gerrit.libreoffice.org/34337
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: Ie6dbc4a005f1840dc6b324a99406283676580b96
Reviewed-on: https://gerrit.libreoffice.org/34315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Id505edb3ca1b03817d3a98e6102d79df901a3dc2
Reviewed-on: https://gerrit.libreoffice.org/34308
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I06445065d138788652759b172436a7deb5f6c5c7
|
|
Changing font to a bundled one does not solve the issue.
Change-Id: I2606657a78115bc9b01cda9f0825b55ecfad3ab8
|
|
...by increasing the deltas to whatever ridiculously large values happen to make
the test pass. Tamás said he'll take a look later.
Change-Id: Ia839608ef3899dfca71886ccf57c31d4eb8bd72d
|
|
Change-Id: I87ca8286f586d5811e4db22ebe4df0317fab567f
|
|
Change-Id: I517fbb53db888276805e3c0d215337425d6cace1
|
|
Change-Id: I936c24c4b1d6854fcfec86dc2642ef57a241b8ea
Reviewed-on: https://gerrit.libreoffice.org/34225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Let's see whether this caused the position and size
differences between different machines.
Change-Id: I6cf0a2fff86d7ce8613d4ca4bbcfe6e001bd9f49
Reviewed-on: https://gerrit.libreoffice.org/34226
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I49e15f57e8eddb53dbf4d1b7ddbf6d33fed116f2
Reviewed-on: https://gerrit.libreoffice.org/34172
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I9f682f976e22407cd47c61bd2874ddf7f6fbc144
Reviewed-on: https://gerrit.libreoffice.org/34188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|