summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2019-05-31tdf#122765: Legend interferes with pie chart after pptx import, second partTamás Zolnai
Revert of: 2903c5f59d257b6ab94f32df64513f2edf94fb0b Reverting this commit does not lead to the original bug to come back, so we can revert it without a problem. Change-Id: I244a6b9451c47e1094db8a77c71b6696e0c464cc Reviewed-on: https://gerrit.libreoffice.org/73139 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 63d17d01da0f9e3a7554e4327244ee4457b7188d) Reviewed-on: https://gerrit.libreoffice.org/73159 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-31tdf#122765: Legend interferes with pie chart after pptx importTamás Zolnai
Revert the commit caused this regression: 0fc41c53dfbd21e526fb0ad68a6651693c4a2ecd The original issue does not come back with reverting this commit. Reviewed-on: https://gerrit.libreoffice.org/72679 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 10609749126ca76eaf12904d4cce9cc5a16d8405) Add unit test for tdf#118150. Reviewed-on: https://gerrit.libreoffice.org/72678 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit a703b4d8842261f55f489c28352df1f53a9b070a) Fix outdated comment. Reviewed-on: https://gerrit.libreoffice.org/72697 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit c43534d5e8d33f73ee4ba70867065be675302579) Change-Id: I666c4f92e3b70b416ec6da7a704298d207451649 cea2c8aacb36e843dad67a056d07d6495fbbb17a 1be6e4cf52ccd385d59f85d9d5fa5b8a47caf4f1 Reviewed-on: https://gerrit.libreoffice.org/72761 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-15Resolves: tdf#120423 dispatch against the correct FrameCaolán McNamara
Change-Id: I5ea2e5d7b79efbd2b14d0b528e5a5c3e44e643bc Reviewed-on: https://gerrit.libreoffice.org/72292 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-04-27Fix CppunitTest_chart2_xshape failing with Display Scaling on WindowsMike Kaganski
See thread starting at https://lists.freedesktop.org/archives/libreoffice/2018-December/081589.html Regression from commit 7263d223ddf42cc39d10a501159c7b04ef48df96. That change has made unit tests DPI-aware; and then some tests started failing on systems with resolutions other than 96 DPI. It has been suggested that the proper fix would be to do for Windows what commit ada20402efa81273e03e46cbedc21f25b9daeeac did for macOS. Another approach would be to fix all the tests to be DPI-aware. I cannot do the first mentioned fix; so I have fixed testFDO74215 test in sw_ooxmlexport4; and added DPI checks to the other failing tests in chart2_xshape and sc_subsequent_filters_test to skip testing when using non-default DPI. This is not ideal, of course, and conditionally skipped tests need to be re-enabled unconditionally once a proper fix arrives. Change-Id: I5c92cfe93ae65f53a8a180fcaec49231df377b8a Reviewed-on: https://gerrit.libreoffice.org/65595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 9520378e37b97b0a44130c86be482060465b479e) Reviewed-on: https://gerrit.libreoffice.org/71356 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-03-26tdf#124112 Insert drawing object in chart crashes LibreOfficeNoel Grandin
regression from commit 6be7e2e9dd8027d284f1b00ef6e3b4654eec7d79 Date: Thu Aug 30 13:54:33 2018 +0200 pass SdrUndoAction around by std::unique_ptr Looks like previously this memory was just leaked, so fix that and the crash Change-Id: I5eb5c104dccd82cef30af533ce1fe8546ced0ea0 Reviewed-on: https://gerrit.libreoffice.org/69648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit dec5b1191d18a059b63cf2d66b1ce95703804079) Reviewed-on: https://gerrit.libreoffice.org/69662
2019-03-20Resolves: tdf#124111 Cannot enter negative numberCaolán McNamara
Change-Id: I9b08595f5dc7ca0bd3e86891330dd1caa0446e63 Reviewed-on: https://gerrit.libreoffice.org/69419 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-20tdf#123504: 0 and 360 are different angles in chartsMike Kaganski
This partly reverts commit 81302f33073e7629d724ed269f1fa21dad29e141. Reviewed-on: https://gerrit.libreoffice.org/69440 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 166a4989a0d1e5a6271c66bceb73a27970afc882) Change-Id: I40cbe739eb4497b8217aca56a2c3661ed1e491f4 Reviewed-on: https://gerrit.libreoffice.org/69447 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-14Resolves: tdf#123694 we need the controller, not the tabpage parentCaolán McNamara
Change-Id: Ib390abaec648a1e06fcc35f83cb170fc654cf021 Reviewed-on: https://gerrit.libreoffice.org/69204 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-05tdf#122226 OOXML Chart Import: data label separatorBalazs Varga
Set the data label separator to "new line" if there is not present explicit point separator and the "percentage format wins over number value format". In MS-Office (2007/2010/2013/2016) the defult separator is the "new line" in that case, any other case the separator is a semicolon. (cherry picked from commit de73efb96fbb1d268caea0f41acbe20a234ec59f) (cherry picked from commit 42fd10b0ab6c6f65ba6394f9ae216c0f13973221) Change-Id: I9ee0fb9f98fc1bb322892616af50954f4f8db0f9 Reviewed-on: https://gerrit.libreoffice.org/67758 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-03-05tdf#97575 Chart OOXML: Export ShapeProps of Error BarsBalazs Varga
Export the shapeProps (fillstyle, linestyle, linewidth, linecolor etc.) of the Error Bars to OOXML. Change-Id: Iff74fa463fdd0fb6ed95e4d1bf0d3e906349860c Reviewed-on: https://gerrit.libreoffice.org/67825 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit b89f239aa9d3d4660380bbd0c893aecde0986032) Reviewed-on: https://gerrit.libreoffice.org/67950 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-02-16tdf#123400 OOXML Chart: Export Data Label SeparatorBalazs Varga
Export the data label separator XML tag and the separated character to OOXML. Change-Id: I9b3bcb588e42a42494107ebde70f4a72492cfac4 Reviewed-on: https://gerrit.libreoffice.org/67753 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e32e5e61b509dcae0462419acfc556d445895840) Reviewed-on: https://gerrit.libreoffice.org/67772 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-12Resolves: tdf#123231 spin-button focus loss triggers changing active radioCaolán McNamara
Change-Id: I6562631df4225d5aa4fe650c40be7c0424eb5621 Reviewed-on: https://gerrit.libreoffice.org/67690 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-10tdf#122800 Chart view: Textbreak of X axis labelsBalazs Varga
Do not break the word into individual letters below each other in the X axis labels. Keep the default 45 degree (even if the textbreak is true) rotation if there is no enough space for a single word between two tickmark. (cherry picked from commit 82913d296709ccf4d4f35d53835bcbf49286ba28) Change-Id: I6f11e55b7ee8373210c1c417e64d552a6cd89812 Reviewed-on: https://gerrit.libreoffice.org/67546 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-08tdf#108021 Chart: Fix text break of column chart X axisBalazs Varga
With this patch the text break is allowed for column chart X axis if the text is rotated with 0, 90 or 270 degree. Also recalculate the nLimitedSpaceForText in case of 90 and 270 degree if the X axis label's text break is true. (cherry-picked from commit: f8d6de19181d749d7c2b345ce7084c0c07fa3eab) (cherry-picked from commit: 40ffaa4f23fe59f979222facf1688d25c60651b6) Change-Id: I5d78be6ed83dd195bbc34185d5f6b7e44f555d9b Reviewed-on: https://gerrit.libreoffice.org/66061 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-02-08tdf#122091 OOXML Import: Automatically break of X Axis labelsBalazs Varga
Set the TextBreak value automatically true, only if the X axis labels rotation is 0 degree. The MS Office using a similar method because there is no any XML tag in the OOXML standard which refer to this setting. Change-Id: Ie84a95935f0d5c4c1f9a30803e22572141385960 Reviewed-on: https://gerrit.libreoffice.org/65853 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 015569fc919b702f7a1b0f09038bafa9f104ca70) Reviewed-on: https://gerrit.libreoffice.org/65934
2019-01-29tdf#123013: Allow to change trendline name in gtk3Xisco Fauli
Change-Id: I3eeb6b8e27cced0a8a86969368f48a2af8ac5892 Reviewed-on: https://gerrit.libreoffice.org/67035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11Resolves: tdf#122398 max/min limits too small for scale FormattedSpinButtonsCaolán McNamara
Change-Id: I679b6cc7e4bfc4273fc438e6d1d897ba66ead77b Reviewed-on: https://gerrit.libreoffice.org/66050 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: tdf#122597 chart dialog should be modalCaolán McNamara
Change-Id: I66881168fe2c6f3d033f2037e3d1b884bb74bc1a Reviewed-on: https://gerrit.libreoffice.org/66016 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-07tdf#122494: Activate orientation by defaultXisco Fauli
Change-Id: I417c5b75206627b84c748ec5ef58c84c80e82683 Reviewed-on: https://gerrit.libreoffice.org/65927 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-20tdf#121744 XLSX Export Combinated Chart (Column and Line)Jozsef Szakacs
Each of the Column and Line Chart creates it's own x and y Axes. So now the LineChart Exporter Method uses the same Axes as the BarChart. Thanks for the help: - Balazs Varga - Adam Kovacs Change-Id: Ie763cf831c2ce63ef204d1fdcbff634e7ca8fad5 Reviewed-on: https://gerrit.libreoffice.org/64146 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/65449
2018-12-20Related: tdf#118705 Fix Column/Bar Chart data label placementBalazs Varga
Modify the chart data label rendering in case of Column/Bar chart only if the datapoint value is 0. This patch fix in case of NEAR_ORIGIN and CENTER DataLabelPlacement. Change-Id: Ia9857b5ac0cc5feaf2e1fd08e98c9f8534e5af04 Reviewed-on: https://gerrit.libreoffice.org/65082 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit abd9272ef1be9da58d405a0ddf3913a816a7e362) Reviewed-on: https://gerrit.libreoffice.org/65440 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
2018-12-18tdf#122090 Chart: Fix OOXML export of X axis labels rotationBalazs Varga
The MS Office UI allows values only in range of [-90,90]. Because of this, we should reflect the angle if the Textrotation is between 90 and 270 degree. Also we have to recalculated the the Textrotation between 270 and 360 degree, because the OOXML counts clockwise. Change-Id: I2fbd53d93ab2e8ea4e26840fd056de20b337daa3 Reviewed-on: https://gerrit.libreoffice.org/65194 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 527772d8dfcedad56b11b5b13540ec1defa464e5) Reviewed-on: https://gerrit.libreoffice.org/65351 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-13tdf#94231 OOXML Import: Fix disappeared Hatch Background ColorBalazs Varga
With adding the PROP_FillBackground property to spnCommonPropIds and spnFilledPropIds the hatch background color imported correctly, an will not disappear. Change-Id: I56745179236d2912a2d5c8585098e54acc4e3062 Reviewed-on: https://gerrit.libreoffice.org/63069 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit dddcfa0089bc84965d7a2c94f5f738a325cfae78) Reviewed-on: https://gerrit.libreoffice.org/64944 Reviewed-by: László Németh <nemeth@numbertext.org>
2018-12-11tdf#114163 Chart: fix order of legend namesBalazs Varga
Respecting the axis direction in case of normal/stacked/percent stacked Bar chart and the legend names will be in the right order. Change-Id: If782393a33e48dae32f919d137e1d1148a85b0b0 Reviewed-on: https://gerrit.libreoffice.org/64632 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 40144617ce05d7eff86eeb8a412c6991fe0b819e) Reviewed-on: https://gerrit.libreoffice.org/64835 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
2018-12-05Related: tdf#121904 widget hidden but label and frame remainCaolán McNamara
if we want to hide the text direction widget, we should hide the rest of the elements too. For now show them all. Change-Id: Icb2ef69c50eb2335170dda9bfcfcb947ce4d6d19 Reviewed-on: https://gerrit.libreoffice.org/64553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-05tdf#121904 use min size for attribute dialogCaolán McNamara
Change-Id: I98cdda7e384dce35f02d20d5b98b61168d34f786 Reviewed-on: https://gerrit.libreoffice.org/64554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-30tdf#42915, NaN in a date axis can destroy the whole chartMarkus Mohrhard
The NaN value forces the scaling of the axis to be based on years and introduces gaps in the rendering. Change-Id: I78219be289d76edb53b5672209e1c031ab62def9 Reviewed-on: https://gerrit.libreoffice.org/64267 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> related tdf#42915, pass NaN through date transformation Many places in chart2 use NaN to mean no available value. Not propagating NaN through the helper disables all this functionality. Change-Id: I37f966007b5b7cc16778c5c6903710fbd144631b Reviewed-on: https://gerrit.libreoffice.org/64266 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/64304
2018-11-28weld DataSourceDialogCaolán McNamara
Change-Id: I4d3eb8aa354043d3ff57b4996db7b28ad25e0262 Reviewed-on: https://gerrit.libreoffice.org/64127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27improve chart type dialog treeview widthCaolán McNamara
Change-Id: I41a053f63db6bced24dd6586e2c347d286339c29 Reviewed-on: https://gerrit.libreoffice.org/64076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26weld DataSourceTabPageCaolán McNamara
Change-Id: I99b7c2ec397829c2f7ceb7ec18ae24195b9781e2 Reviewed-on: https://gerrit.libreoffice.org/64045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26Put text label outside of the pie if..Tamas Bunth
performLabelBestFitInnerPlacement fails. Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305 Reviewed-on: https://gerrit.libreoffice.org/64015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 3339c730f8c9a6088a2e8b335185f1bf0b232216) Reviewed-on: https://gerrit.libreoffice.org/64032 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-11-23Related: tdf#118764 last of the GtkCheckButtons with can-focus FalseCaolán McNamara
Change-Id: I81d3e03a0ccea3851b01d39b2e972b13ef4f6359 Reviewed-on: https://gerrit.libreoffice.org/63870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Related: tdf#118764 last of the GtkRadioButtons with can-focus FalseCaolán McNamara
Change-Id: I1346478fb8bbb1720ecc6cf7c88407be3b126bf1 Reviewed-on: https://gerrit.libreoffice.org/63868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Related: tdf#118764 last of the GtkButtons with can-focus FalseCaolán McNamara
Change-Id: I8001d8c6c950e74df0f909e1cebfb3d1e52a84a4 Reviewed-on: https://gerrit.libreoffice.org/63847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwCondCollPageCaolán McNamara
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 47897fdd936d9b6e9ac8cb6110c79352ab080df7) Reviewed-on: https://gerrit.libreoffice.org/63770
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 492ea7e08571e466e37f870b7642a79df55c2e92) Reviewed-on: https://gerrit.libreoffice.org/63768 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19weld TreeViewCaolán McNamara
a) use GtkTreeStores for GtkTreeViews b) ironically can't store GtkTreeStore contents in .ui apparently c) set show_expanders for all non-trees and unconverted cases d) on-demand subtrees Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31 Reviewed-on: https://gerrit.libreoffice.org/63558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17Adapt to C++2a char_tStephan Bergmann
u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-16loplugin:buriedassign in sd..writerfilterNoel Grandin
Change-Id: I954c12d9e1c493be6ac8c7b15076077b5bff5b74 Reviewed-on: https://gerrit.libreoffice.org/62811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16tdf#114179: Custom size and position of the chart wallJozsef Szakacs
By Xlsx files, rChartSize is using the Values that it gets from getChartSize(), this is the same Size as rPageSize. By Docx files rChartSize was a negative number everytime, so the calcAbsRectangle Method gave back a 'false' Value because of this. The rPageSize shows at every Debugging, Width = 16000, and Height = 9000 for Docx files, and beacause rChartSize was equal to rPageSize by Xlsx, I tried rChartSize with this Fixed Size. Change-Id: Ia29fa3401475c33c1b5e3dde9c3cb030a02cceb4 Reviewed-on: https://gerrit.libreoffice.org/62991 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-16Resolves: tdf#121246 crash in chart dialogsCaolán McNamara
Change-Id: I3bc720e44f5ea15749e6bc0f0fada3a17a783e23 Reviewed-on: https://gerrit.libreoffice.org/63463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-16loplugin:staticmethods improvementNoel Grandin
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755 Reviewed-on: https://gerrit.libreoffice.org/63434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15Resolves: tdf#121341 weld TrendlineTabPageCaolán McNamara
Change-Id: I8ecc1901388986bd6a3822e8d0055e48d873586c Reviewed-on: https://gerrit.libreoffice.org/63387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14move fmtfieldCaolán McNamara
Change-Id: Ic3f4388ea2ca92d9e97d4a9e066eea07c7de79e5 Reviewed-on: https://gerrit.libreoffice.org/63363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-13loplugin singlevalfields improvementNoel Grandin
checking for casting to void* turns out to mask useful stuff, so remove that and just deal with a few extra false+ Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668 Reviewed-on: https://gerrit.libreoffice.org/63145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11cppCheck redundantAssignment variable bUseCustomLabelZdibák Zoltán
Change-Id: Ic900d5116fd1cf5a90526078c6e4802f09589aa7 Reviewed-on: https://gerrit.libreoffice.org/63253 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-11cppCheck redundantAssignmentZdibák Zoltán
Change-Id: Ib9203fa65d7b9825b0a7181dcfc0f522bc575541 Reviewed-on: https://gerrit.libreoffice.org/63242 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-10tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643 Reviewed-on: https://gerrit.libreoffice.org/63235 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-20 00:27:53 +0000