summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2015-07-13disable newly unused code since last disableCaolán McNamara
Change-Id: I9f0abc3963ac4687e29fc629f1b9e9bb1fffaf8a
2015-07-13disable that code for nowMarkus Mohrhard
Change-Id: I9f65babd0314498145746c452180ccf4fab64720 Reviewed-on: https://gerrit.libreoffice.org/17020 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-13chart2: Fix .ui widget namesMaxim Monastirsky
warn:vcl.layout:13283:1:include/vcl/builder.hxx:413: widget "checkbutton_x_axis_title" not found in .ui warn:vcl.layout:14352:1:include/vcl/builder.hxx:413: widget "checkbutton_y_axis_title" not found in .ui Change-Id: I5a6e29b24706df0925038e869be94b0f6a8d232f
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-13loplugin:staticmethodsStephan Bergmann
Change-Id: I8b57b7ce707438ad3c7c901b03c94d9045585ed8
2015-07-12WaE: C2872 chart is ambiguousCaolán McNamara
Change-Id: Ib847a0f4ec804766727a2d7a247912f93b30045c
2015-07-12WaE: C4065 switch contains default but no caseCaolán McNamara
Change-Id: I33620609d0b39c8bedf5641101e5c0229364cde0
2015-07-12add ChartElements panelMarkus Mohrhard
Change-Id: I935a0d637a9ea3a1716d6e839e65c4e565a2c840
2015-07-12big step towards real chart sidebarMarkus Mohrhard
Change-Id: I9b7d1f963746f7689b02099fbae77c9c943bad58
2015-07-12finally manage to register chart2 in the ChartControllerMarkus Mohrhard
We need to do some jumps through pink hoops to connect the chart controller with the host sidebar. Would we use the chart window as parent for our sidebar the sidebar would be directlz beside the chart and not at the border of the host window. Change-Id: Ica44ae370518882ef367999f57251b1256907016
2015-07-12fix crashMarkus Mohrhard
Change-Id: Ic1bc31b68c4a2aafb1e40ebff84fbf052df7041f
2015-07-12add SidebarChangeHandler to chart2Markus Mohrhard
I still need to wire the correct frame to the correct sidebar for it to work. Change-Id: I0fecc2be674d6b024bc39e707930a4c30f67cb81
2015-07-09tdf#91725: Use lighter default colour for minor grid linesKatarina Behrens
Change-Id: I4be2adac1004ad4ace474c9a271cf8e21986da07 Reviewed-on: https://gerrit.libreoffice.org/16819 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-08s/Coordiante/CoordinateTor Lillqvist
Change-Id: Iac584b09844b5877586061e9a44b1f7473bffed4
2015-07-08chart2: typed Link<>Noel Grandin
Change-Id: I98c882d64cb4d6430390ac705f3f2208dd523598
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-04Fix typosAndrea Gelmini
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29return and use std::vector from OInterfaceContainerHelperNoel Grandin
since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-24coverity#1308146 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ida37b83fed0ff5f76fab38153d2e8021a398faa1
2015-06-24coverity#1308147 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1021b02aa2dc9afffa34d52ddfc71f683a594a0e
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22loplugin:saloverrideMiklos Vajna
Change-Id: Ia20ffdc44d33501f5999aa47d990e769dcb632ec
2015-06-22loplugin:passstuffbyrefMiklos Vajna
Change-Id: I17d0aa6e9c0322924c5251eb524e06e91ee43ced
2015-06-22chart2: -Werror=unused-macrosMichael Stahl
Change-Id: I91e8a11934ae10bedfafdd98362e2e1e4f5fe51f
2015-06-22tdf#70673 Power trendline: enable negative Y valuesLaurent Balland-Poirier
With a negative intercept, Y values can be negative Change-Id: I9c23cc89b74498f7e7c7bcee00057627768f48aa Reviewed-on: https://gerrit.libreoffice.org/15357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-22tdf#70673 Exponential trendline: enable negative Y valuesLaurent Balland-Poirier
With a negative intercept, Y values can be negative Rebase with forced intercept fec037e68f0dea164915fbfe1db4699a3861adf4 Conflicts: chart2/source/tools/ExponentialRegressionCurveCalculator.cxx Change-Id: Ie351c006fb1688ef3e657da7ce0789a9da1317f0 Reviewed-on: https://gerrit.libreoffice.org/15353 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-22Add unit tests for chart2 trend calculatorsPhilippe Jung
Will be used to check tdf#70673 is fixed. Test will fail before the fix and should pass after. Change-Id: I9e0fdc696fb99ac2f0e24b04273391d526c629a6 Reviewed-on: https://gerrit.libreoffice.org/16406 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-21Revert "tdf#92231 Potential regression curve calculation is wrong"Philippe Jung
This reverts commit e0e285574244e855fd148ab7320b1aeb5914655a. Wrong fix Change-Id: Iddcbb84efbfc88013c6f2a217cb44061016c043b Reviewed-on: https://gerrit.libreoffice.org/16405 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-21tdf#92231 Potential regression curve calculation is wrongPhilippe Jung
Fixes potential regression curve class. For potential regression curve algorithm, we try to get y = C * D^x Switching to neperian logs: ln(y) = ln(C) + x ln(D) So we make a linear regression and get slope = ln(D) => D = exp(slope) intercept = ln(C) => C = exp(intercept) The current code computes the linear regression between log(y) and log(x) It should be between ln(y) and x. Moreover, the slope is ln(D) so exp(slope) should be returned. Finally, in getCurveValue, the return value is y = C x^D which is wrong Change-Id: If8c952001229d3436be48abfef87c8302cf0544f Reviewed-on: https://gerrit.libreoffice.org/16400 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-19Fix expected/actual argument orderStephan Bergmann
Change-Id: I57a44ce4ca9c1e26366a90fb28616f46c209f7b2
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-14Remove unused OpenGLObjectZolnai Tamás
Change-Id: I5c4832bd076cc5f05f936ac0d6a80027344e40ff
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09cppcheck: variableScopeCaolán McNamara
Change-Id: If0c56c89e2722d47a401363f3854331229856490
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: If5ab427ab320e2623df182e6143c4e7123610eae
2015-06-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-06-08\<the the\> -> theJan Holesovsky
Change-Id: I9d820446411eb7dfca37bb3baf5e994f4ba6f421