summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24AccStatisticsObject is apparently dead codeStephan Bergmann
Change-Id: I4e04b13538d1242ea38d1400df0ced813171bc5e
2017-01-24use rtl::Reference in AccessibleBaseNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I583de7a25893baa65363aa6d3199564f63f4fa60
2017-01-24use rtl::Reference in ControllerCommandDispatchNoel Grandin
rather than storing both a raw pointer and an uno::Reference Change-Id: I46496da508689d82211940da765d53378f72fd7a
2017-01-24use rtl::Reference in ChartModelNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I86846c2c756255eb5627a4b1e5144c41865db895
2017-01-24loplugin: unnecessary destructor: basctl..codemakerNoel Grandin
Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c Reviewed-on: https://gerrit.libreoffice.org/33452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23pass ownership by pointerJochen Nitschke
to show the intend of the code. assert on invalid objects. remove useless OSL_ENSURE. make sure list of owning pointers can't be copied. Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c Reviewed-on: https://gerrit.libreoffice.org/33393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-20chart2: replace custom Deg2Rad/Rad2Deg for basegfx functionsTomaž Vajngerl
Change-Id: Idbc843b54b3037bd55199a8918b06d21eb7b2f2c Reviewed-on: https://gerrit.libreoffice.org/33343 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-20use rtl::Reference in TheModelRefNoel Grandin
instead of manual acquire/release Change-Id: I7a5ae0337fc8fa1465ac716050e7187aa1accb87
2017-01-19New loplugin:dynexcspec: Add @throws documentation, chart2Stephan Bergmann
Change-Id: I9b558b713186c64054914ebfc4c122ff769b71a1
2017-01-19svx: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Id23523170f757361f3fc3d8a18b6db827f45d109
2017-01-19make SfxItemSet with SAL_WARN_UNUSEDNoel Grandin
Change-Id: Ia74ca329d8438f614169031acfbe0406faf7c281 Reviewed-on: https://gerrit.libreoffice.org/33268 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17replace boost::checked_deleter with std::default_deleteJochen Nitschke
and remove all traces of boost/checked_delete.hpp Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2 Reviewed-on: https://gerrit.libreoffice.org/33182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-16b*, c*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
2017-01-16new loplugin: useuniqueptr: chart2Noel Grandin
Change-Id: Ic029ed28fd6de8cf4ee204585c1c6e0c8a4b67ff Reviewed-on: https://gerrit.libreoffice.org/32960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10loplugin:nullptrKhaled Hosny
Change-Id: Iaf69f87564ff0f9f8aab6fafb833714426c8bc30
2017-01-10loplugin:unusedfieldsNoel Grandin
Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1 Reviewed-on: https://gerrit.libreoffice.org/32873 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-05This lock seems uselessTamás Zolnai
m_pCurrentMainType->commitToModel creates the same lock. Change-Id: Iaecf6b3392ce7b1371623f962b0fdc58f8ddaa07
2017-01-05I miss empty lines from between these function definitionsTamás Zolnai
Change-Id: Icec3a948a92bf54bfc442b34cf806e053a9096f3
2017-01-05m_bDoLiveUpdate is always trueTamás Zolnai
Change-Id: I169027a02bd4e0e5c2e0011e6aca4d6063547ca0
2017-01-05Remove useless explicit bool conversionTamás Zolnai
Change-Id: I81caa89fe2ebfb88ce4eb36b8edb9460e9aca9c8
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-21ODR violation (base class must be the same across compilation units)Stephan Bergmann
Change-Id: I6e386574d0366ef75f24811266134d93b28dc3a5
2016-12-21No apparent reason for an unnamed namespace in an include file hereStephan Bergmann
Change-Id: I56f21c94086b34f766e3f2745f5a1291af676984
2016-12-21convert EnumContext::Context to scoped enumNoel Grandin
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3 Reviewed-on: https://gerrit.libreoffice.org/32272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21Recreate the reference files, againKhaled Hosny
After the rounding change in 9eb4b14ffa57cd7bbdf0fc43096f5f1e65c8e388. Change-Id: I0836ba34f23d256075611e9fae1658cf4d737a89 Reviewed-on: https://gerrit.libreoffice.org/32242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-21Add move column right and move row up in DataTablebansan85
Change-Id: Ib224a99636dfbb4451aa26263573af2f3d31b84a Reviewed-on: https://gerrit.libreoffice.org/32265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-18recreate the reference filesMarkus Mohrhard
Change-Id: I24c5943cbb371717e3354fe292800abd1536129e Reviewed-on: https://gerrit.libreoffice.org/32139 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-18add missing component fileMarkus Mohrhard
Change-Id: Ica945030f955cb192cee44a0f97f4f9d881bf9a0 Reviewed-on: https://gerrit.libreoffice.org/32138 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-18-Werror,-Wunused-functionTor Lillqvist
Change-Id: Ia6c8c807c90931da4a5f3cab79d178f88bce290e
2016-12-17Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann
...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-17fix !HAVE_FEATURE_UI buildCaolán McNamara
Change-Id: I5df340811b98c87f8b64fbaca469e2cd4535b81f
2016-12-13post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13Fix fallout from 60b1c95cc47831246f097ee13dda8bcd71c57eb4Tor Lillqvist
Change-Id: I77722619a249616ab59af0eeaeb075e89040c715
2016-12-13Revert "verify SolarMutex when ref-counting VclPtr" seriesNoel Grandin
This reverts the following commits: commit 722f4e1d86710f2facd37d7e040df9e1fd585e26 tdf#104573 - Assertion failed: SolarMutex not locked commit f04ec99f5e6a543b8191ced61db4710c3c0de356 tdf#104573 - Assertion failed: SolarMutex not locked commit 71b1e3ff6374c23e65200d3bcafca387d29af04f tdf#104573 - Assertion failed: SolarMutex not locked when trying commit e794ce1eef6730e5a46d5fb0aa6db2895ede85e7 verify that we hold the SolarMutex when ref-counting VclPtr IRC discussion: <noelgrandin> sberg, maybe I should revert this whole "VclPtr assert" series, I don't have mental bandwidth to sort this out properly now <sberg> noelgrandin, what I fear is that you'll end up adding lots of SolarMutex locks to small places, where the proper fix would be to add it further out; and once such a dreaded recursive SolarMutex lock is in place (but needlessly so, once the proper fix is done), it's hard to clean that up again <noelgrandin> sberg, yeah, in that case I'll just remove all of this, leave it for another day Change-Id: Ie4f84b72b79a1b7e80164b5c7693af398c2c569a Reviewed-on: https://gerrit.libreoffice.org/31946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13change from glew to epoxyCaolán McNamara
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12loplugin:staticmethodsTor Lillqvist
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
2016-12-12loplugin:unreffun and loplugin:externandnotdefinedTor Lillqvist
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
2016-12-11AccessibleEventNotifier AccessibleBase (chart2)Julien Nabet
See https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c876d497dd3320cbc06cf21b7b14ab859755bac This one fixes tdf#104551 Change-Id: Idd173bcb85655ec1b210fa00510fbabba0f5d867 Reviewed-on: https://gerrit.libreoffice.org/31844 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-10tdf#104534: Retrieve list of patternsJulien Nabet
using same way as gradients, bitmap, etc. Change-Id: I49788d5af163aa6f06a12c87ee08e6599fc940c8 Reviewed-on: https://gerrit.libreoffice.org/31833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-08verify that we hold the SolarMutex when ref-counting VclPtrNoel Grandin
Change-Id: If0c5a8c99f0f853c9ecad0f1a4a7299d69805b34 Reviewed-on: https://gerrit.libreoffice.org/31755 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08Try to fix a --disable-gui problemTor Lillqvist
Change-Id: I7fa187b0dea7f058f7486fe2c2e16693f21c063c
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-01tdf#102621: import empty chart cells as NaN instead of 0Jean-Tiare Le Bigot
Change-Id: I574c3f719e52bc2244597532783130564621a891 Reviewed-on: https://gerrit.libreoffice.org/31303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2024-08-19 00:02:01 +0000