summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2019-02-08loplugin:indentation in canvas..chart2Noel Grandin
Change-Id: I9ef57a2e9aaf298f4cfd029aa9b8143871b1bc21 Reviewed-on: https://gerrit.libreoffice.org/67526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-03Fix typoAndrea Gelmini
Change-Id: Iaaae552001af05d0d9cfd5d942876ae488d89e3b Reviewed-on: https://gerrit.libreoffice.org/67299 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-02Fix typoAndrea Gelmini
Change-Id: I19361359910a3b30c12a4bef28308e082b4ff66f Reviewed-on: https://gerrit.libreoffice.org/67273 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-01Better fix for missing [[noreturn]] of CPPUNIT_FAILStephan Bergmann
This includes a revert of commit 9808486a89c6368f836579f8d8c0dda63fd0063c "Avoid -Werror,-Wimplicit-fallthrough with clang-cl", and also undoes older MSVC workarounds (that would start to cause "warning C4702: unreachable code" now). Change-Id: If72bf336e12e0a2db589857e8875003dae861977 Reviewed-on: https://gerrit.libreoffice.org/67248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: If1a2ae9432b1d5b7cfbc89c891d8f86625cc62e1 Reviewed-on: https://gerrit.libreoffice.org/67172 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-31Fix typoAndrea Gelmini
Change-Id: Icc9b6b67e917f2de7fbd3ceed52d03f8ca70d37e Reviewed-on: https://gerrit.libreoffice.org/67186 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-30tdf#122915 Chart OOXML: Export individual data label propBalazs Varga
Export the xLabelPropSet instead of the xPropset and the individual data label formatting will not be disappeared. Change-Id: Ic8c64543ad1e8b40d6d6a5cb7a9a244923e028f1 Reviewed-on: https://gerrit.libreoffice.org/66995 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-01-29tdf#123013: Allow to change trendline name in gtk3Xisco Fauli
Change-Id: I3eeb6b8e27cced0a8a86969368f48a2af8ac5892 Reviewed-on: https://gerrit.libreoffice.org/67026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-24loplugin:constparams in basctl..chart2Noel Grandin
Change-Id: I9ac9a34ba58f411d5aad235407553df63216319c Reviewed-on: https://gerrit.libreoffice.org/66791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-22Related: tdf#108021 Fix text break of X axis labelsBalazs Varga
Recalculate the nLimitedSpaceForText in case of 90 and 270 degree if the X axis label's text break is true. The first part of the fix: https://gerrit.libreoffice.org/65165 Change-Id: I5d78be6ed83dd195bbc34185d5f6b7e44f555d9b Reviewed-on: https://gerrit.libreoffice.org/65937 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-22tdf#122031 Unit test checks pie chart data label format.Gülşah Köse
Change-Id: Ie2f153591e69a7a2718e54a0379725dcd659a737 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/66668 Tested-by: Jenkins
2019-01-20Fix typoAndrea Gelmini
Change-Id: I0bbe9da97de8a71824888ee0d4387aaa338e40a0 Reviewed-on: https://gerrit.libreoffice.org/66645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-18tdf#122800 Chart view: Textbreak of X axis labelsBalazs Varga
Do not break the word into individual letters below each other in the X axis labels. Keep the default 45 degree (even if the textbreak is true) rotation if there is no enough space for a single word between two tickmark. Change-Id: I6f11e55b7ee8373210c1c417e64d552a6cd89812 Reviewed-on: https://gerrit.libreoffice.org/66580 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-18convert MoveDirection to scoped enumNoel Grandin
Change-Id: I077604051af8af05a3a6ea278d7164d39303f09f Reviewed-on: https://gerrit.libreoffice.org/66568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert StockVariant to scoped enumNoel Grandin
and simplify naming Change-Id: Ieada4e83fcc2eafd03f65b1216bf5ad026ced4c7 Reviewed-on: https://gerrit.libreoffice.org/66567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert some enums to scopedNoel Grandin
Change-Id: Ib381bb24abb4bf09c87d9fa372374ce133cb7848 Reviewed-on: https://gerrit.libreoffice.org/66566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18o3tl::make_unique -> std::make_unique in chart2...cuiGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I2ba0b9b44971166bd79527b52745f3c40dc14387 Reviewed-on: https://gerrit.libreoffice.org/66490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-17Fix typoAndrea Gelmini
Change-Id: Ib920de1dfbe5ddf4c8576a00fcc7a557b5a6b2da Reviewed-on: https://gerrit.libreoffice.org/66492 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-15tdf#42949 Fix IWYU warnings in include/toolkit/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icebcf1a6ab073dce935a74ce79ee0f302b62e8a8 Reviewed-on: https://gerrit.libreoffice.org/65947 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-14tdf#42949 Fix IWYU warnings in chart2/qa/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4fa8e6e7dad8b87d8e31140de35fa948f631bee9 Reviewed-on: https://gerrit.libreoffice.org/65888 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-14Fix typoAndrea Gelmini
Change-Id: Ibf7d46963bddddfb3cb75170c43ba8a3279f1c34 Reviewed-on: https://gerrit.libreoffice.org/66281 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-13Fix typoAndrea Gelmini
Change-Id: Ia182da4c6f364d302ca189a10a7e9619211770cc Reviewed-on: https://gerrit.libreoffice.org/66247 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-12Fix typoAndrea Gelmini
Change-Id: I59109cd24cc4d6a40bb72bb7cdd854b8910d7586 Reviewed-on: https://gerrit.libreoffice.org/66204 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-10Resolves: tdf#122398 max/min limits too small for scale FormattedSpinButtonsCaolán McNamara
Change-Id: I679b6cc7e4bfc4273fc438e6d1d897ba66ead77b Reviewed-on: https://gerrit.libreoffice.org/66049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: tdf#122597 chart dialog should be modalCaolán McNamara
Change-Id: I66881168fe2c6f3d033f2037e3d1b884bb74bc1a Reviewed-on: https://gerrit.libreoffice.org/66015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08Removed executable permission on data filesAndrea Gelmini
Change-Id: I20aa503bb011d7222ecc29cb87bb72c0f3ee7539 Reviewed-on: https://gerrit.libreoffice.org/65949 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-07tdf#122091 OOXML Import: Automatically break of X Axis labelsBalazs Varga
Set the TextBreak value automatically true, only if the X axis labels rotation is 0 degree. The MS Office using a similar method because there is no any XML tag in the OOXML standard which refer to this setting. Change-Id: Ie84a95935f0d5c4c1f9a30803e22572141385960 Reviewed-on: https://gerrit.libreoffice.org/65853 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-01-07tdf#122494: Activate orientation by defaultXisco Fauli
Change-Id: I417c5b75206627b84c748ec5ef58c84c80e82683 Reviewed-on: https://gerrit.libreoffice.org/65879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-03tdf#42949 Fix IWYU warnings in chart2/source/controller/* (2)Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Cleaned directories are chartapiwrapper and dialogs Also a few other hxx in other inc dirs that came up during the process Change-Id: Ibf9c33aeee91a92216e8ab512f87acc482e13ae5 Reviewed-on: https://gerrit.libreoffice.org/65566 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-01tdf#114141 draw the top of the zero height 3D barsJozsef Szakacs
in bar charts, instead of leaving an empty place at the zero data point. Note: This is an initial workaround for the interoperability problem. We need a new LibreOffice chart option or setting to support both ways of data visualization. Change-Id: I5c04a265ffe1392f659097054ab11a23374e88b7 Reviewed-on: https://gerrit.libreoffice.org/65269 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-29Do not use indexing for single getToken call, simplifyMatteo Casalin
Change-Id: I8ee0ccbbc596a4edd0da50e8bbcf573afc9bb53b Reviewed-on: https://gerrit.libreoffice.org/65665 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-12-28Use indexed getTokenMatteo Casalin
Change-Id: Ia44cbd763d06948fcf7f7633d0ee0b1aaeeda84a Reviewed-on: https://gerrit.libreoffice.org/65664 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-12-28Fix typoAndrea Gelmini
Change-Id: Ibb25b79c1ec394eb04d40c5419e5cdffc17829f0 Reviewed-on: https://gerrit.libreoffice.org/65651 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-24Fix CppunitTest_chart2_xshape failing with Display Scaling on WindowsMike Kaganski
See thread starting at https://lists.freedesktop.org/archives/libreoffice/2018-December/081589.html Regression from commit 7263d223ddf42cc39d10a501159c7b04ef48df96. That change has made unit tests DPI-aware; and then some tests started failing on systems with resolutions other than 96 DPI. It has been suggested that the proper fix would be to do for Windows what commit ada20402efa81273e03e46cbedc21f25b9daeeac did for macOS. Another approach would be to fix all the tests to be DPI-aware. I cannot do the first mentioned fix; so I have fixed testFDO74215 test in sw_ooxmlexport4; and added DPI checks to the other failing tests in chart2_xshape and sc_subsequent_filters_test to skip testing when using non-default DPI. This is not ideal, of course, and conditionally skipped tests need to be re-enabled unconditionally once a proper fix arrives. Change-Id: I5c92cfe93ae65f53a8a180fcaec49231df377b8a Reviewed-on: https://gerrit.libreoffice.org/65595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-19Removed executable permission on data fileAndrea Gelmini
Change-Id: Idee9984b91c992e4a782332f031b546774fc1568 Reviewed-on: https://gerrit.libreoffice.org/65387 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-18tdf#122121 Fix checkbox alignment & spacing in Data Series dialogAdolfo Jayme Barrientos
Change-Id: Ibe5c344a45b96cd92591ce721c24009a646313d5
2018-12-18tdf#122090 Chart: Fix OOXML export of X axis labels rotationBalazs Varga
The MS Office UI allows values only in range of [-90,90]. Because of this, we should reflect the angle if the Textrotation is between 90 and 270 degree. Also we have to recalculated the the Textrotation between 270 and 360 degree, because the OOXML counts clockwise. Change-Id: I2fbd53d93ab2e8ea4e26840fd056de20b337daa3 Reviewed-on: https://gerrit.libreoffice.org/65194 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-12-18tdf#108021 Chart: Fix text break of column chart X axisBalazs Varga
With this patch the text break is allowed for column chart X axis if the text is rotated with 0, 90 or 270 degree. (The MS Office only allowed the text break of X axis text when the rotation is 0, 90, or 270 degree.) Change-Id: I0914f6208d5a5c0c864dc0227032ef858b044445 Reviewed-on: https://gerrit.libreoffice.org/65165 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-12-14Related: tdf#118705 Fix Column/Bar Chart data label placementBalazs Varga
Modify the chart data label rendering in case of Column/Bar chart only if the datapoint value is 0. This patch fix in case of NEAR_ORIGIN and CENTER DataLabelPlacement. Change-Id: Ia9857b5ac0cc5feaf2e1fd08e98c9f8534e5af04 Reviewed-on: https://gerrit.libreoffice.org/65082 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-12-14tdf#42949 Fix IWYU warnings in chart2/source/controller/*/cxx (1)Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Cleaned directories are: accessibility, drawinglayer, itemsetwrapper, main, sidebar Change-Id: I612eae9dec636d57a3a3a00102d74b964da5b54c Reviewed-on: https://gerrit.libreoffice.org/64307 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-13Fix typoAndrea Gelmini
Change-Id: Ib380d6cbb1d858877cb14263cdc6beff6f0b97af Reviewed-on: https://gerrit.libreoffice.org/65068 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-13use unique_ptr in checkForUniqueItemNoel Grandin
fixing a memory leak in chart2 Change-Id: Idddb6a46b1bde5c1a11148c03bbdaac20ac78e13 Reviewed-on: https://gerrit.libreoffice.org/65031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12Fix typoAndrea Gelmini
Change-Id: I2914579b935a7e7556264222293d043618555b91 Reviewed-on: https://gerrit.libreoffice.org/64997 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-10Fix typoAndrea Gelmini
Change-Id: I8dc57b73218277c4bc9df693578dcb25f5ebbe0a Reviewed-on: https://gerrit.libreoffice.org/64855 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-29 21:58:21 +0000