summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2014-07-10coverity#1224984 Dereference before null checkCaolán McNamara
Change-Id: I05d54983d6231ec0b4293df51c7d55570d10cee7
2014-07-07bnc#881025: Write test for this.Kohei Yoshida
Change-Id: Ifb1f83bbe5f9bb9ecb7fca26f883d1331052f10d
2014-07-07bnc#882383: Add chart unit test for GradientName property.Matúš Kukan
It needs to be set, so that the chart has colors. It was grey before. The bug was fixed already in aacfd5038d05a02f8b1eade3a5896d3d7e959f3d, which got pushed sooner, so this commit only changes the property name from 'INVALID' to 'FillTransparenceGradientName'. Change-Id: If06899258a4307d583480538338480ba5bb830b9
2014-07-04add parenthese to fix precedence issueNorbert Thiebaud
Change-Id: Ifb4c750f4ddedd27593acde4e93331e74e9d37c4
2014-07-04coverity#735602-3 Division by zeroNorbert Thiebaud
Change-Id: I2da9857e4d526b60b3bf50e10ab180c493fb288f
2014-07-04chart2: add some locking to chart::ChartType UNO serviceMichael Stahl
On the libreoffice-4-3 branch, chart2_unoapi crashed with what looks like a corrupted ChartType::m_aDataSeries triggering STL assertions. Try to protect the mutable members with SolarMutex guards. Change-Id: I3f2edd36b8ecf37ef60239415f70abfc8b59244d
2014-07-03Make these non-inline.Kohei Yoshida
Change-Id: I0de443a78e3024c7d3834f964a92f5ccdabe3cc3
2014-07-03Test the import of data series values as well.Kohei Yoshida
There was a bug in there earlier that none of the tests didn't catch. Change-Id: I1f4ed1ba5e08e7842899a140163f9e165705569b
2014-07-03Better and more descriptive naming.Kohei Yoshida
Change-Id: Ic2e3b14399d2acc91c75922a25dc736b1605c320
2014-07-03bnc#812796: Write test for this.Kohei Yoshida
Right now, we skip hidden data series when importing OOXML charts into our internal data table. This of course means that if/when we add support for hidden columns in the internal data table, we may want to change this. Change-Id: Ida1b77821fbc2f8f937244576b52521b59d6ab89
2014-07-03fdo#54361:Add test case for the chart backgroundHeena Gupta
Change-Id: I03f0a45d821b14fe687b3ec7df98f9367adab1f2 Reviewed-on: https://gerrit.libreoffice.org/9978 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-02bnc#812796: Correctly handle static value array for OOXML charts.Kohei Yoshida
We need to pass the role of the data sequence in order to avoid unreliable guess work when importing static value array. Also, not all Excel's scatter plots have real numeric X values; some have textural X values in which case Excel switch to generating 1, 2, 3, ... as X values. When importing to our chart implementation, using "categories" role in such cases instead of "values-x" results in a more faithful chart rendering. Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02More fine-grained check of data series labels in the unit test.Kohei Yoshida
Change-Id: I6b23126816bb114407f2b75545094bc297ee7cc3
2014-07-02remove whitespacesMarkus Mohrhard
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02coverity#705359 Mixing enum typesCaolán McNamara
and coverity#705361 Mixing enum types coverity#705362 Mixing enum types Change-Id: I557d7178277e5d497e3bbab12b75724c05653f57
2014-07-01New loplugin:stringconcatStephan Bergmann
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01coverity#1219805 Uninitialized scalar fieldCaolán McNamara
Change-Id: Id6b15e8515d73cb5bdf4bc6d02d235ebc7e282da
2014-07-01coverity#1213562 Uninitialized scalar fieldCaolán McNamara
Change-Id: I9a40cee6e807599e8e3d9f3df52186fd6226f7e1
2014-07-01coverity#706266 Uncaught exceptionCaolán McNamara
Change-Id: Iba3d2b8cddcd9e0f228d5b9fef1ce3290047c8b0
2014-07-01clang scan-build: various warningsCaolán McNamara
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-30CreationWizard already inherits boost::noncopyable via OutputDeviceMiklos Vajna
Change-Id: Ie155742ea9fc29b5b1adfa219c0bc6fdd78cb637
2014-06-27Flush modified data to the model when pressing OK in the data table dialog.Kohei Yoshida
This dialog used to have no OK / Cancel buttons, and the data would get flushed when the dialog got dismissed. This behavior got lost during the dialog conversion. Also, SaveModified() does check whether or not the data table is modified. No need to call IsModified() before calling SaveModified(). Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c
2014-06-27Missing include dirStephan Bergmann
Change-Id: Id1d1ed3639548b335dff2d9fa5689b90f1ae5f61
2014-06-27fix invalid memory access in chart testsMarkus Mohrhard
Change-Id: I056101d146c939ff958c83efc57fd110e8d52509
2014-06-26fdo#79151: No need to offset column index by category labels.Kohei Yoshida
In fact, doing so would lead to a corrupt internal data table. The internal data stores category labels separately from the column data, so there is no reason why we need to offset for category labels here. Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805
2014-06-26Use new GridPrinter instance for each table.Kohei Yoshida
resize() sometimes leads to a crash. Need to debug later. Change-Id: Ia3809eb4f171369a58b84d5b44001692be1453a1
2014-06-26Track all uses of ErrorBarX and ErrorBarY UNO property names.Kohei Yoshida
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26Prevent a crash while dumping internal data content.Kohei Yoshida
Change-Id: I0938b955b460d8c91607e6df0b9d9e1a4a971013
2014-06-26Better way to dump the content of InternalData.Kohei Yoshida
Row levels are currently not dumped, but that may change later. Change-Id: I849f8b65d6f419bc4d97e2af2d456e73c7e9a355
2014-06-26clang: Uninitialized argument valueCaolán McNamara
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-26Clarify the code a little more.Kohei Yoshida
Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495
2014-06-26Move the category level removal code into its own method.Kohei Yoshida
Change-Id: I4f0cfb4b15bc145b7a5c3491a7acbff13999bf5d
2014-06-25Remove these pesky ::com::sun::star ....Kohei Yoshida
Change-Id: I5c8e1418cc7e01426b67233e48289497a92868d3
2014-06-25Tuck this anonymous namespace inside chart namespace.Kohei Yoshida
This way we can eliminate those explicit '::chart' qualifications. Change-Id: I764e0ca57c8e10f7eac47f48a4cabf28d0562113
2014-06-25Add class descriptions. These two classes' roles were not very clear.Kohei Yoshida
Change-Id: Ib45c9037f2c4b3ee5bfed79f3c93e5020bac477b
2014-06-24Re-use DataSeriesHelper::getRole().Kohei Yoshida
Change-Id: Ia880bc03400d4cbf4c3033e01affafccc0a384fb
2014-06-24Annotate the code a little more, to make it easier to follow.Kohei Yoshida
Change-Id: Iefc61fdc132a18e73b0136f0248d69ab9e07a5e8
2014-06-24Unwind this logic a bit.Kohei Yoshida
Change-Id: I320b28fb319b42eeae7cada31b6f27f9e342db15
2014-06-24Reduce indentation levels.Kohei Yoshida
Change-Id: I5de3dea88a1e6f36c995697ba648ce6b82f4e8ae
2014-06-24Let's remove these lcl_ fetish.Kohei Yoshida
These are not even static local functions anyway, which was what lcl_ prefix was originally used for. Change-Id: I0e6b6cebbcf7cdfb449cf17320fb362fc73d92a8
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-23fdo#76203 - use consistent titlecase for UI title labelsJoren De Cuyper
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9 Reviewed-on: https://gerrit.libreoffice.org/9858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23XY chart needs to set the X value propertyMarkus Mohrhard
Change-Id: Ib17b564c187dfec8abb7a17b2602f814362dd34f
2014-06-22fdo#80295 - Mismatched icons in Chart Data Table dialogJoren De Cuyper
Change-Id: I31d9ea145e8c01a0e81507534e2cf6c584174048 Reviewed-on: https://gerrit.libreoffice.org/9843 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2014-06-22add test case for fdo#78080Markus Mohrhard
Change-Id: If676eb03f5bd19f8abf13d1d7826d500d51e542e
2014-06-22remove now unused dialogMarkus Mohrhard
Change-Id: I42c340a6aee016e37ee558d46a8eab101837e9c5
2014-06-22show the property mapping sequences by defaultMarkus Mohrhard
Change-Id: I32417ed53e491a66f700e77ae0fff2154fa5441c
2014-06-22extract common codeMarkus Mohrhard
Change-Id: I9327f232f1edb9ef052eb7868ac60774f3b6e4cf
2014-06-22add test case for property mappingMarkus Mohrhard
Change-Id: Ib8630d15f40b00c8620eeb1c79d5d9f00d07ef49
2014-06-22don't try to set property mapping if there is no valueMarkus Mohrhard
Change-Id: I422d651e303553e2ce30895b44b8d96664418c19
generated by cgit (git 2.34.1) at 2025-02-25 12:17:23 +0000