summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2015-02-19Missing constructorStephan Bergmann
...the implementation in ChartView.cxx oddly got removed from <https://gerrit.libreoffice.org/#/c/14431/1> to <https://gerrit.libreoffice.org/#/c/14431/2>, but the declaration in chartcore.component was missing from the start Change-Id: I71699ee74278f7e419eca63c5784b46efc42d96b
2015-02-19Clean upStephan Bergmann
Change-Id: Id91be8ec8a97d8fad398d798cd2a9b77773a39e2
2015-02-19add test for tdf#89454Markus Mohrhard
Change-Id: Iefb52f6fa77cf90955dbb47c1b9ca7ab699a43eb
2015-02-18TyposJulien Nabet
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-02-18add test for missing chart area style fill import, tdf#89451Markus Mohrhard
Change-Id: I052838eaf4134a72feb067fc2a1355fabcafe11f
2015-02-18Missing dependencyStephan Bergmann
Change-Id: I4b66f7e549fe318f61b5ec8127ca073b2eb19ed3
2015-02-17tdf#39440 - cppcheck cleanlinessRadu Ioan
Fixed some cppcheck defects Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb Reviewed-on: https://gerrit.libreoffice.org/14487 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-17update chart xshape reference filesMarkus Mohrhard
Change-Id: I499595df25f9a36eb1326cb5374db0541bd42ee4 Reviewed-on: https://gerrit.libreoffice.org/14514 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-02-13Add an overlooked constructor to chartcore.component.Jan Holesovsky
com.sun.star.comp.chart2.report.XMLFilter was pointing to com.sun.star.comp.chart2.XMLFilter by mistake. Change-Id: Ia3c96cc98a4f81f2bb918200dc39eae1dbafdb58
2015-02-13loplugin:literaltoboolconversionStephan Bergmann
Change-Id: I077c8cf0a7f04d5eb926ec55136b25eb9db7a245
2015-02-12tdf#84514: don't hide grid along with checkbox if not neededKatarina Behrens
Regression from .ui migration, which unconditionally (and wrongly) hides the grid with radiobuttons. Do what the old code did - hide the whole frame iff the grid ain't visible. Change-Id: Ia9dc8b166f4031b4c07fbb1969908d314cc3456c
2015-02-12Blind attempt to fix the Windows build.Jan Holesovsky
Change-Id: Iac7b066e3af311f71bbcff7ac418fd3b5e94dff2
2015-02-12Use constructors for services from chartcore.component.Ursache Vladimir
Change-Id: I72227b45f305734060a669275044f6f9c8859bc5
2015-02-12But then again, no need to go via UNO here anyway (cf. previous commit)Stephan Bergmann
Change-Id: I2e5015b9c360fadb6747b5e2e0bd0a62b252312d
2015-02-12Add missing registration of GL3DBarChartType in g_entries_chart2_charttypesStephan Bergmann
...looks like it just got forgotten in 05efb605b36ea340762ef1583b3aea6a6b5cdddb "Add a new skeleton plotter for the GL3D bar chart." Change-Id: I54b7164d3702de6bdbcc3c3e21ea5569ada0336b
2015-02-10Added doc notes for classes and methods used for the scaling automatism.Marco Cecchetti
2015-02-10Added more doc notes for classes and methods used for pie charts.Marco Cecchetti
2015-02-09Fixed a too long comment line.Marco Cecchetti
2015-02-09chart2: fix buildMichael Stahl
Change-Id: I25a960bfdcd9938f68bf4f1535c7822959d95b71
2015-02-09Added doc notes for classes and methods used for pie charts.Marco Cecchetti
2015-02-08Typo: relaese->releaseJulien Nabet
Change-Id: I9e2e8f11c376fc808b12bc1db509babeac0ff7d8
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Ifdbeea8d4e49ae38b843675758fcc29aee974bdf
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-02coverity#1267657 Logically dead codeCaolán McNamara
Change-Id: I50bb5d47c5f430818237308a691306dc097d245e
2015-01-30chisel off some more unused codeCaolán McNamara
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-23Resolves: fdo#88229 Crash when you try to create a bar chart GL3DCaolán McNamara
Change-Id: I6390f8988ca287de19e9981053bdeb9473d1e3e1
2015-01-23'Ownership' is one word, as is 'relationship'Tor Lillqvist
Change-Id: I45c441f68ed5f20cfc87e34e7bfb529a30952f81
2015-01-23Allow for null xModel in TitleHelper::getTitleStephan Bergmann
Witnessed a JunitTest_chart2_unoapi failure where (deep within Idle::Timeout) chart::impl::ModelState::update is apparently called with a null xModel. All the code called from there appears to be careful to handle a null xModel, except for chart::TitleHelper::getTitle, which---presumably by accident---stopped doing so with 401f01caf5b357ac6c15b37a89c0a9aaeb46f4e4 "use ChartModel instead of XModel in a few places." Change-Id: I5788b5e41a6d68fe193cb214d736ee54c4c581d7
2015-01-20Some more loplugin:cstylecast: chart2Stephan Bergmann
Change-Id: I5cfbf9bb47d4464db0226d44397f76cb6f972b50
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07fdo#39440 reduce scope of local variablesŁukasz Hryniuk
Beside scope changes, it fixes lack of initialization in a few places. Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2 Reviewed-on: https://gerrit.libreoffice.org/13755 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05fdo#67343 Arrange Help button in a secondary groupAdolfo Jayme Barrientos
This helps de-clutter action button groups and eases visual scanning. This patch also contains little layout tweaks where needed to separate the Help button from its neighbors when the dialog is too small. Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce Reviewed-on: https://gerrit.libreoffice.org/13427 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-03fdo#39440 reduce scope of local variablesŁukasz Hryniuk
Change-Id: Iabcd57c5f11a53db9fc6fab3606a9ab36c94fcc0 Reviewed-on: https://gerrit.libreoffice.org/13722 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-03fdo#83058 File corrupt due to data label position is invalid in chart.xmlPriyankaGaikwad
- File getting corrupted after RT due to data label position is invalid in chart.xml - LO must not export invalid label position property if chart type doesn't support that positioning in MS Office. - For clusterd bar chart XML Difference chart1.xml Original file <c:barChart> <c:grouping val="clustered" /> <c:ser> <c:dLbls> ... <c:dLbl> <c:dLblPos val="outEnd" /> </c:dLbl> ... </c:dLbls> </c:ser> </c:barChart> Roundtrip file <c:barChart> <c:grouping val="clustered" /> <c:ser> <c:dLbls> ... <c:dLbl> <c:dLblPos val="r" /> </c:dLbl> ... </c:dLbls> </c:ser> </c:barChart> Change-Id: I9cae11b8d198aaa70fb05cb3bf329cd898519170 Reviewed-on: https://gerrit.libreoffice.org/11141 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-24bnc#830738 Now all axis labels of a chart are displaied.Marco Cecchetti
Problem: Some axis labels of a chart are missing, when they should not. Analysis and solution: The current implementation is affected by the following issues: 1) When the method switches to the 45-degrees layout the `nRhythm` parameter is not reset to 1. 2) The bounding boxes computed by the `doesOverlap` test routine for the 45-degrees layout are wrong. Because of the first issue only one label every `nRhythm` is showed even if in the 45-degrees layout no overlap occurs. The second issue is located inside the `lcl_getRotatedPolygon` routine which is used by the `doesOverlap` routine for building a polygon representing the bb for a text label. The polygon is created in the following way: a new rectangle is created: the top-left vertex is placed at axes origin and it is initialized with the same width and height of the bb of the passed text label. Later several transformations are performed on the new rectangle: 1) the rectangle is rotated by a 45-degrees angle respect with its center; 2) the rectangle is translated by a vector equals to the top-left vertex of the bb of the passed text label. There are 2 errors in this sequence of transformations: 1) The `B2DHomMatrix` class used for representing the transformation, performs rotations in the positive direction (from the X axis to the Y axis). However since the coordinate system used by the chart has the Y-axis pointing downward, a rotation in the positive direction means a clockwise rotation. On the contrary text labels are rotated counterclockwise. This can be easily fixed by using the opposite angle. 2) Rotating the rectangle respect with its center is wrong since the fixed point of the rotation must be the top-left corner of the rectangle: in this way when the final translation is performed the top-left vertex of the transformed rectangle will be coincident with the top-left vertex of the text label bb, and so the transformed rectangle will be coincident with the text label bb. Change-Id: Ia8072c3d5bd6c1a11f66c33d45d56e55634edf4c
2014-12-22update the xml files with current reference filesMarkus Mohrhard
Change-Id: Ia1a392e41939485844ad1b518bcdd0d01a80febb
2014-12-18fix buildCaolán McNamara
Change-Id: I920227cd175dace306ebb16a8e476f483cf11a7a
2014-12-18chart2: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
2014-12-18bCategoriesUsed is always false at this pointLionel Elie Mamane
Change-Id: I7e6851ce3f24ef3c5051eb7431b6aa1df845836d
2014-12-15chart2: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ia5a340049f787d7173140482853730a00d5d12df
2014-12-10java: remove comment noiseNoel Grandin
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6 Reviewed-on: https://gerrit.libreoffice.org/13408 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-09changed timers to idleJennifer Liebel
Change-Id: Ibdecb970f7e6119929ec172e56d986c682008487
generated by cgit (git 2.34.1) at 2025-02-08 18:16:20 +0000