summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2020-10-27Fire selection change event before sidebar is unregisteredSzymon Kłos
Prevent us from crash in online using mobile phone when leaving chart edit mode with chart type modified. Change-Id: I8da70612786141a2c92b55a45822ef8ff5713e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104606 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-26tdf#137505 OOXML Import: Custom shape in chart: fix font sizeBalazs Varga
The default font size of text in shapes is 12pt in LibreOffice, nevertheless, we used 24 pt for font size in custom shapes inside chart objects during ooxml import. Change-Id: I69d02374bc4b4781e2ca617913c642999b3d5fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104429 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-21use tools::Long in basegfx..chart2Noel
Change-Id: Ide4014348d51f0b5f59e1e91b8d41c7748853254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20cid#1468269 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4457019570571c810265bf721cdefb0bdd65dd7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104551 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-19tdf#137585 Chart ODF: fix export of DataLabelPlacement::CUSTOMTünde Tóth
Saving .ods, the DataLabelPlacement::CUSTOM converted to the default "avoid-overlap" instead of the requested "outside". Follow-up of commit 20da1a5dd37c7edac620566c992d5a53b23a5f12 (tdf#134978 Chart OOXML Import: fix pie chart label custom position) Change-Id: Ib15c7f24e0a650c84e6afce08b84e7eece8dafea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104430 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19tdf#134121 pie chart: add leader linesTünde Tóth
to data labels with custom position. See commit 769433ad93040bc81f06672c8a2c01e2b76fece3 (tdf#90749 chart: add leader lines to custom data label positions) Change-Id: If5d912cc04993e59bd5ab93b644ea49ba8642b49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104410 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19tdf#137154 pie chart: improve Outside position of data labelsTünde Tóth
Some pie chart data labels were too close to the pie with Outside placement. Change-Id: I0eecdfc32601bdfa8bb3115183f9ca723a9f945b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103683 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-16chart2: use the fastparser API when possibleNoel
part of the process of making SvXMLImport fastparser-only Change-Id: I9fd7dbcc8b5c345f7e86bc06b1b898b7d39f36da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-09tdf#134978 Chart OOXML Import: fix pie chart label custom positionTünde Tóth
Follow-up of commit dff7a46fb46d1fa2a3ad674ee493ae2d59150fe3 (tdf#130032 Chart OOXML Import: fix data label custom position). Change-Id: Iaaf4ae654ac0c1b4896a53be6034e6c027412df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102981 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06lok: Add posibility to change chart fill colorSzymon Kłos
Change-Id: I519a0fe15c4983803109aed7eef840d36a5e7b21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102920 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103141 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-06Use default diagram page selection for chartsSzymon Kłos
Change-Id: I0bf0e5d2d1ef43a61c1bb723b25bafa30b5ad5c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104013 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-02tdf#137116 pie chart: improve BestFit position of data labelsTünde Tóth
Regression from commit: 2e1a1054a4a98415057e72269ace9db075d3b191 (tdf#136752 pie chart: improve data label position) Change-Id: I66943684957a220c81db7f928fbb47700b78d012 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103610 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-02tdf#137165 chart2: fix label position in Position and SizeBalazs Varga
dialog window. Follow-up of commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property). Change-Id: Ie676af7b9438b928041a404fb1efac6919b30030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103750 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-02lint-ui.py check that GtkMenuButton has a label propertyNoel
Change-Id: Ib1aa8ee050d2425387ddc1080f11f0ddfc2f9236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-01loplugin:reducevarscope in canvas,chart2Noel
Change-Id: I6c73e609cc8ce0ed9cf0f5a6b68c6e299bf26a44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-29Add extended tip to chart2 leader lines uiOlivier Hallot
Remove mention to pie charts Change-Id: I00fffd6a77be5905266999c3dc8953a507aabf15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103556 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-28Removed duplicated includeAndrea Gelmini
Change-Id: I0eb3ea540270dd2200c957762139c68eaedd9fd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103538 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-09-28rename for disentangling AA and B2D use in VCL drawingLuboš Luňák
This renames AntialiasingFlags::EnableB2dDraw to just Enable, and the AntiAliasB2DDraw names to just AntiAlias. This is in preparation for a second commit that will actually separate the AA and B2D functionality of these flags. Change-Id: I9cc215c5752dfabce41e00e19d9074fc8dc3d4de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103416 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-28tdf#108059 Introduce compatibility key for pie chart orientationKelemen Gábor
There is no similar setting in MSO, it just always uses clockwise. LO on the other hand confuses users by using counterclockwise which turns to clockwise upon save to OOXML and reload. Eliminate this behavior by introducing a compatibility key for OOXML-heavy environments that: - sets the orientation to clockwise when pie chart type is selected - hides the checkbox that would have no effect after a save to OOXML Default value is false to keep current behavior Change-Id: I9e12ecad8e9978f960c921a521461aee023a5063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/82524 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-28Fix typo in codeAndrea Gelmini
Change-Id: Ifab76c880b1802740689704f929858b261e1f5bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103488 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I76287ff3309c78283947886882456a01cdc01725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103463 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-24Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Icf1d8dae0f357aabeeda70f8c059e4cbf785df89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103309 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-09-24tdf#136402 Chart View: remove custom label textBalazs Varga
Now Delete Data Labels and Insert Data Labels local menu options remove custom label text instead of keeping it. See with unit test document custom_data_label.xlsx of commit bcda268cde1f8408c2066ce985acedfce3e3bc2e (tdf#134977 Chart OOXML: fix import of custom data label). Change-Id: Ifc7afd0f2ece9da528e6206a6bd393b394b36f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101929 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-23Fix typoAndrea Gelmini
Change-Id: I29de3e8483f3a6921bdf3d402fd10d0d587da2c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103250 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-23tdf#136752 pie chart: improve data label positionTünde Tóth
to avoid chart distortion. Set the maximum text width of data point label shape based to the 80% of the remaining space, when text wrapping is enabled and the label placement is AVOID_OVERLAP. Change-Id: I174089ec62df3aa21b5d1f26f74d475945d83684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102744 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-22Move MimeContentTypeFactory into vclJan-Marek Glogowski
The code is just used in vcl from LO's POV. This way we can drop the dtrans directory and get rid of yet an other library. Change-Id: Id77568e63a6fef4af30b49e035a9d76211b127a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103210 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-22OUStringLiteral/OStringLiteral coverity PARSE_ERROR workaroundCaolán McNamara
do more like commit 121771e37f7e2de41cd5643475861062bf25627b Date: Mon Sep 21 09:17:54 2020 +0200 Make some OUStringLiteral vars constexpr cause coverity can live with that Change-Id: I9efd7f848289c4865997a44c6780373068422227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-22cid#1467075 silence Unchecked return valueCaolán McNamara
Change-Id: I77809ff271004a216131f26a26696d5717877a8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-22tdf#136650 DOCX pie chart import: fix percentageBalazs Varga
Follow-up of commit e0da00d655ecca5986eea3812a8a670c6adbc40f (tdf#132174 Chart DOCX import: fix label number format). Change-Id: Ie0b2fe6305d7696de6dddc1f17d078fc2e749e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102753 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-21update pchesCaolán McNamara
Change-Id: I41a204fbc5e2c9b819fb948c5288f8d7b4195489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-20cid#1466912 silence Unchecked return valueCaolán McNamara
Change-Id: I5d8ef4a52f0aeef9012445a382aa472bd69ec925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-19tdf#135366 Save line and fill of data labels to ODFRegina Henschel
LibreOffice has line and fill properties of data labels in charts as loext attributes in the style of the <chart:series> or <chart:data-point> element. For ODF there has to be a <chart:data-label> element with line and fill properties in its style. This patch adds the needed <chart:data-label> elements and their associated <style:style> elements. The element <chart:data-lable> exists in ODF since version 1.2. The solution requires no extended namespace. The check is adapted in lcl_getCustomLabelField. Import was already done in commit 87d1ebeb11a00301745ee3c3c03fffb7033ab59d Change-Id: I829dae5433e8257c775aa4f08e511d514df4e936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102381 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-09-18tdf#136247 OOXML export data label background color.Gülşah Köse
Change-Id: Ie3e00e8195239e6570bfe76c2451bae11c209145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102999 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-18tdf#136267 OOXML Chart Import: create main category axis labels onceBalazs Varga
because InternalDataProvider can not handle different category names on the primary and secondary category axis. Revert e0b0502516a10181bbd1737b93b38b2bba4c98e8 commit, except the relevant unit test. Regression from commit: e0b0502516a10181bbd1737b93b38b2bba4c98e8 (tdf#128016 Chart OOXML Import: fix duplicated category labels) Also fix tdf#129994 (FILEOPEN - hang at import time), which is a a regression from commit fa0a981af41a2606541eec1cb20a379a739691e0 (tdf#114166 DOCX chart import: fix missing complex categories) Change-Id: I5d049e760eb1a647ea774be264349a2f16f15f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102463 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-17tdf#133482 don't increase dialog width when new columns addedCaolán McNamara
gtk will expand to fit all children, while vcl will clip. insert a borderless ScrolledWindow with "external" scrolling to allow the dialog to clip the children (same thing we do for our menubar to shrink down past its natural size) adjust the width calculation to avoid logictopixel rounding Change-Id: Id2e4f92959f1827c6960360d1530a9c63a4d0c00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uStringStephan Bergmann
...from which an OUString can cheaply be instantiated. This is the OUString equivalent of 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String". Most remarks about that commit apply here too (this commit is just substantially bigger and a bit more complicated because there were so much more uses of OUStringLiteral than of OStringLiteral): The one downside is that OUStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a container that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::u16string_view, without loss of efficiency compared to the original OUStringLiteral, and without loss of expressivity. The new OUStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OUStringLiteral is in all cases where an object that shall itself not be an OUString (e.g., because it shall be a global static variable for which the OUString ctor/dtor would be detrimental at library load/unload) must be converted to an OUString instance in at least one place. Other string literal abstractions could use std::u16string_view (or just plain char16_t const[N]), but interestingly OUStringLiteral might be more efficient than constexpr std::u16string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. Global constexpr OUStringLiteral variables defined in an included file would be somewhat suboptimal, as each translation unit that uses them would create its own, unshared instance. The envisioned solution is to turn them into static data members of some class (and there may be a loplugin coming to find and fix affected places). Another approach that has been taken here in a few cases where such variables were only used in one .cxx anyway is to move their definitions from the .hxx into that one .cxx (in turn causing some files to become empty and get removed completely)---which also silenced some GCC -Werror=unused-variable if a variable from a .hxx was not used in some .cxx including it. To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc. In a similar vein, comparison operators between OUString and std::u16string_view have been added to the existing plethora of comparison operator overloads. It would be nice to eventually consolidate them, esp. with the overloads taking OUStringLiteral and/or char16_t const[N] string literals, but that appears tricky to get right without introducing new ambiguities. Also, a handful of places across the code base use comparisons between OUString and OUStringNumber, which are now ambiguous (converting the OUStringNumber to either OUString or std::u16string_view). For simplicity, those few places have manually been fixed for now by adding explicit conversion to std::u16string_view. Also some compilerplugins code needed to be adapted, and some of the compilerplugins/test cases have become irrelevant (and have been removed), as the tested code would no longer compile in the first place. sal/qa/rtl/strings/test_oustring_concat.cxx documents a workaround for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". That place, as well as uses of OUStringLiteral in extensions/source/abpilot/fieldmappingimpl.cxx and i18npool/source/localedata/localedata.cxx, which have been replaced with OUString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). Change-Id: I34174462a28f2000cfeb2d219ffd533a767920b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-15tdf#133227 chart UI: option to hide leader linesBalazs Varga
between data points and displaced data labels of a data series. Follow-up of the following commits related to the new UNO property ShowCustomLeaderLines for data labels: commit e2f4e65a7b8024c00b049eebf0d87637efda7f24 (tdf#134571 chart2, xmloff: add loext:custom-leader-lines) commit 5d67d70b26706ce8a08612c12a68821f984210a2 (tdf#134563 Add UNO API for custom leader lines) Change-Id: Id8a953b16ff737ca924c0c2c3241fba4e3ac904b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102221 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-15tdf#77007: chart must honor its parent's IsEnableSetModifiedMike Kaganski
Regression from commit bb97ecdbcc8d8dafd39e728b21bc68efee4eccbc, which had dropped storing chart doc (calling its storeOwn) while loading back in 2012, to avoid performance problems when loading XLS. Funnily, in 2013, commit a666862deffa33013d3df3bb62e87c67f9a89948 was merged, that was expected to solve exactly the same problem as this change, by calling storeOwn for charts being loaded; while obviously not fixing the problem properly, it seems to had undone the effect of the Markus's commit. The latter commit had a side effect of updating views of modified charts while exporting them inside storeOwn, which made respective draw pages to be up-to-date right after loading, including those on inactive sheets. Now, after this change, this is not so, thus unit tests' getChartDocFromSheet was made to update the view explicitly. Unfortunately, it's not yet possible to revert the change from commit a666862deffa33013d3df3bb62e87c67f9a89948, because obviously some dependency grew, which makes e.g. testTdf122594 fail if that commit is reverted. Given that testTdf122594 has no charts, storing the modified objects while loading has much wider side effects than was expected by author of a666862deffa33013d3df3bb62e87c67f9a89948. Change-Id: Iee1b9ef6f4d8c2dfa0a49680c5e2b465f1817a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102534 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-13Unify the code used to get object shell for componentsMike Kaganski
and their parents across the codebase. Change-Id: Ifb37fb940d285f81c1724a912204533e8c3b0044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-11tdf#136573 chart2: enable arrow keys in data labelTünde Tóth
moving to custom positions. Follow-up of commit c10d5854b5427ad1bfffc00e77a9306c99c78c63 (tdf#136430 Fix chart crash trying to move data labels with arrow keys.) Change-Id: I8833e14a7c9c8f7bdb758fc0eb97be38aee35b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102262 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-10remove image_position top from GtkButtonandreas kainz
Change-Id: Ib7a8eb77b31a8abb08be501b1e0ce8d480f163c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102340 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-09improve loplugin:unusedvarsglobalNoel Grandin
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07loplugin:unusedfieldsNoel Grandin
Change-Id: Id1b1c07ddcacca8eef8af71890d9392f29b6be6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I596ef2603560f521386e273b6f0fb2f672db56d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07tdf#136430 Fix chart crash trying to move data labelsBalazs Varga
with arrow keys. Change-Id: I357c320406d9f044b12b1289aa0f88045001c283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102002 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-05tdf#135366 ODF import of line and fill of data labelsRegina Henschel
LibreOffice has line and fill properties of data labels in a chart in properties of kind "LabelBorderWidth" or "LabelFillColor" at a data point or, as defaults for the points, at a series. But ODF has such information in a <style:style> element, which is refered by a <chart:data-label> element. That one can be child of a <chart:data-point> and child of a <chart:series> element. Microsoft Office correctly uses the <chart:data-point> element and its style for the line and fill properties of data labels. Up to now LO cannot import such information and does not write the ODF elements. Instead LibreOffice reads and writes attributes in 'loext' namespace. Using the "LabelFoo" properties was implemented by Kohei Yoshida, July 2014. Although there is no published service, these properties can be used in macros. Because they are now available since six years, the decision was to keep this internal model and convert on import and export. This patch implements the import of the ODF fill and line properties from the <chart:data-label> element and converts them to the internal used properties. LibreOffice has currently only implemented a few of the possible line and fill properties. When more are implemented, their <ODF,LabelFoo> pairs need to be added to the array aApiToLabelFooPairs, further adaptions are not needed. The <chart:data-label> contains in addition the absolute position of a data label. LibreOffice has internally only a position offset relative to the regular position of the label. The conversion of the position is not included in the patch. Change-Id: I5fd868945585971dac3dd945804a4a2951b8c12d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101194 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
generated by cgit (git 2.34.1) at 2025-01-10 15:42:28 +0000