summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2019-03-04simplify UNO getTypes methodsNoel Grandin
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unnecessaryoverride look for more patternsNoel Grandin
like bool Foo::bar() { b = Super::bar(); return b; } Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7 Reviewed-on: https://gerrit.libreoffice.org/68418 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:simplifybool improve search for negated operatorNoel Grandin
Change-Id: Id6ac35fefa5c3e1f64c222713791e849b3cb4d34 Reviewed-on: https://gerrit.libreoffice.org/68379 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25loplugin:unusedfields in variousNoel Grandin
Change-Id: I31d0e6c3559af2e322fb474b97f3bbf4d5064831 Reviewed-on: https://gerrit.libreoffice.org/68280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19tdf#42949 Fix IWYU warnings in include/framework/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia9616f644a68ec6da22e646ba0d919a3489a9481 Reviewed-on: https://gerrit.libreoffice.org/67745 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-18Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: Ib09622d0fd01546f3020a2fd40e5e89a33517277 Reviewed-on: https://gerrit.libreoffice.org/67946 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-15These items are of type SfxUInt32ItemStephan Bergmann
...see include/svx/svxids.hrc for SID_ATTR_NUMBERFORMAT_VALUE and chart2/source/inc/chartview/ChartSfxItemIds.hxx for SCHATTR_AXIS_CROSSING_MAIN_AXIS_NUMBERFORMAT, and as reported by -fsanitize=vptr in sc/qa/uitest/chart/tdf122398.py recently added to UITest_chart (<https://ci.libreoffice.org/job/lo_ubsan/1188/>). Change-Id: Ic1e2f3390bd54b722730e6dd7962d613587774b1 Reviewed-on: https://gerrit.libreoffice.org/67884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15tdf#97575 Chart OOXML: Export ShapeProps of Error BarsBalazs Varga
Export the shapeProps (fillstyle, linestyle, linewidth, linecolor etc.) of the Error Bars to OOXML. Change-Id: Iff74fa463fdd0fb6ed95e4d1bf0d3e906349860c Reviewed-on: https://gerrit.libreoffice.org/67825 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-14Removed executable permission on docx fileAndrea Gelmini
Change-Id: I9908b65280ae4e468a73932e9e560e8a4b0f01f4 Reviewed-on: https://gerrit.libreoffice.org/67799 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13tdf#123400 OOXML Chart: Export Data Label SeparatorBalazs Varga
Export the data label separator XML tag and the separated character to OOXML. Change-Id: I9b3bcb588e42a42494107ebde70f4a72492cfac4 Reviewed-on: https://gerrit.libreoffice.org/67753 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-12Removed executable permission on docx fileAndrea Gelmini
Change-Id: I66dcbda8d91d05229b2c6c9185a4d02ce5361294 Reviewed-on: https://gerrit.libreoffice.org/67742 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-12tdf#122226 OOXML Chart Import: data label new line separatorBalazs Varga
Set the data label separator to "new line" if there is not present explicit point separator, just like in MS Office. Change-Id: I9ee0fb9f98fc1bb322892616af50954f4f8db0f9 Reviewed-on: https://gerrit.libreoffice.org/67533 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-11Resolves: tdf#123231 spin-button focus loss triggers changing active radioCaolán McNamara
Change-Id: I6562631df4225d5aa4fe650c40be7c0424eb5621 Reviewed-on: https://gerrit.libreoffice.org/67689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Meryem Ezber
Change-Id: I4446858ed30df4adffbf18ab609c95690cff99c0 Reviewed-on: https://gerrit.libreoffice.org/67668 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-11tdf#112689: Replace chained O(U)StringBuffer::append() with operator+Meryem Ezber
Change-Id: Icfedb77943721f0ed7504ec68c3b63c4709352bc Reviewed-on: https://gerrit.libreoffice.org/67615 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-11tdf#120703 PVS: remove obsolete check (leftover from static removal)Mike Kaganski
V560 A part of conditional expression is always true: !pSymbolList. In commit a2cd17d19085d739b979445d7f9ec7158b89df49, pSymbolList and xSymbols were made non-static. The check below was left though. Actually, I don't know if that was a safe move, since it's unclear how the lifetime of the returned pointer is managed now to prevent use-after-free. Change-Id: Ia51a9790503694f909ce7953337d3caaebfabfc1 Reviewed-on: https://gerrit.libreoffice.org/67512 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I62cb3b8927d664b3d5359ee6ac7db30d354f4821 Reviewed-on: https://gerrit.libreoffice.org/67496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-09Fix typoAndrea Gelmini
Change-Id: I72fafb21ac51de7537622b5265af266073cdb293 Reviewed-on: https://gerrit.libreoffice.org/67576 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-08loplugin:indentation in canvas..chart2Noel Grandin
Change-Id: I9ef57a2e9aaf298f4cfd029aa9b8143871b1bc21 Reviewed-on: https://gerrit.libreoffice.org/67526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-03Fix typoAndrea Gelmini
Change-Id: Iaaae552001af05d0d9cfd5d942876ae488d89e3b Reviewed-on: https://gerrit.libreoffice.org/67299 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-02Fix typoAndrea Gelmini
Change-Id: I19361359910a3b30c12a4bef28308e082b4ff66f Reviewed-on: https://gerrit.libreoffice.org/67273 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-01Better fix for missing [[noreturn]] of CPPUNIT_FAILStephan Bergmann
This includes a revert of commit 9808486a89c6368f836579f8d8c0dda63fd0063c "Avoid -Werror,-Wimplicit-fallthrough with clang-cl", and also undoes older MSVC workarounds (that would start to cause "warning C4702: unreachable code" now). Change-Id: If72bf336e12e0a2db589857e8875003dae861977 Reviewed-on: https://gerrit.libreoffice.org/67248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: If1a2ae9432b1d5b7cfbc89c891d8f86625cc62e1 Reviewed-on: https://gerrit.libreoffice.org/67172 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-31Fix typoAndrea Gelmini
Change-Id: Icc9b6b67e917f2de7fbd3ceed52d03f8ca70d37e Reviewed-on: https://gerrit.libreoffice.org/67186 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-30tdf#122915 Chart OOXML: Export individual data label propBalazs Varga
Export the xLabelPropSet instead of the xPropset and the individual data label formatting will not be disappeared. Change-Id: Ic8c64543ad1e8b40d6d6a5cb7a9a244923e028f1 Reviewed-on: https://gerrit.libreoffice.org/66995 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-01-29tdf#123013: Allow to change trendline name in gtk3Xisco Fauli
Change-Id: I3eeb6b8e27cced0a8a86969368f48a2af8ac5892 Reviewed-on: https://gerrit.libreoffice.org/67026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-24loplugin:constparams in basctl..chart2Noel Grandin
Change-Id: I9ac9a34ba58f411d5aad235407553df63216319c Reviewed-on: https://gerrit.libreoffice.org/66791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-22Related: tdf#108021 Fix text break of X axis labelsBalazs Varga
Recalculate the nLimitedSpaceForText in case of 90 and 270 degree if the X axis label's text break is true. The first part of the fix: https://gerrit.libreoffice.org/65165 Change-Id: I5d78be6ed83dd195bbc34185d5f6b7e44f555d9b Reviewed-on: https://gerrit.libreoffice.org/65937 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-22tdf#122031 Unit test checks pie chart data label format.Gülşah Köse
Change-Id: Ie2f153591e69a7a2718e54a0379725dcd659a737 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/66668 Tested-by: Jenkins
2019-01-20Fix typoAndrea Gelmini
Change-Id: I0bbe9da97de8a71824888ee0d4387aaa338e40a0 Reviewed-on: https://gerrit.libreoffice.org/66645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-18tdf#122800 Chart view: Textbreak of X axis labelsBalazs Varga
Do not break the word into individual letters below each other in the X axis labels. Keep the default 45 degree (even if the textbreak is true) rotation if there is no enough space for a single word between two tickmark. Change-Id: I6f11e55b7ee8373210c1c417e64d552a6cd89812 Reviewed-on: https://gerrit.libreoffice.org/66580 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-18convert MoveDirection to scoped enumNoel Grandin
Change-Id: I077604051af8af05a3a6ea278d7164d39303f09f Reviewed-on: https://gerrit.libreoffice.org/66568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert StockVariant to scoped enumNoel Grandin
and simplify naming Change-Id: Ieada4e83fcc2eafd03f65b1216bf5ad026ced4c7 Reviewed-on: https://gerrit.libreoffice.org/66567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert some enums to scopedNoel Grandin
Change-Id: Ib381bb24abb4bf09c87d9fa372374ce133cb7848 Reviewed-on: https://gerrit.libreoffice.org/66566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18o3tl::make_unique -> std::make_unique in chart2...cuiGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I2ba0b9b44971166bd79527b52745f3c40dc14387 Reviewed-on: https://gerrit.libreoffice.org/66490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-17Fix typoAndrea Gelmini
Change-Id: Ib920de1dfbe5ddf4c8576a00fcc7a557b5a6b2da Reviewed-on: https://gerrit.libreoffice.org/66492 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-15tdf#42949 Fix IWYU warnings in include/toolkit/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icebcf1a6ab073dce935a74ce79ee0f302b62e8a8 Reviewed-on: https://gerrit.libreoffice.org/65947 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-14tdf#42949 Fix IWYU warnings in chart2/qa/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4fa8e6e7dad8b87d8e31140de35fa948f631bee9 Reviewed-on: https://gerrit.libreoffice.org/65888 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-14Fix typoAndrea Gelmini
Change-Id: Ibf7d46963bddddfb3cb75170c43ba8a3279f1c34 Reviewed-on: https://gerrit.libreoffice.org/66281 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-13Fix typoAndrea Gelmini
Change-Id: Ia182da4c6f364d302ca189a10a7e9619211770cc Reviewed-on: https://gerrit.libreoffice.org/66247 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-12Fix typoAndrea Gelmini
Change-Id: I59109cd24cc4d6a40bb72bb7cdd854b8910d7586 Reviewed-on: https://gerrit.libreoffice.org/66204 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-10Resolves: tdf#122398 max/min limits too small for scale FormattedSpinButtonsCaolán McNamara
Change-Id: I679b6cc7e4bfc4273fc438e6d1d897ba66ead77b Reviewed-on: https://gerrit.libreoffice.org/66049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09Resolves: tdf#122597 chart dialog should be modalCaolán McNamara
Change-Id: I66881168fe2c6f3d033f2037e3d1b884bb74bc1a Reviewed-on: https://gerrit.libreoffice.org/66015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-13 12:14:35 +0000