summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2022-04-06Resolves: tdf#117162 ImportDocumentHandler expects data provider to existCaolán McNamara
already in its ctor which changed since... commit 9009663deb8f0862f419fd99bf0b761c7f923eff Date: Sun Feb 26 22:48:06 2017 +0100 tdf#83257 [API-CHANGE] Pivot chart implementation which defers it, take a probably safely backportable approach here to fix it. Change-Id: I1863791af7ae737f337993833a9cf1429a3a8028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 78f7bd90b96ac168fdacd1e0cb0693ab3861872a) also contains... tdf#117162 ImportDocumentHandler expected XDocumentHandler argument but SvXMLImport not longer supports XDocumentHandler since commit fe2b4e7dc6533535736a8f08496f316427386179 Date: Tue Oct 6 18:27:27 2020 +0200 make SvXMLImport fast-parser only here use a SvXMLLegacyToFastDocHandler to try and glue the two parts together again. Though the use of reflection::XProxyFactory is a bit worrying here wrt this change so unforseen side effects are possible. Full change over to fast-parser only is probably advisable. Change-Id: Ie14d1d9fa8534c187efc67a6c1cc0989316c4634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 70f3a94949cce612be9eff14fca94976acfc61a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132333 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-09cid#1500515 Dereference after null checkCaolán McNamara
Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130257 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-09chart2: Break labels text and limit the size to the axis sizeTomaž Vajngerl
Previously a long label wouldn't be broken into multiple lines and be limited to the axis size if the chart sizing was automatic. This would cause the label to distort the whole chart and make the chart area very narrow. With this change the label text is limited to the axis width and gets broken into multiple lines if this is necessary. BarChartVeryLongLabel.odp provides a test document which includes automatic size and fixed size chart are. We make sure the area that the label text occupies is not larger than the chart wall size. Change-Id: If58bfa3e51ab68f720f22df5416ae305401bcd34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129814 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ca22f1ce703c1d03fc1b1ed1f5ac1fc903b09e6f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129900 Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-03-09chart2: crop x-axis label if it's too long on fixed size chartsTomaž Vajngerl
If the label text is too long on a fixed size chart area, crop it as we can't resize the chart area to accomodate for text breaking into multiple lines. The algorithm to determine if cropping is needed has assumed that we need this in case the x-axis label is vertical, so there was no check to actually make sure the text is horizontal or vertical and in case it was horizontal, it has taken height into account and not width, so nothing got cropped. Change-Id: I8e73027fc51722280418c9e0be34ce487c41171e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129813 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 92da88582ae8d5ddbd786f9936e1b2b46eaddf2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129899 Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-03-09tdf#146463 Apply data series filter to the chart legendOuyang Leyan
Consider a data series as hidden if there is no unfiltered value, do not consider data labels. It solves a regression introduced when working on tdf#134059. Change-Id: I6072bf469137d70e0aa353ffbeb0d0a1216ffa5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7c5cfe54357e4e8d08b4696e80741097d3335dcb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130645 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-09cid#1500452 Using a moved objectCaolán McNamara
and cid#1500429 Using a moved object Change-Id: Iecd989345cc043149ff1a2e24da4f6070c014c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130550 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-27tdf#127720 chart2: create new columns for error barsJustin Luth
This is basically a copy/paste of the bubble chart fix for tdf#103984 against the same LO 4.4 regression. No exist unit tests had error bars. Very interesting. make CppunitTest_chart2_import CPPUNIT_TEST_NAME=testPPTXChartErrorBars Change-Id: I81ff91ee2ba75277502a8e261106bf5837a8903b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130444 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit dfd0717b3f55eeb15a5634e52d7d0ed544d17578) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130447 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-27Resolves: tdf#147292 the area of the tooltip is wrongCaolán McNamara
gen happens to make use of the current mouse point so it gets shown anyway which gtk uses the designated area which isn't in the expected units or screen relative positions Change-Id: I11fdb09ad4ce2965d2f2e27fb1427c9d93de7a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130385 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-20Resolves: tdf#147393 SpinButtons should be can-focusCaolán McNamara
Change-Id: I092ed9c3421267ea3b2c671020e7079c3f792e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130131 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-13[cp] Remove Help - Donate to LibreOffice menu itemAndras Timar
... and remove Help - Get Involved menu item, too Change-Id: I7a701173f596306ee628ae4a12ad81d2d756caca
2022-02-01tdf#146066 chart: fix automatic axis scaling at datesTünde Tóth
Automatic scaling of the Y axis was incorrect when the X axis was a date axis and the last Y value was the highest value. To fix this, increase maximum date value by one month/year. Regression from commit ed2c880a691a0b179bbc92a8ce4ee49eac004035 (tdf#133005 Chart: fix ODF import of date axis position). Change-Id: I0989ae8002e55f4ecfaf530ab845badb4409ecf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128209 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 81abc0d7657f194804681415a786627ab71475e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129085 Tested-by: Jenkins Reviewed-by: Tünde Tóth <toth.tunde@nisz.hu>
2022-01-22Related: tdf#135935 set some hints as to what widget should have starting focusCaolán McNamara
for wizards where the help button gets initial focus under gen Change-Id: I40b0a4620f417a4688366c028db4c9cb59eb333c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128750 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-22tdf#135935 Ensure help page is opened in chart creation Wizard dialogRafael Lima
Prior to this patch, if the user opens the Chart Wizard dialog (Insert > Chart) and clicks the Help button without clicking anywhere in the dialog, the help ID was not being applied. This problem happens on kf5 and gen, but not on gtk3. With this patch, the expected behavior is achieved in gtk3, gen and kf5. Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 67e88d173fb56a2628a5464d56276134bf6f65a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128680 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22Use less DegreeN::get()Mike Kaganski
Change-Id: I97b8d6282c72307cc29a913af221d283523f2fae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-19Drop F_PI1800/F_PI18000, and unify deg2rad/rad2deg conversionsMike Kaganski
Change-Id: Ib89b00c3dc8cd440e8a88906eea133becd1cef64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125509 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-11-19Use M_PI* instead of F_PI*Mike Kaganski
Change-Id: Ie2b7a1c74fc516781a17a20157b8217bc41e383d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125504 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-18remove some unused definesNoel Grandin
Change-Id: I4424329c1b803ccdd901f1428d332a6c56652100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125479 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-18loplugin:stringliteraldefine in chart2Noel Grandin
and drop namespace declarations that were surrounding the #define - namespace decls have no affect on #defines Change-Id: Ic66ba7837ba3a5c48a0cf414af30985c480d73af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-16chart2: disambiguate ShiftedCategoryPositionMiklos Vajna
There are two of these: one sal_Bool in a .idl file and a bool in a .hxx file. They need to be printed differently with SAL_DEBUG(), so rename the C++ one to avoid confusion. Change-Id: I0f79908a7b74742410813166370cb8ba3017e727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125256 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-15Resolves: tdf#145663 nL is the index of the light to set to the modelCaolán McNamara
don't reuse the variable in another loop before its finally set to the model Change-Id: I336d8c0f3ce612448dd639e939e65fb434da1513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125208 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12Use more o3tl::convert in scMike Kaganski
Change-Id: I624b6c570eff8b6cdc83ffcb2d0dbadf848715b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120330 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-10tdf#136111 fix scaling problem on chart driven by a macroAndras Timar
Change-Id: I9a55bcfceb9259f0d5dc944c00a34b3e4a891e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124940 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 0644f44daef7caa8a246221d762fbc0f6af3672c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124864 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-11-09rtl::Static to thread-safe staticNoel Grandin
Change-Id: I35e2a252708228bdbeaee557ef35763c64608653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-08use more OUStringLiteral in MediaDescriptorNoel Grandin
Change-Id: I0567d103db8db401c737fed98483912a39352929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-07forward decls go after #includeNoel Grandin
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-04libstdc++ bug 103022 is fixed in GCC 12Stephan Bergmann
(<https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html> states that _GLIBCXX_RELEASE "first appeared in the GCC 7.1 release and is not defined for GCC 6.x or older releases", leaving it a bit unclear what the status is for our GCC 7.0.0 baseline, so play it safe and assume it can be undefined) Change-Id: Iae10060bdab88e2e6df3954c2b6806534a761b31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124675 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-03Introduce 'scale' to Point/Size/Rectangle, to simplify anisotropic scalingMike Kaganski
Change-Id: I12c25838e8eec8d05e43b593790847c626edde31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124638 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-03tdf#114441 Convert use of sal_uLong to sal_uInt32, intNatalia Gavrilova
* Changed moduldlg.hxx, moduldl2.cxx * Changed res_DataLabel.hxx, res_DataLabel.cxx Change-Id: I845c9fb7b60b5a8f898aaac433c0b5e520c58678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123360 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-03Drop TWIPS_PER_PIXEL and use o3tl::convertMike Kaganski
Change-Id: I8ee3fddaccf6809c95319db1da9a1d2897d00c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124626 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-01add a comment referencing gcc#103022Caolán McNamara
Change-Id: Iccb7d5dccdd77563244e2262834274a548b369bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31crashtesting: assert on conversion of fdo67521-1.odg to pdfCaolán McNamara
#4 0x00007fffcb03c5d9 in std::__replacement_assert(char const*, int, char const*, char const*) (__file=0x7fffcb4fbb03 "/usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray", __line=586, __function=0x7fffcb4fbd8c "const _Tp &std::valarray<double>::operator[](std::size_t) const [_Tp = double]", __condition=0x7fffcb4fbb95 "__i < this->size()") at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/x86_64-redhat-linux/bits/c++config.h:2660 #5 0x00007fffcb3b4b54 in std::valarray<double>::operator[](unsigned long) const (this=0x7ffffffefea8, __i=0) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:586 #6 0x00007fffcb3b4a79 in std::begin<double>(std::valarray<double> const&) (__va=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:1225 #7 0x00007fffcb3b49ac in comphelper::containerToSequence<double, std::valarray<double> >(std::valarray<double> const&) (i_Container=...) at include/comphelper/sequence.hxx:192 #8 0x00007fffcb3b4963 in comphelper::containerToSequence<std::valarray<double> >(std::valarray<double> const&) (i_Container=...) at include/comphelper/sequence.hxx:200 #9 0x00007fffcb3aaa83 in chart::(anonymous namespace)::lcl_ValarrayToSequence<double>(std::valarray<double> const&) (rValarray=...) at chart2/source/tools/InternalData.cxx:72 where begin() is implemented with return std::__addressof(__va[0]) and that operator[] (for arg __i) then has __glibcxx_requires_subscript(__i) which asserts if there is no index __i which is the case for 0 when the valarray is empty Change-Id: Idc2c185cbfb3806764c3071ecee302dc823b4660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124529 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31uniformly allow focus into GtkToolbarCaolán McNamara
Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara
so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in chart2Mike Kaganski
The bits missing from 5b0ae3b59cd2cccfb72d991657366eb2a69bff49, where explicit use of sal_Bool* was needed instead of 'auto', to workaround loplugin:implicitboolconversion warnings. Change-Id: I32ef417d46ceea38fbcebae053e288222179818c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124428 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in chart2Mike Kaganski
Change-Id: I71e0b458c4dd2a85e36a485e3efa72b1077b0e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124346 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-27tdf#141908: CppUnittests: replace usage of sal_Int32 with colors4k5h1t
Change-Id: Ic87c8e57a6b530a742a6bf3916c7a944e1bed2b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121306 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-26Drop ContainerHelper::vectorToSequence and use comphelper::containerToSequenceMike Kaganski
Change-Id: I987c56feab147cdbeb4ad58bd5ebb23dce6dbbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124215 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-15Simplify vector initialization in chart2Julien Nabet
Change-Id: I26dd2e0480bb60719f4f1b6dcc30cb28bb35ee09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123660 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-15Remove non-const Sequence::begin()/end() in internal codeMike Kaganski
... to avoid hidden cost of multiple COW checks, because they call getArray() internally. This obsoletes [loplugin:sequenceloop]. Also rename toNonConstRange to asNonConstRange, to reflect that the result is a view of the sequence, not an independent object. TODO: also drop non-const operator[], but introduce operator[] in SequenceRange. Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-14Avoid COW overhead using css::uno::SequenceMike Kaganski
The scenarios are: 1. Calling sequence's begin() and end() in pairs to pass to algorithms (both calls use getArray(), which does the COW checks) 2. In addition to #1, calling end() again when checking result of find algorithms, and/or begin() to calculate result's distance 3. Using non-const sequences in range-based for loops, which internally do #1 4. Assigning sequence to another sequence variable, and then modifying one of them In many cases, the sequences could be made const, or treated as const for the purposes of the algorithms (using std::as_const, std::cbegin, and std::cend). Where algorithm modifies the sequence, it was changed to only call getArray() once. For that, css::uno::toNonConstRange was introduced, which returns a struct (sublclass of std::pair) with two iterators [begin, end], that are calculated using one call to begin() and one call to getLength(). To handle #4, css::uno::Sequence::swap was introduced, that swaps the internal pointer to uno_Sequence. So when a local Sequence variable should be assigned to another variable, and the latter will be modified further, it's now possible to use swap instead, so the two sequences are kept independent. The modified places were found by temporarily removing non-const end(). Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-11In O[U]StringBuffer, make string_view params replacements for OUString onesStephan Bergmann
...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads. That way, loplugin:bufferadd and loplugin:stringviewparam found many further opportunities for simplification (all addressed here). Some notes: * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer (as that goes via user-defined conversions through string_view now), which was most noticeable in copy initializations like OStringBuffer buf = someStr; that had to be changed to direct initialization, OStringBuffer buf(someStr); But then again, it wasn't too many places that were affected and I think we can live with that. * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to get them in line with their counterparts taking O[U]String. * I added an OUStringBuffer::lastIndexOf string_view overload that was missing (relative to OUStringBuffer::indexOf). * loplugin:stringconstant needed some addition to keep the compilerplugins/clang/test/stringconstant.cxx checks related to OStringBuffer::append and OStringBuffer::insert working. * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea "loplugin:stringviewparam extend to new.." Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-11loplugin:moveparam in chart2Noel Grandin
Change-Id: I6a47abf80f0f45bbb55bc9e0fe817f3c3650aff3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123351 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10use SfxItemSetFixed in swNoel Grandin
Change-Id: I69e188d7599b7fc439f613cec0a0967ccb748b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-09Typo: *adress* -> *address* (except from not translated German parts)Julien Nabet
Change-Id: I62e12aed5bc67119433c39ff333f69b79944dca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-06sidebar: update chart panel on checkbox changeSzymon Kłos
This fixes not working checkboxes for "title" and "subtitle" on mobile Change-Id: I126bb020f669c8c4a34687f750a538513cd06eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122876 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123132 Tested-by: Jenkins
2021-10-03A more lightweight O[U]StringConcatenationStephan Bergmann
...compared to a full-blown O[U]String, for temporary objects holding an O[U]StringConcat result that can then be used as a std::[u16]string_view. It's instructive to see how some invocations of operator ==, operator !=, and O[U]StringBuffer::insert with an O[U]StringConcat argument required implicit materialization of an O[U]String temporary, and how that expensive operation has now been made explicit with the explicit O[U]StringConcatenation ctor. (The additional operator == and operator != overloads are necessary because the overloads taking two std::[u16]string_view parameters wouldn't even be found here with ADL. And the OUString-related ones would cause ambiguities in at least sal/qa/rtl/strings/test_oustring_stringliterals.cxx built with RTL_STRING_UNITTEST, so have simply been disabled for that special test-code case.) Change-Id: Id29799fa8da21a09ff9794cbc7cc9b366e6803b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30loplugin:constparams improve handling of pointer paramsNoel Grandin
Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-28gives names to all the Idles and TasksNoel Grandin
enforce it by making the constructor parameter non-default. Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-14 12:00:10 +0000