summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2023-04-17Resolves: tdf#146068 don't crash when MA(central) lacks dataCaolán McNamara
Change-Id: I2c9b78f4d1a963bb71abb21068e61e6983ade777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-04jsdialog: enable and make async chart line prop dialogSzymon Kłos
Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150014 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2023-04-02make some methods final in chart OPropertySetNoel Grandin
so that the subclasses use the right overrides to implement custom behaviour Change-Id: Ida9d1de51b5595c4d9532a5c98a220bf39d9a208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-02map->unordered_map in chart OPropertySetNoel Grandin
no need for ordering here Change-Id: I7e0928284c98aca297d4452e65efd8a4f3b1e56d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-01fix locking in chart::DiagramNoel Grandin
we can't return a reference to internal state that needs to be protected by a mutex Change-Id: I13c0128559546cc2078584fc0de818c568617b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149914 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-01use more XVclWindowPeerNoel Grandin
Rather than using it's superclass XWindowPeer and implicitly relying on it being XVclWindowPeer and casting it everywhere. Change-Id: Icfb46f3b920d00f4a167a31803a71bbb0368d05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149894 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-31crashtesting: XDataSeries OPropertySetHelper::getFastPropertyValue crashCaolán McNamara
seen with gcc --version gcc (Debian 10.2.1-6) 10.2.1 20210110 similar to commit ad59487053bcd267b53febde0cecbd64c7f94cc0 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Mar 19 20:40:35 2023 +0000 crashtesting: frequent XDiagram OPropertySetHelper::getFastPropertyValue crash Change-Id: If190e0c51a0b983165ff6f36bb2185456ea6bade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-30use more concrete types in chart2Noel Grandin
Change-Id: Iaefad282d40c83f58758b41db9b14f6e95552354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: I1ba60b690a0402d1a98f792c86ddd033e0c39ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more get/setFastPropertyValue in chart2Noel Grandin
Change-Id: I4979cf5dab8b35ba35a46808cef76dc3f81c59b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149725 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more get/setFastPropertyValue in chart2Noel Grandin
Change-Id: I1471309e200c8eec21844658b873f817565f9604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: I932d8a45d525b1b629a0aaee96a1643b155069f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149692 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29fix bug in WrappedRegressionCurvesProperty::setValueToSeriesNoel Grandin
ever since commit 1cd3e2038010cb37bda82d38dd058b793b7eec26 Author: Tomaž Vajngerl <quikee@gmail.com> Date: Sat Jun 29 18:43:16 2013 +0200 Multiple trendline removing and changing type support. Change-Id: Ibd24d0831932f25e60c05a00450d611e15875102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: Id665050f4f0763505e7f1ace6ade5bf9ab02edf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more get/setFastPropertyValue in pie chartsNoel Grandin
Change-Id: I17bf8631b5934d6d112f17e4a05025802dcde2f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: I938aa1d6d3c20b35d9e11818d4b641d8a03decaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29crashtesting: Null-deref on export of forum-mso-en4-274729.xls to odsCaolán McNamara
and others, probably since: commit f02ec0d8489404966596cb0e949bf969e8e66fa2 Date: Wed Mar 22 08:50:15 2023 +0200 move hasUnhiddenData inside chart2::DataSeries Change-Id: Icf59439f00a40ef036decaa36f3d5af68787c864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29fix concurrent access to fontcacheNoel Grandin
Every now and then I see a crash in fontcache code. Add some DBG_SOLARMUTEX calls there, which spots a few issues. (*) In writer, SwDLL needs to be under the SolarMutex during init, and we can just move a method call to fix that. (*) in chart2, life is more complicated. Various of the static defaults we build want to call OutputDevice::getFontInstance. We can't just stick a SolarMutex somewhere in the call chain, because those maps are built on-demand, and then we end up with ABBA deadlocks between the SolarMutex and the mutex in the cppu::PropertySetHelper. So I picked a spot that is init'ed early on in chart2, and force the init of all the troublesome tables there. Change-Id: I832978bea35fd5fa681d144b8beff1af13ef3341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29expand out ChartModelHelper::findDiagramNoel Grandin
since it just calls findFirstChartDiagram Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: I286ad05252bb34f7a1b8f7c08190bddc601faf3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: I818253350bd954d3a2a0f302493c896eb2e26994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: Ifd3bce5fc22371559203da673ca98913bc742c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin
Change-Id: I7ec6df57504b3515be09796016b6db02521e5d67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149673 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28use more concrete types in chart2Noel Grandin
Change-Id: I067e9424a77fb1d835f2847bba3c3f2cda3430f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28move switchRightAngledAxes from ThreeDHelper to DiagramNoel Grandin
so we can use the get/setFastPropertyValue methods Change-Id: Id17fa2466f75a3b4530306143ce50f66fc5593b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149651 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28move setDefaultRotation from ThreeDHelper to DiagramNoel Grandin
so we can use the get/setFastPropertyValue methods Change-Id: Id9470e5b878ed15e20ca285cacc36cd2e9511365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28move get/setScheme from ThreeDHelper to DiagramNoel Grandin
so we can use the get/setFastPropertyValue methods Change-Id: I2b57212a1d3933cd2825e647f692e2ae3cb8b484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28move get/setRotation from ThreeDHelper to DiagramNoel Grandin
so we can use the get/setFastPropertyValue methods Change-Id: I147ed5c092b44283bfbbf4ea5a3145736417b92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-28move get/setCameraDistance from ThreeDHelper to DiagramNoel Grandin
so we can use the get/setFastPropertyValue methods Change-Id: Ibce7c93f067468f2e88f196158dfcb80686d01c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149635 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-24loplugin:stringadd in c*Noel Grandin
after my patch to merge the bufferadd loplugin into stringadd Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23rtl::Static-> thread-safe-static in chart2Noel Grandin
Change-Id: Ie1379a1d40a6d65b28fd94ed114853e399fea5f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23rtl::Static-> thread-safe-static in chart2Noel Grandin
Change-Id: I5bd595d5251cd92904750d6e6830f1d95f41b177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23rtl::Static-> thread-safe-static in chart2Noel Grandin
Change-Id: Ie629e4e2d4e3a56894bc964b8bb50dac5823cf4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin
Change-Id: If67a4f0fe75554e14c3030c68374607b76d5b840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin
Change-Id: I33deb726da5a59093b1104696da7c80ce830b7e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin
Change-Id: I215bf2a6e2fbd4cdd57fd14c2d34fb11a0d2a862 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin
Change-Id: I92e0cb707b0fdd8e82ba350919294584904f2c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22simplify ViewLegendEntryNoel Grandin
we never have more than one FormattedString Change-Id: Id61a2a89a053f49da758a2bb888cef189515458f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin
Change-Id: I568530c1db0add697f7f257a4e5560a3e50919f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149290 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22move hasUnhiddenData inside chart2::DataSeriesNoel Grandin
Change-Id: Id8a4daf046f2306a52948c7ed434854b25ee7936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin
Change-Id: I0ed45cf9acd1c9bf702bbe335f8a07b6947fb946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete types in chart2Noel Grandin
Change-Id: I70042284e4549b3eef67866a35741b06305d720f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-21move getLabel inside chart2::DataSeriesNoel Grandin
Change-Id: I38baff5980d8cae5f63ee9163d667385837d249b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-21move getAllRegressionCurvesNotMeanValueLine inside chart2::DiagramNoel Grandin
Change-Id: Ic01a886f575022fa106aa2e3b384e184683df6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149197 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-21move getTemplate inside chart2::DiagramNoel Grandin
Change-Id: I05da4e4a9acb2683633eda42cf18d740913c2e37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-21move getVertical/setVertical inside chart2::DiagramNoel Grandin
Change-Id: Ide512e20fea94b1d7d038290d1c833f1d8cf42ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-20move getStackMode/setStackmode inside chart2::DiagramNoel Grandin
Change-Id: Ie359d2a21d288e989bf2bcdfab781938bc8fa26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-20move setDimension/getDimension inside chart2::DiagramNoel Grandin
Change-Id: If52f92e152011ead81a1b25f30ba15124e6a8e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149151 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-20Don't let workaround for old GCC affect ClangStephan Bergmann
(which defines __GNUC__ as 4) Change-Id: I5cf79ed9194150b13e480c91289c42e7bfeed31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-13 03:36:11 +0000