summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2022-02-23tdf#127720 chart2: create new columns for error barsJustin Luth
This is basically a copy/paste of the bubble chart fix for tdf#103984 against the same LO 4.4 regression. No exist unit tests had error bars. Very interesting. make CppunitTest_chart2_import CPPUNIT_TEST_NAME=testPPTXChartErrorBars Change-Id: I81ff91ee2ba75277502a8e261106bf5837a8903b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130444 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-23Resolves: tdf#147292 the area of the tooltip is wrongCaolán McNamara
gen happens to make use of the current mouse point so it gets shown anyway while gtk uses the designated area which isn't in the expected units or screen relative positions Change-Id: I11fdb09ad4ce2965d2f2e27fb1427c9d93de7a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130442 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-23cid#1500434 Dereference after null checkCaolán McNamara
Change-Id: I1a9531446fbd5f977d02775f5d25696aba16287d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130431 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-23cid#1500643 Dereference before null checkCaolán McNamara
Change-Id: I1456b9a935c167344e0a56c7339da2c702a43e0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130419 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-23cid#1500665 Dereference before null checkCaolán McNamara
Change-Id: I451c0faad1060ff7e97ef24af61940f402e1b243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130416 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-22tdf#64914 small improvementsNoel Grandin
(1) do not read the config inside a hot loop (2) do not create a SvxShapeGroup only to remove it Change-Id: I8ff3840d0972d2f617a326a67d18260e44220f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22eliminate a layer of conversion in createSymbol2DNoel Grandin
speeds up loading large charts Change-Id: I935971e21dd5384d8f3e04e0022fd81c2c1c8232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22tdf#64914 slow opening large chartNoel Grandin
shaves 2% off the load time by avoid the cost of comphelper::getFromUnoTunnel Change-Id: I9d0438bd0ad3cf753d34fe181481f3a57193651c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-21cid#1500515 Dereference after null checkCaolán McNamara
Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-21cid#1500458 Dereference after null checkCaolán McNamara
Change-Id: Ic9626b0817ee65fbc6d68592c592c3c2e39d42e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18Resolves: tdf#147393 SpinButtons should be can-focusCaolán McNamara
Change-Id: I092ed9c3421267ea3b2c671020e7079c3f792e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18resave with latest gladeCaolán McNamara
Change-Id: Ia6fcf99a0d9bb914eb977f20426d6b093f21e3de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17loplugin:unusedmethodsNoel Grandin
Change-Id: I58c60262ca543bafb4db4433dbb98b195f7571ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-17micro-optimisation: use std::moveNoel Grandin
Change-Id: I3acee160130185e65a154bf205fcdcf52b9f8797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-17loplugin:unusedfieldsNoel Grandin
Change-Id: I07ec409ea3663e789b6505dbfc999666525ed97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-17loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I44c70bd930380d0e3f76524f37e6276cf4faeccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-16simplify some vector constructionNoel Grandin
Change-Id: I0bd131066f5d70fb1dc1c4f851d4d6059994a6f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-13tdf#147394 delete crash legendNoel Grandin
regression from commit 63e8c2ccd39263b24f644c3d0394044a2613eb88 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sat Jan 29 21:21:27 2022 +0200 use more concrete types in chart2, Diagram Change-Id: I6598bb7c116bd94272a805e77751aa8cf5dc174a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-13rtl::Static -> local staticNoel Grandin
Change-Id: I43059938f1fc814b2b8306258210a67d7a1fac84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-12chart2: Break labels text and limit the size to the axis sizeTomaž Vajngerl
Previously a long label wouldn't be broken into multiple lines and be limited to the axis size if the chart sizing was automatic. This would cause the label to distort the whole chart and make the chart area very narrow. With this change the label text is limited to the axis width and gets broken into multiple lines if this is necessary. BarChartVeryLongLabel.odp provides a test document which includes automatic size and fixed size chart are. We make sure the area that the label text occupies is not larger than the chart wall size. Change-Id: If58bfa3e51ab68f720f22df5416ae305401bcd34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129814 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-12chart2: crop x-axis label if it's too long on fixed size chartsTomaž Vajngerl
If the label text is too long on a fixed size chart area, crop it as we can't resize the chart area to accomodate for text breaking into multiple lines. The algorithm to determine if cropping is needed has assumed that we need this in case the x-axis label is vertical, so there was no check to actually make sure the text is horizontal or vertical and in case it was horizontal, it has taken height into account and not width, so nothing got cropped. Change-Id: I8e73027fc51722280418c9e0be34ce487c41171e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129813 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-11svx::PropertyChangeNotifier improvementsNoel Grandin
(*) rename the enum to make it's purpose more obvious (*) remove the enum header - it belongs to this class, no need to have it somewhere else (*) return property name by const&, no need to copy here (*) use a o3tl::enumarray instead of a std::unordered_map - there are only 3 entries here, and two of them are ALWAYS used, so just flatten the data structure. Change-Id: Ic496bd5220d55be1209a3243c095d461df0a02ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-10crashtesting ooo#ooo83229-2Noel Grandin
this reverts part of commit b314b5a0612c9dc7279039dae44a250d4d3ec6b1 use more concrete types in chart2, DataSeries since writer uses it's own implementation of the XLabeledDataSequence UNO interface Change-Id: I52154dcee104ca17bfa63a3a8b11ef739cef147f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-10use more concrete types in chart2, SvxShapeNoel Grandin
Change-Id: Ieadcd95d7d75d925b2c5528ba231d4686d4fcb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-10use more concrete types in chart2, SvxShapeNoel Grandin
Change-Id: I9ae954f8efaec31d5b848c633e66adb62a13f3f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129737 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-10can avoid UNO_QUERY hereNoel Grandin
Change-Id: Ie43759ab2771a40a0553eb61847766932cac2e47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129736 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-09use more concrete types in chart2, AxisNoel Grandin
Change-Id: Ia47fd6deedd0a1cf6bedc882cb9817206dfa88b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129690 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-09use more concrete types in chart2, AxisNoel Grandin
Change-Id: Iab742573a18384adbd1a397326ca6f4998b45ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-09use more concrete types in chart2, AxisNoel Grandin
Change-Id: Ia45eac5e63d4937310a52a88c142623274fd4e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129688 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-09use more concrete types in chart2, DataSourceNoel Grandin
Change-Id: I513491e8d39ee79edf8521d279bd32031cf22a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-08use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-07use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: If92f6ff6f90d53a9dc6211fd9f071d4d3fce2997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-07crashtesting ooo#20372Noel Grandin
this reverts parts of the "use more concrete types in chart2, LabeledDataSequence" commits, since writer uses it's own implementation of the XLabeledDataSequence UNO interface Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-06tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroVaibhavMalik4187
Change-Id: I4f5258ca5b37e9b1b4237c5d29e4a9e5362fa855 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129116 Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2022-02-06chart: prefix members of AxisLabelPropertiesTomaž Vajngerl
Change-Id: Ife658e44dc039811d61b45f4712635920f5c34b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129545 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-05use more concrete types in chart2, AxisNoel Grandin
Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-05use more concrete types in chart2, LabeledDataSequenceNoel Grandin
Change-Id: I50b23923c1aa946f2c448534719a6c18003592a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04use more concrete types in chart2, LabeledDataSequenceNoel Grandin
Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, DataSourceNoel Grandin
Change-Id: If5001a8a8fc1103a8d662429d3077c7ce81cc2b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, LabeledDataSequenceNoel Grandin
Change-Id: I88d5b7e045814cbd40750ebe927e6a76d5a463d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: I51a30d2a6a3c424dcdc29b6647aa2b67fa35884a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-03tools::Long -> sal_Int32Noel Grandin
Change-Id: Ife7fc63f4ad0f3dcd34c9079d74044bae7924988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-03make css::chart2::InterpretedData a normal structNoel Grandin
this is internal-only, no need for it to use UNO IDL Change-Id: I5f9844f48640618ac5bd348721bdee43e5f0a57f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-03tdf#147027 Cannot display pattern, gradient or hatch fill in bar or area chartNoel Grandin
this partially reverts commit 0b0934056b47485527442b6366d7fd3274a4601f Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Jan 4 18:50:01 2022 +0200 bypass SvxShape when creating rectangles in chart2 specifically the part responsible for setting all the style-related properties on the SdrPathObj. There is just too much logic to re-implement in bypassing SvxShape. And the logic is spread out over several different classes/methods and overrides, so getting it perfect is pretty much impossible. Change-Id: I7dbae95dda780e7fa40c4e0798e6c199e4eaf41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02UBSan build missing RTTI nowStephan Bergmann
...e.g. during CppunitTest_chart2_import2 > [_RUN_____] Chart2ImportTest2::testTdf114179 [...] > warn:sal.osl:1990837:1990837:sal/osl/unx/module.cxx:152: dlopen(instdir/program/libchartcontrollerlo.so, 257): instdir/program/libchartcontrollerlo.so: undefined symbol: _ZTIN5chart20RegressionCurveModelE [...] Change-Id: I2c89fef471139f7b5417aadf1321d2da4f4ffec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129367 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-02use more concrete types in chart2, RegressionCurveModelNoel Grandin
Change-Id: I0efecc48c63dc0fc62372eff7e9d5471666346b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-01use more concrete types in chart2, RegressionCurveModelNoel Grandin
Change-Id: I844238da0ce0ce4aea308c652c341efa540149a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-31tdf#146066 chart: fix automatic axis scaling at datesTünde Tóth
Automatic scaling of the Y axis was incorrect when the X axis was a date axis and the last Y value was the highest value. To fix this, increase maximum date value by one month/year. Regression from commit ed2c880a691a0b179bbc92a8ce4ee49eac004035 (tdf#133005 Chart: fix ODF import of date axis position). Change-Id: I0989ae8002e55f4ecfaf530ab845badb4409ecf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128209 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-31use more concrete types in chart2, DataSeriesNoel Grandin
Change-Id: I561d3d04cd534a30e774b0ed3fe1fb927a40c8df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-13 18:03:35 +0000