summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)Author
2016-11-18loplugin:unusedmethodsNoel Grandin
Change-Id: I567c672a0606ac11c0f269fcf5cc3906684e23f9 Reviewed-on: https://gerrit.libreoffice.org/30950 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15Revert some chart2 shader-affecting changesNoel Grandin
from commit 8d4a306eb04742f499ab693e7f8ebd3ae3c01415 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 11:26:59 2016 +0200 loplugin:unusedfields and commit c79b7fd8d4e6e029cf8e6bfb2c7e10b52a4d5781 Author: Noel Grandin <noel@peralex.com> Date: 2015-11-20 10:41:00 (GMT) loplugin:unusedfields in chart2 Change-Id: I6b61aa9c6abb1d51e96d5eb6c623d86fd6fd5b82
2016-11-15loplugin:unusedfieldsNoel Grandin
Change-Id: I1400ca0af2c357dff06e5f733ec62b13d6a96461 Reviewed-on: https://gerrit.libreoffice.org/30861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14coverity#703927 Unchecked return valueCaolán McNamara
make these less odd and simply return the thing they selected, rather than a bool that indicates that the rpObj arg was successfully set to non-null, so there's one flag to check not two which both mean the same thing. Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50 Reviewed-on: https://gerrit.libreoffice.org/30794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11loplugin:expandablemethods in chart2Noel Grandin
Change-Id: Ie6650628683ec7c67359351eec0e09033f2b50cb Reviewed-on: https://gerrit.libreoffice.org/30750 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in basctl..chart2Noel Grandin
Change-Id: Id4eeb12792c3a66b68a907cb459ab437e3d64e4c Reviewed-on: https://gerrit.libreoffice.org/30680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07loplugin:oncevar in chart2Noel Grandin
Change-Id: Id9308f9265c2453075971c8105b4d161bd145da7 Reviewed-on: https://gerrit.libreoffice.org/30654 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-06chartx: fix sparse chart importJean-Tiare Le Bigot
Change-Id: I1bcd2257da900c6a88bc78040fabe5696e2bab7d Reviewed-on: https://gerrit.libreoffice.org/29801 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04unify color selectorsCaolán McNamara
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: Ief4a9dfc0e0a2dad04c3ac9f1840b823fd9357de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01Omit the default comparatorTakeshi Abe
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-01Omit the default comparator for std::sort()Takeshi Abe
Change-Id: Ib865bdf911b53d809fc2979f524da3735bb39ce5 Reviewed-on: https://gerrit.libreoffice.org/30432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-27Make XServiceInfo match what's in .component fileMaxim Monastirsky
also should match the entry in officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu Change-Id: If5f532d428bfcd925123ab83df6185680a04249e
2016-10-22fix 32bit buildsCaolán McNamara
where for amusing windows historical reasons sal_Int32 is long and not int Change-Id: Icb73408b6c8ef245bc809aebc8ffc9f28e57a1e5
2016-10-22fix for windows buildsJochen Nitschke
MSVC does not know and keyword > InternalDataProvider.cxx(552) : error C2065: ´and´ : undeclared identifier Change-Id: I7cac0719561b75e37e20534edd2efa5bf3a97fa8 Reviewed-on: https://gerrit.libreoffice.org/30164 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-22chart2: fix unserialization of empty cellsJean-Tiare Le Bigot
Change-Id: Ib7e5c8c4db6cac7ef1255246eea13325cf7cca69 Reviewed-on: https://gerrit.libreoffice.org/30030 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-21Avoid further crash with empty Chart documentStephan Bergmann
following up on 8b5f8c26f007c8e67bc46b1b09340cae660d0b8b "Avoid crash with empty Chart document", when you then close the Writer doc (discarding the changes), it crashes in a chart::sidebar::ChartSidebarModifyListener::disposing call whose mpParent (that was a ChartElementsPanel) is already destroyed. The problem is that the ChartElementsPanel ctor creates an mxListener pointing to this, then calls Initialize, which calls xBroadcaster->addModifyListener(mxListener) and then, during updateData, throws a RuntimeException when xDiagram is null in getChartType, causing the ChartElementsPanel object to immediately be destroyed, but the listener still registered. This apparently needs fixing independently of the immediate problem. (The immediate problem is a regression introduced with d7748842e96536daeb0c638c6f8d01d99b9a3e08 "hide grid and axes options in chart elements if not supported, tdf#94297".) Change-Id: I2fe4f2a59600664f6210456c65e033f9453f4cc9
2016-10-21Only call getChartType when the return value is actually usedStephan Bergmann
Change-Id: I687ef0ce7013bce08caa25e1e6035507b814e20a
2016-10-21Minor improvement of previous commitStephan Bergmann
Change-Id: I1ab0d8756be5f8bf60c6bac3e9217db71e8e05a3
2016-10-21Avoid crash with empty Chart documentStephan Bergmann
In a fresh Writer document, "Insert - Object - OLE Object... - Create new - LibreOffice 5.3 Chart - OK", then left-clicking into the empty Chart are, caused an unhandled (or rather, handled by desktop's FatalError) RuntimeException since 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320". Change-Id: I7ff53a84e4b06b20409d09e6010bac80e5a7c4b2
2016-10-19expand WRITE_PROPERTY macroJochen Nitschke
in case the property is an Any this commit changes behaviour. (ComponentData, FilterData and ViewData) ISSET_%Property% is only true if the property value hasValue(), before it was always true. Change-Id: I3bea0bde99938911354f619ac092666199aa2016 Reviewed-on: https://gerrit.libreoffice.org/30038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot
Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-19No need to check here if menu name is emptyMaxim Monastirsky
We now do this on the ResourceMenuController side. Change-Id: Ic249b6a687fe059393ccf55bbc4534242c08e30e
2016-10-19loplugin:expandablemethodds in basctl..chart2Noel Grandin
Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993 Reviewed-on: https://gerrit.libreoffice.org/29998 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-15use initializer list ...Jochen Nitschke
... for default pool item arrays and item infos Change-Id: I79db1b4e4a78471d81409dd976a912eeccf1065b Reviewed-on: https://gerrit.libreoffice.org/29540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-15avoid exceptionJochen Nitschke
Transformation is an optional property of XShape, rATransformation can refer to an empty Any. results in warnings like this, e.g. when you add a legend: > warn:chart2:27587:1:chart2/source/view/main/ShapeFactory.cxx:2135: > Exception caught. Type: N3com3sun4star3uno9ExceptionE, Message: set Transformation property only if needed Change-Id: I1edae0a984f8264a6a0638b90a7197e316832c02 Reviewed-on: https://gerrit.libreoffice.org/29527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-13Use FeatureStateEvent directly for status updatesMaxim Monastirsky
... for SfxPopupWindow and SvxColorToolBoxControl (the latter shares BorderColorStatus with SvxColorWindow_Impl, so it was easier to convert it too). Change-Id: Ifcb23fe5809e467322d1cf4d790420886ac79b47
2016-10-12Don't allow O[U]StringBuffer in string concatenationStephan Bergmann
...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-11avoid crashes on broken charts, related tdf#98690Markus Mohrhard
Change-Id: If81f963babc15fc549d9daa904fd9836ea02ecef
2016-10-10safemode: Add uno command and menu entrySamuel Mehrbrodt
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-06rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke
... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-06drop unused STD_MASKCOLOR definesCaolán McNamara
Change-Id: I9e6d499788467e5215464cf8f5146721b847909c
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06drop now unused sfx2/sidebar/ResourceDefinitions.hrcCaolán McNamara
Change-Id: I151a37a37435a44e7331d957bd9d36f84cdf8677
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05loplugin:unnecessaryoverride in accessibility..chart2Noel Grandin
Change-Id: I14ba52fe8352f8bbdfcaa90177f4f3ac9f0e08b1
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03Fix typosAndrea Gelmini
Change-Id: Ie44267e7c9f92eb1920f05235826abff761251f1 Reviewed-on: https://gerrit.libreoffice.org/29430 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-17 06:00:39 +0000