summaryrefslogtreecommitdiff
path: root/cli_ure/source/climaker
AgeCommit message (Collapse)Author
2024-11-08Simplify a bitMike Kaganski
Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I2fddf8ae5803041344fe63c4375fe5a3ee46fed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-01WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I6eb8e490e878349f2063910e0cbc901aa7a6d524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166942 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-04-29Drop uses of css::uno::Sequence::getConstArray in canvas .. connectivityMike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: I9467028fd1a7eeafad7f0dd776a91a9a40770b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-02-23Fix warning C4456 when building with MSVC without -Wv:18Mike Kaganski
Discovered by https://gerrit.libreoffice.org/c/core/+/163717 Like these: C:/lo/core/cli_ure/source/climaker/climaker_emit.cxx(972): warning C4456: declaration of 'attrBuilder' hides previous local declaration C:/lo/core/cli_ure/source/climaker/climaker_emit.cxx(962): note: see declaration of 'attrBuilder' Change-Id: I95cba76cfcbfd9da31e7294ed421cfc38d279740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163778 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-17Avoid MSVC error C2039Stephan Bergmann
At least with VS 2022 Preview 17.6.0 Preview 3.0 and (if that makes a difference here) --with-latest-c++, the build started to fail now for me with > cli_ure/source/climaker/climaker_app.cxx(603): error C2039: '{dtor}': is not a member of 'System::IDisposable' Originally, in 4c937bbdbbfd954936fdc92c4b35d90c2233719e "#107130# new", TypeEmitter in cli_ure/source/climaker/climaker_share.h had been defined as > __gc class TypeEmitter : public ::System::IDisposable with an overriding Dispose member function (and no user-declared dtor), and the code in cli_ure/source/climaker/climaker_app.cxx had called > type_emitter->Dispose(); when done. Then, in 6fa1a74ec4bb5820d1638ff3b872476f8652efe0 "convert climaker to new syntax", the definition of TypeEmitter had been changed to > ref class TypeEmitter : public ::System::IDisposable with a dtor instead of the overriding Dispose member function, and the code in cli_ure/source/climaker/climaker_app.cxx had been changed to call > type_emitter->~TypeEmitter(); instead. I have no deep understanding of the Managed C++/CLI stuff at play here, but it looks reasonable to avoid all this by not deriving from IDisposable (and relying on GC to clean up all instances) and introducing some explicit finish() protocol. Change-Id: I8ebfba9d9f9c32b65a50104d200306e06dc69f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150387 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-28Drop 'using namespace ::std' in Windows-specific filesGabor Kelemen
Change-Id: Id66d42f2139fbcac0fed56fe534107f65d198f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147877 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-04Just use Any ctor instead of makeAny in cli_ureStephan Bergmann
Change-Id: Iae41d9c4b600635bd5e2e61b65ea3859a14e6a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133840 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-22Fix typosAndrea Gelmini
Change-Id: I49d7dc8a2cbcba5413d05d97559321e672ed413a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92655 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-14Fix typoAndrea Gelmini
Change-Id: I3f4a60a977c20b2e5d380fe9dd26d80a20099c05 Reviewed-on: https://gerrit.libreoffice.org/70741 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-12Simplify containers iterations in chart2, cli_ure, comphelper, configmgrArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76 Reviewed-on: https://gerrit.libreoffice.org/69010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-20createInstanceWithContextAndArguments->createInstanceWithArgumentsAndContextCaolán McNamara
Change-Id: Ie22398eb42f61e50177f88672a1407d9dda58f8a Reviewed-on: https://gerrit.libreoffice.org/68106 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19Some uses of C++17 class template argument deductionStephan Bergmann
Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686 Reviewed-on: https://gerrit.libreoffice.org/68020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-04Fix typoAndrea Gelmini
Change-Id: If5772a609d7333f3fc07ade887e9a25762ebb75a Reviewed-on: https://gerrit.libreoffice.org/67340 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-21pvs-studio: Potentially uninitialized pointer 'ret_type' used.Caolán McNamara
Change-Id: I2f6faf1264a62012724d9fe34352a76ea5491717 Reviewed-on: https://gerrit.libreoffice.org/62096 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20Simplify containers iterations, tdf#96099 follow-upArkadiy Illarionov
Use range-based loop or replace with std::any_of, std::find and std::find_if where applicable. Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6 Reviewed-on: https://gerrit.libreoffice.org/59143 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23Fix typosAndrea Gelmini
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2 Reviewed-on: https://gerrit.libreoffice.org/57810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-11tdf#96099 Remove some trivial std::vector typedefsArkadiy Illarionov
Change-Id: I0e60ec7a3edae42b25ff0917828d0a893ed39a38 Reviewed-on: https://gerrit.libreoffice.org/55245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01cli_ure: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I63e12a22a46de27a8bd010e4d21bf36d3a7e9178 Reviewed-on: https://gerrit.libreoffice.org/48967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-10Clean up uses of SAL_U/SAL_W: cli_ureStephan Bergmann
Change-Id: I198be4023710206d66135c33fe01e1d9bb859272
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann
Change-Id: I3d29240b7a3aa1d8941ca97f3c3e941e884cbf8b Reviewed-on: https://gerrit.libreoffice.org/34272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-11-02cli_ure: fix buildMichael Stahl
Change-Id: Ib35a951ea813151ca330c3eb2286cbada91bd972
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-10-13remove some useless commentsNoel Grandin
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-06cli_ure: climaker should open keyfile read-onlyMichael Stahl
This should fix build failures due to file locking preventing concurrent access to cli_ure/source/cliuno.snk. Change-Id: Iefd16ed83a01523b3612844c2f777516dc4e44c6
2015-09-30Fix typosAndrea Gelmini
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea Reviewed-on: https://gerrit.libreoffice.org/18941 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-03climaker: Fix std::array and cli::array collisionDavid Ostrovsky
Change-Id: I7b4815b4b7e8f016ce7a9047c77a6dde46b1ee0a Reviewed-on: https://gerrit.libreoffice.org/18320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-03-30fdo#57950 Replace chained append() with operator+Krisztian Pinter
Replaced all in cli_ure Change-Id: I144542f386fe26444c290edd9e23b26cb07941a6 Reviewed-on: https://gerrit.libreoffice.org/15040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-25TyposJulien Nabet
Change-Id: I665a56fcad10e136e949a10497f6ab8813af9968
2015-03-19We require MSVC2013 (_MSC_VER == 1800) nowTor Lillqvist
Change-Id: Ice8504041f22e00f2e5010813d9dff1d2987c8d6
2015-03-12cli_ure: PVS-Studio V618 non-const format stringMichael Stahl
Change-Id: I54834111ce8aac91f2a6605473bef5eeaa4fb171
2015-02-03climaker: Fix handling incomplete typesDavid Ostrovsky
The order in which the hash table of incomplete structure types is iterated is non-deterministic. Make sure that the array fields are complete types before they are assigned. This fixed weird error on Windows 64 bit. The reason this bug wasn't hitting on 32 bit Windows build is because the generation order was different and by chance the referenced fields were already generated. Change-Id: Ifc8622b420fc25fea5a0ac8c09d08f7804c9b77c Reviewed-on: https://gerrit.libreoffice.org/13851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-12-12osl_getCommandArg always returns osl_Process_E_NoneStephan Bergmann
Change-Id: I0ff1e44f17976fd3a3060d8ee7fe15d77c918b79
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-08Remove redundant inclusions of header "cppuhelper/shlib.h"Matthew Pottage
Change-Id: Iab402035613a6cc96b7b4ebd2981a1fd0f8bed23 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-29Typo: apend->appendJulien Nabet
Change-Id: I062c95ca8d478ba6c241723dda25c1dc4d7bb852
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23Combine unoidl::loadProvider and unoidl::Manager::addProviderStephan Bergmann
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-05-12use css prefix consistentlyThomas Arnhold
Change-Id: Ia2f827381ec768a7867918d61d7afb2f68457832
2014-02-27Remove visual noise from cli_ureAlexander Wilms
Change-Id: I1ddada46767b2840c663a0a077e1b723f9645b56 Reviewed-on: https://gerrit.libreoffice.org/8240 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-14Drop unused #includeTakeshi Abe
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c