summaryrefslogtreecommitdiff
path: root/codemaker
AgeCommit message (Collapse)Author
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Ice7788ebcfbc638ec21a824c4267757218c14478
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-01-22SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVMStephan Bergmann
The Itanium C++ ABI mandates that for a unique (complete) C++ type a single unique symbol for the type's RTTI name is used across a process's dynamic objects (so type equivalence can be determined via pointer comparison on the RTTI names). GCC nowadays deviates from that, using strcmp to determine equivalence, so it is resilient to RTTI names being bound locally within dynamic objects (which has performance benefits, but also makes it impossible to have unrelated types that happen to have the same name "encapsulated" in individual dynamic objects--- whether or not that would violate the ODR would be open to interpretation of how dynamic objects fit into the C++ Standard). LLVM sticks to the Itanium ABI, which becomes notable in at least two places: For one, libc++abi's __dynamic_cast uses strict checking. It still has a _LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and syslogs visibility violations. Mac OS X uses libc++abi with _LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast errors to the Console there. For another, RTTI-based UBSan checks unconditionally only use strict checking (cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not using libc++abi. Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to have default visibility under the Itanium/LLVM semantics. There is unfortunately no way to mark only the (implicitly generated) RTTI symbols for default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual functions. It appears that even the vtables of those classes remain hidden, at least with Mach-O on Mac OS X. (That also means there is no need for a SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect--- CPPU_GCC_DLLPRIVATE one.) Nevertheless, the number of exported symbols of course increases when SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac OS X, find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \ wc -l increased from 125541 to 139239. For Linux, an option might be to "activate" SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS. The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker- generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and IUndoManager) is chosen so that a full "make check" on Mac OS X no longer syslogs any dynamic_cast errors to the Console. Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
2014-12-27coverity#1019332 Unchecked dynamic_castCaolán McNamara
Change-Id: I280928da005b8cdd94c8bf33eb5aaa86a5ea2fcd
2014-12-27coverity#1019331 Unchecked dynamic_castCaolán McNamara
Change-Id: I902fdbcfd171e93ac57b5021269d2279610b4b0d
2014-12-27coverity#1019327 Unchecked dynamic_castCaolán McNamara
Change-Id: Ibc5a1478d196681cbc124886924eebf065bbdb11
2014-12-27coverity#1019325 Unchecked dynamic_castCaolán McNamara
Change-Id: Ic1607eea119a7321f65b0a0145a263a03406ed6d
2014-12-10Fix generation of com.sun.star.uno.[Runtime]Exception classesStephan Bergmann
Change-Id: If9bd4d906906e0e6cd7c5bb61f8a67a163218395
2014-12-08protected -> privateStephan Bergmann
Change-Id: I807b31eaa0b0cd68e0ca018b6df4269c1aab5763
2014-11-18cppumaker: only include rtl/instance.hxx and mutex.hxx when necessaryMichael Stahl
Change-Id: Ib21a3cfe4b02e421f8848a6e2cca4e2a1c04adb9
2014-11-18More iwyu suggested headers removalRiccardo Magliocchetti
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-24coverity#441989 Uncaught exceptionCaolán McNamara
Change-Id: I579bfc6f4a57aea49e2b023917d0dbd7c3db6c88
2014-10-24coverity#441732 Uncaught exceptionCaolán McNamara
Change-Id: Icd11b81566fec7ce4855cd4e54ff3a3d9862d354
2014-10-07coverity#1242375 Don't call fscanf without specifiersCaolán McNamara
Change-Id: I58082770ca79da9c4d235b5ea0dc79c688c7498b
2014-09-30codemaker: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I205c0908254f13970315f8e159997a5ec2f96ed3
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-08-20java: avoid unnecessary comparisons in boolean expressionsNoel Grandin
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-07-26coverity#1019323 Unchecked dynamic_castCaolán McNamara
Change-Id: I3d8b598e86339fdd51af48e62393550821b6278d
2014-07-25coverity#1219788 Unchecked dynamic_castCaolán McNamara
Change-Id: I1bedfb601320bc27adc0d0d72fcb8b3c5dfe73ff
2014-07-01New loplugin:stringconcatStephan Bergmann
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-26coverity#1019311 Unchecked return valueCaolán McNamara
Change-Id: I682ca0b62e6eb0d02113218de97d1440089b782c
2014-05-26coverity#1019326 Unchecked dynamic_castCaolán McNamara
Change-Id: Ib3f0776048ca3dbb8a7efa4d9240f4ee9d6ac9dd
2014-05-26coverity#1019329 Unchecked dynamic_castCaolán McNamara
Change-Id: Ic340559c9ab9b74f4f932c90e08f2530c08e8d08
2014-05-26coverity#1019330 Unchecked dynamic_castCaolán McNamara
Change-Id: I9c7893f7c9af2b42dcc50f2d1463ec497bb85e30
2014-05-23improve parameter flow in cpputype.cxxNoel Grandin
after commit c5d47c327a57df55 "add default value for Context param in uno::Exception constructors" Change-Id: Ib429b58c559ecd48764a8df2f49d5470057c2c63
2014-05-23add default value for Context param in uno::Exception constructorsNoel Grandin
and all it's subtypes, which is almost never used, so this allows us to simplify lots of call sites. Change-Id: I0b05793ea2bdd1027679f63252d42ce4af89433b
2014-05-23Combine unoidl::loadProvider and unoidl::Manager::addProviderStephan Bergmann
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-11coverity#1213117 Unchecked dynamic_castCaolán McNamara
Change-Id: I6f55030ea7bebce99537c7cdd5156c83c38a765a
2014-04-28prefer makefile-gmake-modeTakeshi Abe
Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
2014-04-14Reduce the amount of strings in the release builds.Jan Holesovsky
I guess even in the debug builds these strings do not add much info, but... Change-Id: I5cf765539a821513b5ce77c5484071d181459881
2014-04-04codemaker: sal_Bool->boolNoel Grandin
Change-Id: I0a0691df58455b712eb27695f4cce15fd3494b65
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-17codemaker,editeng: prefer passing OUString by referenceNoel Grandin
Change-Id: If3e2dd3905cc33f1e7fc9fbfbb9f2bb49a756a34
2014-02-27Remove visual noise from codemakerAlexander Wilms
Change-Id: I098c636ed8794c858317fdbefa9ffa1c6d81c320 Reviewed-on: https://gerrit.libreoffice.org/8241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-17codemaker: sal_Bool -> boolStephan Bergmann
Change-Id: I2cacac2aa7e48b3b9d8d060137d5c6d6f1d06b3f
2014-02-01coverity#707676 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I546c3f497dc98c88a0d678622c20cced387a4ab2
2014-01-31Remove UNOIDL "array" and "union" vaporware remnantsStephan Bergmann
...and deprecate what cannot be removed for compatibility. Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-28copy&paste typoMatúš Kukan
Change-Id: I528a6a747e88fe2a4b4abfd9372daddf4e8aa502
generated by cgit (git 2.34.1) at 2024-12-29 02:23:23 +0000